mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
fd8aa5ec7d
rust/tests/ui-fulldeps/session-diagnostic/diagnostic-derive.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

658 lines
20 KiB
Plaintext
Raw Normal View History

macros: support diagnostic derive on enums Signed-off-by: David Wood <david.wood@huawei.com>
2022-09-23 06:49:02 -05:00
error: unsupported type attribute for diagnostic derive enum
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:44:1
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
macros: support diagnostic derive on enums Signed-off-by: David Wood <david.wood@huawei.com>
2022-09-23 06:49:02 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:47:5
macros: support diagnostic derive on enums Signed-off-by: David Wood <david.wood@huawei.com>
2022-09-23 06:49:02 -05:00
|
LL | Foo,
| ^^^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
macros: support diagnostic derive on enums Signed-off-by: David Wood <david.wood@huawei.com>
2022-09-23 06:49:02 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:49:5
macros: support diagnostic derive on enums Signed-off-by: David Wood <david.wood@huawei.com>
2022-09-23 06:49:02 -05:00
|
LL | Bar,
| ^^^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: expected parentheses: #[diag(...)]
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:55:8
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | #[diag = "E0123"]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
macros: add helper functions for invalid attrs Remove some duplicated code between both diagnostic derives by introducing helper functions for reporting an error in case of a invalid attribute. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:06:13 -05:00
error: `#[nonsense(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:60:1
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[nonsense(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
Make derived SessionDiagnostics generic on diagnostic level Deriving SessionDiagnostic on a type no longer forces that diagnostic to be one of warning, error, or fatal. The level is instead decided when the struct is passed to the respective Handler::emit_*() method.
2022-08-19 08:02:10 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:60:1
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | / #[nonsense(no_crate_example, code = "E0123")]
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
LL | |
LL | |
LL | |
LL | | struct InvalidStructAttr {}
| |___________________________^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:67:1
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | / #[diag("E0123")]
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
LL | |
LL | | struct InvalidLitNestedAttr {}
| |______________________________^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: diagnostic slug must be the first argument
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:77:16
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | #[diag(nonsense("foo"), code = "E0123", slug = "foo")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:77:1
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | / #[diag(nonsense("foo"), code = "E0123", slug = "foo")]
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
LL | |
LL | |
LL | | struct InvalidNestedStructAttr1 {}
| |__________________________________^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: unknown argument
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:83:8
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
LL | #[diag(nonsense = "...", code = "E0123", slug = "foo")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
= note: only the `code` parameter is valid after the slug
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:83:1
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | / #[diag(nonsense = "...", code = "E0123", slug = "foo")]
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
LL | |
LL | |
LL | | struct InvalidNestedStructAttr2 {}
| |__________________________________^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: unknown argument
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:89:8
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
LL | #[diag(nonsense = 4, code = "E0123", slug = "foo")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
= note: only the `code` parameter is valid after the slug
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:89:1
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | / #[diag(nonsense = 4, code = "E0123", slug = "foo")]
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
LL | |
LL | |
LL | | struct InvalidNestedStructAttr3 {}
| |__________________________________^
macros: add helper functions for invalid attrs Remove some duplicated code between both diagnostic derives by introducing helper functions for reporting an error in case of a invalid attribute. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:06:13 -05:00
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: unknown argument
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:95:42
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0123", slug = "foo")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
= note: only the `code` parameter is valid after the slug
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
error: `#[suggestion = ...]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:102:5
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
LL | #[suggestion = "bar"]
| ^^^^^^^^^^^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
macros: reuse `SetOnce` trait in diagnostic derive `SetOnce` trait was introduced in the subdiagnostic derive to simplify the code a little bit, re-use it in the diagnostic derive too. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:28:21 -05:00
error: specified multiple times
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:109:8
macros: reuse `SetOnce` trait in diagnostic derive `SetOnce` trait was introduced in the subdiagnostic derive to simplify the code a little bit, re-use it in the diagnostic derive too. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:28:21 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0456")]
| ^^^^^^^^^^^^^^^^
macros: reuse `SetOnce` trait in diagnostic derive `SetOnce` trait was introduced in the subdiagnostic derive to simplify the code a little bit, re-use it in the diagnostic derive too. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:28:21 -05:00
|
note: previously specified here
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:108:8
macros: reuse `SetOnce` trait in diagnostic derive `SetOnce` trait was introduced in the subdiagnostic derive to simplify the code a little bit, re-use it in the diagnostic derive too. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:28:21 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^
macros: reuse `SetOnce` trait in diagnostic derive `SetOnce` trait was introduced in the subdiagnostic derive to simplify the code a little bit, re-use it in the diagnostic derive too. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:28:21 -05:00
error: specified multiple times
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:109:26
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0456")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
note: previously specified here
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:108:26
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0123")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
macros: reuse `SetOnce` trait in diagnostic derive `SetOnce` trait was introduced in the subdiagnostic derive to simplify the code a little bit, re-use it in the diagnostic derive too. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:28:21 -05:00
error: specified multiple times
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:115:42
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0456", code = "E0457")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
note: previously specified here
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:115:26
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, code = "E0456", code = "E0457")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: diagnostic slug must be the first argument
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:120:43
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[diag(no_crate_example, no_crate::example, code = "E0456")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
Make derived SessionDiagnostics generic on diagnostic level Deriving SessionDiagnostic on a type no longer forces that diagnostic to be one of warning, error, or fatal. The level is instead decided when the struct is passed to the respective Handler::emit_*() method.
2022-08-19 08:02:10 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:125:1
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
LL | struct KindNotProvided {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:128:1
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | / #[diag(code = "E0456")]
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
LL | |
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
LL | | struct SlugNotProvided {}
| |_________________________^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
macros: support `MultiSpan` in diag derives Add support for `MultiSpan` with any of the attributes that work on a `Span` - requires that diagnostic logic generated for these attributes are emitted in the by-move block rather than the by-ref block that they would normally have been generated in. Signed-off-by: David Wood <david.wood@huawei.com>
2022-07-11 11:15:31 -05:00
error: the `#[primary_span]` attribute can only be applied to fields of type `Span` or `MultiSpan`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:139:5
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
macros: rename `#[message]` to `#[primary_span]` Small commit renaming `#[message]` to `#[primary_span]` as this more accurately reflects what it does now. Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:50:45 -05:00
LL | #[primary_span]
| ^^^^^^^^^^^^^^^
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
macros: add helper functions for invalid attrs Remove some duplicated code between both diagnostic derives by introducing helper functions for reporting an error in case of a invalid attribute. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:06:13 -05:00
error: `#[nonsense]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:147:5
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
LL | #[nonsense]
| ^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
macros: support `MultiSpan` in diag derives Add support for `MultiSpan` with any of the attributes that work on a `Span` - requires that diagnostic logic generated for these attributes are emitted in the by-move block rather than the by-ref block that they would normally have been generated in. Signed-off-by: David Wood <david.wood@huawei.com>
2022-07-11 11:15:31 -05:00
error: the `#[label(...)]` attribute can only be applied to fields of type `Span` or `MultiSpan`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:164:5
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[label(no_crate_label)]
| ^^^^^^^^^^^^^^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
error: `name` doesn't refer to a field on this type
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:172:46
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion, code = "{name}")]
| ^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
error: invalid format string: expected `'}'` but string was terminated
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:177:10
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
UPDATE - rename DiagnosticHandler macro to Diagnostic
2022-09-18 10:46:56 -05:00
LL | #[derive(Diagnostic)]
Update tests.
2022-08-26 11:52:08 -05:00
| ^^^^^^^^^^ expected `'}'` in format string
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
= note: if you intended to print `{`, you can escape it using `{{`
UPDATE - rename DiagnosticHandler macro to Diagnostic
2022-09-18 10:46:56 -05:00
= note: this error originates in the derive macro `Diagnostic` (in Nightly builds, run with -Z macro-backtrace for more info)
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
error: invalid format string: unmatched `}` found
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:187:10
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
UPDATE - rename DiagnosticHandler macro to Diagnostic
2022-09-18 10:46:56 -05:00
LL | #[derive(Diagnostic)]
Update tests.
2022-08-26 11:52:08 -05:00
| ^^^^^^^^^^ unmatched `}` in format string
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
= note: if you intended to print `}`, you can escape it using `}}`
UPDATE - rename DiagnosticHandler macro to Diagnostic
2022-09-18 10:46:56 -05:00
= note: this error originates in the derive macro `Diagnostic` (in Nightly builds, run with -Z macro-backtrace for more info)
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
macros: support `MultiSpan` in diag derives Add support for `MultiSpan` with any of the attributes that work on a `Span` - requires that diagnostic logic generated for these attributes are emitted in the by-move block rather than the by-ref block that they would normally have been generated in. Signed-off-by: David Wood <david.wood@huawei.com>
2022-07-11 11:15:31 -05:00
error: the `#[label(...)]` attribute can only be applied to fields of type `Span` or `MultiSpan`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:207:5
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[label(no_crate_label)]
| ^^^^^^^^^^^^^^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
error: suggestion without `code = "..."`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:226:5
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: invalid nested attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:234:18
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
macros: support translatable suggestions Extends support for generating `DiagnosticMessage::FluentIdentifier` messages from `SessionDiagnostic` derive to `#[suggestion]`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 07:10:13 -05:00
LL | #[suggestion(nonsense = "bar")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^
macros: add helper functions for invalid attrs Remove some duplicated code between both diagnostic derives by introducing helper functions for reporting an error in case of a invalid attribute. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:06:13 -05:00
|
Add style= parameter to suggestion attributes
2022-10-20 13:28:24 -05:00
= help: only `style`, `code` and `applicability` are valid nested attributes
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
error: suggestion without `code = "..."`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:234:5
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
LL | #[suggestion(nonsense = "bar")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: invalid nested attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:243:18
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
macros: support translatable suggestions Extends support for generating `DiagnosticMessage::FluentIdentifier` messages from `SessionDiagnostic` derive to `#[suggestion]`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 07:10:13 -05:00
LL | #[suggestion(msg = "bar")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^
macros: add helper functions for invalid attrs Remove some duplicated code between both diagnostic derives by introducing helper functions for reporting an error in case of a invalid attribute. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:06:13 -05:00
|
Add style= parameter to suggestion attributes
2022-10-20 13:28:24 -05:00
= help: only `style`, `code` and `applicability` are valid nested attributes
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
error: suggestion without `code = "..."`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:243:5
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
LL | #[suggestion(msg = "bar")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
error: wrong field type for suggestion
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:266:5
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | / #[suggestion(no_crate_suggestion, code = "This is suggested code")]
Revert "Auto merge of #79132 - pietroalbini:beta-next, r=Mark-Simulacrum" This was landed on master instead of beta!
2020-11-18 04:18:40 -06:00
LL | |
LL | | suggestion: Applicability,
| |_____________________________^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
macros: update session diagnostic errors Small commit adding backticks around types and annotations in the error messages from the session diagnostic derive. Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-30 04:04:03 -05:00
= help: `#[suggestion(...)]` should be applied to fields of type `Span` or `(Span, Applicability)`
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
error: specified multiple times
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:282:24
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
LL | suggestion: (Span, Span, Applicability),
| ^^^^
|
note: previously specified here
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:282:18
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
|
LL | suggestion: (Span, Span, Applicability),
| ^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
error: specified multiple times
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:290:33
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
|
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
LL | suggestion: (Applicability, Applicability, Span),
| ^^^^^^^^^^^^^
|
note: previously specified here
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:290:18
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
|
LL | suggestion: (Applicability, Applicability, Span),
| ^^^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
error: `#[label = ...]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:297:5
macros: add helper functions for invalid attrs Remove some duplicated code between both diagnostic derives by introducing helper functions for reporting an error in case of a invalid attribute. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 22:06:13 -05:00
|
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
LL | #[label = "bar"]
| ^^^^^^^^^^^^^^^^
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
Point to previous applicability when declared multiple times
2022-09-10 07:48:01 -05:00
error: specified multiple times
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:448:5
macros: allow setting applicability in attribute In the initial implementation of the `SessionSubdiagnostic`, the `Applicability` of a suggestion can be set both as a field and as part of the attribute, this commit adds the same support to the original `SessionDiagnostic` derive. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 23:43:36 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion, code = "...", applicability = "maybe-incorrect")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Point to previous applicability when declared multiple times
2022-09-10 07:48:01 -05:00
|
note: previously specified here
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:450:24
Point to previous applicability when declared multiple times
2022-09-10 07:48:01 -05:00
|
LL | suggestion: (Span, Applicability),
| ^^^^^^^^^^^^^
macros: allow setting applicability in attribute In the initial implementation of the `SessionSubdiagnostic`, the `Applicability` of a suggestion can be set both as a field and as part of the attribute, this commit adds the same support to the original `SessionDiagnostic` derive. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 23:43:36 -05:00
error: invalid applicability
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:456:69
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion, code = "...", applicability = "batman")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
Migrate most of `rustc_builtin_macros` to diagnostic impls Co-authored-by: Joe ST <joe@fbstj.net> Co-authored-by: Michael Goulet <michael@errs.io>
2023-04-08 14:37:41 -05:00
error: the `#[help(...)]` attribute can only be applied to fields of type `Span`, `MultiSpan`, `bool` or `()`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:523:5
Allow using `bool` for optional diagnostics
2023-02-27 06:54:11 -06:00
|
LL | #[help(no_crate_help)]
| ^^^^^^^^^^^^^^^^^^^^^^
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: a diagnostic slug must be the first argument to the attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:532:32
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[label(no_crate_label, foo)]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: invalid nested attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:540:29
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[label(no_crate_label, foo = "...")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: invalid nested attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:548:29
macros: allow setting applicability in attribute In the initial implementation of the `SessionSubdiagnostic`, the `Applicability` of a suggestion can be set both as a field and as part of the attribute, this commit adds the same support to the original `SessionDiagnostic` derive. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 23:43:36 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[label(no_crate_label, foo("..."))]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^
macros: allow setting applicability in attribute In the initial implementation of the `SessionSubdiagnostic`, the `Applicability` of a suggestion can be set both as a field and as part of the attribute, this commit adds the same support to the original `SessionDiagnostic` derive. Signed-off-by: David Wood <david.wood@huawei.com>
2022-04-26 23:43:36 -05:00
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: `#[primary_span]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:560:5
macros: add diagnostic derive for lints `SessionDiagnostic` isn't suitable for use on lints as whether or not it creates an error or a warning is decided at compile-time by the macro, whereas lints decide this at runtime based on the location of the lint being reported (as it will depend on the user's `allow`/`deny` attributes, etc). Re-using most of the machinery for `SessionDiagnostic`, this macro introduces a `LintDiagnostic` derive which implements a `DecorateLint` trait, taking a `LintDiagnosticBuilder` and adding to the lint according to the diagnostic struct.
2022-06-30 02:57:45 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | #[primary_span]
| ^^^^^^^^^^^^^^^
macros: add diagnostic derive for lints `SessionDiagnostic` isn't suitable for use on lints as whether or not it creates an error or a warning is decided at compile-time by the macro, whereas lints decide this at runtime based on the location of the lint being reported (as it will depend on the user's `allow`/`deny` attributes, etc). Re-using most of the machinery for `SessionDiagnostic`, this macro introduces a `LintDiagnostic` derive which implements a `DecorateLint` trait, taking a `LintDiagnosticBuilder` and adding to the lint according to the diagnostic struct.
2022-06-30 02:57:45 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
= help: the `primary_span` field attribute is not valid for lint diagnostics
macros: add diagnostic derive for lints `SessionDiagnostic` isn't suitable for use on lints as whether or not it creates an error or a warning is decided at compile-time by the macro, whereas lints decide this at runtime based on the location of the lint being reported (as it will depend on the user's `allow`/`deny` attributes, etc). Re-using most of the machinery for `SessionDiagnostic`, this macro introduces a `LintDiagnostic` derive which implements a `DecorateLint` trait, taking a `LintDiagnosticBuilder` and adding to the lint according to the diagnostic struct.
2022-06-30 02:57:45 -05:00
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: `#[error(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:580:1
macros: add diagnostic derive for lints `SessionDiagnostic` isn't suitable for use on lints as whether or not it creates an error or a warning is decided at compile-time by the macro, whereas lints decide this at runtime based on the location of the lint being reported (as it will depend on the user's `allow`/`deny` attributes, etc). Re-using most of the machinery for `SessionDiagnostic`, this macro introduces a `LintDiagnostic` derive which implements a `DecorateLint` trait, taking a `LintDiagnosticBuilder` and adding to the lint according to the diagnostic struct.
2022-06-30 02:57:45 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[error(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
macros: add diagnostic derive for lints `SessionDiagnostic` isn't suitable for use on lints as whether or not it creates an error or a warning is decided at compile-time by the macro, whereas lints decide this at runtime based on the location of the lint being reported (as it will depend on the user's `allow`/`deny` attributes, etc). Re-using most of the machinery for `SessionDiagnostic`, this macro introduces a `LintDiagnostic` derive which implements a `DecorateLint` trait, taking a `LintDiagnosticBuilder` and adding to the lint according to the diagnostic struct.
2022-06-30 02:57:45 -05:00
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:580:1
Disallow #[primary_span] on LintDiagnostics
2022-08-19 08:04:34 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | / #[error(no_crate_example, code = "E0123")]
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | |
LL | |
LL | |
LL | | struct ErrorAttribute {}
| |________________________^
Disallow #[primary_span] on LintDiagnostics
2022-08-19 08:04:34 -05:00
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
translations: rename warn_ to warning The macro warn_ was named like that because it the keyword warn is a built-in attribute and at the time this macro was created the word 'warning' was also taken. However it is no longer the case and we can rename warn_ to warning.
2022-08-24 10:57:10 -05:00
error: `#[warn_(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:587:1
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[warn_(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:587:1
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | / #[warn_(no_crate_example, code = "E0123")]
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | |
LL | |
LL | |
translations: rename warn_ to warning The macro warn_ was named like that because it the keyword warn is a built-in attribute and at the time this macro was created the word 'warning' was also taken. However it is no longer the case and we can rename warn_ to warning.
2022-08-24 10:57:10 -05:00
LL | | struct WarnAttribute {}
| |_______________________^
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: `#[lint(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:594:1
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[lint(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:594:1
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | / #[lint(no_crate_example, code = "E0123")]
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | |
LL | |
LL | |
LL | | struct LintAttributeOnSessionDiag {}
| |____________________________________^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the `#[diag(...)]` attribute, such as `#[diag(hir_analysis_example_error)]`
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: `#[lint(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:601:1
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[lint(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
`ui-fulldeps`: adopt to the new rustc lint API
2022-09-22 09:25:05 -05:00
error: `#[lint(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:601:1
`ui-fulldeps`: adopt to the new rustc lint API
2022-09-22 09:25:05 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[lint(no_crate_example, code = "E0123")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
`ui-fulldeps`: adopt to the new rustc lint API
2022-09-22 09:25:05 -05:00
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: diagnostic slug not specified
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:601:1
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | / #[lint(no_crate_example, code = "E0123")]
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | |
LL | |
LL | |
`ui-fulldeps`: adopt to the new rustc lint API
2022-09-22 09:25:05 -05:00
LL | |
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | | struct LintAttributeOnLintDiag {}
| |_________________________________^
|
Update translation tests
2022-10-22 04:08:09 -05:00
= help: specify the slug as the first argument to the attribute, such as `#[diag(compiletest_example)]`
Disallow #[primary_span] on LintDiagnostics
2022-08-19 08:04:34 -05:00
Ensure code= in #[suggestion(...)] is only set once
2022-09-10 07:28:12 -05:00
error: specified multiple times
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:611:53
Ensure code= in #[suggestion(...)] is only set once
2022-09-10 07:28:12 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion, code = "...", code = ",,,")]
fix errors
2023-04-03 10:11:30 -05:00
| ^^^^
Ensure code= in #[suggestion(...)] is only set once
2022-09-10 07:28:12 -05:00
|
note: previously specified here
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:611:39
Ensure code= in #[suggestion(...)] is only set once
2022-09-10 07:28:12 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion, code = "...", code = ",,,")]
fix errors
2023-04-03 10:11:30 -05:00
| ^^^^
Ensure code= in #[suggestion(...)] is only set once
2022-09-10 07:28:12 -05:00
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
error: wrong types for suggestion
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:620:24
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
|
LL | suggestion: (Span, usize),
| ^^^^^
|
= help: `#[suggestion(...)]` on a tuple field must be applied to fields of type `(Span, Applicability)`
error: wrong types for suggestion
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:628:17
Ensure #[suggestion] is only applied to correct tuple types
2022-09-10 07:43:07 -05:00
|
LL | suggestion: (Span,),
| ^^^^^^^
|
= help: `#[suggestion(...)]` on a tuple field must be applied to fields of type `(Span, Applicability)`
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
error: suggestion without `code = "..."`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:635:5
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
error: `#[multipart_suggestion(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:642:1
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[multipart_suggestion(no_crate_suggestion)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
= help: consider creating a `Subdiagnostic` instead
error: `#[multipart_suggestion(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:649:5
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[multipart_suggestion(no_crate_suggestion)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
= help: consider creating a `Subdiagnostic` instead
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: unexpected end of input, unexpected token in nested attribute, expected ident
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:645:24
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
|
LL | #[multipart_suggestion()]
| ^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
error: `#[suggestion(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:657:1
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion, code = "...")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
= help: `#[label]` and `#[suggestion]` can only be applied to fields
error: `#[label]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:666:1
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
LL | #[label]
| ^^^^^^^^
|
= help: `#[label]` and `#[suggestion]` can only be applied to fields
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: `eager` is the only supported nested attribute for `subdiagnostic`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:700:7
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
|
LL | #[subdiagnostic(bad)]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^^^^^^^^^^^
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
error: `#[subdiagnostic = ...]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:708:5
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
|
LL | #[subdiagnostic = "bad"]
| ^^^^^^^^^^^^^^^^^^^^^^^^
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: `eager` is the only supported nested attribute for `subdiagnostic`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:716:7
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
|
LL | #[subdiagnostic(bad, bad)]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: `eager` is the only supported nested attribute for `subdiagnostic`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:724:7
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
|
LL | #[subdiagnostic("bad")]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^^^^^^^^^^^^^^^^^^^^
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
error: `#[subdiagnostic(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:732:5
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
|
LL | #[subdiagnostic(eager)]
| ^^^^^^^^^^^^^^^^^^^^^^^
|
Support eager subdiagnostics again
2023-01-08 17:00:41 -06:00
= help: eager subdiagnostics are not supported on lints
macros: `#[subdiagnostic(eager)]` Add support for `eager` argument to the `subdiagnostic` attribute which generates a call to `eager_subdiagnostic`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-03 08:24:17 -05:00
Allow specifying multiple alternative suggestions This allows porting uses of span_suggestions() to diagnostic structs. Doesn't work for multipart_suggestions() because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while multipart_suggestions() creates multiple possible replacements, each with multiple spans.
2022-10-17 12:41:49 -05:00
error: expected at least one string literal for `code(...)`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:790:23
Allow specifying multiple alternative suggestions This allows porting uses of span_suggestions() to diagnostic structs. Doesn't work for multipart_suggestions() because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while multipart_suggestions() creates multiple possible replacements, each with multiple spans.
2022-10-17 12:41:49 -05:00
|
LL | #[suggestion(code())]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^
Allow specifying multiple alternative suggestions This allows porting uses of span_suggestions() to diagnostic structs. Doesn't work for multipart_suggestions() because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while multipart_suggestions() creates multiple possible replacements, each with multiple spans.
2022-10-17 12:41:49 -05:00
error: `code(...)` must contain only string literals
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:798:23
Allow specifying multiple alternative suggestions This allows porting uses of span_suggestions() to diagnostic structs. Doesn't work for multipart_suggestions() because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while multipart_suggestions() creates multiple possible replacements, each with multiple spans.
2022-10-17 12:41:49 -05:00
|
LL | #[suggestion(code(foo))]
| ^^^
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: unexpected token
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:798:23
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
|
LL | #[suggestion(code(foo))]
| ^^^
error: expected string literal
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:807:25
Allow specifying multiple alternative suggestions This allows porting uses of span_suggestions() to diagnostic structs. Doesn't work for multipart_suggestions() because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while multipart_suggestions() creates multiple possible replacements, each with multiple spans.
2022-10-17 12:41:49 -05:00
|
LL | #[suggestion(code = 3)]
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
| ^
Allow specifying multiple alternative suggestions This allows porting uses of span_suggestions() to diagnostic structs. Doesn't work for multipart_suggestions() because the rank would be reversed - the struct would specify multiple spans, each of which has multiple possible replacements, while multipart_suggestions() creates multiple possible replacements, each with multiple spans.
2022-10-17 12:41:49 -05:00
Forbid #[suggestion_*(...)] on Vecs It is ambiguous whether this should produce several `.span_suggestions()` calls or one `.multipart_suggestions()` call.
2022-10-16 09:15:39 -05:00
error: `#[suggestion(...)]` is not a valid attribute
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:822:5
Forbid #[suggestion_*(...)] on Vecs It is ambiguous whether this should produce several `.span_suggestions()` calls or one `.multipart_suggestions()` call.
2022-10-16 09:15:39 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[suggestion(no_crate_suggestion, code = "")]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Forbid #[suggestion_*(...)] on Vecs It is ambiguous whether this should produce several `.span_suggestions()` calls or one `.multipart_suggestions()` call.
2022-10-16 09:15:39 -05:00
|
= note: `#[suggestion(...)]` applied to `Vec` field is ambiguous
= help: to show a suggestion consisting of multiple parts, use a `Subdiagnostic` annotated with `#[multipart_suggestion(...)]`
= help: to show a variable set of suggestions, use a `Vec` of `Subdiagnostic`s annotated with `#[suggestion(...)]`
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
error: cannot find attribute `nonsense` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:60:3
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[nonsense(no_crate_example, code = "E0123")]
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
| ^^^^^^^^
error: cannot find attribute `nonsense` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:147:7
macros: translatable struct attrs and warnings Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 02:35:17 -05:00
|
LL | #[nonsense]
| ^^^^^^^^
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: cannot find attribute `error` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:580:3
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[error(no_crate_example, code = "E0123")]
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
| ^^^^^
translations: rename warn_ to warning The macro warn_ was named like that because it the keyword warn is a built-in attribute and at the time this macro was created the word 'warning' was also taken. However it is no longer the case and we can rename warn_ to warning.
2022-08-24 10:57:10 -05:00
error: cannot find attribute `warn_` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:587:3
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[warn_(no_crate_example, code = "E0123")]
translations: rename warn_ to warning The macro warn_ was named like that because it the keyword warn is a built-in attribute and at the time this macro was created the word 'warning' was also taken. However it is no longer the case and we can rename warn_ to warning.
2022-08-24 10:57:10 -05:00
| ^^^^^ help: a built-in attribute with a similar name exists: `warn`
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
error: cannot find attribute `lint` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:594:3
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[lint(no_crate_example, code = "E0123")]
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
| ^^^^ help: a built-in attribute with a similar name exists: `link`
error: cannot find attribute `lint` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:601:3
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[lint(no_crate_example, code = "E0123")]
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
| ^^^^ help: a built-in attribute with a similar name exists: `link`
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
error: cannot find attribute `multipart_suggestion` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:642:3
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[multipart_suggestion(no_crate_suggestion)]
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
| ^^^^^^^^^^^^^^^^^^^^
error: cannot find attribute `multipart_suggestion` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:645:3
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
LL | #[multipart_suggestion()]
| ^^^^^^^^^^^^^^^^^^^^
error: cannot find attribute `multipart_suggestion` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:649:7
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
|
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
LL | #[multipart_suggestion(no_crate_suggestion)]
Unify subdiagnostic attribute parsing
2022-09-14 10:19:40 -05:00
| ^^^^^^^^^^^^^^^^^^^^
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
error[E0425]: cannot find value `nonsense` in module `crate::fluent_generated`
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:72:8
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
|
Replace #[lint/warning/error] with #[diag]
2022-08-19 08:40:48 -05:00
LL | #[diag(nonsense, code = "E0123")]
errors: generate typed identifiers in each crate Instead of loading the Fluent resources for every crate in `rustc_error_messages`, each crate generates typed identifiers for its own diagnostics and creates a static which are pulled together in the `rustc_driver` crate and provided to the diagnostic emitter. Signed-off-by: David Wood <david.wood@huawei.com>
2022-10-13 04:13:02 -05:00
| ^^^^^^^^ not found in `crate::fluent_generated`
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error[E0425]: cannot find value `__code_34` in this scope
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:804:10
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
|
LL | #[derive(Diagnostic)]
| ^^^^^^^^^^ not found in this scope
|
= note: this error originates in the derive macro `Diagnostic` (in Nightly builds, run with -Z macro-backtrace for more info)
errors: `set_arg` takes `IntoDiagnosticArg` Manual implementors of translatable diagnostics will need to call `set_arg`, not just the derive, so make this function a bit more ergonomic by taking `IntoDiagnosticArg` rather than `DiagnosticArgValue`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-05-07 01:26:03 -05:00
error[E0277]: the trait bound `Hello: IntoDiagnosticArg` is not satisfied
Add `rustc_fluent_macro` to decouple fluent from `rustc_macros` Fluent, with all the icu4x it brings in, takes quite some time to compile. `fluent_messages!` is only needed in further downstream rustc crates, but is blocking more upstream crates like `rustc_index`. By splitting it out, we allow `rustc_macros` to be compiled earlier, which speeds up `x check compiler` by about 5 seconds (and even more after the needless dependency on `serde_json` is removed from `rustc_data_structures`).
2023-04-16 07:33:00 -05:00
--> $DIR/diagnostic-derive.rs:341:10
macros: add `#[no_arg]` to skip `set_arg` call A call to `set_arg` is generated for every field of a `SessionDiagnostic` struct without attributes, but not all types support being an argument, so `#[no_arg]` is introduced to skip these fields. Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 03:02:31 -05:00
|
UPDATE - rename DiagnosticHandler macro to Diagnostic
2022-09-18 10:46:56 -05:00
LL | #[derive(Diagnostic)]
FIX - adopt new Diagnostic naming in newly migrated modules FIX - ambiguous Diagnostic link in docs UPDATE - rename diagnostic_items to IntoDiagnostic and AddToDiagnostic [Gardening] FIX - formatting via `x fmt` FIX - rebase conflicts. NOTE: Confirm wheather or not we want to handle TargetDataLayoutErrorsWrapper this way DELETE - unneeded allow attributes in Handler method FIX - broken test FIX - Rebase conflict UPDATE - rename residual _SessionDiagnostic and fix LintDiag link
2022-09-14 23:01:44 -05:00
| ^^^^^^^^^^ the trait `IntoDiagnosticArg` is not implemented for `Hello`
errors: `set_arg` takes `IntoDiagnosticArg` Manual implementors of translatable diagnostics will need to call `set_arg`, not just the derive, so make this function a bit more ergonomic by taking `IntoDiagnosticArg` rather than `DiagnosticArgValue`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-05-07 01:26:03 -05:00
|
tests: avoid inadvertent diffs in diag derive test In the diagnostic derive test, a "the following other types implement trait" diagnostic is output which lists rustc types that implement `IntoDiagnosticArg`. As the output of this test can change due to new internal compiler types like implementing `IntoDiagnosticArg`, it can start failing without indicating a problem to be fixed - so normalize that output away. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-29 03:21:44 -05:00
= help: normalized in stderr
errors: `set_arg` takes `IntoDiagnosticArg` Manual implementors of translatable diagnostics will need to call `set_arg`, not just the derive, so make this function a bit more ergonomic by taking `IntoDiagnosticArg` rather than `DiagnosticArgValue`. Signed-off-by: David Wood <david.wood@huawei.com>
2022-05-07 01:26:03 -05:00
note: required by a bound in `DiagnosticBuilder::<'a, G>::set_arg`
Adjust stderr file
2022-08-31 09:46:51 -05:00
--> $COMPILER_DIR/rustc_errors/src/diagnostic_builder.rs:LL:CC
bless fulldeps tests
2022-12-12 11:32:20 -06:00
= note: this error originates in the derive macro `Diagnostic` which comes from the expansion of the macro `forward` (in Nightly builds, run with -Z macro-backtrace for more info)
macros: add `#[no_arg]` to skip `set_arg` call A call to `set_arg` is generated for every field of a `SessionDiagnostic` struct without attributes, but not all types support being an argument, so `#[no_arg]` is introduced to skip these fields. Signed-off-by: David Wood <david.wood@huawei.com>
2022-03-31 03:02:31 -05:00
fix and bless ui tests 1/2
2023-04-03 09:36:50 -05:00
error: aborting due to 84 previous errors
Add SessionDiagnostic derive macro. Co-authored-by: Oliver Scherer <github35764891676564198441@oli-obk.de>
2020-08-27 05:00:21 -05:00
macros: use typed identifiers in diag derive Using typed identifiers instead of strings with the Fluent identifier enables the diagnostic derive to benefit from the compile-time validation that comes with typed identifiers - use of a non-existent Fluent identifier will not compile. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-23 08:51:44 -05:00
Some errors have detailed explanations: E0277, E0425.
For more information about an error, try `rustc --explain E0277`.
Reference in New Issue Copy Permalink