rust/crates/ide-assists/src/handlers/extract_variable.rs

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

1464 lines
28 KiB
Rust
Raw Normal View History

use hir::TypeInfo;
2020-08-12 11:26:51 -05:00
use syntax::{
ast::{self, edit::IndentLevel, edit_in_place::Indent, make, AstNode, HasName},
ted, NodeOrToken,
SyntaxKind::{BLOCK_EXPR, BREAK_EXPR, COMMENT, LOOP_EXPR, MATCH_GUARD, PATH_EXPR, RETURN_EXPR},
2020-05-20 16:07:17 -05:00
SyntaxNode,
2019-01-03 06:08:32 -06:00
};
use crate::{utils::suggest_name, AssistContext, AssistId, AssistKind, Assists};
2019-01-03 06:08:32 -06:00
2020-06-26 18:21:43 -05:00
// Assist: extract_variable
2019-10-26 11:58:18 -05:00
//
// Extracts subexpression into a variable.
//
// ```
// fn main() {
2021-01-06 14:15:48 -06:00
// $0(1 + 2)$0 * 4;
2019-10-26 11:58:18 -05:00
// }
// ```
// ->
// ```
// fn main() {
2020-05-20 16:07:17 -05:00
// let $0var_name = (1 + 2);
2019-10-26 11:58:18 -05:00
// var_name * 4;
// }
// ```
2022-07-20 08:02:08 -05:00
pub(crate) fn extract_variable(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
let node = if ctx.has_empty_selection() {
if let Some(expr_stmt) = ctx.find_node_at_offset::<ast::ExprStmt>() {
expr_stmt.syntax().clone()
} else if let Some(expr) = ctx.find_node_at_offset::<ast::Expr>() {
expr.syntax().ancestors().find_map(valid_target_expr)?.syntax().clone()
} else {
return None;
}
} else {
match ctx.covering_element() {
NodeOrToken::Node(it) => it,
NodeOrToken::Token(it) if it.kind() == COMMENT => {
cov_mark::hit!(extract_var_in_comment_is_not_applicable);
return None;
}
NodeOrToken::Token(it) => it.parent()?,
}
};
let node = node.ancestors().take_while(|anc| anc.text_range() == node.text_range()).last()?;
let range = node.text_range();
let to_extract = node
.descendants()
.take_while(|it| range.contains_range(it.text_range()))
.find_map(valid_target_expr)?;
let ty = ctx.sema.type_of_expr(&to_extract).map(TypeInfo::adjusted);
if matches!(&ty, Some(ty_info) if ty_info.is_unit()) {
return None;
}
let parent = to_extract.syntax().parent().and_then(ast::Expr::cast);
let needs_adjust = parent
.as_ref()
.map_or(false, |it| matches!(it, ast::Expr::FieldExpr(_) | ast::Expr::MethodCallExpr(_)));
2020-07-21 11:10:03 -05:00
let anchor = Anchor::from(&to_extract)?;
let target = to_extract.syntax().text_range();
2020-06-28 17:36:05 -05:00
acc.add(
2020-07-02 16:48:35 -05:00
AssistId("extract_variable", AssistKind::RefactorExtract),
2020-06-28 17:36:05 -05:00
"Extract into variable",
target,
move |edit| {
let field_shorthand = to_extract
.syntax()
.parent()
.and_then(ast::RecordExprField::cast)
.filter(|field| field.name_ref().is_some());
let (var_name, expr_replace) = match field_shorthand {
Some(field) => (field.to_string(), field.syntax().clone()),
None => (
suggest_name::for_variable(&to_extract, &ctx.sema),
to_extract.syntax().clone(),
),
2020-06-28 17:36:05 -05:00
};
let ident_pat = match parent {
Some(ast::Expr::RefExpr(expr)) if expr.mut_token().is_some() => {
make::ident_pat(false, true, make::name(&var_name))
}
_ => make::ident_pat(false, false, make::name(&var_name)),
2020-06-28 17:36:05 -05:00
};
let to_extract = match ty.as_ref().filter(|_| needs_adjust) {
Some(receiver_type) if receiver_type.is_mutable_reference() => {
make::expr_ref(to_extract, true)
2022-01-04 19:03:27 -06:00
}
Some(receiver_type) if receiver_type.is_reference() => {
make::expr_ref(to_extract, false)
}
_ => to_extract,
2020-06-28 17:36:05 -05:00
};
2020-05-20 16:07:17 -05:00
let expr_replace = edit.make_syntax_mut(expr_replace);
let let_stmt =
make::let_stmt(ident_pat.into(), None, Some(to_extract)).clone_for_update();
let name_expr = make::expr_path(make::ext::ident_path(&var_name)).clone_for_update();
match anchor {
Anchor::Before(place) => {
let prev_ws = place.prev_sibling_or_token().and_then(|it| it.into_token());
let indent_to = IndentLevel::from_node(&place);
let insert_place = edit.make_syntax_mut(place);
// Adjust ws to insert depending on if this is all inline or on separate lines
let trailing_ws = if prev_ws.is_some_and(|it| it.text().starts_with("\n")) {
format!("\n{indent_to}")
} else {
format!(" ")
};
ted::insert_all_raw(
ted::Position::before(insert_place),
vec![
let_stmt.syntax().clone().into(),
make::tokens::whitespace(&trailing_ws).into(),
],
);
ted::replace(expr_replace, name_expr.syntax());
if let Some(cap) = ctx.config.snippet_cap {
if let Some(ast::Pat::IdentPat(ident_pat)) = let_stmt.pat() {
if let Some(name) = ident_pat.name() {
edit.add_tabstop_before(cap, name);
}
}
2020-06-28 17:36:05 -05:00
}
}
Anchor::Replace(stmt) => {
cov_mark::hit!(test_extract_var_expr_stmt);
2020-06-28 17:36:05 -05:00
let stmt_replace = edit.make_mut(stmt);
ted::replace(stmt_replace.syntax(), let_stmt.syntax());
2020-06-28 17:36:05 -05:00
if let Some(cap) = ctx.config.snippet_cap {
if let Some(ast::Pat::IdentPat(ident_pat)) = let_stmt.pat() {
if let Some(name) = ident_pat.name() {
edit.add_tabstop_before(cap, name);
}
}
}
2020-05-20 16:07:17 -05:00
}
Anchor::WrapInBlock(to_wrap) => {
let indent_to = to_wrap.indent_level();
let block = if to_wrap.syntax() == &expr_replace {
// Since `expr_replace` is the same that needs to be wrapped in a block,
// we can just directly replace it with a block
let block =
make::block_expr([let_stmt.into()], Some(name_expr)).clone_for_update();
ted::replace(expr_replace, block.syntax());
block
} else {
// `expr_replace` is a descendant of `to_wrap`, so both steps need to be
// handled seperately, otherwise we wrap the wrong expression
let to_wrap = edit.make_mut(to_wrap);
// Replace the target expr first so that we don't need to find where
// `expr_replace` is in the wrapped `to_wrap`
ted::replace(expr_replace, name_expr.syntax());
// Wrap `to_wrap` in a block
let block = make::block_expr([let_stmt.into()], Some(to_wrap.clone()))
.clone_for_update();
ted::replace(to_wrap.syntax(), block.syntax());
block
};
if let Some(cap) = ctx.config.snippet_cap {
// Adding a tabstop to `name` requires finding the let stmt again, since
// the existing `let_stmt` is not actually added to the tree
let pat = block.statements().find_map(|stmt| {
let ast::Stmt::LetStmt(let_stmt) = stmt else { return None };
let_stmt.pat()
});
if let Some(ast::Pat::IdentPat(ident_pat)) = pat {
if let Some(name) = ident_pat.name() {
edit.add_tabstop_before(cap, name);
}
}
}
2020-05-20 16:07:17 -05:00
// fixup indentation of block
block.indent(indent_to);
}
2019-01-28 08:12:07 -06:00
}
2020-06-28 17:36:05 -05:00
},
)
2019-01-03 09:59:17 -06:00
}
2019-01-03 06:08:32 -06:00
2019-02-08 17:34:05 -06:00
/// Check whether the node is a valid expression which can be extracted to a variable.
/// In general that's true for any expression, but in some cases that would produce invalid code.
2019-07-19 03:24:41 -05:00
fn valid_target_expr(node: SyntaxNode) -> Option<ast::Expr> {
2019-02-06 14:50:26 -06:00
match node.kind() {
2019-09-02 13:41:50 -05:00
PATH_EXPR | LOOP_EXPR => None,
BREAK_EXPR => ast::BreakExpr::cast(node).and_then(|e| e.expr()),
RETURN_EXPR => ast::ReturnExpr::cast(node).and_then(|e| e.expr()),
2019-09-02 13:41:50 -05:00
BLOCK_EXPR => {
ast::BlockExpr::cast(node).filter(|it| it.is_standalone()).map(ast::Expr::from)
}
_ => ast::Expr::cast(node),
2019-02-06 14:50:26 -06:00
}
}
#[derive(Debug)]
2020-07-21 11:10:03 -05:00
enum Anchor {
Before(SyntaxNode),
Replace(ast::ExprStmt),
WrapInBlock(ast::Expr),
2020-07-21 11:10:03 -05:00
}
impl Anchor {
fn from(to_extract: &ast::Expr) -> Option<Anchor> {
to_extract
.syntax()
.ancestors()
.take_while(|it| !ast::Item::can_cast(it.kind()) || ast::MacroCall::can_cast(it.kind()))
.find_map(|node| {
if ast::MacroCall::can_cast(node.kind()) {
return None;
}
if let Some(expr) =
node.parent().and_then(ast::StmtList::cast).and_then(|it| it.tail_expr())
{
if expr.syntax() == &node {
cov_mark::hit!(test_extract_var_last_expr);
return Some(Anchor::Before(node));
}
2020-07-21 11:10:03 -05:00
}
2019-01-28 08:12:07 -06:00
if let Some(parent) = node.parent() {
if let Some(parent) = ast::ClosureExpr::cast(parent.clone()) {
cov_mark::hit!(test_extract_var_in_closure_no_block);
return parent.body().map(Anchor::WrapInBlock);
}
if let Some(parent) = ast::MatchArm::cast(parent) {
if node.kind() == MATCH_GUARD {
cov_mark::hit!(test_extract_var_in_match_guard);
} else {
cov_mark::hit!(test_extract_var_in_match_arm_no_block);
return parent.expr().map(Anchor::WrapInBlock);
}
}
}
2019-01-28 08:12:07 -06:00
if let Some(stmt) = ast::Stmt::cast(node.clone()) {
if let ast::Stmt::ExprStmt(stmt) = stmt {
if stmt.expr().as_ref() == Some(to_extract) {
return Some(Anchor::Replace(stmt));
}
2020-07-21 11:10:03 -05:00
}
return Some(Anchor::Before(node));
2020-07-21 11:10:03 -05:00
}
None
})
2020-07-21 11:10:03 -05:00
}
2019-01-03 06:08:32 -06:00
}
#[cfg(test)]
mod tests {
2020-05-06 03:16:55 -05:00
use crate::tests::{check_assist, check_assist_not_applicable, check_assist_target};
2019-01-03 06:08:32 -06:00
2019-02-24 05:22:25 -06:00
use super::*;
#[test]
fn test_extract_var_simple_without_select() {
check_assist(
extract_variable,
r#"
fn main() -> i32 {
if true {
1
} else {
2
}$0
}
"#,
r#"
fn main() -> i32 {
let $0var_name = if true {
1
} else {
2
};
var_name
}
"#,
);
check_assist(
extract_variable,
r#"
fn foo() -> i32 { 1 }
fn main() {
foo();$0
}
"#,
r#"
fn foo() -> i32 { 1 }
fn main() {
let $0foo = foo();
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
let a = Some(2);
a.is_some();$0
}
"#,
r#"
fn main() {
let a = Some(2);
let $0is_some = a.is_some();
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
"hello"$0;
}
"#,
r#"
fn main() {
let $0var_name = "hello";
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
1 + 2$0;
}
"#,
r#"
fn main() {
let $0var_name = 1 + 2;
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
match () {
() if true => 1,
_ => 2,
};$0
}
"#,
r#"
fn main() {
let $0var_name = match () {
() if true => 1,
_ => 2,
};
}
"#,
);
}
#[test]
fn test_extract_var_unit_expr_without_select_not_applicable() {
check_assist_not_applicable(
extract_variable,
r#"
fn foo() {}
fn main() {
foo()$0;
}
"#,
);
check_assist_not_applicable(
extract_variable,
r#"
fn foo() {
let mut i = 3;
if i >= 0 {
i += 1;
} else {
i -= 1;
}$0
}"#,
);
}
2019-01-03 06:08:32 -06:00
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_simple() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
2020-05-20 16:07:17 -05:00
r#"
2019-01-03 06:08:32 -06:00
fn foo() {
2021-01-06 14:15:48 -06:00
foo($01 + 1$0);
2020-05-20 16:07:17 -05:00
}"#,
r#"
2019-01-03 06:08:32 -06:00
fn foo() {
2020-05-20 16:07:17 -05:00
let $0var_name = 1 + 1;
2019-01-03 06:08:32 -06:00
foo(var_name);
2020-05-20 16:07:17 -05:00
}"#,
2019-01-03 06:08:32 -06:00
);
}
2019-02-24 05:22:25 -06:00
#[test]
2020-06-26 18:21:43 -05:00
fn extract_var_in_comment_is_not_applicable() {
2021-03-08 14:19:44 -06:00
cov_mark::check!(extract_var_in_comment_is_not_applicable);
2021-01-06 14:15:48 -06:00
check_assist_not_applicable(extract_variable, "fn main() { 1 + /* $0comment$0 */ 1; }");
2019-02-24 05:22:25 -06:00
}
2019-01-03 06:08:32 -06:00
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_expr_stmt() {
2021-03-08 14:19:44 -06:00
cov_mark::check!(test_extract_var_expr_stmt);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
2020-05-20 16:07:17 -05:00
r#"
2019-01-03 06:08:32 -06:00
fn foo() {
$0 1 + 1$0;
2020-05-20 16:07:17 -05:00
}"#,
r#"
2019-01-03 06:08:32 -06:00
fn foo() {
2020-05-20 16:07:17 -05:00
let $0var_name = 1 + 1;
}"#,
2019-02-24 05:22:25 -06:00
);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
r"
2019-02-24 05:22:25 -06:00
fn foo() {
2023-03-04 07:58:58 -06:00
$0{ let x = 0; x }$0;
2019-02-24 05:22:25 -06:00
something_else();
}",
r"
2019-02-24 05:22:25 -06:00
fn foo() {
2020-05-20 16:07:17 -05:00
let $0var_name = { let x = 0; x };
2019-02-24 05:22:25 -06:00
something_else();
2019-01-03 06:08:32 -06:00
}",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_part_of_expr_stmt() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
r"
2019-01-03 06:08:32 -06:00
fn foo() {
2021-01-06 14:15:48 -06:00
$01$0 + 1;
2019-01-03 06:08:32 -06:00
}",
r"
2019-01-03 06:08:32 -06:00
fn foo() {
2020-05-20 16:07:17 -05:00
let $0var_name = 1;
2019-01-03 06:08:32 -06:00
var_name + 1;
}",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_last_expr() {
2021-03-08 14:19:44 -06:00
cov_mark::check!(test_extract_var_last_expr);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
2020-06-23 17:30:34 -05:00
r#"
2019-01-03 06:08:32 -06:00
fn foo() {
2021-01-06 14:15:48 -06:00
bar($01 + 1$0)
2020-06-23 17:30:34 -05:00
}
"#,
r#"
2019-01-03 06:08:32 -06:00
fn foo() {
2020-05-20 16:07:17 -05:00
let $0var_name = 1 + 1;
2019-01-03 06:08:32 -06:00
bar(var_name)
2020-06-23 17:30:34 -05:00
}
"#,
2019-01-03 06:08:32 -06:00
);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
2020-06-23 17:30:34 -05:00
r#"
fn foo() -> i32 {
2021-01-06 14:15:48 -06:00
$0bar(1 + 1)$0
2020-06-23 17:30:34 -05:00
}
fn bar(i: i32) -> i32 {
i
}
2020-06-23 17:30:34 -05:00
"#,
r#"
fn foo() -> i32 {
let $0bar = bar(1 + 1);
bar
2020-06-23 17:30:34 -05:00
}
fn bar(i: i32) -> i32 {
i
}
2020-06-23 17:30:34 -05:00
"#,
2019-02-24 05:22:25 -06:00
)
}
2019-01-28 08:12:07 -06:00
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_in_match_arm_no_block() {
cov_mark::check!(test_extract_var_in_match_arm_no_block);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
let x = true;
let tuple = match x {
2021-01-06 14:15:48 -06:00
true => ($02 + 2$0, true)
2019-01-28 08:12:07 -06:00
_ => (0, false)
};
}
"#,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
let x = true;
let tuple = match x {
true => {
let $0var_name = 2 + 2;
(var_name, true)
}
2019-01-28 08:12:07 -06:00
_ => (0, false)
};
}
"#,
2019-01-28 08:12:07 -06:00
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_in_match_arm_with_block() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
let x = true;
let tuple = match x {
true => {
let y = 1;
2021-01-06 14:15:48 -06:00
($02 + y$0, true)
2019-01-28 08:12:07 -06:00
}
_ => (0, false)
};
}
"#,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
let x = true;
let tuple = match x {
true => {
let y = 1;
2020-05-20 16:07:17 -05:00
let $0var_name = 2 + y;
2019-01-28 08:12:07 -06:00
(var_name, true)
}
_ => (0, false)
};
}
"#,
);
}
#[test]
fn test_extract_var_in_match_guard() {
cov_mark::check!(test_extract_var_in_match_guard);
check_assist(
extract_variable,
r#"
fn main() {
match () {
() if $010 > 0$0 => 1
_ => 2
};
}
"#,
r#"
fn main() {
let $0var_name = 10 > 0;
match () {
() if var_name => 1
_ => 2
};
}
"#,
2019-01-28 08:12:07 -06:00
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_in_closure_no_block() {
cov_mark::check!(test_extract_var_in_closure_no_block);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
2021-01-06 14:15:48 -06:00
let lambda = |x: u32| $0x * 2$0;
2019-01-28 08:12:07 -06:00
}
"#,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
let lambda = |x: u32| {
let $0var_name = x * 2;
var_name
};
2019-01-28 08:12:07 -06:00
}
"#,
2019-01-28 08:12:07 -06:00
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_in_closure_with_block() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
2021-01-06 14:15:48 -06:00
let lambda = |x: u32| { $0x * 2$0 };
2019-01-28 08:12:07 -06:00
}
"#,
r#"
2019-01-28 08:12:07 -06:00
fn main() {
2020-05-20 16:07:17 -05:00
let lambda = |x: u32| { let $0var_name = x * 2; var_name };
2019-01-28 08:12:07 -06:00
}
"#,
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_path_simple() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn main() {
2021-01-06 14:15:48 -06:00
let o = $0Some(true)$0;
}
",
"
fn main() {
2020-05-20 16:07:17 -05:00
let $0var_name = Some(true);
let o = var_name;
}
",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_path_method() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn main() {
2021-01-06 14:15:48 -06:00
let v = $0bar.foo()$0;
}
",
"
fn main() {
let $0foo = bar.foo();
let v = foo;
}
",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_return() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn foo() -> u32 {
2021-01-06 14:15:48 -06:00
$0return 2 + 2$0;
}
",
"
fn foo() -> u32 {
2020-05-20 16:07:17 -05:00
let $0var_name = 2 + 2;
return var_name;
}
",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_does_not_add_extra_whitespace() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn foo() -> u32 {
2021-01-06 14:15:48 -06:00
$0return 2 + 2$0;
}
",
"
fn foo() -> u32 {
2020-05-20 16:07:17 -05:00
let $0var_name = 2 + 2;
return var_name;
}
",
);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn foo() -> u32 {
2021-01-06 14:15:48 -06:00
$0return 2 + 2$0;
}
",
"
fn foo() -> u32 {
2020-05-20 16:07:17 -05:00
let $0var_name = 2 + 2;
return var_name;
}
",
);
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn foo() -> u32 {
let foo = 1;
// bar
2021-01-06 14:15:48 -06:00
$0return 2 + 2$0;
}
",
"
fn foo() -> u32 {
let foo = 1;
// bar
2020-05-20 16:07:17 -05:00
let $0var_name = 2 + 2;
return var_name;
}
",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_break() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn main() {
let result = loop {
2021-01-06 14:15:48 -06:00
$0break 2 + 2$0;
};
}
",
"
fn main() {
let result = loop {
2020-05-20 16:07:17 -05:00
let $0var_name = 2 + 2;
break var_name;
};
}
",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_for_cast() {
2020-02-25 11:57:47 -06:00
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
"
fn main() {
2021-01-06 14:15:48 -06:00
let v = $00f32 as u32$0;
}
",
"
fn main() {
2020-05-20 16:07:17 -05:00
let $0var_name = 0f32 as u32;
let v = var_name;
}
",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn extract_var_field_shorthand() {
check_assist(
2020-06-26 18:21:43 -05:00
extract_variable,
r#"
struct S {
foo: i32
}
fn main() {
2021-01-06 14:15:48 -06:00
S { foo: $01 + 1$0 }
}
"#,
r#"
struct S {
foo: i32
}
fn main() {
let $0foo = 1 + 1;
S { foo }
}
"#,
)
}
#[test]
fn extract_var_name_from_type() {
check_assist(
extract_variable,
r#"
struct Test(i32);
fn foo() -> Test {
$0{ Test(10) }$0
}
"#,
r#"
struct Test(i32);
fn foo() -> Test {
let $0test = { Test(10) };
test
}
"#,
)
}
#[test]
fn extract_var_name_from_parameter() {
check_assist(
extract_variable,
r#"
fn bar(test: u32, size: u32)
fn foo() {
bar(1, $01+1$0);
}
"#,
r#"
fn bar(test: u32, size: u32)
fn foo() {
let $0size = 1+1;
bar(1, size);
}
"#,
)
}
#[test]
fn extract_var_parameter_name_has_precedence_over_type() {
check_assist(
extract_variable,
r#"
struct TextSize(u32);
fn bar(test: u32, size: TextSize)
fn foo() {
bar(1, $0{ TextSize(1+1) }$0);
}
"#,
r#"
struct TextSize(u32);
fn bar(test: u32, size: TextSize)
fn foo() {
let $0size = { TextSize(1+1) };
bar(1, size);
}
"#,
)
}
#[test]
fn extract_var_name_from_function() {
check_assist(
extract_variable,
r#"
fn is_required(test: u32, size: u32) -> bool
fn foo() -> bool {
$0is_required(1, 2)$0
}
"#,
r#"
fn is_required(test: u32, size: u32) -> bool
fn foo() -> bool {
let $0is_required = is_required(1, 2);
is_required
}
"#,
)
}
#[test]
fn extract_var_name_from_method() {
check_assist(
extract_variable,
r#"
struct S;
impl S {
fn bar(&self, n: u32) -> u32 { n }
}
fn foo() -> u32 {
$0S.bar(1)$0
}
"#,
r#"
struct S;
impl S {
fn bar(&self, n: u32) -> u32 { n }
}
fn foo() -> u32 {
let $0bar = S.bar(1);
bar
}
"#,
)
}
#[test]
fn extract_var_name_from_method_param() {
check_assist(
extract_variable,
r#"
struct S;
impl S {
fn bar(&self, n: u32, size: u32) { n }
}
fn foo() {
S.bar($01 + 1$0, 2)
}
"#,
r#"
struct S;
impl S {
fn bar(&self, n: u32, size: u32) { n }
}
fn foo() {
let $0n = 1 + 1;
S.bar(n, 2)
}
"#,
)
}
#[test]
fn extract_var_name_from_ufcs_method_param() {
check_assist(
extract_variable,
r#"
struct S;
impl S {
fn bar(&self, n: u32, size: u32) { n }
}
fn foo() {
S::bar(&S, $01 + 1$0, 2)
}
"#,
r#"
struct S;
impl S {
fn bar(&self, n: u32, size: u32) { n }
}
fn foo() {
let $0n = 1 + 1;
S::bar(&S, n, 2)
}
"#,
)
}
#[test]
fn extract_var_parameter_name_has_precedence_over_function() {
check_assist(
extract_variable,
r#"
fn bar(test: u32, size: u32)
fn foo() {
bar(1, $0symbol_size(1, 2)$0);
}
"#,
r#"
fn bar(test: u32, size: u32)
fn foo() {
let $0size = symbol_size(1, 2);
bar(1, size);
}
"#,
)
}
#[test]
fn extract_macro_call() {
check_assist(
extract_variable,
r"
struct Vec;
macro_rules! vec {
() => {Vec}
}
fn main() {
let _ = $0vec![]$0;
}
",
r"
struct Vec;
macro_rules! vec {
() => {Vec}
}
fn main() {
let $0vec = vec![];
let _ = vec;
}
",
);
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_for_return_not_applicable() {
2021-01-06 14:15:48 -06:00
check_assist_not_applicable(extract_variable, "fn foo() { $0return$0; } ");
}
#[test]
2020-06-26 18:21:43 -05:00
fn test_extract_var_for_break_not_applicable() {
2021-01-06 14:15:48 -06:00
check_assist_not_applicable(extract_variable, "fn main() { loop { $0break$0; }; }");
}
#[test]
fn test_extract_var_unit_expr_not_applicable() {
check_assist_not_applicable(
extract_variable,
r#"
fn foo() {
let mut i = 3;
$0if i >= 0 {
i += 1;
} else {
i -= 1;
}$0
}"#,
);
}
2019-02-08 17:34:05 -06:00
// FIXME: This is not quite correct, but good enough(tm) for the sorting heuristic
#[test]
2020-06-26 18:21:43 -05:00
fn extract_var_target() {
2021-01-06 14:15:48 -06:00
check_assist_target(extract_variable, "fn foo() -> u32 { $0return 2 + 2$0; }", "2 + 2");
2019-02-08 17:34:05 -06:00
2020-02-25 11:57:47 -06:00
check_assist_target(
2020-06-26 18:21:43 -05:00
extract_variable,
2019-02-08 17:34:05 -06:00
"
fn main() {
let x = true;
let tuple = match x {
2021-01-06 14:15:48 -06:00
true => ($02 + 2$0, true)
2019-02-08 17:34:05 -06:00
_ => (0, false)
};
}
",
"2 + 2",
);
}
#[test]
fn extract_var_no_block_body() {
check_assist_not_applicable(
extract_variable,
r"
const X: usize = $0100$0;
",
);
}
2022-01-04 19:03:27 -06:00
#[test]
fn test_extract_var_mutable_reference_parameter() {
check_assist(
extract_variable,
r#"
struct S {
vec: Vec<u8>
}
struct Vec<T>;
impl<T> Vec<T> {
fn push(&mut self, _:usize) {}
}
2022-01-04 19:03:27 -06:00
fn foo(s: &mut S) {
$0s.vec$0.push(0);
}"#,
r#"
struct S {
vec: Vec<u8>
}
struct Vec<T>;
impl<T> Vec<T> {
fn push(&mut self, _:usize) {}
}
2022-01-04 19:03:27 -06:00
fn foo(s: &mut S) {
let $0vec = &mut s.vec;
vec.push(0);
2022-01-04 19:03:27 -06:00
}"#,
);
}
#[test]
fn test_extract_var_mutable_reference_parameter_deep_nesting() {
check_assist(
extract_variable,
r#"
struct Y {
field: X
}
struct X {
field: S
}
struct S {
vec: Vec<u8>
}
struct Vec<T>;
impl<T> Vec<T> {
fn push(&mut self, _:usize) {}
}
2022-01-04 19:03:27 -06:00
fn foo(f: &mut Y) {
$0f.field.field.vec$0.push(0);
}"#,
r#"
struct Y {
field: X
}
struct X {
field: S
}
struct S {
vec: Vec<u8>
}
struct Vec<T>;
impl<T> Vec<T> {
fn push(&mut self, _:usize) {}
}
2022-01-04 19:03:27 -06:00
fn foo(f: &mut Y) {
let $0vec = &mut f.field.field.vec;
vec.push(0);
2022-01-04 19:15:54 -06:00
}"#,
);
}
#[test]
fn test_extract_var_reference_parameter() {
check_assist(
extract_variable,
r#"
struct X;
impl X {
fn do_thing(&self) {
}
}
struct S {
sub: X
}
fn foo(s: &S) {
$0s.sub$0.do_thing();
}"#,
r#"
struct X;
impl X {
fn do_thing(&self) {
}
}
struct S {
sub: X
}
fn foo(s: &S) {
let $0x = &s.sub;
x.do_thing();
}"#,
);
}
#[test]
fn test_extract_var_reference_parameter_deep_nesting() {
check_assist(
extract_variable,
r#"
struct Z;
impl Z {
fn do_thing(&self) {
}
}
struct Y {
field: Z
}
struct X {
field: Y
}
struct S {
sub: X
}
fn foo(s: &S) {
$0s.sub.field.field$0.do_thing();
}"#,
r#"
struct Z;
impl Z {
fn do_thing(&self) {
}
}
struct Y {
field: Z
}
struct X {
field: Y
}
struct S {
sub: X
}
fn foo(s: &S) {
let $0z = &s.sub.field.field;
z.do_thing();
}"#,
);
}
#[test]
fn test_extract_var_regular_parameter() {
check_assist(
extract_variable,
r#"
struct X;
impl X {
fn do_thing(&self) {
}
}
struct S {
sub: X
}
fn foo(s: S) {
$0s.sub$0.do_thing();
}"#,
r#"
struct X;
impl X {
fn do_thing(&self) {
}
}
struct S {
sub: X
}
fn foo(s: S) {
let $0x = &s.sub;
x.do_thing();
2022-01-04 19:27:15 -06:00
}"#,
);
}
#[test]
fn test_extract_var_mutable_reference_local() {
2022-01-04 19:27:15 -06:00
check_assist(
extract_variable,
r#"
struct X;
struct S {
sub: X
}
impl S {
fn new() -> S {
2022-01-04 20:16:22 -06:00
S {
2022-01-04 19:27:15 -06:00
sub: X::new()
}
}
}
impl X {
fn new() -> X {
X { }
}
fn do_thing(&self) {
}
}
fn foo() {
let local = &mut S::new();
$0local.sub$0.do_thing();
}"#,
r#"
struct X;
struct S {
sub: X
}
impl S {
fn new() -> S {
2022-01-04 20:16:22 -06:00
S {
2022-01-04 19:27:15 -06:00
sub: X::new()
}
}
}
impl X {
fn new() -> X {
X { }
}
fn do_thing(&self) {
}
}
fn foo() {
let local = &mut S::new();
let $0x = &local.sub;
x.do_thing();
}"#,
);
}
#[test]
fn test_extract_var_reference_local() {
check_assist(
extract_variable,
r#"
struct X;
struct S {
sub: X
}
impl S {
fn new() -> S {
2022-01-04 20:16:22 -06:00
S {
sub: X::new()
}
}
}
impl X {
fn new() -> X {
X { }
}
fn do_thing(&self) {
}
}
fn foo() {
let local = &S::new();
$0local.sub$0.do_thing();
}"#,
r#"
struct X;
struct S {
sub: X
}
impl S {
fn new() -> S {
2022-01-04 20:16:22 -06:00
S {
sub: X::new()
}
}
}
impl X {
fn new() -> X {
X { }
}
fn do_thing(&self) {
}
}
fn foo() {
let local = &S::new();
let $0x = &local.sub;
2022-01-04 19:27:15 -06:00
x.do_thing();
}"#,
);
}
#[test]
fn test_extract_var_for_mutable_borrow() {
check_assist(
extract_variable,
r#"
fn foo() {
let v = &mut $00$0;
}"#,
r#"
fn foo() {
let mut $0var_name = 0;
let v = &mut var_name;
2022-01-04 19:03:27 -06:00
}"#,
);
}
2019-01-03 06:08:32 -06:00
}