rust/crates/ide_assists/src/handlers/generate_new.rs

361 lines
7.0 KiB
Rust
Raw Normal View History

2020-08-12 08:04:06 -05:00
use itertools::Itertools;
2020-08-12 11:26:51 -05:00
use stdx::format_to;
2021-09-27 05:54:24 -05:00
use syntax::ast::{self, AstNode, HasName, HasVisibility, StructKind};
use crate::{
utils::{find_impl_block_start, find_struct_impl, generate_impl_text},
AssistContext, AssistId, AssistKind, Assists,
};
2020-07-03 11:15:03 -05:00
// Assist: generate_new
//
// Adds a new inherent impl for a type.
//
// ```
// struct Ctx<T: Clone> {
2021-01-06 14:15:48 -06:00
// data: T,$0
// }
// ```
// ->
// ```
// struct Ctx<T: Clone> {
// data: T,
// }
//
// impl<T: Clone> Ctx<T> {
2020-05-20 03:17:46 -05:00
// fn $0new(data: T) -> Self { Self { data } }
// }
// ```
2020-07-03 11:15:03 -05:00
pub(crate) fn generate_new(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
2020-07-30 10:50:40 -05:00
let strukt = ctx.find_node_at_offset::<ast::Struct>()?;
// We want to only apply this to non-union structs with named fields
2019-11-25 08:30:50 -06:00
let field_list = match strukt.kind() {
StructKind::Record(named) => named,
_ => return None,
};
// Return early if we've found an existing new fn
2021-06-12 22:54:16 -05:00
let impl_def = find_struct_impl(ctx, &ast::Adt::Struct(strukt.clone()), "new")?;
let target = strukt.syntax().text_range();
2020-07-03 12:14:42 -05:00
acc.add(AssistId("generate_new", AssistKind::Generate), "Generate `new`", target, |builder| {
let mut buf = String::with_capacity(512);
if impl_def.is_some() {
buf.push('\n');
}
let vis = strukt.visibility().map_or(String::new(), |v| format!("{} ", v));
let params = field_list
.fields()
2020-07-30 13:51:43 -05:00
.filter_map(|f| Some(format!("{}: {}", f.name()?.syntax(), f.ty()?.syntax())))
2020-08-12 08:04:06 -05:00
.format(", ");
let fields = field_list.fields().filter_map(|f| f.name()).format(", ");
format_to!(buf, " {}fn new({}) -> Self {{ Self {{ {} }} }}", vis, params, fields);
let start_offset = impl_def
.and_then(|impl_def| find_impl_block_start(impl_def, &mut buf))
.unwrap_or_else(|| {
2021-05-14 10:53:53 -05:00
buf = generate_impl_text(&ast::Adt::Struct(strukt.clone()), &buf);
strukt.syntax().text_range().end()
});
match ctx.config.snippet_cap {
None => builder.insert(start_offset, buf),
Some(cap) => {
buf = buf.replace("fn new", "fn $0new");
builder.insert_snippet(cap, start_offset, buf);
2020-05-20 03:17:46 -05:00
}
}
})
}
#[cfg(test)]
mod tests {
2020-05-06 03:16:55 -05:00
use crate::tests::{check_assist, check_assist_not_applicable, check_assist_target};
2019-11-15 13:48:07 -06:00
use super::*;
#[test]
2020-07-03 11:15:03 -05:00
fn test_generate_new() {
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo {$0}
"#,
r#"
struct Foo {}
impl Foo {
2020-05-20 03:17:46 -05:00
fn $0new() -> Self { Self { } }
2021-05-14 10:53:53 -05:00
}
"#,
);
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo<T: Clone> {$0}
"#,
r#"
struct Foo<T: Clone> {}
impl<T: Clone> Foo<T> {
2020-05-20 03:17:46 -05:00
fn $0new() -> Self { Self { } }
2021-05-14 10:53:53 -05:00
}
"#,
);
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo<'a, T: Foo<'a>> {$0}
"#,
r#"
struct Foo<'a, T: Foo<'a>> {}
impl<'a, T: Foo<'a>> Foo<'a, T> {
2020-05-20 03:17:46 -05:00
fn $0new() -> Self { Self { } }
2021-05-14 10:53:53 -05:00
}
"#,
);
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo { baz: String $0}
"#,
r#"
struct Foo { baz: String }
impl Foo {
2020-05-20 03:17:46 -05:00
fn $0new(baz: String) -> Self { Self { baz } }
2021-05-14 10:53:53 -05:00
}
"#,
);
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo { baz: String, qux: Vec<i32> $0}
"#,
r#"
struct Foo { baz: String, qux: Vec<i32> }
impl Foo {
2020-05-20 03:17:46 -05:00
fn $0new(baz: String, qux: Vec<i32>) -> Self { Self { baz, qux } }
2021-05-14 10:53:53 -05:00
}
"#,
);
2021-05-14 10:53:53 -05:00
}
2021-05-14 10:53:53 -05:00
#[test]
fn check_that_visibility_modifiers_dont_get_brought_in() {
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo { pub baz: String, pub qux: Vec<i32> $0}
"#,
r#"
struct Foo { pub baz: String, pub qux: Vec<i32> }
impl Foo {
2020-05-20 03:17:46 -05:00
fn $0new(baz: String, qux: Vec<i32>) -> Self { Self { baz, qux } }
2021-05-14 10:53:53 -05:00
}
"#,
);
2021-05-14 10:53:53 -05:00
}
2021-05-14 10:53:53 -05:00
#[test]
fn check_it_reuses_existing_impls() {
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo {$0}
impl Foo {}
2021-05-14 10:53:53 -05:00
"#,
r#"
struct Foo {}
impl Foo {
2020-05-20 03:17:46 -05:00
fn $0new() -> Self { Self { } }
}
2021-05-14 10:53:53 -05:00
"#,
);
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo {$0}
impl Foo {
fn qux(&self) {}
}
2021-05-14 10:53:53 -05:00
"#,
r#"
struct Foo {}
impl Foo {
2020-05-20 03:17:46 -05:00
fn $0new() -> Self { Self { } }
fn qux(&self) {}
}
2021-05-14 10:53:53 -05:00
"#,
);
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct Foo {$0}
impl Foo {
fn qux(&self) {}
fn baz() -> i32 {
5
}
}
2021-05-14 10:53:53 -05:00
"#,
r#"
struct Foo {}
impl Foo {
2020-05-20 03:17:46 -05:00
fn $0new() -> Self { Self { } }
fn qux(&self) {}
fn baz() -> i32 {
5
}
}
2021-05-14 10:53:53 -05:00
"#,
);
2021-05-14 10:53:53 -05:00
}
2021-05-14 10:53:53 -05:00
#[test]
fn check_visibility_of_new_fn_based_on_struct() {
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
pub struct Foo {$0}
"#,
r#"
pub struct Foo {}
impl Foo {
2020-05-20 03:17:46 -05:00
pub fn $0new() -> Self { Self { } }
2021-05-14 10:53:53 -05:00
}
"#,
);
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
pub(crate) struct Foo {$0}
"#,
r#"
pub(crate) struct Foo {}
impl Foo {
2020-05-20 03:17:46 -05:00
pub(crate) fn $0new() -> Self { Self { } }
2021-05-14 10:53:53 -05:00
}
"#,
);
}
#[test]
2020-07-03 11:15:03 -05:00
fn generate_new_not_applicable_if_fn_exists() {
check_assist_not_applicable(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
2021-01-06 14:15:48 -06:00
struct Foo {$0}
impl Foo {
fn new() -> Self {
Self
2019-11-15 13:48:07 -06:00
}
2021-05-14 10:53:53 -05:00
}
"#,
);
check_assist_not_applicable(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
2021-01-06 14:15:48 -06:00
struct Foo {$0}
impl Foo {
fn New() -> Self {
Self
2019-11-15 13:48:07 -06:00
}
2021-05-14 10:53:53 -05:00
}
"#,
);
}
#[test]
2020-07-03 11:15:03 -05:00
fn generate_new_target() {
check_assist_target(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
struct SomeThingIrrelevant;
/// Has a lifetime parameter
2021-01-06 14:15:48 -06:00
struct Foo<'a, T: Foo<'a>> {$0}
struct EvenMoreIrrelevant;
2021-05-14 10:53:53 -05:00
"#,
"/// Has a lifetime parameter
struct Foo<'a, T: Foo<'a>> {}",
);
}
2019-11-15 13:48:07 -06:00
#[test]
fn test_unrelated_new() {
check_assist(
2020-07-03 11:15:03 -05:00
generate_new,
2021-05-14 10:53:53 -05:00
r#"
2019-11-15 13:48:07 -06:00
pub struct AstId<N: AstNode> {
file_id: HirFileId,
file_ast_id: FileAstId<N>,
}
impl<N: AstNode> AstId<N> {
pub fn new(file_id: HirFileId, file_ast_id: FileAstId<N>) -> AstId<N> {
AstId { file_id, file_ast_id }
}
}
pub struct Source<T> {
2021-01-06 14:15:48 -06:00
pub file_id: HirFileId,$0
2019-11-15 13:48:07 -06:00
pub ast: T,
}
impl<T> Source<T> {
pub fn map<F: FnOnce(T) -> U, U>(self, f: F) -> Source<U> {
Source { file_id: self.file_id, ast: f(self.ast) }
}
2021-05-14 10:53:53 -05:00
}
"#,
r#"
2019-11-15 13:48:07 -06:00
pub struct AstId<N: AstNode> {
file_id: HirFileId,
file_ast_id: FileAstId<N>,
}
impl<N: AstNode> AstId<N> {
pub fn new(file_id: HirFileId, file_ast_id: FileAstId<N>) -> AstId<N> {
AstId { file_id, file_ast_id }
}
}
pub struct Source<T> {
pub file_id: HirFileId,
pub ast: T,
}
impl<T> Source<T> {
2020-05-20 03:17:46 -05:00
pub fn $0new(file_id: HirFileId, ast: T) -> Self { Self { file_id, ast } }
2019-11-15 13:48:07 -06:00
pub fn map<F: FnOnce(T) -> U, U>(self, f: F) -> Source<U> {
Source { file_id: self.file_id, ast: f(self.ast) }
}
2021-05-14 10:53:53 -05:00
}
"#,
2019-11-15 13:48:07 -06:00
);
}
}