2015-09-20 06:57:27 -05:00
|
|
|
#![allow(unused)]
|
2018-07-28 10:34:52 -05:00
|
|
|
#![warn(clippy::let_and_return)]
|
2015-08-11 15:06:30 -05:00
|
|
|
|
|
|
|
fn test() -> i32 {
|
|
|
|
let _y = 0; // no warning
|
2017-02-08 07:58:07 -06:00
|
|
|
let x = 5;
|
|
|
|
x
|
2015-08-11 15:06:30 -05:00
|
|
|
}
|
|
|
|
|
2015-09-20 06:57:27 -05:00
|
|
|
fn test_inner() -> i32 {
|
|
|
|
if true {
|
2017-02-08 07:58:07 -06:00
|
|
|
let x = 5;
|
|
|
|
x
|
2015-09-20 06:57:27 -05:00
|
|
|
} else {
|
|
|
|
0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-08-11 15:06:30 -05:00
|
|
|
fn test_nowarn_1() -> i32 {
|
|
|
|
let mut x = 5;
|
|
|
|
x += 1;
|
|
|
|
x
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_nowarn_2() -> i32 {
|
|
|
|
let x = 5;
|
|
|
|
x + 1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_nowarn_3() -> (i32, i32) {
|
|
|
|
// this should technically warn, but we do not compare complex patterns
|
|
|
|
let (x, y) = (5, 9);
|
|
|
|
(x, y)
|
|
|
|
}
|
|
|
|
|
2017-05-11 09:32:06 -05:00
|
|
|
fn test_nowarn_4() -> i32 {
|
2018-07-28 10:34:52 -05:00
|
|
|
// this should technically warn, but not b/c of clippy::let_and_return, but b/c of useless type
|
2017-05-11 09:32:06 -05:00
|
|
|
let x: i32 = 5;
|
|
|
|
x
|
|
|
|
}
|
|
|
|
|
2019-04-24 01:32:16 -05:00
|
|
|
fn test_nowarn_5(x: i16) -> u16 {
|
|
|
|
#[allow(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
|
|
|
|
let x = x as u16;
|
|
|
|
x
|
|
|
|
}
|
|
|
|
|
2020-01-06 14:26:20 -06:00
|
|
|
// False positive example
|
|
|
|
trait Decode {
|
|
|
|
fn decode<D: std::io::Read>(d: D) -> Result<Self, ()>
|
|
|
|
where
|
|
|
|
Self: Sized;
|
|
|
|
}
|
|
|
|
|
|
|
|
macro_rules! tuple_encode {
|
|
|
|
($($x:ident),*) => (
|
|
|
|
impl<$($x: Decode),*> Decode for ($($x),*) {
|
|
|
|
#[inline]
|
|
|
|
#[allow(non_snake_case)]
|
|
|
|
fn decode<D: std::io::Read>(mut d: D) -> Result<Self, ()> {
|
|
|
|
// Shouldn't trigger lint
|
|
|
|
Ok(($({let $x = Decode::decode(&mut d)?; $x }),*))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
tuple_encode!(T0, T1, T2, T3, T4, T5, T6, T7);
|
|
|
|
|
2018-12-09 16:26:16 -06:00
|
|
|
fn main() {}
|