rust/src/test/ui/lint/dead-code/with-core-crate.stderr

error: function is never used: `foo`
  --> $DIR/with-core-crate.rs:7:4
   |
LL | fn foo() {
   |    ^^^
   |
note: lint level defined here
  --> $DIR/with-core-crate.rs:1:9
   |
LL | #![deny(dead_code)]
   |         ^^^^^^^^^

error: aborting due to previous error
Moved compile-fail tests to ui tests. 2018-08-08 07:28:26 -05:00			error: function is never used: `foo`
Use ident instead of def_span in dead-code pass According to @estebank, def_span scans forward on the line until it finds a {, and if it can't find one, fallse back to the span for the whole item. This was apparently written before the identifier span was explicitly tracked on each node. This means that if an unused function signature spans multiple lines, the entire function (potentially hundreds of lines) gets flagged as dead code. This could, for example, cause IDEs to add error squiggly's to the whole function. By using the span from the ident instead, we narrow the scope of this in most cases. In a wider sense, it's probably safe to use ident.span instead of def_span in most locations throughout the whole code base, but since this is my first contribution, I kept it small. Some interesting points that came up while I was working on this: - I reorganized the tests a bit to bring some of the dead code ones all into the same location - A few tests were for things unrelated to dead code (like the path-lookahead for parens), so I added #![allow(dead_code)] and cleaned up the stderr file to reduce noise in the future - The same fix doesn't apply to const and static declarations. I tried adding these cases to the match expression, but that created a much wider change to tests and error messages, so I left it off until I could get some code review to validate the approach. 2019-10-25 13:46:07 -05:00			`--> $DIR/with-core-crate.rs:7:4`
Moved compile-fail tests to ui tests. 2018-08-08 07:28:26 -05:00			`\|`
Update tests 2019-03-09 06:03:44 -06:00			`LL \| fn foo() {`
Use ident instead of def_span in dead-code pass According to @estebank, def_span scans forward on the line until it finds a {, and if it can't find one, fallse back to the span for the whole item. This was apparently written before the identifier span was explicitly tracked on each node. This means that if an unused function signature spans multiple lines, the entire function (potentially hundreds of lines) gets flagged as dead code. This could, for example, cause IDEs to add error squiggly's to the whole function. By using the span from the ident instead, we narrow the scope of this in most cases. In a wider sense, it's probably safe to use ident.span instead of def_span in most locations throughout the whole code base, but since this is my first contribution, I kept it small. Some interesting points that came up while I was working on this: - I reorganized the tests a bit to bring some of the dead code ones all into the same location - A few tests were for things unrelated to dead code (like the path-lookahead for parens), so I added #![allow(dead_code)] and cleaned up the stderr file to reduce noise in the future - The same fix doesn't apply to const and static declarations. I tried adding these cases to the match expression, but that created a much wider change to tests and error messages, so I left it off until I could get some code review to validate the approach. 2019-10-25 13:46:07 -05:00			`\| ^^^`
Moved compile-fail tests to ui tests. 2018-08-08 07:28:26 -05:00			`\|`
			`note: lint level defined here`
Move dead_code related tests to test/ui/dead-code This helps organize the tests better. I also renamed several of the tests to remove redundant dead-code in the path, and better match what they're testing 2019-10-24 23:42:05 -05:00			`--> $DIR/with-core-crate.rs:1:9`
Moved compile-fail tests to ui tests. 2018-08-08 07:28:26 -05:00			`\|`
			`LL \| #![deny(dead_code)]`
			`\| ^^^^^^^^^`

			`error: aborting due to previous error`