rust/tests/ui/needless_bool.rs

62 lines
1.7 KiB
Rust
Raw Normal View History

2018-10-06 11:18:06 -05:00
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
2018-10-11 05:16:22 -05:00
2017-09-18 05:47:33 -05:00
2018-07-28 10:34:52 -05:00
#![warn(clippy::needless_bool)]
2017-09-18 05:47:33 -05:00
2018-07-28 10:34:52 -05:00
#[allow(clippy::if_same_then_else)]
fn main() {
let x = true;
2016-07-03 18:17:31 -05:00
let y = false;
2017-02-08 07:58:07 -06:00
if x { true } else { true };
if x { false } else { false };
2016-03-14 11:13:10 -05:00
if x { true } else { false };
if x { false } else { true };
2016-07-03 18:17:31 -05:00
if x && y { false } else { true };
if x { x } else { false }; // would also be questionable, but we don't catch this yet
bool_ret(x);
bool_ret2(x);
bool_ret3(x);
2016-07-03 18:17:31 -05:00
bool_ret5(x, x);
bool_ret4(x);
2016-07-03 18:17:31 -05:00
bool_ret6(x, x);
}
2018-07-28 10:34:52 -05:00
#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret(x: bool) -> bool {
if x { return true } else { return true };
}
2018-07-28 10:34:52 -05:00
#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret2(x: bool) -> bool {
if x { return false } else { return false };
}
2018-07-28 10:34:52 -05:00
#[allow(clippy::needless_return)]
fn bool_ret3(x: bool) -> bool {
2016-03-14 11:13:10 -05:00
if x { return true } else { return false };
2016-07-03 18:17:31 -05:00
}
2018-07-28 10:34:52 -05:00
#[allow(clippy::needless_return)]
2016-07-03 18:17:31 -05:00
fn bool_ret5(x: bool, y: bool) -> bool {
if x && y { return true } else { return false };
}
2018-07-28 10:34:52 -05:00
#[allow(clippy::needless_return)]
fn bool_ret4(x: bool) -> bool {
2016-03-14 11:13:10 -05:00
if x { return false } else { return true };
2016-07-03 18:17:31 -05:00
}
2018-07-28 10:34:52 -05:00
#[allow(clippy::needless_return)]
2016-07-03 18:17:31 -05:00
fn bool_ret6(x: bool, y: bool) -> bool {
if x && y { return false } else { return true };
}