2018-10-06 11:18:06 -05:00
|
|
|
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
|
|
|
|
2018-09-15 02:21:58 -05:00
|
|
|
use crate::rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
|
|
use crate::rustc::{declare_tool_lint, lint_array};
|
2018-07-19 03:00:54 -05:00
|
|
|
use if_chain::if_chain;
|
2018-09-15 02:21:58 -05:00
|
|
|
use crate::rustc::hir::*;
|
|
|
|
use crate::syntax::ast::RangeLimits;
|
|
|
|
use crate::syntax::source_map::Spanned;
|
2018-08-30 12:06:13 -05:00
|
|
|
use crate::utils::{is_integer_literal, paths, snippet, span_lint, span_lint_and_then, snippet_opt};
|
2018-07-14 17:00:27 -05:00
|
|
|
use crate::utils::{get_trait_def_id, higher, implements_trait, SpanlessEq};
|
2018-05-30 03:15:50 -05:00
|
|
|
use crate::utils::sugg::Sugg;
|
2018-09-15 11:14:08 -05:00
|
|
|
use crate::rustc_errors::Applicability;
|
2015-08-15 11:55:25 -05:00
|
|
|
|
2017-06-18 08:14:46 -05:00
|
|
|
/// **What it does:** Checks for calling `.step_by(0)` on iterators,
|
2016-08-06 02:55:04 -05:00
|
|
|
/// which never terminates.
|
2015-12-10 18:22:27 -06:00
|
|
|
///
|
2016-08-06 02:55:04 -05:00
|
|
|
/// **Why is this bad?** This very much looks like an oversight, since with
|
|
|
|
/// `loop { .. }` there is an obvious better way to endlessly loop.
|
2015-12-10 18:22:27 -06:00
|
|
|
///
|
2016-08-06 02:55:04 -05:00
|
|
|
/// **Known problems:** None.
|
2015-12-10 18:22:27 -06:00
|
|
|
///
|
2016-07-15 17:25:44 -05:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// for x in (5..5).step_by(0) { .. }
|
|
|
|
/// ```
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2017-06-18 08:14:46 -05:00
|
|
|
pub ITERATOR_STEP_BY_ZERO,
|
2018-03-28 08:24:26 -05:00
|
|
|
correctness,
|
2017-06-18 08:14:46 -05:00
|
|
|
"using `Iterator::step_by(0)`, which produces an infinite iterator"
|
2015-08-15 11:55:25 -05:00
|
|
|
}
|
2017-06-18 08:14:46 -05:00
|
|
|
|
2017-08-09 02:30:56 -05:00
|
|
|
/// **What it does:** Checks for zipping a collection with the range of
|
|
|
|
/// `0.._.len()`.
|
2015-12-10 18:22:27 -06:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is better expressed with `.enumerate()`.
|
|
|
|
///
|
2016-08-06 02:55:04 -05:00
|
|
|
/// **Known problems:** None.
|
2015-12-10 18:22:27 -06:00
|
|
|
///
|
2016-07-15 17:25:44 -05:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// x.iter().zip(0..x.len())
|
|
|
|
/// ```
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2016-08-06 03:18:36 -05:00
|
|
|
pub RANGE_ZIP_WITH_LEN,
|
2018-03-28 08:24:26 -05:00
|
|
|
complexity,
|
2016-08-06 03:18:36 -05:00
|
|
|
"zipping iterator with a range when `enumerate()` would do"
|
2015-11-03 08:42:52 -06:00
|
|
|
}
|
2015-08-15 11:55:25 -05:00
|
|
|
|
2017-10-07 09:56:45 -05:00
|
|
|
/// **What it does:** Checks for exclusive ranges where 1 is added to the
|
|
|
|
/// upper bound, e.g. `x..(y+1)`.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is more readable with an inclusive range
|
|
|
|
/// like `x..=y`.
|
|
|
|
///
|
2018-08-30 12:06:13 -05:00
|
|
|
/// **Known problems:** Will add unnecessary pair of parentheses when the
|
|
|
|
/// expression is not wrapped in a pair but starts with a opening parenthesis
|
|
|
|
/// and ends with a closing one.
|
2018-09-03 15:01:28 -05:00
|
|
|
/// I.e: `let _ = (f()+1)..(f()+1)` results in `let _ = ((f()+1)..=f())`.
|
2017-10-07 09:56:45 -05:00
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// for x..(y+1) { .. }
|
|
|
|
/// ```
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2017-10-07 09:56:45 -05:00
|
|
|
pub RANGE_PLUS_ONE,
|
2018-08-26 03:57:04 -05:00
|
|
|
complexity,
|
2017-10-07 09:56:45 -05:00
|
|
|
"`x..(y+1)` reads better as `x..=y`"
|
|
|
|
}
|
|
|
|
|
|
|
|
/// **What it does:** Checks for inclusive ranges where 1 is subtracted from
|
|
|
|
/// the upper bound, e.g. `x..=(y-1)`.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is more readable with an exclusive range
|
|
|
|
/// like `x..y`.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// for x..=(y-1) { .. }
|
|
|
|
/// ```
|
2018-03-28 08:24:26 -05:00
|
|
|
declare_clippy_lint! {
|
2017-10-07 09:56:45 -05:00
|
|
|
pub RANGE_MINUS_ONE,
|
2018-08-26 03:57:04 -05:00
|
|
|
complexity,
|
2017-10-07 09:56:45 -05:00
|
|
|
"`x..=(y-1)` reads better as `x..y`"
|
|
|
|
}
|
|
|
|
|
2017-08-09 02:30:56 -05:00
|
|
|
#[derive(Copy, Clone)]
|
2017-10-07 09:56:45 -05:00
|
|
|
pub struct Pass;
|
2015-08-15 11:55:25 -05:00
|
|
|
|
2017-10-07 09:56:45 -05:00
|
|
|
impl LintPass for Pass {
|
2015-08-15 11:55:25 -05:00
|
|
|
fn get_lints(&self) -> LintArray {
|
2017-11-04 14:55:56 -05:00
|
|
|
lint_array!(ITERATOR_STEP_BY_ZERO, RANGE_ZIP_WITH_LEN, RANGE_PLUS_ONE, RANGE_MINUS_ONE)
|
2015-08-15 11:55:25 -05:00
|
|
|
}
|
2015-09-18 21:53:04 -05:00
|
|
|
}
|
2015-08-15 11:55:25 -05:00
|
|
|
|
2017-10-07 09:56:45 -05:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
2016-12-07 06:13:40 -06:00
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2018-07-12 02:30:57 -05:00
|
|
|
if let ExprKind::MethodCall(ref path, _, ref args) = expr.node {
|
2018-06-28 08:46:58 -05:00
|
|
|
let name = path.ident.as_str();
|
2016-11-23 14:19:03 -06:00
|
|
|
|
2015-11-03 08:42:52 -06:00
|
|
|
// Range with step_by(0).
|
2017-06-18 08:14:46 -05:00
|
|
|
if name == "step_by" && args.len() == 2 && has_step_by(cx, &args[0]) {
|
2018-05-30 03:15:50 -05:00
|
|
|
use crate::consts::{constant, Constant};
|
2018-05-13 06:16:31 -05:00
|
|
|
if let Some((Constant::Int(0), _)) = constant(cx, cx.tables, &args[1]) {
|
2018-03-13 05:38:11 -05:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
ITERATOR_STEP_BY_ZERO,
|
|
|
|
expr.span,
|
|
|
|
"Iterator::step_by(0) will panic at runtime",
|
|
|
|
);
|
2017-06-18 08:14:46 -05:00
|
|
|
}
|
2016-11-23 14:19:03 -06:00
|
|
|
} else if name == "zip" && args.len() == 2 {
|
2015-11-03 08:42:52 -06:00
|
|
|
let iter = &args[0].node;
|
2016-03-07 09:31:38 -06:00
|
|
|
let zip_arg = &args[1];
|
2017-10-23 14:18:02 -05:00
|
|
|
if_chain! {
|
2016-06-05 19:09:19 -05:00
|
|
|
// .iter() call
|
2018-07-12 02:30:57 -05:00
|
|
|
if let ExprKind::MethodCall(ref iter_path, _, ref iter_args ) = *iter;
|
2018-06-28 08:46:58 -05:00
|
|
|
if iter_path.ident.name == "iter";
|
2016-06-05 19:09:19 -05:00
|
|
|
// range expression in .zip() call: 0..x.len()
|
2018-05-08 10:16:01 -05:00
|
|
|
if let Some(higher::Range { start: Some(start), end: Some(end), .. }) = higher::range(cx, zip_arg);
|
2017-10-23 14:18:02 -05:00
|
|
|
if is_integer_literal(start, 0);
|
2016-06-05 19:09:19 -05:00
|
|
|
// .len() call
|
2018-07-12 02:30:57 -05:00
|
|
|
if let ExprKind::MethodCall(ref len_path, _, ref len_args) = end.node;
|
2018-06-28 08:46:58 -05:00
|
|
|
if len_path.ident.name == "len" && len_args.len() == 1;
|
2016-06-05 19:09:19 -05:00
|
|
|
// .iter() and .len() called on same Path
|
2018-07-12 02:30:57 -05:00
|
|
|
if let ExprKind::Path(QPath::Resolved(_, ref iter_path)) = iter_args[0].node;
|
|
|
|
if let ExprKind::Path(QPath::Resolved(_, ref len_path)) = len_args[0].node;
|
2018-07-14 17:00:27 -05:00
|
|
|
if SpanlessEq::new(cx).eq_path_segments(&iter_path.segments, &len_path.segments);
|
2017-10-23 14:18:02 -05:00
|
|
|
then {
|
|
|
|
span_lint(cx,
|
|
|
|
RANGE_ZIP_WITH_LEN,
|
|
|
|
expr.span,
|
|
|
|
&format!("It is more idiomatic to use {}.iter().enumerate()",
|
|
|
|
snippet(cx, iter_args[0].span, "_")));
|
|
|
|
}
|
|
|
|
}
|
2015-11-03 08:42:52 -06:00
|
|
|
}
|
2015-08-15 11:55:25 -05:00
|
|
|
}
|
2017-10-07 09:56:45 -05:00
|
|
|
|
|
|
|
// exclusive range plus one: x..(y+1)
|
2017-10-23 14:18:02 -05:00
|
|
|
if_chain! {
|
2018-05-08 10:16:01 -05:00
|
|
|
if let Some(higher::Range { start, end: Some(end), limits: RangeLimits::HalfOpen }) = higher::range(cx, expr);
|
2017-10-23 14:18:02 -05:00
|
|
|
if let Some(y) = y_plus_one(end);
|
|
|
|
then {
|
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
RANGE_PLUS_ONE,
|
|
|
|
expr.span,
|
|
|
|
"an inclusive range would be more readable",
|
|
|
|
|db| {
|
2018-08-21 05:46:18 -05:00
|
|
|
let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
|
2017-10-23 14:18:02 -05:00
|
|
|
let end = Sugg::hir(cx, y, "y");
|
2018-08-30 12:06:13 -05:00
|
|
|
if let Some(is_wrapped) = &snippet_opt(cx, expr.span) {
|
2018-09-04 10:56:48 -05:00
|
|
|
if is_wrapped.starts_with('(') && is_wrapped.ends_with(')') {
|
2018-09-18 10:07:54 -05:00
|
|
|
db.span_suggestion_with_applicability(
|
|
|
|
expr.span,
|
|
|
|
"use",
|
|
|
|
format!("({}..={})", start, end),
|
2018-09-18 12:01:17 -05:00
|
|
|
Applicability::MaybeIncorrect,
|
2018-09-18 10:07:54 -05:00
|
|
|
);
|
2018-08-30 12:06:13 -05:00
|
|
|
} else {
|
2018-09-18 10:07:54 -05:00
|
|
|
db.span_suggestion_with_applicability(
|
|
|
|
expr.span,
|
|
|
|
"use",
|
|
|
|
format!("{}..={}", start, end),
|
2018-09-18 12:01:17 -05:00
|
|
|
Applicability::MachineApplicable, // snippet
|
2018-09-18 10:07:54 -05:00
|
|
|
);
|
2018-08-30 12:06:13 -05:00
|
|
|
}
|
|
|
|
}
|
2017-10-23 14:18:02 -05:00
|
|
|
},
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
2017-10-07 09:56:45 -05:00
|
|
|
|
|
|
|
// inclusive range minus one: x..=(y-1)
|
2017-10-23 14:18:02 -05:00
|
|
|
if_chain! {
|
2018-05-08 10:16:01 -05:00
|
|
|
if let Some(higher::Range { start, end: Some(end), limits: RangeLimits::Closed }) = higher::range(cx, expr);
|
2017-10-23 14:18:02 -05:00
|
|
|
if let Some(y) = y_minus_one(end);
|
|
|
|
then {
|
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
RANGE_MINUS_ONE,
|
|
|
|
expr.span,
|
|
|
|
"an exclusive range would be more readable",
|
|
|
|
|db| {
|
2018-08-21 05:46:18 -05:00
|
|
|
let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
|
2017-10-23 14:18:02 -05:00
|
|
|
let end = Sugg::hir(cx, y, "y");
|
2018-09-18 10:07:54 -05:00
|
|
|
db.span_suggestion_with_applicability(
|
|
|
|
expr.span,
|
|
|
|
"use",
|
|
|
|
format!("{}..{}", start, end),
|
2018-09-18 12:01:17 -05:00
|
|
|
Applicability::MachineApplicable, // snippet
|
2018-09-18 10:07:54 -05:00
|
|
|
);
|
2017-10-23 14:18:02 -05:00
|
|
|
},
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
2015-08-15 11:55:25 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-23 06:01:12 -05:00
|
|
|
fn has_step_by(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
|
2015-08-15 11:55:25 -05:00
|
|
|
// No need for walk_ptrs_ty here because step_by moves self, so it
|
|
|
|
// can't be called on a borrowed range.
|
2017-06-18 08:14:46 -05:00
|
|
|
let ty = cx.tables.expr_ty_adjusted(expr);
|
2016-04-26 06:31:52 -05:00
|
|
|
|
2017-06-29 09:07:43 -05:00
|
|
|
get_trait_def_id(cx, &paths::ITERATOR).map_or(false, |iterator_trait| implements_trait(cx, ty, iterator_trait, &[]))
|
2015-08-15 11:55:25 -05:00
|
|
|
}
|
2017-10-07 09:56:45 -05:00
|
|
|
|
|
|
|
fn y_plus_one(expr: &Expr) -> Option<&Expr> {
|
|
|
|
match expr.node {
|
2018-07-12 02:50:09 -05:00
|
|
|
ExprKind::Binary(Spanned { node: BinOpKind::Add, .. }, ref lhs, ref rhs) => if is_integer_literal(lhs, 1) {
|
2017-11-04 14:55:56 -05:00
|
|
|
Some(rhs)
|
|
|
|
} else if is_integer_literal(rhs, 1) {
|
|
|
|
Some(lhs)
|
|
|
|
} else {
|
|
|
|
None
|
2017-10-07 09:56:45 -05:00
|
|
|
},
|
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn y_minus_one(expr: &Expr) -> Option<&Expr> {
|
|
|
|
match expr.node {
|
2018-07-12 02:50:09 -05:00
|
|
|
ExprKind::Binary(Spanned { node: BinOpKind::Sub, .. }, ref lhs, ref rhs) if is_integer_literal(rhs, 1) => Some(lhs),
|
2017-10-07 09:56:45 -05:00
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|