mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
e6b9bb7b72
rust/tests/ui/fmt/format-string-error.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

126 lines
4.0 KiB
Plaintext
Raw Normal View History

On fmt string with unescaped `{` note how to escape On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a note explaining how to escape the `{` char.
2016-11-10 14:48:55 -06:00
error: invalid format string: expected `'}'` but string was terminated
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/format-string-error.rs:4:16
On fmt string with unescaped `{` note how to escape On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a note explaining how to escape the `{` char.
2016-11-10 14:48:55 -06:00
|
Update UI tests
2018-02-22 18:42:32 -06:00
LL | println!("{");
Various changes to string format diagnostics - Point at opening mismatched formatting brace - Account for differences between raw and regular strings - Account for differences between the code snippet and `InternedString` - Add more tests
2018-12-21 00:33:16 -06:00
| -^ expected `'}'` in format string
| |
| because of this opening brace
On fmt string with unescaped `{` note how to escape On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a note explaining how to escape the `{` char.
2016-11-10 14:48:55 -06:00
|
= note: if you intended to print `{`, you can escape it using `{{`
error: invalid format string: unmatched `}` found
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/format-string-error.rs:7:15
On fmt string with unescaped `{` note how to escape On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a note explaining how to escape the `{` char.
2016-11-10 14:48:55 -06:00
|
Update UI tests
2018-02-22 18:42:32 -06:00
LL | println!("}");
Improve suggestion for missing fmt str in println Avoid using `concat!(fmt, "\n")` to improve the diagnostics being emitted when the first `println!()` argument isn't a formatting string literal.
2018-07-14 22:50:30 -05:00
| ^ unmatched `}` in format string
On fmt string with unescaped `{` note how to escape On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a note explaining how to escape the `{` char.
2016-11-10 14:48:55 -06:00
|
= note: if you intended to print `}`, you can escape it using `}}`
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
error: invalid format string: invalid argument name `_`
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/format-string-error.rs:9:23
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
LL | let _ = format!("{_}", _ = 6usize);
| ^ invalid argument name in format string
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
= note: argument name cannot be a single underscore
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
error: invalid format string: invalid argument name `_`
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:11:25
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
LL | let _ = format!("{a:_}", a = "", _ = 0);
| ^ invalid argument name in format string
|
= note: argument name cannot be a single underscore
error: invalid format string: invalid argument name `_`
--> $DIR/format-string-error.rs:13:26
|
LL | let _ = format!("{a:._$}", a = "", _ = 0);
| ^ invalid argument name in format string
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
= note: argument name cannot be a single underscore
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
error: invalid format string: expected `'}'` but string was terminated
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:15:23
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
LL | let _ = format!("{");
Various changes to string format diagnostics - Point at opening mismatched formatting brace - Account for differences between raw and regular strings - Account for differences between the code snippet and `InternedString` - Add more tests
2018-12-21 00:33:16 -06:00
| -^ expected `'}'` in format string
| |
| because of this opening brace
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
= note: if you intended to print `{`, you can escape it using `{{`
error: invalid format string: unmatched `}` found
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:17:22
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
LL | let _ = format!("}");
| ^ unmatched `}` in format string
|
= note: if you intended to print `}`, you can escape it using `}}`
compiletest: make path normalization smarter
2019-03-12 23:47:36 -05:00
error: invalid format string: expected `'}'`, found `'\'`
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:19:23
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
|
compiletest: make path normalization smarter
2019-03-12 23:47:36 -05:00
LL | let _ = format!("{\}");
Fix quotes in output
2023-07-16 19:32:13 -05:00
| -^ expected `'}'` in format string
Various changes to string format diagnostics - Point at opening mismatched formatting brace - Account for differences between raw and regular strings - Account for differences between the code snippet and `InternedString` - Add more tests
2018-12-21 00:33:16 -06:00
| |
| because of this opening brace
|
= note: if you intended to print `{`, you can escape it using `{{`
Improve format string errors - Point at format string position inside the formatting string - Explain that argument names can't start with an underscore
2018-05-10 11:09:58 -05:00
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
error: invalid format string: expected `'}'` but string was terminated
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:21:35
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
|
compiletest: make path normalization smarter
2019-03-12 23:47:36 -05:00
LL | let _ = format!("\n\n\n{\n\n\n");
Various changes to string format diagnostics - Point at opening mismatched formatting brace - Account for differences between raw and regular strings - Account for differences between the code snippet and `InternedString` - Add more tests
2018-12-21 00:33:16 -06:00
| - ^ expected `'}'` in format string
| |
| because of this opening brace
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
|
= note: if you intended to print `{`, you can escape it using `{{`
error: invalid format string: expected `'}'` but string was terminated
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:27:3
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
|
LL | {"###);
Various changes to string format diagnostics - Point at opening mismatched formatting brace - Account for differences between raw and regular strings - Account for differences between the code snippet and `InternedString` - Add more tests
2018-12-21 00:33:16 -06:00
| -^ expected `'}'` in format string
| |
| because of this opening brace
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
|
= note: if you intended to print `{`, you can escape it using `{{`
error: invalid format string: expected `'}'` but string was terminated
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:35:1
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
|
Various changes to string format diagnostics - Point at opening mismatched formatting brace - Account for differences between raw and regular strings - Account for differences between the code snippet and `InternedString` - Add more tests
2018-12-21 00:33:16 -06:00
LL | {
| - because of this opening brace
fix one more case of trailing space
2022-06-08 13:07:59 -05:00
LL |
Various changes to string format diagnostics - Point at opening mismatched formatting brace - Account for differences between raw and regular strings - Account for differences between the code snippet and `InternedString` - Add more tests
2018-12-21 00:33:16 -06:00
LL | "###);
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
| ^ expected `'}'` in format string
|
= note: if you intended to print `{`, you can escape it using `{{`
error: invalid format string: unmatched `}` found
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:41:2
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
|
LL | }
| ^ unmatched `}` in format string
|
= note: if you intended to print `}`, you can escape it using `}}`
error: invalid format string: unmatched `}` found
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:49:9
Use correct spans for format string errors When encountering format string errors in a raw string, or regular string literal with embedded newlines, account for the positional change to use correct spans. :drive by fix: 🚗
2018-07-20 01:14:00 -05:00
|
LL | }
| ^ unmatched `}` in format string
|
= note: if you intended to print `}`, you can escape it using `}}`
Tweak format string error to point at arguments always Add secondary span labels with no text to make it clear when there's a mismatch bewteen the positional arguments in a format string and the arguments to the macro. This shouldn't affect experienced users, but it should make it easier for newcomers to more clearly understand how `format!()` and `println!()` are supposed to be used. ``` error: 2 positional arguments in format string, but there is 1 argument --> file8.rs:2:14 | 2 | format!("{} {}", 1); | ^^ ^^ - ``` instead of ``` error: 2 positional arguments in format string, but there is 1 argument --> file8.rs:2:14 | 2 | format!("{} {}", 1); | ^^ ^^ ```
2019-10-23 19:32:33 -05:00
error: 3 positional arguments in format string, but there are 2 arguments
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
--> $DIR/format-string-error.rs:53:15
Tweak format string error to point at arguments always Add secondary span labels with no text to make it clear when there's a mismatch bewteen the positional arguments in a format string and the arguments to the macro. This shouldn't affect experienced users, but it should make it easier for newcomers to more clearly understand how `format!()` and `println!()` are supposed to be used. ``` error: 2 positional arguments in format string, but there is 1 argument --> file8.rs:2:14 | 2 | format!("{} {}", 1); | ^^ ^^ - ``` instead of ``` error: 2 positional arguments in format string, but there is 1 argument --> file8.rs:2:14 | 2 | format!("{} {}", 1); | ^^ ^^ ```
2019-10-23 19:32:33 -05:00
|
LL | println!("{} {} {}", 1, 2);
| ^^ ^^ ^^ - -
Allow any identifier as format arg name Previously: error: invalid format string: invalid argument name `_x` --> src/main.rs:2:16 | 2 | println!("{_x}", a=0); | ^^ invalid argument name in format string | = note: argument names cannot start with an underscore Not supporting identifiers starting with underscore appears to have been an arbitrary limitation from 2013 in code that was most likely never reviewed: https://github.com/rust-lang/rust/pull/8245/files#diff-0347868ef389c805e97636623e4a4ea6R277 The error message was dutifully improved in #50610 but is there any reason that leading underscore would be a special case? This commit updates the format_args parser to accept identifiers with leading underscores.
2019-11-28 12:49:13 -06:00
error: aborting due to 14 previous errors
On fmt string with unescaped `{` note how to escape On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a note explaining how to escape the `{` char.
2016-11-10 14:48:55 -06:00
Reference in New Issue Copy Permalink