mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
e603f994b1
rust/src/test/ui/deref-suggestion.stderr

113 lines
3.2 KiB
Plaintext
Raw Normal View History

Add deref suggestion
2017-08-14 17:21:36 -05:00
error[E0308]: mismatched types
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/deref-suggestion.rs:8:9
Add deref suggestion
2017-08-14 17:21:36 -05:00
|
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
LL | foo(s);
type error method suggestions use whitelisted identity-like conversions Previously, on a type mismatch (and if this wasn't preëmpted by a higher-priority suggestion), we would look for argumentless methods returning the expected type, and list them in a `help` note. This had two major shortcomings. Firstly, a lot of the suggestions didn't really make sense (if you used a &str where a String was expected, `.to_ascii_uppercase()` is probably not the solution you were hoping for). Secondly, we weren't generating suggestions from the most useful traits! We address the first problem with an internal `#[rustc_conversion_suggestion]` attribute meant to mark methods that keep the "same value" in the relevant sense, just converting the type. We address the second problem by making `FnCtxt.probe_for_return_type` pass the `ProbeScope::AllTraits` to `probe_op`: this would seem to be safe because grep reveals no other callers of `probe_for_return_type`. Also, structured suggestions are preferred (because they're pretty, but also for RLS and friends). Also also, we make the E0055 autoderef recursion limit error use the one-time-diagnostics set, because we can potentially hit the limit a lot during probing. (Without this, test/ui/did_you_mean/recursion_limit_deref.rs would report "aborting due to 51 errors"). Unfortunately, the trait probing is still not all one would hope for: at a minimum, we don't know how to rule out `into()` in cases where it wouldn't actually work, and we don't know how to rule in `.to_owned()` where it would. Issues #46459 and #46460 have been filed and are ref'd in a FIXME. This is hoped to resolve #42929, #44672, and #45777.
2017-11-19 13:25:35 -06:00
| ^
| |
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
| expected struct `String`, found `&String`
type error method suggestions use whitelisted identity-like conversions Previously, on a type mismatch (and if this wasn't preëmpted by a higher-priority suggestion), we would look for argumentless methods returning the expected type, and list them in a `help` note. This had two major shortcomings. Firstly, a lot of the suggestions didn't really make sense (if you used a &str where a String was expected, `.to_ascii_uppercase()` is probably not the solution you were hoping for). Secondly, we weren't generating suggestions from the most useful traits! We address the first problem with an internal `#[rustc_conversion_suggestion]` attribute meant to mark methods that keep the "same value" in the relevant sense, just converting the type. We address the second problem by making `FnCtxt.probe_for_return_type` pass the `ProbeScope::AllTraits` to `probe_op`: this would seem to be safe because grep reveals no other callers of `probe_for_return_type`. Also, structured suggestions are preferred (because they're pretty, but also for RLS and friends). Also also, we make the E0055 autoderef recursion limit error use the one-time-diagnostics set, because we can potentially hit the limit a lot during probing. (Without this, test/ui/did_you_mean/recursion_limit_deref.rs would report "aborting due to 51 errors"). Unfortunately, the trait probing is still not all one would hope for: at a minimum, we don't know how to rule out `into()` in cases where it wouldn't actually work, and we don't know how to rule in `.to_owned()` where it would. Issues #46459 and #46460 have been filed and are ref'd in a FIXME. This is hoped to resolve #42929, #44672, and #45777.
2017-11-19 13:25:35 -06:00
| help: try using a conversion method: `s.to_string()`
Add deref suggestion
2017-08-14 17:21:36 -05:00
error[E0308]: mismatched types
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/deref-suggestion.rs:14:10
Add deref suggestion
2017-08-14 17:21:36 -05:00
|
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
LL | foo3(u);
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
2017-11-25 08:00:26 -06:00
| ^
| |
Surround types with backticks in type errors
2019-11-15 11:37:01 -06:00
| expected `u32`, found `&u32`
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
2017-11-25 08:00:26 -06:00
| help: consider dereferencing the borrow: `*u`
Add deref suggestion
2017-08-14 17:21:36 -05:00
error[E0308]: mismatched types
Account for short-hand field syntax when suggesting borrow
2019-03-26 21:04:25 -05:00
--> $DIR/deref-suggestion.rs:30:9
Add deref suggestion
2017-08-14 17:21:36 -05:00
|
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
LL | foo(&"aaa".to_owned());
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
2017-11-25 08:00:26 -06:00
| ^^^^^^^^^^^^^^^^^
| |
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
| expected struct `String`, found `&String`
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
2017-11-25 08:00:26 -06:00
| help: consider removing the borrow: `"aaa".to_owned()`
Add deref suggestion
2017-08-14 17:21:36 -05:00
error[E0308]: mismatched types
Account for short-hand field syntax when suggesting borrow
2019-03-26 21:04:25 -05:00
--> $DIR/deref-suggestion.rs:32:9
Add deref suggestion
2017-08-14 17:21:36 -05:00
|
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
LL | foo(&mut "aaa".to_owned());
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
2017-11-25 08:00:26 -06:00
| ^^^^^^^^^^^^^^^^^^^^^
| |
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
| expected struct `String`, found `&mut String`
Use suggestions instead of notes ref mismatches On type mismatch errors, use a suggestion when encountering minimal differences in type differences due to refs, instead of a note.
2017-11-25 08:00:26 -06:00
| help: consider removing the borrow: `"aaa".to_owned()`
Add deref suggestion
2017-08-14 17:21:36 -05:00
error[E0308]: mismatched types
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/deref-suggestion.rs:2:20
Add deref suggestion
2017-08-14 17:21:36 -05:00
|
Update tests
2019-03-09 06:03:44 -06:00
LL | ($x:expr) => { &$x }
Surround types with backticks in type errors
2019-11-15 11:37:01 -06:00
| ^^^ expected `u32`, found `&{integer}`
Add deref suggestion
2017-08-14 17:21:36 -05:00
...
Update UI tests
2018-02-22 18:42:32 -06:00
LL | foo3(borrow!(0));
Add deref suggestion
2017-08-14 17:21:36 -05:00
| ---------- in this macro invocation
rustc_macros: don't limit the -Zmacro-backtrace suggestion to extern macros.
2019-12-16 07:56:47 -06:00
|
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
Add deref suggestion
2017-08-14 17:21:36 -05:00
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
error[E0308]: mismatched types
Account for short-hand field syntax when suggesting borrow
2019-03-26 21:04:25 -05:00
--> $DIR/deref-suggestion.rs:36:5
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
|
LL | assert_eq!(3i32, &3i32);
Surround types with backticks in type errors
2019-11-15 11:37:01 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^ expected `i32`, found `&i32`
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
|
rustc_macros: don't limit the -Zmacro-backtrace suggestion to extern macros.
2019-12-16 07:56:47 -06:00
= note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
Do not suggest dereferencing in macro
2018-08-26 18:54:06 -05:00
Account for short-hand field syntax when suggesting borrow
2019-03-26 21:04:25 -05:00
error[E0308]: mismatched types
--> $DIR/deref-suggestion.rs:39:17
|
LL | let s = S { u };
| ^
| |
Surround types with backticks in type errors
2019-11-15 11:37:01 -06:00
| expected `&u32`, found integer
Account for short-hand field syntax when suggesting borrow
2019-03-26 21:04:25 -05:00
| help: consider borrowing here: `u: &u`
error[E0308]: mismatched types
Expand test
2019-03-26 21:07:15 -05:00
--> $DIR/deref-suggestion.rs:41:20
|
LL | let s = S { u: u };
| ^
| |
Surround types with backticks in type errors
2019-11-15 11:37:01 -06:00
| expected `&u32`, found integer
Expand test
2019-03-26 21:07:15 -05:00
| help: consider borrowing here: `&u`
error[E0308]: mismatched types
--> $DIR/deref-suggestion.rs:44:17
Account for short-hand field syntax when suggesting borrow
2019-03-26 21:04:25 -05:00
|
LL | let r = R { i };
| ^
| |
Surround types with backticks in type errors
2019-11-15 11:37:01 -06:00
| expected `u32`, found `&{integer}`
Account for short-hand field syntax when suggesting borrow
2019-03-26 21:04:25 -05:00
| help: consider dereferencing the borrow: `i: *i`
Expand test
2019-03-26 21:07:15 -05:00
error[E0308]: mismatched types
--> $DIR/deref-suggestion.rs:46:20
|
LL | let r = R { i: i };
| ^
| |
Surround types with backticks in type errors
2019-11-15 11:37:01 -06:00
| expected `u32`, found `&{integer}`
Expand test
2019-03-26 21:07:15 -05:00
| help: consider dereferencing the borrow: `*i`
Properly suggest deref in else block
2020-12-05 18:14:21 -06:00
error[E0308]: mismatched types
--> $DIR/deref-suggestion.rs:55:9
|
LL | b
| ^
| |
| expected `i32`, found `&{integer}`
| help: consider dereferencing the borrow: `*b`
Address review comments Co-authored-by: Léo Lanteri Thauvin <leseulartichaut@gmail.com>
2020-12-17 06:24:51 -06:00
error[E0308]: mismatched types
--> $DIR/deref-suggestion.rs:63:9
|
LL | b
| ^
| |
| expected `i32`, found `&{integer}`
| help: consider dereferencing the borrow: `*b`
error: aborting due to 12 previous errors
Add deref suggestion
2017-08-14 17:21:36 -05:00
update tests
2018-03-03 08:59:40 -06:00
For more information about this error, try `rustc --explain E0308`.
Reference in New Issue Copy Permalink