2019-08-22 00:41:00 -05:00
|
|
|
// run-rustfix
|
|
|
|
|
2019-04-11 00:47:04 -05:00
|
|
|
#![warn(clippy::or_fun_call)]
|
2019-08-22 00:41:00 -05:00
|
|
|
#![allow(dead_code)]
|
2019-04-11 00:47:04 -05:00
|
|
|
|
|
|
|
use std::collections::BTreeMap;
|
|
|
|
use std::collections::HashMap;
|
2019-05-12 03:18:38 -05:00
|
|
|
use std::time::Duration;
|
2019-04-11 00:47:04 -05:00
|
|
|
|
|
|
|
/// Checks implementation of the `OR_FUN_CALL` lint.
|
|
|
|
fn or_fun_call() {
|
|
|
|
struct Foo;
|
|
|
|
|
|
|
|
impl Foo {
|
|
|
|
fn new() -> Foo {
|
|
|
|
Foo
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
enum Enum {
|
|
|
|
A(i32),
|
|
|
|
}
|
|
|
|
|
|
|
|
fn make<T>() -> T {
|
|
|
|
unimplemented!();
|
|
|
|
}
|
|
|
|
|
|
|
|
let with_enum = Some(Enum::A(1));
|
|
|
|
with_enum.unwrap_or(Enum::A(5));
|
|
|
|
|
2019-05-12 03:18:38 -05:00
|
|
|
let with_const_fn = Some(Duration::from_secs(1));
|
|
|
|
with_const_fn.unwrap_or(Duration::from_secs(5));
|
2019-04-11 00:47:04 -05:00
|
|
|
|
|
|
|
let with_constructor = Some(vec![1]);
|
|
|
|
with_constructor.unwrap_or(make());
|
|
|
|
|
|
|
|
let with_new = Some(vec![1]);
|
|
|
|
with_new.unwrap_or(Vec::new());
|
|
|
|
|
|
|
|
let with_const_args = Some(vec![1]);
|
|
|
|
with_const_args.unwrap_or(Vec::with_capacity(12));
|
|
|
|
|
|
|
|
let with_err: Result<_, ()> = Ok(vec![1]);
|
|
|
|
with_err.unwrap_or(make());
|
|
|
|
|
|
|
|
let with_err_args: Result<_, ()> = Ok(vec![1]);
|
|
|
|
with_err_args.unwrap_or(Vec::with_capacity(12));
|
|
|
|
|
|
|
|
let with_default_trait = Some(1);
|
|
|
|
with_default_trait.unwrap_or(Default::default());
|
|
|
|
|
|
|
|
let with_default_type = Some(1);
|
|
|
|
with_default_type.unwrap_or(u64::default());
|
|
|
|
|
|
|
|
let with_vec = Some(vec![1]);
|
|
|
|
with_vec.unwrap_or(vec![]);
|
|
|
|
|
|
|
|
let without_default = Some(Foo);
|
|
|
|
without_default.unwrap_or(Foo::new());
|
|
|
|
|
|
|
|
let mut map = HashMap::<u64, String>::new();
|
|
|
|
map.entry(42).or_insert(String::new());
|
|
|
|
|
|
|
|
let mut btree = BTreeMap::<u64, String>::new();
|
|
|
|
btree.entry(42).or_insert(String::new());
|
|
|
|
|
|
|
|
let stringy = Some(String::from(""));
|
|
|
|
let _ = stringy.unwrap_or("".to_owned());
|
2019-04-24 01:11:20 -05:00
|
|
|
|
|
|
|
let opt = Some(1);
|
|
|
|
let hello = "Hello";
|
|
|
|
let _ = opt.ok_or(format!("{} world.", hello));
|
2019-04-11 00:47:04 -05:00
|
|
|
}
|
|
|
|
|
2019-05-12 02:32:39 -05:00
|
|
|
struct Foo(u8);
|
2019-05-12 03:18:38 -05:00
|
|
|
struct Bar(String, Duration);
|
2019-05-12 02:32:39 -05:00
|
|
|
#[rustfmt::skip]
|
|
|
|
fn test_or_with_ctors() {
|
|
|
|
let opt = Some(1);
|
|
|
|
let opt_opt = Some(Some(1));
|
|
|
|
// we also test for const promotion, this makes sure we don't hit that
|
|
|
|
let two = 2;
|
|
|
|
|
|
|
|
let _ = opt_opt.unwrap_or(Some(2));
|
|
|
|
let _ = opt_opt.unwrap_or(Some(two));
|
|
|
|
let _ = opt.ok_or(Some(2));
|
|
|
|
let _ = opt.ok_or(Some(two));
|
|
|
|
let _ = opt.ok_or(Foo(2));
|
|
|
|
let _ = opt.ok_or(Foo(two));
|
|
|
|
let _ = opt.or(Some(2));
|
|
|
|
let _ = opt.or(Some(two));
|
2019-05-12 03:18:38 -05:00
|
|
|
|
|
|
|
let _ = Some("a".to_string()).or(Some("b".to_string()));
|
|
|
|
|
|
|
|
let b = "b".to_string();
|
|
|
|
let _ = Some(Bar("a".to_string(), Duration::from_secs(1)))
|
|
|
|
.or(Some(Bar(b, Duration::from_secs(2))));
|
2019-05-12 02:32:39 -05:00
|
|
|
}
|
|
|
|
|
2019-09-08 04:03:45 -05:00
|
|
|
// Issue 4514 - early return
|
|
|
|
fn f() -> Option<()> {
|
|
|
|
let a = Some(1);
|
|
|
|
let b = 1i32;
|
|
|
|
|
|
|
|
let _ = a.unwrap_or(b.checked_mul(3)?.min(240));
|
|
|
|
|
|
|
|
Some(())
|
|
|
|
}
|
|
|
|
|
2019-04-11 00:47:04 -05:00
|
|
|
fn main() {}
|