2019-09-25 07:03:28 -05:00
|
|
|
// run-rustfix
|
|
|
|
|
2022-06-16 10:39:06 -05:00
|
|
|
#![feature(lint_reasons)]
|
|
|
|
|
2019-09-25 07:03:28 -05:00
|
|
|
#[warn(clippy::all, clippy::needless_borrow)]
|
2021-12-06 05:33:31 -06:00
|
|
|
#[allow(unused_variables, clippy::unnecessary_mut_passed)]
|
2019-09-25 07:03:28 -05:00
|
|
|
fn main() {
|
|
|
|
let a = 5;
|
2021-12-06 05:33:31 -06:00
|
|
|
let ref_a = &a;
|
2021-09-28 12:03:12 -05:00
|
|
|
let _ = x(&a); // no warning
|
|
|
|
let _ = x(&a); // warn
|
|
|
|
|
|
|
|
let mut b = 5;
|
|
|
|
mut_ref(&mut b); // no warning
|
|
|
|
mut_ref(&mut b); // warn
|
|
|
|
|
2019-09-25 07:03:28 -05:00
|
|
|
let s = &String::from("hi");
|
|
|
|
let s_ident = f(&s); // should not error, because `&String` implements Copy, but `String` does not
|
|
|
|
let g_val = g(&Vec::new()); // should not error, because `&Vec<T>` derefs to `&[T]`
|
|
|
|
let vec = Vec::new();
|
|
|
|
let vec_val = g(&vec); // should not error, because `&Vec<T>` derefs to `&[T]`
|
|
|
|
h(&"foo"); // should not error, because the `&&str` is required, due to `&Trait`
|
|
|
|
let garbl = match 42 {
|
|
|
|
44 => &a,
|
|
|
|
45 => {
|
|
|
|
println!("foo");
|
2021-12-06 05:33:31 -06:00
|
|
|
&a
|
2019-09-25 07:03:28 -05:00
|
|
|
},
|
|
|
|
46 => &a,
|
2021-12-06 05:33:31 -06:00
|
|
|
47 => {
|
|
|
|
println!("foo");
|
|
|
|
loop {
|
|
|
|
println!("{}", a);
|
|
|
|
if a == 25 {
|
|
|
|
break ref_a;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
},
|
2019-09-25 07:03:28 -05:00
|
|
|
_ => panic!(),
|
|
|
|
};
|
2021-12-06 05:33:31 -06:00
|
|
|
|
|
|
|
let _ = x(&a);
|
|
|
|
let _ = x(&a);
|
|
|
|
let _ = x(&mut b);
|
|
|
|
let _ = x(ref_a);
|
|
|
|
{
|
|
|
|
let b = &mut b;
|
|
|
|
x(b);
|
|
|
|
}
|
2022-01-27 08:12:45 -06:00
|
|
|
|
|
|
|
// Issue #8191
|
|
|
|
let mut x = 5;
|
|
|
|
let mut x = &mut x;
|
|
|
|
|
|
|
|
mut_ref(x);
|
|
|
|
mut_ref(x);
|
|
|
|
let y: &mut i32 = x;
|
|
|
|
let y: &mut i32 = x;
|
|
|
|
|
|
|
|
let y = match 0 {
|
|
|
|
// Don't lint. Removing the borrow would move 'x'
|
|
|
|
0 => &mut x,
|
|
|
|
_ => &mut *x,
|
|
|
|
};
|
2022-06-30 03:50:09 -05:00
|
|
|
let y: &mut i32 = match 0 {
|
|
|
|
// Lint here. The type given above triggers auto-borrow.
|
|
|
|
0 => x,
|
|
|
|
_ => &mut *x,
|
|
|
|
};
|
|
|
|
fn ref_mut_i32(_: &mut i32) {}
|
|
|
|
ref_mut_i32(match 0 {
|
|
|
|
// Lint here. The type given above triggers auto-borrow.
|
|
|
|
0 => x,
|
|
|
|
_ => &mut *x,
|
|
|
|
});
|
|
|
|
// use 'x' after to make sure it's still usable in the fixed code.
|
2022-01-27 08:12:45 -06:00
|
|
|
*x = 5;
|
|
|
|
|
|
|
|
let s = String::new();
|
2022-02-16 22:14:39 -06:00
|
|
|
// let _ = (&s).len();
|
|
|
|
// let _ = (&s).capacity();
|
|
|
|
// let _ = (&&s).capacity();
|
2022-01-27 08:12:45 -06:00
|
|
|
|
|
|
|
let x = (1, 2);
|
|
|
|
let _ = x.0;
|
|
|
|
let x = &x as *const (i32, i32);
|
|
|
|
let _ = unsafe { (*x).0 };
|
2022-06-30 03:50:09 -05:00
|
|
|
|
|
|
|
// Issue #8367
|
|
|
|
trait Foo {
|
|
|
|
fn foo(self);
|
|
|
|
}
|
|
|
|
impl Foo for &'_ () {
|
|
|
|
fn foo(self) {}
|
|
|
|
}
|
|
|
|
(&()).foo(); // Don't lint. `()` doesn't implement `Foo`
|
|
|
|
(&()).foo();
|
|
|
|
|
|
|
|
impl Foo for i32 {
|
|
|
|
fn foo(self) {}
|
|
|
|
}
|
|
|
|
impl Foo for &'_ i32 {
|
|
|
|
fn foo(self) {}
|
|
|
|
}
|
|
|
|
(&5).foo(); // Don't lint. `5` will call `<i32 as Foo>::foo`
|
|
|
|
(&5).foo();
|
|
|
|
|
|
|
|
trait FooRef {
|
|
|
|
fn foo_ref(&self);
|
|
|
|
}
|
|
|
|
impl FooRef for () {
|
|
|
|
fn foo_ref(&self) {}
|
|
|
|
}
|
|
|
|
impl FooRef for &'_ () {
|
|
|
|
fn foo_ref(&self) {}
|
|
|
|
}
|
|
|
|
(&&()).foo_ref(); // Don't lint. `&()` will call `<() as FooRef>::foo_ref`
|
2019-09-25 07:03:28 -05:00
|
|
|
}
|
|
|
|
|
2021-09-28 12:03:12 -05:00
|
|
|
#[allow(clippy::needless_borrowed_reference)]
|
|
|
|
fn x(y: &i32) -> i32 {
|
|
|
|
*y
|
|
|
|
}
|
|
|
|
|
|
|
|
fn mut_ref(y: &mut i32) {
|
|
|
|
*y = 5;
|
|
|
|
}
|
|
|
|
|
2019-09-25 07:03:28 -05:00
|
|
|
fn f<T: Copy>(y: &T) -> T {
|
|
|
|
*y
|
|
|
|
}
|
|
|
|
|
|
|
|
fn g(y: &[u8]) -> u8 {
|
|
|
|
y[0]
|
|
|
|
}
|
|
|
|
|
|
|
|
trait Trait {}
|
|
|
|
|
|
|
|
impl<'a> Trait for &'a str {}
|
|
|
|
|
|
|
|
fn h(_: &dyn Trait) {}
|
2022-06-16 10:39:06 -05:00
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn check_expect_suppression() {
|
|
|
|
let a = 5;
|
|
|
|
#[expect(clippy::needless_borrow)]
|
|
|
|
let _ = x(&&a);
|
|
|
|
}
|