rust/tests/ui/bool_assert_comparison.rs

170 lines
4.5 KiB
Rust
Raw Normal View History

#![allow(unused, clippy::assertions_on_constants)]
#![warn(clippy::bool_assert_comparison)]
2021-08-26 09:15:04 -05:00
use std::ops::Not;
macro_rules! a {
() => {
true
};
}
macro_rules! b {
() => {
true
};
}
2021-08-26 09:15:04 -05:00
// Implements the Not trait but with an output type
// that's not bool. Should not suggest a rewrite
#[derive(Debug, Clone, Copy)]
2021-08-31 02:06:14 -05:00
enum ImplNotTraitWithoutBool {
2021-08-26 09:15:04 -05:00
VariantX(bool),
VariantY(u32),
}
2021-08-31 02:06:14 -05:00
impl PartialEq<bool> for ImplNotTraitWithoutBool {
2021-08-26 09:15:04 -05:00
fn eq(&self, other: &bool) -> bool {
match *self {
2021-08-31 02:06:14 -05:00
ImplNotTraitWithoutBool::VariantX(b) => b == *other,
2021-08-26 09:15:04 -05:00
_ => false,
}
}
}
2021-08-31 02:06:14 -05:00
impl Not for ImplNotTraitWithoutBool {
2021-08-26 09:15:04 -05:00
type Output = Self;
fn not(self) -> Self::Output {
match self {
2021-08-31 02:06:14 -05:00
ImplNotTraitWithoutBool::VariantX(b) => ImplNotTraitWithoutBool::VariantX(!b),
ImplNotTraitWithoutBool::VariantY(0) => ImplNotTraitWithoutBool::VariantY(1),
ImplNotTraitWithoutBool::VariantY(_) => ImplNotTraitWithoutBool::VariantY(0),
2021-08-26 09:15:04 -05:00
}
}
}
// This type implements the Not trait with an Output of
// type bool. Using assert!(..) must be suggested
#[derive(Debug, Clone, Copy)]
2021-08-31 02:06:14 -05:00
struct ImplNotTraitWithBool;
2021-08-26 09:15:04 -05:00
2021-08-31 02:06:14 -05:00
impl PartialEq<bool> for ImplNotTraitWithBool {
2021-08-26 09:15:04 -05:00
fn eq(&self, other: &bool) -> bool {
false
}
}
2021-08-31 02:06:14 -05:00
impl Not for ImplNotTraitWithBool {
2021-08-26 09:15:04 -05:00
type Output = bool;
fn not(self) -> Self::Output {
true
}
}
#[derive(Debug)]
struct NonCopy;
impl PartialEq<bool> for NonCopy {
fn eq(&self, other: &bool) -> bool {
false
}
}
impl Not for NonCopy {
type Output = bool;
fn not(self) -> Self::Output {
true
}
}
fn main() {
2021-08-31 02:06:14 -05:00
let a = ImplNotTraitWithoutBool::VariantX(true);
let b = ImplNotTraitWithBool;
2021-08-26 09:15:04 -05:00
assert_eq!("a".len(), 1);
assert_eq!("a".is_empty(), false);
assert_eq!("".is_empty(), true);
assert_eq!(true, "".is_empty());
assert_eq!(a!(), b!());
assert_eq!(a!(), "".is_empty());
assert_eq!("".is_empty(), b!());
2021-08-26 09:15:04 -05:00
assert_eq!(a, true);
assert_eq!(b, true);
assert_ne!("a".len(), 1);
assert_ne!("a".is_empty(), false);
assert_ne!("".is_empty(), true);
assert_ne!(true, "".is_empty());
assert_ne!(a!(), b!());
assert_ne!(a!(), "".is_empty());
assert_ne!("".is_empty(), b!());
2021-08-26 09:15:04 -05:00
assert_ne!(a, true);
assert_ne!(b, true);
debug_assert_eq!("a".len(), 1);
debug_assert_eq!("a".is_empty(), false);
debug_assert_eq!("".is_empty(), true);
debug_assert_eq!(true, "".is_empty());
debug_assert_eq!(a!(), b!());
debug_assert_eq!(a!(), "".is_empty());
debug_assert_eq!("".is_empty(), b!());
2021-08-26 09:15:04 -05:00
debug_assert_eq!(a, true);
debug_assert_eq!(b, true);
debug_assert_ne!("a".len(), 1);
debug_assert_ne!("a".is_empty(), false);
debug_assert_ne!("".is_empty(), true);
debug_assert_ne!(true, "".is_empty());
debug_assert_ne!(a!(), b!());
debug_assert_ne!(a!(), "".is_empty());
debug_assert_ne!("".is_empty(), b!());
2021-08-26 09:15:04 -05:00
debug_assert_ne!(a, true);
debug_assert_ne!(b, true);
// assert with error messages
assert_eq!("a".len(), 1, "tadam {}", 1);
assert_eq!("a".len(), 1, "tadam {}", true);
assert_eq!("a".is_empty(), false, "tadam {}", 1);
assert_eq!("a".is_empty(), false, "tadam {}", true);
assert_eq!(false, "a".is_empty(), "tadam {}", true);
2021-08-26 09:15:04 -05:00
assert_eq!(a, true, "tadam {}", false);
debug_assert_eq!("a".len(), 1, "tadam {}", 1);
debug_assert_eq!("a".len(), 1, "tadam {}", true);
debug_assert_eq!("a".is_empty(), false, "tadam {}", 1);
debug_assert_eq!("a".is_empty(), false, "tadam {}", true);
debug_assert_eq!(false, "a".is_empty(), "tadam {}", true);
2021-08-26 09:15:04 -05:00
debug_assert_eq!(a, true, "tadam {}", false);
assert_eq!(a!(), true);
assert_eq!(true, b!());
use debug_assert_eq as renamed;
renamed!(a, true);
renamed!(b, true);
let non_copy = NonCopy;
assert_eq!(non_copy, true);
// changing the above to `assert!(non_copy)` would cause a `borrow of moved value`
println!("{non_copy:?}");
macro_rules! in_macro {
($v:expr) => {{
assert_eq!($v, true);
}};
}
in_macro!(a);
assert_eq!("".is_empty(), true);
assert_ne!("".is_empty(), false);
assert_ne!("requires negation".is_empty(), true);
assert_eq!("requires negation".is_empty(), false);
debug_assert_eq!("".is_empty(), true);
debug_assert_ne!("".is_empty(), false);
debug_assert_ne!("requires negation".is_empty(), true);
debug_assert_eq!("requires negation".is_empty(), false);
}