mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
df5c2cf9bc
rust/tests/ui/rfcs/rfc-2008-non-exhaustive/enum.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

60 lines
1.9 KiB
Plaintext
Raw Normal View History

pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error[E0004]: non-exhaustive patterns: type `EmptyNonExhaustiveEnum` is non-empty
Add tests
2019-11-30 09:51:26 -06:00
--> $DIR/enum.rs:7:11
|
LL | match x {}
| ^
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `EmptyNonExhaustiveEnum` defined here
--> $DIR/auxiliary/enums.rs:18:1
|
LL | pub enum EmptyNonExhaustiveEnum {}
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Improve error message for non-exhaustive matches on non-exhaustive enums
2021-05-12 12:25:12 -05:00
= note: the matched value is of type `EmptyNonExhaustiveEnum`, which is marked as non-exhaustive
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern as shown
When encountering a match expr with no arms, suggest it Given ```rust match Some(42) {} ``` suggest ```rust match Some(42) { None | Some(_) => todo!(), } ```
2021-12-15 20:05:58 -06:00
|
LL ~ match x {
LL + _ => todo!(),
LL ~ }
|
Add tests
2019-11-30 09:51:26 -06:00
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
error[E0004]: non-exhaustive patterns: `_` not covered
Add tests
2019-11-30 09:51:26 -06:00
--> $DIR/enum.rs:16:11
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
|
LL | match enum_unit {
| ^^^^^^^^^ pattern `_` not covered
Point at enum definition when match patterns are not exhaustive ``` error[E0004]: non-exhaustive patterns: type `X` is non-empty --> file.rs:9:11 | 1 | / enum X { 2 | | A, | | - variant not covered 3 | | B, | | - variant not covered 4 | | C, | | - variant not covered 5 | | } | |_- `X` defined here ... 9 | match x { | ^ | = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms error[E0004]: non-exhaustive patterns: `B` and `C` not covered --> file.rs:11:11 | 1 | / enum X { 2 | | A, 3 | | B, 4 | | C, | | - not covered 5 | | } | |_- `X` defined here ... 11 | match x { | ^ patterns `C` not covered ``` When a match expression doesn't have patterns covering every variant, point at the enum's definition span. On a best effort basis, point at the variant(s) that are missing. This does not handle the case when the missing pattern is due to a field's enum variants: ``` enum E1 { A, B, C, } enum E2 { A(E1), B, } fn foo() { match E2::A(E1::A) { E2::A(E1::B) => {} E2::B => {} } //~^ ERROR `E2::A(E1::A)` and `E2::A(E1::C)` not handled } ``` Unify look between match with no arms and match with some missing patterns. Fix #37518.
2019-02-10 07:12:00 -06:00
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `NonExhaustiveEnum` defined here
--> $DIR/auxiliary/enums.rs:4:1
|
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
LL | pub enum NonExhaustiveEnum {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Improve error message for non-exhaustive matches on non-exhaustive enums
2021-05-12 12:25:12 -05:00
= note: the matched value is of type `NonExhaustiveEnum`, which is marked as non-exhaustive
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
|
LL ~ NonExhaustiveEnum::Struct { .. } => "third",
LL + _ => todo!()
|
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
Forgot to update some test outputs
2019-12-04 10:04:44 -06:00
error[E0004]: non-exhaustive patterns: `_` not covered
Add tests
2019-11-30 09:51:26 -06:00
--> $DIR/enum.rs:23:11
|
LL | match enum_unit {};
Forgot to update some test outputs
2019-12-04 10:04:44 -06:00
| ^^^^^^^^^ pattern `_` not covered
Add tests
2019-11-30 09:51:26 -06:00
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `NonExhaustiveEnum` defined here
--> $DIR/auxiliary/enums.rs:4:1
|
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
LL | pub enum NonExhaustiveEnum {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Improve error message for non-exhaustive matches on non-exhaustive enums
2021-05-12 12:25:12 -05:00
= note: the matched value is of type `NonExhaustiveEnum`, which is marked as non-exhaustive
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
When encountering a match expr with no arms, suggest it Given ```rust match Some(42) {} ``` suggest ```rust match Some(42) { None | Some(_) => todo!(), } ```
2021-12-15 20:05:58 -06:00
|
LL ~ match enum_unit {
LL + _ => todo!(),
LL ~ };
|
Add tests
2019-11-30 09:51:26 -06:00
error: aborting due to 3 previous errors
Moved compile-fail tests to ui tests.
2018-08-08 07:28:26 -05:00
For more information about this error, try `rustc --explain E0004`.
Reference in New Issue Copy Permalink