mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
df5c2cf9bc
rust/tests/ui/lint/rfc-2457-non-ascii-idents/lint-confusable-idents.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

27 lines
706 B
Plaintext
Raw Normal View History

Refactor non_ascii_idents lints, exclude ascii pair for confusable_idents lint.
2020-05-09 20:10:15 -05:00
error: identifier pair considered confusable between `ｓ` and `s`
Stablize `non_ascii_idents` feature.
2021-04-02 21:35:11 -05:00
--> $DIR/lint-confusable-idents.rs:8:9
Implement `confusable_idents` lint.
2020-04-24 20:38:31 -05:00
|
LL | const ｓ: usize = 42;
Refactor non_ascii_idents lints, exclude ascii pair for confusable_idents lint.
2020-05-09 20:10:15 -05:00
| -- this is where the previous identifier occurred
Implement `confusable_idents` lint.
2020-04-24 20:38:31 -05:00
...
LL | let s = "rust";
Refactor non_ascii_idents lints, exclude ascii pair for confusable_idents lint.
2020-05-09 20:10:15 -05:00
| ^
Implement `confusable_idents` lint.
2020-04-24 20:38:31 -05:00
|
note: the lint level is defined here
Stablize `non_ascii_idents` feature.
2021-04-02 21:35:11 -05:00
--> $DIR/lint-confusable-idents.rs:1:9
Implement `confusable_idents` lint.
2020-04-24 20:38:31 -05:00
|
LL | #![deny(confusable_idents)]
| ^^^^^^^^^^^^^^^^^
Fix symbol ordering for confusable idents detection. Confusable idents detection uses a type `BTreeMap<Symbol, Span>`. This is highly dubious given that `Symbol` doesn't guarantee a meaningful order. (In practice, it currently gives an order that mostly matches source code order.) As a result, changes in `Symbol` representation make the `lint-confusable-idents.rs` test fail, because this error message: > identifier pair considered confusable between `ｓ` and `s` is changed to this: > identifier pair considered confusable between `s` and `ｓ` and the corresponding span pointers get swapped erroneously, leading to an incorrect "previous identifier" label. This commit sorts the relevant symbols by span before doing the checking, which ensures that the ident that appears first in the code will be mentioned first in the message. The commit also extends the test slightly to be more thorough.
2020-08-05 02:29:13 -05:00
error: identifier pair considered confusable between `s_s` and `ｓ_ｓ`
Stablize `non_ascii_idents` feature.
2021-04-02 21:35:11 -05:00
--> $DIR/lint-confusable-idents.rs:9:9
Fix symbol ordering for confusable idents detection. Confusable idents detection uses a type `BTreeMap<Symbol, Span>`. This is highly dubious given that `Symbol` doesn't guarantee a meaningful order. (In practice, it currently gives an order that mostly matches source code order.) As a result, changes in `Symbol` representation make the `lint-confusable-idents.rs` test fail, because this error message: > identifier pair considered confusable between `ｓ` and `s` is changed to this: > identifier pair considered confusable between `s` and `ｓ` and the corresponding span pointers get swapped erroneously, leading to an incorrect "previous identifier" label. This commit sorts the relevant symbols by span before doing the checking, which ensures that the ident that appears first in the code will be mentioned first in the message. The commit also extends the test slightly to be more thorough.
2020-08-05 02:29:13 -05:00
|
LL | const s_s: usize = 42;
| --- this is where the previous identifier occurred
...
LL | let ｓ_ｓ = "rust2";
| ^^^^^
error: aborting due to 2 previous errors
Implement `confusable_idents` lint.
2020-04-24 20:38:31 -05:00
Reference in New Issue Copy Permalink