mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
de96f3d873
rust/tests/ui/suggestions/match-prev-arm-needing-semi.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

112 lines
3.2 KiB
Plaintext
Raw Normal View History

Suggest semicolon removal on prior match arm
2020-10-21 21:08:28 -05:00
error[E0308]: `match` arms have incompatible types
Remove confusing 'while checking' note from opaque future type mismatches
2023-01-22 10:28:23 -06:00
--> $DIR/match-prev-arm-needing-semi.rs:26:18
Suggest semicolon removal on prior match arm
2020-10-21 21:08:28 -05:00
|
LL | let _ = match true {
| _____________-
LL | | true => {
LL | | async_dummy();
| | -------------- this is found to be of type `()`
LL | |
LL | | }
LL | | false => async_dummy(),
fix: improve the suggestion on future not awaited Considering the following code ```rust fn foo() -> u8 { async fn async_fn() -> u8 { 22 } async_fn() } fn main() {} ``` the error generated before this commit from the compiler is ``` ➜ rust git:(macros/async_fn_suggestion) ✗ rustc test.rs --edition 2021 error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found opaque type | = note: expected type `u8` found opaque type `impl Future<Output = u8>` help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` In this case the error is nor perfect, and can confuse the user that do not know that the opaque type is the future. So this commit will propose (and conclude the work start in https://github.com/rust-lang/rust/issues/80658) to change the string `opaque type` to `future` when applicable and also remove the Expected vs Received note by adding a more specific one regarding the async function that return a future type. So the new error emitted by the compiler is ``` error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found future | note: calling an async function returns a future --> test.rs:4:5 | 4 | async_fn() | ^^^^^^^^^^ help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
2023-02-10 12:03:54 -06:00
| | ^^^^^^^^^^^^^ expected `()`, found future
Suggest semicolon removal on prior match arm
2020-10-21 21:08:28 -05:00
... |
LL | |
LL | | };
| |_____- `match` arms have incompatible types
|
fix: improve the suggestion on future not awaited Considering the following code ```rust fn foo() -> u8 { async fn async_fn() -> u8 { 22 } async_fn() } fn main() {} ``` the error generated before this commit from the compiler is ``` ➜ rust git:(macros/async_fn_suggestion) ✗ rustc test.rs --edition 2021 error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found opaque type | = note: expected type `u8` found opaque type `impl Future<Output = u8>` help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` In this case the error is nor perfect, and can confuse the user that do not know that the opaque type is the future. So this commit will propose (and conclude the work start in https://github.com/rust-lang/rust/issues/80658) to change the string `opaque type` to `future` when applicable and also remove the Expected vs Received note by adding a more specific one regarding the async function that return a future type. So the new error emitted by the compiler is ``` error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found future | note: calling an async function returns a future --> test.rs:4:5 | 4 | async_fn() | ^^^^^^^^^^ help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
2023-02-10 12:03:54 -06:00
note: calling an async function returns a future
--> $DIR/match-prev-arm-needing-semi.rs:26:18
|
LL | false => async_dummy(),
| ^^^^^^^^^^^^^
Suggest semicolon removal on prior match arm
2020-10-21 21:08:28 -05:00
help: consider `await`ing on the `Future`
|
LL | false => async_dummy().await,
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
| ++++++
Update 'match-prev-arm-needing-semi'
2021-02-11 11:17:57 -06:00
help: consider removing this semicolon
Add more `.await` suggestions on E0308
2020-10-22 21:03:36 -05:00
|
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
LL - async_dummy();
LL + async_dummy()
diagnostics: fix trailing space
2022-06-08 12:34:57 -05:00
|
Suggest semicolon removal on prior match arm
2020-10-21 21:08:28 -05:00
Account for possible boxable `impl Future` in semicolon removal suggestions
2020-10-21 21:43:15 -05:00
error[E0308]: `match` arms have incompatible types
Remove confusing 'while checking' note from opaque future type mismatches
2023-01-22 10:28:23 -06:00
--> $DIR/match-prev-arm-needing-semi.rs:39:18
Account for possible boxable `impl Future` in semicolon removal suggestions
2020-10-21 21:43:15 -05:00
|
LL | let _ = match true {
| _____________-
LL | | true => {
LL | | async_dummy();
| | -------------- this is found to be of type `()`
LL | |
LL | | }
LL | | false => async_dummy2(),
fix: improve the suggestion on future not awaited Considering the following code ```rust fn foo() -> u8 { async fn async_fn() -> u8 { 22 } async_fn() } fn main() {} ``` the error generated before this commit from the compiler is ``` ➜ rust git:(macros/async_fn_suggestion) ✗ rustc test.rs --edition 2021 error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found opaque type | = note: expected type `u8` found opaque type `impl Future<Output = u8>` help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` In this case the error is nor perfect, and can confuse the user that do not know that the opaque type is the future. So this commit will propose (and conclude the work start in https://github.com/rust-lang/rust/issues/80658) to change the string `opaque type` to `future` when applicable and also remove the Expected vs Received note by adding a more specific one regarding the async function that return a future type. So the new error emitted by the compiler is ``` error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found future | note: calling an async function returns a future --> test.rs:4:5 | 4 | async_fn() | ^^^^^^^^^^ help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
2023-02-10 12:03:54 -06:00
| | ^^^^^^^^^^^^^^ expected `()`, found future
Account for possible boxable `impl Future` in semicolon removal suggestions
2020-10-21 21:43:15 -05:00
... |
LL | |
LL | | };
| |_____- `match` arms have incompatible types
|
fix: improve the suggestion on future not awaited Considering the following code ```rust fn foo() -> u8 { async fn async_fn() -> u8 { 22 } async_fn() } fn main() {} ``` the error generated before this commit from the compiler is ``` ➜ rust git:(macros/async_fn_suggestion) ✗ rustc test.rs --edition 2021 error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found opaque type | = note: expected type `u8` found opaque type `impl Future<Output = u8>` help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` In this case the error is nor perfect, and can confuse the user that do not know that the opaque type is the future. So this commit will propose (and conclude the work start in https://github.com/rust-lang/rust/issues/80658) to change the string `opaque type` to `future` when applicable and also remove the Expected vs Received note by adding a more specific one regarding the async function that return a future type. So the new error emitted by the compiler is ``` error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found future | note: calling an async function returns a future --> test.rs:4:5 | 4 | async_fn() | ^^^^^^^^^^ help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
2023-02-10 12:03:54 -06:00
note: calling an async function returns a future
--> $DIR/match-prev-arm-needing-semi.rs:39:18
|
LL | false => async_dummy2(),
| ^^^^^^^^^^^^^^
Account for possible boxable `impl Future` in semicolon removal suggestions
2020-10-21 21:43:15 -05:00
help: consider `await`ing on the `Future`
|
LL | false => async_dummy2().await,
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
| ++++++
Suggest semicolon removal and boxing when appropriate
2020-10-22 22:02:55 -05:00
help: consider removing this semicolon and boxing the expressions
|
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
LL ~ Box::new(async_dummy())
Suggest semicolon removal and boxing when appropriate
2020-10-22 22:02:55 -05:00
LL |
LL | }
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
LL ~ false => Box::new(async_dummy2()),
Add more `.await` suggestions on E0308
2020-10-22 21:03:36 -05:00
|
Account for possible boxable `impl Future` in semicolon removal suggestions
2020-10-21 21:43:15 -05:00
Add test case for different `impl Future`s
2020-10-22 13:34:46 -05:00
error[E0308]: `match` arms have incompatible types
Remove confusing 'while checking' note from opaque future type mismatches
2023-01-22 10:28:23 -06:00
--> $DIR/match-prev-arm-needing-semi.rs:50:18
Add test case for different `impl Future`s
2020-10-22 13:34:46 -05:00
|
LL | let _ = match true {
| _____________-
LL | | true => async_dummy(),
Print output ty for opaque future ty
2021-11-16 18:16:23 -06:00
| | ------------- this is found to be of type `impl Future<Output = ()>`
Suggest semicolon removal and boxing when appropriate
2020-10-22 22:02:55 -05:00
LL | |
Add test case for different `impl Future`s
2020-10-22 13:34:46 -05:00
LL | | false => async_dummy2(),
fix: improve the suggestion on future not awaited Considering the following code ```rust fn foo() -> u8 { async fn async_fn() -> u8 { 22 } async_fn() } fn main() {} ``` the error generated before this commit from the compiler is ``` ➜ rust git:(macros/async_fn_suggestion) ✗ rustc test.rs --edition 2021 error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found opaque type | = note: expected type `u8` found opaque type `impl Future<Output = u8>` help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` In this case the error is nor perfect, and can confuse the user that do not know that the opaque type is the future. So this commit will propose (and conclude the work start in https://github.com/rust-lang/rust/issues/80658) to change the string `opaque type` to `future` when applicable and also remove the Expected vs Received note by adding a more specific one regarding the async function that return a future type. So the new error emitted by the compiler is ``` error[E0308]: mismatched types --> test.rs:4:5 | 1 | fn foo() -> u8 { | -- expected `u8` because of return type ... 4 | async_fn() | ^^^^^^^^^^ expected `u8`, found future | note: calling an async function returns a future --> test.rs:4:5 | 4 | async_fn() | ^^^^^^^^^^ help: consider `await`ing on the `Future` | 4 | async_fn().await | ++++++ error: aborting due to previous error ``` Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
2023-02-10 12:03:54 -06:00
| | ^^^^^^^^^^^^^^ expected future, found a different future
LL | |
Add test case for different `impl Future`s
2020-10-22 13:34:46 -05:00
LL | |
LL | | };
| |_____- `match` arms have incompatible types
|
= note: distinct uses of `impl Trait` result in different opaque types
Add more `.await` suggestions on E0308
2020-10-22 21:03:36 -05:00
help: consider `await`ing on both `Future`s
|
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
LL ~ true => async_dummy().await,
Suggest semicolon removal and boxing when appropriate
2020-10-22 22:02:55 -05:00
LL |
Modify structured suggestion output * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-21 21:07:19 -05:00
LL ~ false => async_dummy2().await,
Add more `.await` suggestions on E0308
2020-10-22 21:03:36 -05:00
|
Add test case for different `impl Future`s
2020-10-22 13:34:46 -05:00
Suggest semicolon removal on prior match arm
2020-10-21 21:08:28 -05:00
error[E0308]: `match` arms have incompatible types
--> $DIR/match-prev-arm-needing-semi.rs:11:18
|
LL | let _ = match true {
| _____________-
LL | | true => {
LL | | dummy();
| | --------
| | | |
| | | help: consider removing this semicolon
| | this is found to be of type `()`
LL | |
LL | | }
LL | | false => dummy(),
| | ^^^^^^^ expected `()`, found `i32`
LL | |
LL | | };
| |_____- `match` arms have incompatible types
Add test case for different `impl Future`s
2020-10-22 13:34:46 -05:00
error: aborting due to 4 previous errors
Suggest semicolon removal on prior match arm
2020-10-21 21:08:28 -05:00
For more information about this error, try `rustc --explain E0308`.
Reference in New Issue Copy Permalink