2021-02-09 05:30:13 -06:00
|
|
|
use stdx::{format_to, to_lower_snake_case};
|
2021-02-13 12:58:58 -06:00
|
|
|
use syntax::ast::{self, AstNode, NameOwner, VisibilityOwner};
|
2021-02-09 05:30:13 -06:00
|
|
|
|
|
|
|
use crate::{
|
2021-02-12 04:48:43 -06:00
|
|
|
utils::{find_impl_block_end, find_struct_impl, generate_impl_text},
|
2021-02-13 12:58:58 -06:00
|
|
|
AssistContext, AssistId, AssistKind, Assists, GroupLabel,
|
2021-02-09 05:30:13 -06:00
|
|
|
};
|
|
|
|
|
|
|
|
// Assist: generate_getter
|
|
|
|
//
|
|
|
|
// Generate a getter method.
|
|
|
|
//
|
|
|
|
// ```
|
|
|
|
// struct Person {
|
|
|
|
// nam$0e: String,
|
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
// ->
|
|
|
|
// ```
|
|
|
|
// struct Person {
|
|
|
|
// name: String,
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// impl Person {
|
|
|
|
// /// Get a reference to the person's name.
|
2021-05-23 16:05:14 -05:00
|
|
|
// fn $0name(&self) -> &str {
|
|
|
|
// self.name.as_str()
|
2021-02-09 05:30:13 -06:00
|
|
|
// }
|
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
pub(crate) fn generate_getter(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
|
2021-05-23 15:13:35 -05:00
|
|
|
generate_getter_impl(acc, ctx, false)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Assist: generate_getter_mut
|
|
|
|
//
|
|
|
|
// Generate a mut getter method.
|
|
|
|
//
|
|
|
|
// ```
|
|
|
|
// struct Person {
|
|
|
|
// nam$0e: String,
|
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
// ->
|
|
|
|
// ```
|
|
|
|
// struct Person {
|
|
|
|
// name: String,
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// impl Person {
|
|
|
|
// /// Get a mutable reference to the person's name.
|
2021-05-23 15:22:38 -05:00
|
|
|
// fn $0name_mut(&mut self) -> &mut String {
|
2021-05-23 15:13:35 -05:00
|
|
|
// &mut self.name
|
|
|
|
// }
|
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
pub(crate) fn generate_getter_mut(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
|
|
|
|
generate_getter_impl(acc, ctx, true)
|
|
|
|
}
|
|
|
|
|
|
|
|
pub(crate) fn generate_getter_impl(
|
|
|
|
acc: &mut Assists,
|
|
|
|
ctx: &AssistContext,
|
|
|
|
mutable: bool,
|
|
|
|
) -> Option<()> {
|
2021-02-09 05:30:13 -06:00
|
|
|
let strukt = ctx.find_node_at_offset::<ast::Struct>()?;
|
|
|
|
let field = ctx.find_node_at_offset::<ast::RecordField>()?;
|
|
|
|
|
|
|
|
let strukt_name = strukt.name()?;
|
|
|
|
let field_name = field.name()?;
|
|
|
|
let field_ty = field.ty()?;
|
|
|
|
|
|
|
|
// Return early if we've found an existing fn
|
2021-05-23 15:13:35 -05:00
|
|
|
let mut fn_name = to_lower_snake_case(&field_name.to_string());
|
|
|
|
if mutable {
|
|
|
|
format_to!(fn_name, "_mut");
|
|
|
|
}
|
2021-02-09 05:30:13 -06:00
|
|
|
let impl_def = find_struct_impl(&ctx, &ast::Adt::Struct(strukt.clone()), fn_name.as_str())?;
|
|
|
|
|
2021-05-23 15:13:35 -05:00
|
|
|
let (id, label) = if mutable {
|
|
|
|
("generate_getter_mut", "Generate a mut getter method")
|
|
|
|
} else {
|
|
|
|
("generate_getter", "Generate a getter method")
|
|
|
|
};
|
2021-02-09 05:30:13 -06:00
|
|
|
let target = field.syntax().text_range();
|
2021-02-13 12:58:58 -06:00
|
|
|
acc.add_group(
|
|
|
|
&GroupLabel("Generate getter/setter".to_owned()),
|
2021-05-23 15:13:35 -05:00
|
|
|
AssistId(id, AssistKind::Generate),
|
|
|
|
label,
|
2021-02-09 05:30:13 -06:00
|
|
|
target,
|
|
|
|
|builder| {
|
|
|
|
let mut buf = String::with_capacity(512);
|
|
|
|
|
|
|
|
if impl_def.is_some() {
|
|
|
|
buf.push('\n');
|
|
|
|
}
|
|
|
|
|
|
|
|
let vis = strukt.visibility().map_or(String::new(), |v| format!("{} ", v));
|
2021-05-23 16:05:14 -05:00
|
|
|
let (ty, body) = if mutable {
|
|
|
|
(format!("&mut {}", field_ty), format!("&mut self.{}", field_name))
|
|
|
|
} else {
|
|
|
|
useless_type_special_case(&field_name.to_string(), &field_ty)
|
|
|
|
.unwrap_or_else(|| (format!("&{}", field_ty), format!("&self.{}", field_name)))
|
|
|
|
};
|
|
|
|
|
2021-02-09 05:30:13 -06:00
|
|
|
format_to!(
|
|
|
|
buf,
|
2021-05-23 15:13:35 -05:00
|
|
|
" /// Get a {}reference to the {}'s {}.
|
2021-05-23 16:05:14 -05:00
|
|
|
{}fn {}(&{}self) -> {} {{
|
|
|
|
{}
|
2021-02-09 05:30:13 -06:00
|
|
|
}}",
|
2021-05-23 15:13:35 -05:00
|
|
|
mutable.then(|| "mutable ").unwrap_or_default(),
|
|
|
|
to_lower_snake_case(&strukt_name.to_string()).replace('_', " "),
|
|
|
|
fn_name.trim_end_matches("_mut").replace('_', " "),
|
2021-02-09 05:30:13 -06:00
|
|
|
vis,
|
|
|
|
fn_name,
|
2021-05-23 16:05:14 -05:00
|
|
|
mutable.then(|| "mut ").unwrap_or_default(),
|
|
|
|
ty,
|
|
|
|
body,
|
2021-02-09 05:30:13 -06:00
|
|
|
);
|
|
|
|
|
|
|
|
let start_offset = impl_def
|
2021-02-12 04:48:43 -06:00
|
|
|
.and_then(|impl_def| find_impl_block_end(impl_def, &mut buf))
|
2021-02-09 05:30:13 -06:00
|
|
|
.unwrap_or_else(|| {
|
|
|
|
buf = generate_impl_text(&ast::Adt::Struct(strukt.clone()), &buf);
|
|
|
|
strukt.syntax().text_range().end()
|
|
|
|
});
|
|
|
|
|
2021-05-23 15:22:38 -05:00
|
|
|
match ctx.config.snippet_cap {
|
|
|
|
Some(cap) => {
|
|
|
|
builder.insert_snippet(cap, start_offset, buf.replacen("fn ", "fn $0", 1))
|
|
|
|
}
|
|
|
|
None => builder.insert(start_offset, buf),
|
|
|
|
}
|
2021-02-09 05:30:13 -06:00
|
|
|
},
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
2021-05-23 16:05:14 -05:00
|
|
|
fn useless_type_special_case(field_name: &str, field_ty: &ast::Type) -> Option<(String, String)> {
|
|
|
|
if field_ty.to_string() == "String" {
|
|
|
|
cov_mark::hit!(useless_type_special_case);
|
|
|
|
return Some(("&str".to_string(), format!("self.{}.as_str()", field_name)));
|
|
|
|
}
|
|
|
|
if let Some(arg) = ty_ctor(field_ty, "Vec") {
|
|
|
|
return Some((format!("&[{}]", arg), format!("self.{}.as_slice()", field_name)));
|
|
|
|
}
|
|
|
|
if let Some(arg) = ty_ctor(field_ty, "Box") {
|
|
|
|
return Some((format!("&{}", arg), format!("self.{}.as_ref()", field_name)));
|
|
|
|
}
|
|
|
|
if let Some(arg) = ty_ctor(field_ty, "Option") {
|
|
|
|
return Some((format!("Option<&{}>", arg), format!("self.{}.as_ref()", field_name)));
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
|
|
|
|
// FIXME: This should rely on semantic info.
|
|
|
|
fn ty_ctor(ty: &ast::Type, ctor: &str) -> Option<String> {
|
|
|
|
let res = ty.to_string().strip_prefix(ctor)?.strip_prefix('<')?.strip_suffix('>')?.to_string();
|
|
|
|
Some(res)
|
|
|
|
}
|
|
|
|
|
2021-02-09 05:30:13 -06:00
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use crate::tests::{check_assist, check_assist_not_applicable};
|
|
|
|
|
|
|
|
use super::*;
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_generate_getter_from_field() {
|
|
|
|
check_assist(
|
|
|
|
generate_getter,
|
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
dat$0a: Data,
|
|
|
|
}
|
|
|
|
"#,
|
2021-02-09 05:30:13 -06:00
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
data: Data,
|
2021-02-09 05:30:13 -06:00
|
|
|
}
|
|
|
|
|
2021-05-23 15:19:00 -05:00
|
|
|
impl Context {
|
2021-02-09 05:30:13 -06:00
|
|
|
/// Get a reference to the context's data.
|
2021-05-23 15:22:38 -05:00
|
|
|
fn $0data(&self) -> &Data {
|
2021-02-09 05:30:13 -06:00
|
|
|
&self.data
|
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
}
|
|
|
|
"#,
|
2021-02-09 05:30:13 -06:00
|
|
|
);
|
|
|
|
|
|
|
|
check_assist(
|
2021-05-23 15:15:54 -05:00
|
|
|
generate_getter_mut,
|
2021-02-09 05:30:13 -06:00
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
dat$0a: Data,
|
|
|
|
}
|
|
|
|
"#,
|
2021-02-09 05:30:13 -06:00
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
data: Data,
|
2021-02-09 05:30:13 -06:00
|
|
|
}
|
|
|
|
|
2021-05-23 15:19:00 -05:00
|
|
|
impl Context {
|
2021-05-23 15:15:54 -05:00
|
|
|
/// Get a mutable reference to the context's data.
|
2021-05-23 15:22:38 -05:00
|
|
|
fn $0data_mut(&mut self) -> &mut Data {
|
2021-05-23 15:15:54 -05:00
|
|
|
&mut self.data
|
2021-02-09 05:30:13 -06:00
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
}
|
|
|
|
"#,
|
2021-02-12 04:48:43 -06:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2021-05-23 15:15:54 -05:00
|
|
|
fn test_generate_getter_already_implemented() {
|
|
|
|
check_assist_not_applicable(
|
2021-02-12 04:48:43 -06:00
|
|
|
generate_getter,
|
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
dat$0a: Data,
|
2021-02-12 04:48:43 -06:00
|
|
|
}
|
|
|
|
|
2021-05-23 15:19:00 -05:00
|
|
|
impl Context {
|
|
|
|
fn data(&self) -> &Data {
|
2021-02-12 04:48:43 -06:00
|
|
|
&self.data
|
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
}
|
|
|
|
"#,
|
2021-02-09 05:30:13 -06:00
|
|
|
);
|
2021-05-23 15:13:35 -05:00
|
|
|
|
2021-05-23 15:15:54 -05:00
|
|
|
check_assist_not_applicable(
|
2021-05-23 15:13:35 -05:00
|
|
|
generate_getter_mut,
|
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
dat$0a: Data,
|
2021-05-23 15:13:35 -05:00
|
|
|
}
|
|
|
|
|
2021-05-23 15:19:00 -05:00
|
|
|
impl Context {
|
|
|
|
fn data_mut(&mut self) -> &mut Data {
|
2021-05-23 15:13:35 -05:00
|
|
|
&mut self.data
|
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
}
|
|
|
|
"#,
|
2021-05-23 15:13:35 -05:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2021-05-23 15:15:54 -05:00
|
|
|
fn test_generate_getter_from_field_with_visibility_marker() {
|
2021-05-23 15:13:35 -05:00
|
|
|
check_assist(
|
2021-05-23 15:15:54 -05:00
|
|
|
generate_getter,
|
2021-05-23 15:13:35 -05:00
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
pub(crate) struct Context {
|
|
|
|
dat$0a: Data,
|
|
|
|
}
|
|
|
|
"#,
|
2021-05-23 15:13:35 -05:00
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
pub(crate) struct Context {
|
|
|
|
data: Data,
|
2021-05-23 15:13:35 -05:00
|
|
|
}
|
|
|
|
|
2021-05-23 15:19:00 -05:00
|
|
|
impl Context {
|
2021-05-23 15:15:54 -05:00
|
|
|
/// Get a reference to the context's data.
|
2021-05-23 15:22:38 -05:00
|
|
|
pub(crate) fn $0data(&self) -> &Data {
|
2021-05-23 15:15:54 -05:00
|
|
|
&self.data
|
2021-05-23 15:13:35 -05:00
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
}
|
|
|
|
"#,
|
2021-05-23 15:13:35 -05:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
2021-05-23 15:15:54 -05:00
|
|
|
fn test_multiple_generate_getter() {
|
2021-05-23 15:13:35 -05:00
|
|
|
check_assist(
|
2021-05-23 15:15:54 -05:00
|
|
|
generate_getter,
|
2021-05-23 15:13:35 -05:00
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
data: Data,
|
2021-05-23 15:13:35 -05:00
|
|
|
cou$0nt: usize,
|
|
|
|
}
|
|
|
|
|
2021-05-23 15:19:00 -05:00
|
|
|
impl Context {
|
2021-05-23 15:15:54 -05:00
|
|
|
/// Get a reference to the context's data.
|
2021-05-23 15:19:00 -05:00
|
|
|
fn data(&self) -> &Data {
|
2021-05-23 15:15:54 -05:00
|
|
|
&self.data
|
2021-05-23 15:13:35 -05:00
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
}
|
|
|
|
"#,
|
2021-05-23 15:13:35 -05:00
|
|
|
r#"
|
2021-05-23 15:19:00 -05:00
|
|
|
struct Context {
|
|
|
|
data: Data,
|
2021-05-23 15:13:35 -05:00
|
|
|
count: usize,
|
|
|
|
}
|
|
|
|
|
2021-05-23 15:19:00 -05:00
|
|
|
impl Context {
|
2021-05-23 15:15:54 -05:00
|
|
|
/// Get a reference to the context's data.
|
2021-05-23 15:19:00 -05:00
|
|
|
fn data(&self) -> &Data {
|
2021-05-23 15:15:54 -05:00
|
|
|
&self.data
|
2021-05-23 15:13:35 -05:00
|
|
|
}
|
|
|
|
|
2021-05-23 15:15:54 -05:00
|
|
|
/// Get a reference to the context's count.
|
2021-05-23 15:22:38 -05:00
|
|
|
fn $0count(&self) -> &usize {
|
2021-05-23 15:15:54 -05:00
|
|
|
&self.count
|
2021-05-23 15:13:35 -05:00
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
}
|
2021-05-23 16:05:14 -05:00
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_special_cases() {
|
|
|
|
cov_mark::check!(useless_type_special_case);
|
|
|
|
check_assist(
|
|
|
|
generate_getter,
|
|
|
|
r#"
|
|
|
|
struct S { foo: $0String }
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S { foo: String }
|
|
|
|
|
|
|
|
impl S {
|
|
|
|
/// Get a reference to the s's foo.
|
|
|
|
fn $0foo(&self) -> &str {
|
|
|
|
self.foo.as_str()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
check_assist(
|
|
|
|
generate_getter,
|
|
|
|
r#"
|
|
|
|
struct S { foo: $0Box<Sweets> }
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S { foo: Box<Sweets> }
|
|
|
|
|
|
|
|
impl S {
|
|
|
|
/// Get a reference to the s's foo.
|
|
|
|
fn $0foo(&self) -> &Sweets {
|
|
|
|
self.foo.as_ref()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
check_assist(
|
|
|
|
generate_getter,
|
|
|
|
r#"
|
|
|
|
struct S { foo: $0Vec<()> }
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S { foo: Vec<()> }
|
|
|
|
|
|
|
|
impl S {
|
|
|
|
/// Get a reference to the s's foo.
|
|
|
|
fn $0foo(&self) -> &[()] {
|
|
|
|
self.foo.as_slice()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
check_assist(
|
|
|
|
generate_getter,
|
|
|
|
r#"
|
|
|
|
struct S { foo: $0Option<Failure> }
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S { foo: Option<Failure> }
|
|
|
|
|
|
|
|
impl S {
|
|
|
|
/// Get a reference to the s's foo.
|
|
|
|
fn $0foo(&self) -> Option<&Failure> {
|
|
|
|
self.foo.as_ref()
|
|
|
|
}
|
|
|
|
}
|
2021-05-23 15:19:00 -05:00
|
|
|
"#,
|
2021-05-23 15:13:35 -05:00
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|