2023-04-20 09:37:15 -05:00
|
|
|
//@aux-build:proc_macro_suspicious_else_formatting.rs
|
2021-09-28 12:03:12 -05:00
|
|
|
|
2020-12-20 10:19:49 -06:00
|
|
|
#![warn(clippy::suspicious_else_formatting)]
|
2023-05-22 02:38:16 -05:00
|
|
|
#![allow(clippy::if_same_then_else, clippy::let_unit_value, clippy::needless_else)]
|
2020-12-20 10:19:49 -06:00
|
|
|
|
2021-09-28 12:03:12 -05:00
|
|
|
extern crate proc_macro_suspicious_else_formatting;
|
|
|
|
use proc_macro_suspicious_else_formatting::DeriveBadSpan;
|
|
|
|
|
2020-12-20 10:19:49 -06:00
|
|
|
fn foo() -> bool {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
|
|
|
|
#[rustfmt::skip]
|
|
|
|
fn main() {
|
|
|
|
// weird `else` formatting:
|
|
|
|
if foo() {
|
|
|
|
} {
|
|
|
|
}
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
} if foo() {
|
|
|
|
}
|
|
|
|
|
|
|
|
let _ = { // if as the last expression
|
|
|
|
let _ = 0;
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
} if foo() {
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
let _ = { // if in the middle of a block
|
|
|
|
if foo() {
|
|
|
|
} if foo() {
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
}
|
|
|
|
|
|
|
|
let _ = 0;
|
|
|
|
};
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
} else
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
2021-04-22 04:31:13 -05:00
|
|
|
// This is fine, though weird. Allman style braces on the else.
|
2020-12-20 10:19:49 -06:00
|
|
|
if foo() {
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
} else
|
|
|
|
if foo() { // the span of the above error should continue here
|
|
|
|
}
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
}
|
|
|
|
else
|
|
|
|
if foo() { // the span of the above error should continue here
|
|
|
|
}
|
|
|
|
|
|
|
|
// those are ok:
|
|
|
|
if foo() {
|
|
|
|
}
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
} else {
|
|
|
|
}
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
}
|
|
|
|
else {
|
|
|
|
}
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
}
|
|
|
|
if foo() {
|
|
|
|
}
|
2021-04-22 04:31:13 -05:00
|
|
|
|
|
|
|
// Almost Allman style braces. Lint these.
|
|
|
|
if foo() {
|
|
|
|
}
|
|
|
|
|
|
|
|
else
|
|
|
|
{
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
if foo() {
|
|
|
|
}
|
|
|
|
else
|
|
|
|
|
|
|
|
{
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
// #3864 - Allman style braces
|
|
|
|
if foo()
|
|
|
|
{
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
}
|
2023-06-07 02:35:39 -05:00
|
|
|
|
|
|
|
//#10273 This is fine. Don't warn
|
|
|
|
if foo() {
|
|
|
|
} else
|
|
|
|
/* whelp */
|
|
|
|
{
|
|
|
|
}
|
2020-12-20 10:19:49 -06:00
|
|
|
}
|
2021-09-28 12:03:12 -05:00
|
|
|
|
|
|
|
// #7650 - Don't lint. Proc-macro using bad spans for `if` expressions.
|
|
|
|
#[derive(DeriveBadSpan)]
|
|
|
|
struct _Foo(u32, u32);
|