2018-07-05 05:37:50 -05:00
# Clippy
2016-05-06 09:07:47 -05:00
2018-11-21 21:40:09 -06:00
[![Build Status ](https://travis-ci.org/rust-lang/rust-clippy.svg?branch=master )](https://travis-ci.org/rust-lang/rust-clippy)
2018-03-29 17:12:19 -05:00
[![Windows Build status ](https://ci.appveyor.com/api/projects/status/id677xpw1dguo7iw?svg=true )](https://ci.appveyor.com/project/rust-lang-libs/rust-clippy)
2018-05-04 07:23:53 -05:00
[![Current Version ](https://meritbadge.herokuapp.com/clippy )](https://crates.io/crates/clippy)
2018-10-05 14:37:50 -05:00
[![License: MIT/Apache-2.0 ](https://img.shields.io/crates/l/clippy.svg )](#license)
2014-11-19 01:50:46 -06:00
2017-10-14 14:47:38 -05:00
A collection of lints to catch common mistakes and improve your [Rust ](https://github.com/rust-lang/rust ) code.
2014-11-19 13:19:03 -06:00
2018-12-17 17:25:49 -06:00
[There are 290 lints included in this crate! ](https://rust-lang.github.io/rust-clippy/master/index.html )
2017-09-01 13:29:36 -05:00
2018-07-05 05:37:50 -05:00
We have a bunch of lint categories to allow you to choose how much Clippy is supposed to ~~annoy~~ help you:
2018-03-29 06:04:52 -05:00
2018-07-28 10:35:24 -05:00
* `clippy::all` (everything that has no false positives)
* `clippy::pedantic` (everything)
* `clippy::nursery` (new lints that aren't quite ready yet)
* `clippy::style` (code that should be written in a more idiomatic way)
* `clippy::complexity` (code that does something simple but in a complex way)
* `clippy::perf` (code that can be written in a faster way)
* `clippy::cargo` (checks against the cargo manifest)
* **`clippy::correctness`** (code that is just outright wrong or very very useless)
2018-03-29 06:04:52 -05:00
2018-11-21 21:40:09 -06:00
More to come, please [file an issue ](https://github.com/rust-lang/rust-clippy/issues ) if you have ideas!
2017-09-01 13:29:36 -05:00
2018-10-12 05:15:20 -05:00
Only the following of those categories are enabled by default:
* `clippy::style`
* `clippy::correctness`
* `clippy::complexity`
* `clippy::perf`
Other categories need to be enabled in order for their lints to be executed.
2016-02-22 08:50:40 -06:00
Table of contents:
2016-03-10 14:42:24 -06:00
2016-05-06 09:07:47 -05:00
* [Usage instructions ](#usage )
* [Configuration ](#configuration )
* [License ](#license )
2016-09-15 10:19:30 -05:00
## Usage
2016-11-18 21:46:12 -06:00
Since this is a tool for helping the developer of a library or application
2018-07-05 05:37:50 -05:00
write better code, it is recommended not to include Clippy as a hard dependency.
2016-11-19 21:16:36 -06:00
Options include using it as an optional dependency, as a cargo subcommand, or
2018-07-16 15:05:02 -05:00
as an included feature during build. These options are detailed below.
2016-11-18 21:46:12 -06:00
2018-07-16 15:05:02 -05:00
### As a cargo subcommand (`cargo clippy`)
2016-09-15 10:19:30 -05:00
2018-07-16 15:05:02 -05:00
One way to use Clippy is by installing Clippy through rustup as a cargo
subcommand.
2018-04-02 04:13:02 -05:00
2018-07-16 15:05:02 -05:00
#### Step 1: Install rustup
2018-04-02 04:13:02 -05:00
2018-07-16 15:05:02 -05:00
You can install [rustup ](http://rustup.rs/ ) on supported platforms. This will help
2018-09-11 13:29:00 -05:00
us install Clippy and its dependencies.
2017-12-27 10:06:40 -06:00
2018-07-16 15:05:02 -05:00
If you already have rustup installed, update to ensure you have the latest
rustup and compiler:
2017-12-27 10:06:40 -06:00
```terminal
2018-07-16 15:05:02 -05:00
rustup update
2017-12-27 10:06:40 -06:00
```
2018-09-11 13:29:00 -05:00
#### Step 2: Install Clippy
2018-01-12 04:33:13 -06:00
2018-09-11 13:29:00 -05:00
Once you have rustup and the latest stable release (at least Rust 1.29) installed, run the following command:
2018-04-02 04:13:02 -05:00
```terminal
2018-12-06 10:11:50 -06:00
rustup component add clippy
2018-04-02 04:13:02 -05:00
```
2018-09-11 13:29:00 -05:00
Now you can run Clippy by invoking `cargo clippy` .
2018-07-16 15:05:02 -05:00
2018-09-22 16:35:11 -05:00
If it says that it can't find the `clippy` subcommand, please run `rustup self update`
2018-07-05 05:37:50 -05:00
### Running Clippy from the command line without installing it
2016-09-15 10:19:30 -05:00
2018-07-05 05:37:50 -05:00
To have cargo compile your crate with Clippy without Clippy installation
2016-09-15 10:19:30 -05:00
in your code, you can use:
```terminal
2018-12-18 22:13:43 -06:00
RUSTFLAGS=--sysroot=`rustc --print sysroot` cargo run --bin cargo-clippy --manifest-path=path_to_clippys_Cargo.toml
2016-09-15 10:19:30 -05:00
```
2018-11-21 21:40:09 -06:00
*[Note](https://github.com/rust-lang/rust-clippy/wiki#a-word-of-warning):*
2018-07-05 05:37:50 -05:00
Be sure that Clippy was compiled with the same version of rustc that cargo invokes here!
2016-09-15 10:19:30 -05:00
2018-09-14 01:21:14 -05:00
### Travis CI
You can add Clippy to Travis CI in the same way you use it locally:
```yml
2018-09-25 08:40:17 -05:00
language: rust
rust:
- stable
- beta
before_script:
2018-12-06 10:11:50 -06:00
- rustup component add clippy
2018-09-25 08:40:17 -05:00
script:
- cargo clippy
# if you want the build job to fail when encountering warnings, use
- cargo clippy -- -D warnings
# in order to also check tests and none-default crate features, use
- cargo clippy --all-targets --all-features -- -D warnings
- cargo test
# etc.
2018-09-14 01:21:14 -05:00
```
2018-12-10 15:30:16 -06:00
It might happen that Clippy is not available for a certain nightly release.
In this case you can try to conditionally install Clippy from the git repo.
2018-11-04 17:12:42 -06:00
```yaml
language: rust
rust:
- nightly
before_script:
2018-12-06 10:11:50 -06:00
- rustup component add clippy --toolchain=nightly || cargo install --git https://github.com/rust-lang/rust-clippy/ --force clippy
2018-11-04 17:12:42 -06:00
# etc
```
2016-09-15 10:19:30 -05:00
## Configuration
2018-09-02 04:31:39 -05:00
Some lints can be configured in a TOML file named `clippy.toml` or `.clippy.toml` . It contains a basic `variable = value` mapping eg.
2016-09-15 10:19:30 -05:00
```toml
blacklisted-names = ["toto", "tata", "titi"]
cyclomatic-complexity-threshold = 30
```
2018-11-21 21:50:00 -06:00
See the [list of lints ](https://rust-lang.github.io/rust-clippy/master/index.html ) for more information about which lints can be configured and the
2016-09-15 10:19:30 -05:00
meaning of the variables.
2018-01-07 05:50:42 -06:00
To deactivate the “for further information visit *lint-link* ” message you can
2017-09-01 03:29:49 -05:00
define the `CLIPPY_DISABLE_DOCS_LINKS` environment variable.
2016-09-15 10:19:30 -05:00
### Allowing/denying lints
2018-09-13 04:27:01 -05:00
You can add options to your code to `allow` /`warn`/`deny` Clippy lints:
2016-09-15 10:19:30 -05:00
2018-07-28 10:35:24 -05:00
* the whole set of `Warn` lints using the `clippy` lint group (`#![deny(clippy::all)]`)
2016-09-15 10:19:30 -05:00
2018-07-28 10:35:24 -05:00
* all lints using both the `clippy` and `clippy::pedantic` lint groups (`#![deny(clippy::all)]`,
`#![deny(clippy::pedantic)]` ). Note that `clippy::pedantic` contains some very aggressive
2016-09-15 10:19:30 -05:00
lints prone to false positives.
2018-07-28 10:35:24 -05:00
* only some lints (`#![deny(clippy::single_match, clippy::box_vec)]`, etc)
2016-09-15 10:19:30 -05:00
* `allow` /`warn`/`deny` can be limited to a single function or module using `#[allow(...)]` , etc
Note: `deny` produces errors instead of warnings.
2018-12-10 15:30:16 -06:00
If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to Clippy during the run: `cargo clippy -- -A clippy::lint_name` will run Clippy with `lint_name` disabled and `cargo clippy -- -W clippy::lint_name` will run it with that enabled. This also works with lint groups. For example you can run Clippy with warnings for all lints enabled: `cargo clippy -- -W clippy::pedantic`
2018-10-02 03:39:51 -05:00
2018-12-22 03:16:52 -06:00
## Contributing
If you want to contribute to Clippy, you can find more information in [CONTRIBUTING.md ](https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md ).
2018-12-21 01:11:06 -06:00
2016-05-06 09:07:47 -05:00
## License
2018-10-06 21:29:01 -05:00
Copyright 2014-2018 The Rust Project Developers
Licensed under the Apache License, Version 2.0 < LICENSE-APACHE or
http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
< LICENSE-MIT or http: / / opensource . org / licenses / MIT > , at your
option. All files in the project carrying such notice may not be
copied, modified, or distributed except according to those terms.