2018-09-18 09:33:24 -05:00
|
|
|
// This test checks that a change in a CGU does not invalidate an unrelated CGU
|
|
|
|
// during incremental ThinLTO.
|
|
|
|
|
|
|
|
//@ revisions: cfail1 cfail2 cfail3
|
|
|
|
//@ compile-flags: -Z query-dep-graph -O
|
2023-12-12 08:48:12 -06:00
|
|
|
//@ build-pass
|
2018-09-18 09:33:24 -05:00
|
|
|
|
|
|
|
#![feature(rustc_attrs)]
|
|
|
|
#![crate_type="rlib"]
|
|
|
|
|
|
|
|
#![rustc_expected_cgu_reuse(module="independent_cgus_dont_affect_each_other-foo",
|
|
|
|
cfg="cfail2",
|
|
|
|
kind="no")]
|
|
|
|
#![rustc_expected_cgu_reuse(module="independent_cgus_dont_affect_each_other-foo",
|
|
|
|
cfg="cfail3",
|
2023-12-12 09:47:32 -06:00
|
|
|
kind="pre-lto")] // Should be "post-lto", see issue #119076
|
2018-09-18 09:33:24 -05:00
|
|
|
|
|
|
|
#![rustc_expected_cgu_reuse(module="independent_cgus_dont_affect_each_other-bar",
|
|
|
|
cfg="cfail2",
|
|
|
|
kind="pre-lto")]
|
|
|
|
#![rustc_expected_cgu_reuse(module="independent_cgus_dont_affect_each_other-bar",
|
|
|
|
cfg="cfail3",
|
2023-12-12 09:47:32 -06:00
|
|
|
kind="pre-lto")] // Should be "post-lto", see issue #119076
|
2018-09-18 09:33:24 -05:00
|
|
|
|
|
|
|
#![rustc_expected_cgu_reuse(module="independent_cgus_dont_affect_each_other-baz",
|
|
|
|
cfg="cfail2",
|
2023-12-12 09:47:32 -06:00
|
|
|
kind="pre-lto")] // Should be "post-lto", see issue #119076
|
2018-09-18 09:33:24 -05:00
|
|
|
#![rustc_expected_cgu_reuse(module="independent_cgus_dont_affect_each_other-baz",
|
|
|
|
cfg="cfail3",
|
2023-12-12 09:47:32 -06:00
|
|
|
kind="pre-lto")] // Should be "post-lto", see issue #119076
|
2018-09-18 09:33:24 -05:00
|
|
|
mod foo {
|
|
|
|
|
|
|
|
#[cfg(cfail1)]
|
|
|
|
pub fn inlined_fn() -> u32 {
|
|
|
|
1234
|
|
|
|
}
|
|
|
|
|
|
|
|
#[cfg(not(cfail1))]
|
|
|
|
pub fn inlined_fn() -> u32 {
|
Use llvm::computeLTOCacheKey to determine post-ThinLTO CGU reuse
During incremental ThinLTO compilation, we attempt to re-use the
optimized (post-ThinLTO) bitcode file for a module if it is 'safe' to do
so.
Up until now, 'safe' has meant that the set of modules that our current
modules imports from/exports to is unchanged from the previous
compilation session. See PR #67020 and PR #71131 for more details.
However, this turns out be insufficient to guarantee that it's safe
to reuse the post-LTO module (i.e. that optimizing the pre-LTO module
would produce the same result). When LLVM optimizes a module during
ThinLTO, it may look at other information from the 'module index', such
as whether a (non-imported!) global variable is used. If this
information changes between compilation runs, we may end up re-using an
optimized module that (for example) had dead-code elimination run on a
function that is now used by another module.
Fortunately, LLVM implements its own ThinLTO module cache, which is used
when ThinLTO is performed by a linker plugin (e.g. when clang is used to
compile a C proect). Using this cache directly would require extensive
refactoring of our code - but fortunately for us, LLVM provides a
function that does exactly what we need.
The function `llvm::computeLTOCacheKey` is used to compute a SHA-1 hash
from all data that might influence the result of ThinLTO on a module.
In addition to the module imports/exports that we manually track, it
also hashes information about global variables (e.g. their liveness)
which might be used during optimization. By using this function, we
shouldn't have to worry about new LLVM passes breaking our module re-use
behavior.
In LLVM, the output of this function forms part of the filename used to
store the post-ThinLTO module. To keep our current filename structure
intact, this PR just writes out the mapping 'CGU name -> Hash' to a
file. To determine if a post-LTO module should be reused, we compare
hashes from the previous session.
This should unblock PR #75199 - by sheer chance, it seems to have hit
this issue due to the particular CGU partitioning and optimization
decisions that end up getting made.
2020-09-17 16:36:13 -05:00
|
|
|
// See `cgu_keeps_identical_fn.rs` for why this is different
|
|
|
|
// from the other version of this function.
|
|
|
|
12345
|
2018-09-18 09:33:24 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pub mod bar {
|
|
|
|
use foo::inlined_fn;
|
|
|
|
|
|
|
|
pub fn caller() -> u32 {
|
|
|
|
inlined_fn()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pub mod baz {
|
|
|
|
pub fn unrelated_to_other_fns() -> u64 {
|
|
|
|
0xbeef
|
|
|
|
}
|
|
|
|
}
|