2016-04-20 15:10:23 -05:00
|
|
|
use rustc::lint::*;
|
|
|
|
use rustc::hir::{Expr, ExprCall, ExprPath};
|
2016-04-21 11:36:39 -05:00
|
|
|
use utils::{match_def_path, paths, span_lint};
|
2016-04-20 15:10:23 -05:00
|
|
|
|
2016-04-20 21:24:31 -05:00
|
|
|
/// **What it does:** This lint checks for usage of `std::mem::forget(t)` where `t` is `Drop`.
|
2016-04-20 15:10:23 -05:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** `std::mem::forget(t)` prevents `t` from running its destructor, possibly causing leaks
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
2016-04-20 21:24:31 -05:00
|
|
|
/// **Example:** `mem::forget(Rc::new(55)))`
|
2016-04-20 15:10:23 -05:00
|
|
|
declare_lint! {
|
|
|
|
pub MEM_FORGET,
|
|
|
|
Allow,
|
2016-04-20 21:24:31 -05:00
|
|
|
"`mem::forget` usage on `Drop` types is likely to cause memory leaks"
|
2016-04-20 15:10:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
pub struct MemForget;
|
|
|
|
|
|
|
|
impl LintPass for MemForget {
|
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array![MEM_FORGET]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl LateLintPass for MemForget {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext, e: &Expr) {
|
2016-04-20 21:24:31 -05:00
|
|
|
if let ExprCall(ref path_expr, ref args) = e.node {
|
2016-04-20 15:10:23 -05:00
|
|
|
if let ExprPath(None, _) = path_expr.node {
|
|
|
|
let def_id = cx.tcx.def_map.borrow()[&path_expr.id].def_id();
|
|
|
|
if match_def_path(cx, def_id, &paths::MEM_FORGET) {
|
2016-04-21 11:36:39 -05:00
|
|
|
let forgot_ty = cx.tcx.expr_ty(&args[0]);
|
2016-04-20 21:24:31 -05:00
|
|
|
|
2016-04-21 11:36:39 -05:00
|
|
|
if match forgot_ty.ty_adt_def() {
|
|
|
|
Some(def) => def.has_dtor(),
|
|
|
|
_ => false
|
|
|
|
} {
|
|
|
|
span_lint(cx, MEM_FORGET, e.span, "usage of mem::forget on Drop type");
|
2016-04-20 21:24:31 -05:00
|
|
|
}
|
2016-04-20 15:10:23 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|