rust/clippy_lints/src/methods/iter_count.rs

63 lines
2.2 KiB
Rust
Raw Normal View History

2021-02-25 11:18:52 -06:00
use crate::utils::{
derefs_to_slice, is_type_diagnostic_item, match_type, method_chain_args, paths, snippet_with_applicability,
2021-02-25 11:18:52 -06:00
span_lint_and_sugg,
};
2021-02-25 11:18:52 -06:00
use if_chain::if_chain;
use rustc_errors::Applicability;
use rustc_hir::Expr;
use rustc_lint::LateContext;
use rustc_span::sym;
use super::ITER_COUNT;
pub(crate) fn lints<'tcx>(cx: &LateContext<'tcx>, expr: &Expr<'_>, iter_args: &'tcx [Expr<'tcx>], is_mut: bool) {
let mut_str = if is_mut { "_mut" } else { "" };
let iter_method = if method_chain_args(expr, &[format!("iter{}", mut_str).as_str(), "count"]).is_some() {
"iter"
} else if method_chain_args(expr, &["into_iter", "count"]).is_some() {
"into_iter"
} else {
return;
};
let ty = cx.typeck_results().expr_ty(&iter_args[0]);
2021-02-25 11:18:52 -06:00
if_chain! {
let caller_type = if derefs_to_slice(cx, &iter_args[0], ty).is_some() {
"slice"
} else if is_type_diagnostic_item(cx, ty, sym::vec_type) {
"Vec"
} else if is_type_diagnostic_item(cx, ty, sym!(vecdeque_type)) {
"VecDeque"
} else if is_type_diagnostic_item(cx, ty, sym!(hashset_type)) {
"HashSet"
} else if is_type_diagnostic_item(cx, ty, sym!(hashmap_type)) {
"HashMap"
} else if match_type(cx, ty, &paths::BTREEMAP) {
"BTreeMap"
} else if match_type(cx, ty, &paths::BTREESET) {
"BTreeSet"
} else if match_type(cx, ty, &paths::LINKED_LIST) {
"LinkedList"
} else if match_type(cx, ty, &paths::BINARY_HEAP) {
"BinaryHeap"
2021-02-25 11:18:52 -06:00
} else {
return
2021-02-25 11:18:52 -06:00
};
then {
let mut applicability = Applicability::MachineApplicable;
span_lint_and_sugg(
cx,
ITER_COUNT,
expr.span,
&format!("called `.{}{}().count()` on a `{}`", iter_method, mut_str, caller_type),
"try",
format!(
"{}.len()",
snippet_with_applicability(cx, iter_args[0].span, "..", &mut applicability),
),
applicability,
);
}
}
}