rust/tests/ui/inconsistent_struct_constructor.fixed

74 lines
1.3 KiB
Rust
Raw Normal View History

// run-rustfix
#![warn(clippy::inconsistent_struct_constructor)]
#![allow(clippy::redundant_field_names)]
#![allow(clippy::unnecessary_operation)]
#![allow(clippy::no_effect)]
#![allow(dead_code)]
#[derive(Default)]
struct Foo {
x: i32,
y: i32,
z: i32,
}
2021-04-19 23:33:39 -05:00
macro_rules! new_foo {
() => {
let x = 1;
let y = 1;
let z = 1;
Foo { y, x, z }
};
}
mod without_base {
use super::Foo;
fn test() {
let x = 1;
let y = 1;
let z = 1;
// Should lint.
Foo { x, y, z };
2021-04-19 23:33:39 -05:00
// Should NOT lint.
// issue #7069.
new_foo!();
2022-07-13 09:48:32 -05:00
// Should NOT lint because the order is the same as in the definition.
Foo { x, y, z };
// Should NOT lint because z is not a shorthand init.
Foo { y, x, z: z };
}
}
mod with_base {
use super::Foo;
fn test() {
let x = 1;
let z = 1;
// Should lint.
Foo { x, z, ..Default::default() };
// Should NOT lint because the order is consistent with the definition.
Foo {
x,
z,
..Default::default()
};
// Should NOT lint because z is not a shorthand init.
Foo {
z: z,
x,
..Default::default()
};
}
}
fn main() {}