2019-02-23 23:30:08 -06:00
|
|
|
|
// run-rustfix
|
|
|
|
|
|
2021-09-30 06:40:46 -05:00
|
|
|
|
#![allow(clippy::print_literal, clippy::redundant_clone, clippy::to_string_in_format_args)]
|
2019-02-23 23:30:08 -06:00
|
|
|
|
#![warn(clippy::useless_format)]
|
|
|
|
|
|
|
|
|
|
struct Foo(pub String);
|
|
|
|
|
|
|
|
|
|
macro_rules! foo {
|
2019-03-10 16:07:10 -05:00
|
|
|
|
($($t:tt)*) => (Foo(format!($($t)*)))
|
2019-02-23 23:30:08 -06:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
|
"foo".to_string();
|
2019-04-09 09:15:48 -05:00
|
|
|
|
"{}".to_string();
|
|
|
|
|
"{} abc {}".to_string();
|
2020-10-09 13:23:03 -05:00
|
|
|
|
r##"foo {}
|
|
|
|
|
" bar"##.to_string();
|
2019-02-23 23:30:08 -06:00
|
|
|
|
|
2021-10-10 19:03:11 -05:00
|
|
|
|
let _ = String::new();
|
|
|
|
|
|
2019-02-23 23:30:08 -06:00
|
|
|
|
"foo".to_string();
|
2019-03-10 16:07:10 -05:00
|
|
|
|
format!("{:?}", "foo"); // Don't warn about `Debug`.
|
2019-02-23 23:30:08 -06:00
|
|
|
|
format!("{:8}", "foo");
|
|
|
|
|
format!("{:width$}", "foo", width = 8);
|
2019-03-10 16:07:10 -05:00
|
|
|
|
"foo".to_string(); // Warn when the format makes no difference.
|
|
|
|
|
"foo".to_string(); // Warn when the format makes no difference.
|
2019-02-23 23:30:08 -06:00
|
|
|
|
format!("foo {}", "bar");
|
|
|
|
|
format!("{} bar", "foo");
|
|
|
|
|
|
|
|
|
|
let arg: String = "".to_owned();
|
|
|
|
|
arg.to_string();
|
2019-03-10 16:07:10 -05:00
|
|
|
|
format!("{:?}", arg); // Don't warn about debug.
|
2019-02-23 23:30:08 -06:00
|
|
|
|
format!("{:8}", arg);
|
|
|
|
|
format!("{:width$}", arg, width = 8);
|
2019-03-10 16:07:10 -05:00
|
|
|
|
arg.to_string(); // Warn when the format makes no difference.
|
|
|
|
|
arg.to_string(); // Warn when the format makes no difference.
|
2019-02-23 23:30:08 -06:00
|
|
|
|
format!("foo {}", arg);
|
|
|
|
|
format!("{} bar", arg);
|
|
|
|
|
|
2019-03-10 16:07:10 -05:00
|
|
|
|
// We don’t want to warn for non-string args; see issue #697.
|
2019-02-23 23:30:08 -06:00
|
|
|
|
format!("{}", 42);
|
|
|
|
|
format!("{:?}", 42);
|
|
|
|
|
format!("{:+}", 42);
|
|
|
|
|
format!("foo {}", 42);
|
|
|
|
|
format!("{} bar", 42);
|
|
|
|
|
|
2019-03-10 16:07:10 -05:00
|
|
|
|
// We only want to warn about `format!` itself.
|
2019-02-23 23:30:08 -06:00
|
|
|
|
println!("foo");
|
|
|
|
|
println!("{}", "foo");
|
|
|
|
|
println!("foo {}", "foo");
|
|
|
|
|
println!("{}", 42);
|
|
|
|
|
println!("foo {}", 42);
|
|
|
|
|
|
2019-03-10 16:07:10 -05:00
|
|
|
|
// A `format!` inside a macro should not trigger a warning.
|
2019-02-23 23:30:08 -06:00
|
|
|
|
foo!("should not warn");
|
|
|
|
|
|
2019-03-10 16:07:10 -05:00
|
|
|
|
// Precision on string means slicing without panicking on size.
|
|
|
|
|
format!("{:.1}", "foo"); // Could be `"foo"[..1]`
|
|
|
|
|
format!("{:.10}", "foo"); // Could not be `"foo"[..10]`
|
2019-02-23 23:30:08 -06:00
|
|
|
|
format!("{:.prec$}", "foo", prec = 1);
|
|
|
|
|
format!("{:.prec$}", "foo", prec = 10);
|
|
|
|
|
|
|
|
|
|
42.to_string();
|
|
|
|
|
let x = std::path::PathBuf::from("/bar/foo/qux");
|
|
|
|
|
x.display().to_string();
|
2019-08-23 03:46:23 -05:00
|
|
|
|
|
|
|
|
|
// False positive
|
|
|
|
|
let a = "foo".to_string();
|
|
|
|
|
let _ = Some(a + "bar");
|
2021-04-19 10:20:21 -05:00
|
|
|
|
|
|
|
|
|
// Wrap it with braces
|
|
|
|
|
let v: Vec<String> = vec!["foo".to_string(), "bar".to_string()];
|
|
|
|
|
let _s: String = (&*v.join("\n")).to_string();
|
2021-07-04 16:34:22 -05:00
|
|
|
|
|
|
|
|
|
format!("prepend {:+}", "s");
|
2022-01-15 13:33:43 -06:00
|
|
|
|
|
|
|
|
|
// Issue #8290
|
|
|
|
|
let x = "foo";
|
|
|
|
|
let _ = x.to_string();
|
|
|
|
|
let _ = format!("{x:?}"); // Don't lint on debug
|
|
|
|
|
let _ = x.to_string();
|
2019-02-23 23:30:08 -06:00
|
|
|
|
}
|