rust/crates/ra_ide/src/completion/complete_dot.rs

873 lines
22 KiB
Rust
Raw Normal View History

2020-07-04 10:03:27 +02:00
//! Completes references after dot (fields and method calls).
use hir::{HasVisibility, Type};
2020-07-04 10:03:27 +02:00
use rustc_hash::FxHashSet;
2019-01-08 22:33:36 +03:00
2019-08-03 01:16:20 +07:00
use crate::{
completion::{
completion_context::CompletionContext,
completion_item::{CompletionKind, Completions},
},
2019-08-03 01:16:20 +07:00
CompletionItem,
};
2019-01-08 22:33:36 +03:00
/// Complete dot accesses, i.e. fields or methods (and .await syntax).
pub(super) fn complete_dot(acc: &mut Completions, ctx: &CompletionContext) {
2019-08-04 08:03:17 +07:00
let dot_receiver = match &ctx.dot_receiver {
Some(expr) => expr,
_ => return,
};
let receiver_ty = match ctx.sema.type_of_expr(&dot_receiver) {
2019-08-04 08:03:17 +07:00
Some(ty) => ty,
_ => return,
};
2019-08-04 08:03:17 +07:00
if !ctx.is_call {
complete_fields(acc, ctx, &receiver_ty);
2019-08-04 08:03:17 +07:00
}
complete_methods(acc, ctx, &receiver_ty);
2019-08-04 08:03:17 +07:00
// Suggest .await syntax for types that implement Future trait
if receiver_ty.impls_future(ctx.db) {
2019-08-04 08:03:17 +07:00
CompletionItem::new(CompletionKind::Keyword, ctx.source_range(), "await")
.detail("expr.await")
.insert_text("await")
.add_to(acc);
2019-01-08 22:33:36 +03:00
}
}
fn complete_fields(acc: &mut Completions, ctx: &CompletionContext, receiver: &Type) {
for receiver in receiver.autoderef(ctx.db) {
for (field, ty) in receiver.fields(ctx.db) {
if ctx.scope().module().map_or(false, |m| !field.is_visible_from(ctx.db, m)) {
// Skip private field. FIXME: If the definition location of the
// field is editable, we should show the completion
continue;
}
acc.add_field(ctx, field, &ty);
}
for (i, ty) in receiver.tuple_fields(ctx.db).into_iter().enumerate() {
// FIXME: Handle visibility
acc.add_tuple_field(ctx, i, &ty);
}
2019-01-08 22:33:36 +03:00
}
}
fn complete_methods(acc: &mut Completions, ctx: &CompletionContext, receiver: &Type) {
if let Some(krate) = ctx.krate {
2020-01-14 14:42:52 +01:00
let mut seen_methods = FxHashSet::default();
let traits_in_scope = ctx.scope().traits_in_scope();
2020-01-14 14:42:52 +01:00
receiver.iterate_method_candidates(ctx.db, krate, &traits_in_scope, None, |_ty, func| {
if func.has_self_param(ctx.db)
&& ctx.scope().module().map_or(true, |m| func.is_visible_from(ctx.db, m))
&& seen_methods.insert(func.name(ctx.db))
{
2020-04-03 19:33:12 +02:00
acc.add_function(ctx, func, None);
2020-01-14 14:42:52 +01:00
}
None::<()>
});
}
2019-01-07 19:12:19 +01:00
}
2019-01-08 22:33:36 +03:00
#[cfg(test)]
mod tests {
use crate::completion::{test_utils::do_completion, CompletionItem, CompletionKind};
2019-08-29 16:49:10 +03:00
use insta::assert_debug_snapshot;
2019-01-08 22:33:36 +03:00
2019-04-10 13:47:20 +03:00
fn do_ref_completion(code: &str) -> Vec<CompletionItem> {
do_completion(code, CompletionKind::Reference)
2019-01-08 22:33:36 +03:00
}
#[test]
fn test_struct_field_completion() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
r"
struct A { the_field: u32 }
fn foo(a: A) {
a.<|>
}
",
),
2019-05-24 01:46:23 +03:00
@r###"
2019-11-15 12:56:24 +03:00
[
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 45..45,
delete: 45..45,
2019-11-15 12:56:24 +03:00
insert: "the_field",
kind: Field,
detail: "u32",
},
]
2019-05-24 01:46:23 +03:00
"###
2019-01-08 22:33:36 +03:00
);
}
#[test]
fn test_struct_field_completion_self() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
2019-01-08 22:33:36 +03:00
r"
2019-01-25 14:29:56 -05:00
struct A {
/// This is the_field
the_field: (u32,)
}
2019-01-08 22:33:36 +03:00
impl A {
fn foo(self) {
self.<|>
}
}
",
2019-04-10 13:47:20 +03:00
),
2019-05-24 01:46:23 +03:00
@r###"
[
CompletionItem {
2019-10-10 16:37:56 +03:00
label: "foo()",
2020-06-24 11:29:43 +02:00
source_range: 102..102,
delete: 102..102,
insert: "foo()$0",
kind: Method,
lookup: "foo",
detail: "fn foo(self)",
},
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 102..102,
delete: 102..102,
insert: "the_field",
kind: Field,
detail: "(u32,)",
documentation: Documentation(
"This is the_field",
),
},
]
2019-05-24 01:46:23 +03:00
"###
2019-01-08 22:33:36 +03:00
);
}
#[test]
fn test_struct_field_completion_autoderef() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
2019-01-08 22:33:36 +03:00
r"
2019-01-09 18:46:02 +03:00
struct A { the_field: (u32, i32) }
2019-01-08 22:33:36 +03:00
impl A {
fn foo(&self) {
self.<|>
}
}
",
2019-04-10 13:47:20 +03:00
),
2019-05-24 01:46:23 +03:00
@r###"
[
CompletionItem {
2019-10-10 16:37:56 +03:00
label: "foo()",
2020-06-24 11:29:43 +02:00
source_range: 77..77,
delete: 77..77,
insert: "foo()$0",
kind: Method,
lookup: "foo",
detail: "fn foo(&self)",
},
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 77..77,
delete: 77..77,
insert: "the_field",
kind: Field,
detail: "(u32, i32)",
},
]
2019-05-24 01:46:23 +03:00
"###
2019-01-08 22:33:36 +03:00
);
}
#[test]
fn test_no_struct_field_completion_for_method_call() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
2019-01-08 22:33:36 +03:00
r"
struct A { the_field: u32 }
fn foo(a: A) {
a.<|>()
}
",
2019-04-10 13:47:20 +03:00
),
@"[]"
2019-01-08 22:33:36 +03:00
);
}
2019-01-07 19:12:19 +01:00
#[test]
fn test_struct_field_visibility_private() {
assert_debug_snapshot!(
do_ref_completion(
r"
mod inner {
struct A {
private_field: u32,
pub pub_field: u32,
pub(crate) crate_field: u32,
pub(super) super_field: u32,
}
}
fn foo(a: inner::A) {
a.<|>
}
",
),
@r###"
[
CompletionItem {
label: "crate_field",
2020-06-24 11:29:43 +02:00
source_range: 192..192,
delete: 192..192,
insert: "crate_field",
kind: Field,
detail: "u32",
},
CompletionItem {
label: "pub_field",
2020-06-24 11:29:43 +02:00
source_range: 192..192,
delete: 192..192,
insert: "pub_field",
kind: Field,
detail: "u32",
},
CompletionItem {
label: "super_field",
2020-06-24 11:29:43 +02:00
source_range: 192..192,
delete: 192..192,
insert: "super_field",
kind: Field,
detail: "u32",
},
2020-04-28 22:45:46 +02:00
]
"###
);
}
#[test]
fn test_union_field_completion() {
assert_debug_snapshot!(
do_ref_completion(
r"
union Un {
field: u8,
other: u16,
}
fn foo(u: Un) {
u.<|>
}
",
),
@r###"
[
CompletionItem {
label: "field",
2020-06-24 11:29:43 +02:00
source_range: 67..67,
delete: 67..67,
2020-04-28 22:45:46 +02:00
insert: "field",
kind: Field,
detail: "u8",
},
CompletionItem {
label: "other",
2020-06-24 11:29:43 +02:00
source_range: 67..67,
delete: 67..67,
2020-04-28 22:45:46 +02:00
insert: "other",
kind: Field,
detail: "u16",
},
]
"###
);
}
2019-01-07 19:12:19 +01:00
#[test]
fn test_method_completion() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
2019-01-07 19:12:19 +01:00
r"
struct A {}
impl A {
fn the_method(&self) {}
}
fn foo(a: A) {
a.<|>
}
",
2019-04-10 13:47:20 +03:00
),
2019-05-24 01:46:23 +03:00
@r###"
[
CompletionItem {
2019-10-10 16:37:56 +03:00
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 71..71,
delete: 71..71,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "fn the_method(&self)",
},
]
2019-05-24 01:46:23 +03:00
"###
2019-01-07 19:12:19 +01:00
);
}
#[test]
fn test_method_completion_only_fitting_impls() {
assert_debug_snapshot!(
do_ref_completion(
r"
struct A<T> {}
impl A<u32> {
fn the_method(&self) {}
}
impl A<i32> {
fn the_other_method(&self) {}
}
fn foo(a: A<u32>) {
a.<|>
}
",
),
@r###"
[
CompletionItem {
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 134..134,
delete: 134..134,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "fn the_method(&self)",
},
]
"###
);
}
#[test]
fn test_method_completion_private() {
assert_debug_snapshot!(
do_ref_completion(
r"
struct A {}
mod m {
impl super::A {
fn private_method(&self) {}
pub(super) fn the_method(&self) {}
}
}
fn foo(a: A) {
a.<|>
}
",
),
@r###"
[
CompletionItem {
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 147..147,
delete: 147..147,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "pub(super) fn the_method(&self)",
},
]
"###
);
}
#[test]
fn test_trait_method_completion() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
do_ref_completion(
r"
struct A {}
trait Trait { fn the_method(&self); }
impl Trait for A {}
fn foo(a: A) {
a.<|>
}
",
),
2019-05-24 01:46:23 +03:00
@r###"
[
CompletionItem {
2019-10-10 16:37:56 +03:00
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 90..90,
delete: 90..90,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "fn the_method(&self)",
},
]
2019-05-24 01:46:23 +03:00
"###
);
}
2019-06-29 12:19:03 +02:00
#[test]
fn test_trait_method_completion_deduplicated() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-06-29 12:19:03 +02:00
do_ref_completion(
r"
struct A {}
trait Trait { fn the_method(&self); }
impl<T> Trait for T {}
fn foo(a: &A) {
a.<|>
}
",
),
@r###"
[
CompletionItem {
2019-10-10 16:37:56 +03:00
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 94..94,
delete: 94..94,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "fn the_method(&self)",
},
]
2019-06-29 12:19:03 +02:00
"###
);
}
#[test]
fn completes_trait_method_from_other_module() {
assert_debug_snapshot!(
do_ref_completion(
r"
struct A {}
mod m {
pub trait Trait { fn the_method(&self); }
}
use m::Trait;
impl Trait for A {}
fn foo(a: A) {
a.<|>
}
",
),
@r###"
[
CompletionItem {
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 122..122,
delete: 122..122,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "fn the_method(&self)",
},
]
"###
);
}
2019-01-07 19:12:19 +01:00
#[test]
fn test_no_non_self_method() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
2019-01-07 19:12:19 +01:00
r"
struct A {}
impl A {
fn the_method() {}
}
fn foo(a: A) {
a.<|>
}
",
2019-04-10 13:47:20 +03:00
),
@"[]"
2019-01-07 19:12:19 +01:00
);
}
2019-01-24 08:25:35 -05:00
#[test]
fn test_method_attr_filtering() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
r"
struct A {}
impl A {
#[inline]
fn the_method(&self) {
let x = 1;
let y = 2;
}
}
fn foo(a: A) {
a.<|>
}
",
2019-04-10 13:47:20 +03:00
),
2019-05-24 01:46:23 +03:00
@r###"
[
CompletionItem {
2019-10-10 16:37:56 +03:00
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 128..128,
delete: 128..128,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "fn the_method(&self)",
},
]
2019-05-24 01:46:23 +03:00
"###
);
}
2019-01-24 08:25:35 -05:00
#[test]
fn test_tuple_field_completion() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
2019-01-24 08:25:35 -05:00
r"
fn foo() {
let b = (0, 3.14);
b.<|>
}
",
2019-04-10 13:47:20 +03:00
),
2019-05-24 01:46:23 +03:00
@r###"
2019-11-15 12:56:24 +03:00
[
CompletionItem {
label: "0",
2020-06-24 11:29:43 +02:00
source_range: 38..38,
delete: 38..38,
2019-11-15 12:56:24 +03:00
insert: "0",
kind: Field,
detail: "i32",
},
CompletionItem {
label: "1",
2020-06-24 11:29:43 +02:00
source_range: 38..38,
delete: 38..38,
2019-11-15 12:56:24 +03:00
insert: "1",
kind: Field,
detail: "f64",
},
]
2019-05-24 01:46:23 +03:00
"###
2019-01-24 08:25:35 -05:00
);
}
#[test]
fn test_tuple_field_inference() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
2019-04-10 13:47:20 +03:00
do_ref_completion(
r"
pub struct S;
impl S {
pub fn blah(&self) {}
}
struct T(S);
impl T {
fn foo(&self) {
// FIXME: This doesn't work without the trailing `a` as `0.` is a float
self.0.a<|>
}
}
",
2019-04-10 13:47:20 +03:00
),
2019-05-24 01:46:23 +03:00
@r###"
[
CompletionItem {
2019-10-10 16:37:56 +03:00
label: "blah()",
2020-06-24 11:29:43 +02:00
source_range: 190..191,
delete: 190..191,
insert: "blah()$0",
kind: Method,
lookup: "blah",
detail: "pub fn blah(&self)",
},
]
2019-05-24 01:46:23 +03:00
"###
);
}
#[test]
fn test_completion_works_in_consts() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
do_ref_completion(
r"
struct A { the_field: u32 }
const X: u32 = {
A { the_field: 92 }.<|>
};
",
),
2019-05-24 01:46:23 +03:00
@r###"
2019-11-15 12:56:24 +03:00
[
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 69..69,
delete: 69..69,
2019-11-15 12:56:24 +03:00
insert: "the_field",
kind: Field,
detail: "u32",
},
]
2019-05-24 01:46:23 +03:00
"###
);
}
#[test]
fn test_completion_await_impls_future() {
2019-08-29 16:49:10 +03:00
assert_debug_snapshot!(
do_completion(
r###"
//- /main.rs
use std::future::*;
struct A {}
impl Future for A {}
fn foo(a: A) {
a.<|>
}
//- /std/lib.rs
pub mod future {
2020-01-14 11:13:07 +01:00
#[lang = "future_trait"]
pub trait Future {}
}
"###, CompletionKind::Keyword),
@r###"
2019-11-15 12:56:24 +03:00
[
CompletionItem {
label: "await",
2020-04-24 23:51:02 +02:00
source_range: 74..74,
delete: 74..74,
2019-11-15 12:56:24 +03:00
insert: "await",
detail: "expr.await",
},
]
"###
)
}
2020-02-29 20:53:01 -08:00
#[test]
fn test_super_super_completion() {
assert_debug_snapshot!(
do_ref_completion(
r"
mod a {
const A: usize = 0;
mod b {
const B: usize = 0;
mod c {
use super::super::<|>
}
}
}
",
),
@r###"
[
CompletionItem {
label: "A",
2020-06-24 11:29:43 +02:00
source_range: 120..120,
delete: 120..120,
2020-02-29 20:53:01 -08:00
insert: "A",
kind: Const,
},
CompletionItem {
label: "b",
2020-06-24 11:29:43 +02:00
source_range: 120..120,
delete: 120..120,
2020-02-29 20:53:01 -08:00
insert: "b",
kind: Module,
},
]
"###
);
}
2020-03-07 15:27:03 +01:00
#[test]
fn works_in_simple_macro_1() {
assert_debug_snapshot!(
do_ref_completion(
r"
macro_rules! m { ($e:expr) => { $e } }
struct A { the_field: u32 }
fn foo(a: A) {
m!(a.x<|>)
}
",
),
@r###"
[
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 91..92,
delete: 91..92,
2020-03-07 15:27:03 +01:00
insert: "the_field",
kind: Field,
detail: "u32",
},
]
"###
);
}
#[test]
fn works_in_simple_macro_recursive() {
assert_debug_snapshot!(
do_ref_completion(
r"
macro_rules! m { ($e:expr) => { $e } }
struct A { the_field: u32 }
fn foo(a: A) {
m!(a.x<|>)
}
",
),
@r###"
[
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 91..92,
delete: 91..92,
2020-03-07 15:27:03 +01:00
insert: "the_field",
kind: Field,
detail: "u32",
},
]
"###
);
}
#[test]
fn works_in_simple_macro_2() {
// this doesn't work yet because the macro doesn't expand without the token -- maybe it can be fixed with better recovery
assert_debug_snapshot!(
do_ref_completion(
r"
macro_rules! m { ($e:expr) => { $e } }
struct A { the_field: u32 }
fn foo(a: A) {
m!(a.<|>)
}
",
),
2020-03-15 11:17:13 +01:00
@r###"
[
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 91..91,
delete: 91..91,
2020-03-15 11:17:13 +01:00
insert: "the_field",
kind: Field,
detail: "u32",
},
]
"###
2020-03-07 15:27:03 +01:00
);
}
#[test]
fn works_in_simple_macro_recursive_1() {
assert_debug_snapshot!(
do_ref_completion(
r"
macro_rules! m { ($e:expr) => { $e } }
struct A { the_field: u32 }
fn foo(a: A) {
m!(m!(m!(a.x<|>)))
}
",
),
@r###"
[
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 97..98,
delete: 97..98,
2020-03-07 15:27:03 +01:00
insert: "the_field",
kind: Field,
detail: "u32",
},
]
"###
);
}
#[test]
fn macro_expansion_resilient() {
assert_debug_snapshot!(
do_ref_completion(
r"
macro_rules! dbg {
() => {};
($val:expr) => {
match $val { tmp => { tmp } }
};
// Trailing comma with single argument is ignored
($val:expr,) => { $crate::dbg!($val) };
($($val:expr),+ $(,)?) => {
($($crate::dbg!($val)),+,)
};
}
struct A { the_field: u32 }
fn foo(a: A) {
dbg!(a.<|>)
}
",
),
@r###"
[
CompletionItem {
label: "the_field",
2020-06-24 11:29:43 +02:00
source_range: 327..327,
delete: 327..327,
insert: "the_field",
kind: Field,
detail: "u32",
},
]
"###
);
}
#[test]
fn test_method_completion_3547() {
assert_debug_snapshot!(
do_ref_completion(
r"
struct HashSet<T> {}
impl<T> HashSet<T> {
pub fn the_method(&self) {}
}
fn foo() {
let s: HashSet<_>;
s.<|>
}
",
),
@r###"
[
CompletionItem {
label: "the_method()",
2020-06-24 11:29:43 +02:00
source_range: 116..116,
delete: 116..116,
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "pub fn the_method(&self)",
},
]
"###
);
}
2019-01-08 22:33:36 +03:00
}