rust/tests/ui/non_zero_suggestions.fixed

83 lines
2.6 KiB
Rust
Raw Normal View History

#![warn(clippy::non_zero_suggestions)]
use std::num::{NonZeroI16, NonZeroI8, NonZeroU16, NonZeroU32, NonZeroU64, NonZeroU8, NonZeroUsize};
fn main() {
2024-07-26 16:45:40 -05:00
/// Positive test cases (lint should trigger)
// U32 -> U64
let x: u64 = 100;
let y = NonZeroU32::new(10).unwrap();
let r1 = x / NonZeroU64::from(y);
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroU64::from()` for more efficient and type-safe conversion
let r2 = x % NonZeroU64::from(y);
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroU64::from()` for more efficient and type-safe conversion
// U16 -> U32
let a: u32 = 50;
let b = NonZeroU16::new(5).unwrap();
let r3 = a / NonZeroU32::from(b);
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroU32::from()` for more efficient and type-safe conversion
// I8 -> I16
let c: i16 = 25;
let d = NonZeroI8::new(3).unwrap();
let r4 = NonZeroI16::from(d);
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroI16::from()` for more efficient and type-safe conversion
// Different operations
let m: u64 = 400;
let n = NonZeroU32::new(20).unwrap();
let r5 = m / NonZeroU64::from(n);
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroU64::from()` for more efficient and type-safe conversion
2024-07-26 16:45:40 -05:00
/// Edge cases
// Using the max value of a type
let max_u32 = NonZeroU32::new(u32::MAX).unwrap();
let r6 = NonZeroU64::from(max_u32);
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroU64::from()` for more efficient and type-safe conversion
// Chained method calls
let _ = NonZeroU64::from(NonZeroU32::new(10).unwrap());
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroU64::from()` for more efficient and type-safe conversion
2024-07-26 16:45:40 -05:00
/// Negative test cases (lint should not trigger)
// Same size types
let e: u32 = 200;
let f = NonZeroU32::new(20).unwrap();
let r10 = e / f.get();
// Smaller to larger, but not NonZero
let g: u64 = 1000;
let h: u32 = 50;
let r11 = g / u64::from(h);
// Using From correctly
let k: u64 = 300;
let l = NonZeroU32::new(15).unwrap();
let r12 = k / NonZeroU64::from(l);
}
// Additional function to test the lint in a different context
fn divide_numbers(x: u64, y: NonZeroU32) -> u64 {
x / NonZeroU64::from(y)
2024-07-26 16:45:40 -05:00
//~^ ERROR: consider using `NonZeroU64::from()` for more efficient and type-safe conversion
}
2024-07-26 16:45:40 -05:00
fn no_bin_exp(x: u64, y: NonZeroU32) -> u64 {
NonZeroU64::from(y)
//~^ ERROR: consider using `NonZeroU64::from()` for more efficient and type-safe conversion
}
fn some_fn_that_only_takes_u64(_: u64) {}
struct Calculator {
value: u64,
}
impl Calculator {
fn divide(&self, divisor: NonZeroU32) -> u64 {
self.value / NonZeroU64::from(divisor)
}
}