2020-02-01 05:28:27 -06:00
|
|
|
#![warn(clippy::drop_ref)]
|
|
|
|
#![allow(clippy::toplevel_ref_arg)]
|
2020-09-24 07:49:22 -05:00
|
|
|
#![allow(clippy::map_err_ignore)]
|
2016-12-29 20:45:41 -06:00
|
|
|
|
2020-02-01 05:28:27 -06:00
|
|
|
use std::mem::drop;
|
2016-12-29 20:45:41 -06:00
|
|
|
|
|
|
|
struct SomeStruct;
|
|
|
|
|
|
|
|
fn main() {
|
2017-02-08 07:58:07 -06:00
|
|
|
drop(&SomeStruct);
|
2016-12-29 20:45:41 -06:00
|
|
|
|
|
|
|
let mut owned1 = SomeStruct;
|
2017-02-08 07:58:07 -06:00
|
|
|
drop(&owned1);
|
|
|
|
drop(&&owned1);
|
|
|
|
drop(&mut owned1);
|
2016-12-29 20:45:41 -06:00
|
|
|
drop(owned1); //OK
|
|
|
|
|
|
|
|
let reference1 = &SomeStruct;
|
2017-02-08 07:58:07 -06:00
|
|
|
drop(reference1);
|
2016-12-29 20:45:41 -06:00
|
|
|
|
|
|
|
let reference2 = &mut SomeStruct;
|
2017-02-08 07:58:07 -06:00
|
|
|
drop(reference2);
|
2016-12-29 20:45:41 -06:00
|
|
|
|
2020-02-01 05:28:27 -06:00
|
|
|
let ref reference3 = SomeStruct;
|
|
|
|
drop(reference3);
|
2016-12-29 20:45:41 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn test_generic_fn_drop<T>(val: T) {
|
2017-02-08 07:58:07 -06:00
|
|
|
drop(&val);
|
2016-12-29 20:45:41 -06:00
|
|
|
drop(val); //OK
|
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn test_similarly_named_function() {
|
|
|
|
fn drop<T>(_val: T) {}
|
|
|
|
drop(&SomeStruct); //OK; call to unrelated function which happens to have the same name
|
2017-02-08 07:58:07 -06:00
|
|
|
std::mem::drop(&SomeStruct);
|
2016-12-29 20:45:41 -06:00
|
|
|
}
|
2019-07-31 10:38:08 -05:00
|
|
|
|
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
pub struct Error;
|
|
|
|
fn produce_half_owl_error() -> Result<(), Error> {
|
|
|
|
Ok(())
|
|
|
|
}
|
|
|
|
|
|
|
|
fn produce_half_owl_ok() -> Result<bool, ()> {
|
|
|
|
Ok(true)
|
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn test_owl_result() -> Result<(), ()> {
|
|
|
|
produce_half_owl_error().map_err(|_| ())?;
|
|
|
|
produce_half_owl_ok().map(|_| ())?;
|
|
|
|
// the following should not be linted,
|
|
|
|
// we should not force users to use toilet closures
|
|
|
|
// to produce owl results when drop is more convenient
|
|
|
|
produce_half_owl_error().map_err(drop)?;
|
|
|
|
produce_half_owl_ok().map_err(drop)?;
|
|
|
|
Ok(())
|
|
|
|
}
|
|
|
|
|
|
|
|
#[allow(dead_code)]
|
|
|
|
fn test_owl_result_2() -> Result<u8, ()> {
|
|
|
|
produce_half_owl_error().map_err(|_| ())?;
|
|
|
|
produce_half_owl_ok().map(|_| ())?;
|
|
|
|
// the following should not be linted,
|
|
|
|
// we should not force users to use toilet closures
|
|
|
|
// to produce owl results when drop is more convenient
|
|
|
|
produce_half_owl_error().map_err(drop)?;
|
|
|
|
produce_half_owl_ok().map(drop)?;
|
|
|
|
Ok(1)
|
|
|
|
}
|