2015-03-07 16:46:35 -06:00
|
|
|
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution and at
|
|
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
|
|
|
#![feature(rustc_private)]
|
2015-06-19 18:39:13 -05:00
|
|
|
#![feature(str_escape)]
|
2015-04-13 20:00:46 -05:00
|
|
|
#![feature(str_char)]
|
2015-07-17 01:26:10 -05:00
|
|
|
|
2015-03-07 16:46:35 -06:00
|
|
|
|
2015-03-08 23:18:48 -05:00
|
|
|
// TODO we're going to allocate a whole bunch of temp Strings, is it worth
|
|
|
|
// keeping some scratch mem for this and running our own StrPool?
|
2015-04-13 20:00:46 -05:00
|
|
|
// TODO for lint violations of names, emit a refactor script
|
|
|
|
|
2015-03-08 23:18:48 -05:00
|
|
|
|
2015-03-07 16:46:35 -06:00
|
|
|
#[macro_use]
|
|
|
|
extern crate log;
|
|
|
|
|
|
|
|
extern crate getopts;
|
|
|
|
extern crate rustc;
|
|
|
|
extern crate rustc_driver;
|
|
|
|
extern crate syntax;
|
2015-05-23 00:02:59 -05:00
|
|
|
extern crate rustc_serialize;
|
2015-03-07 16:46:35 -06:00
|
|
|
|
2015-04-13 20:12:56 -05:00
|
|
|
extern crate strings;
|
|
|
|
|
2015-03-07 16:46:35 -06:00
|
|
|
use rustc::session::Session;
|
2015-05-23 00:02:59 -05:00
|
|
|
use rustc::session::config as rustc_config;
|
|
|
|
use rustc::session::config::Input;
|
2015-03-07 16:46:35 -06:00
|
|
|
use rustc_driver::{driver, CompilerCalls, Compilation};
|
|
|
|
|
2015-04-21 04:01:19 -05:00
|
|
|
use syntax::ast;
|
|
|
|
use syntax::codemap::CodeMap;
|
2015-03-07 16:46:35 -06:00
|
|
|
use syntax::diagnostics;
|
|
|
|
use syntax::visit;
|
|
|
|
|
2015-03-09 01:17:14 -05:00
|
|
|
use std::path::PathBuf;
|
2015-04-22 23:22:48 -05:00
|
|
|
use std::collections::HashMap;
|
2015-06-08 18:42:29 -05:00
|
|
|
use std::fmt;
|
2015-06-23 06:26:04 -05:00
|
|
|
use std::mem::swap;
|
2015-03-07 16:46:35 -06:00
|
|
|
|
2015-06-08 18:42:29 -05:00
|
|
|
use issues::{BadIssueSeeker, Issue};
|
2015-03-07 16:46:35 -06:00
|
|
|
use changes::ChangeSet;
|
2015-04-21 04:01:19 -05:00
|
|
|
use visitor::FmtVisitor;
|
2015-06-23 06:26:04 -05:00
|
|
|
use config::Config;
|
2015-03-07 16:46:35 -06:00
|
|
|
|
2015-06-08 13:23:24 -05:00
|
|
|
#[macro_use]
|
|
|
|
mod utils;
|
2015-07-20 16:29:25 -05:00
|
|
|
pub mod config;
|
2015-03-07 16:46:35 -06:00
|
|
|
mod changes;
|
2015-04-21 04:01:19 -05:00
|
|
|
mod visitor;
|
2015-05-24 18:03:26 -05:00
|
|
|
mod items;
|
2015-04-20 23:47:15 -05:00
|
|
|
mod missed_spans;
|
|
|
|
mod lists;
|
2015-04-21 04:01:19 -05:00
|
|
|
mod types;
|
|
|
|
mod expr;
|
|
|
|
mod imports;
|
2015-06-08 18:42:29 -05:00
|
|
|
mod issues;
|
2015-06-16 10:29:05 -05:00
|
|
|
mod rewrite;
|
2015-06-23 08:58:58 -05:00
|
|
|
mod string;
|
|
|
|
mod comment;
|
2015-03-07 16:46:35 -06:00
|
|
|
|
|
|
|
const MIN_STRING: usize = 10;
|
2015-04-22 23:22:48 -05:00
|
|
|
// When we get scoped annotations, we should have rustfmt::skip.
|
|
|
|
const SKIP_ANNOTATION: &'static str = "rustfmt_skip";
|
2015-04-20 19:02:30 -05:00
|
|
|
|
2015-04-22 23:22:48 -05:00
|
|
|
#[derive(Copy, Clone)]
|
2015-04-20 23:28:10 -05:00
|
|
|
pub enum WriteMode {
|
|
|
|
Overwrite,
|
|
|
|
// str is the extension of the new file
|
|
|
|
NewFile(&'static str),
|
|
|
|
// Write the output to stdout.
|
|
|
|
Display,
|
2015-04-22 23:22:48 -05:00
|
|
|
// Return the result as a mapping from filenames to StringBuffers.
|
|
|
|
Return(&'static Fn(HashMap<String, String>)),
|
2015-04-20 23:28:10 -05:00
|
|
|
}
|
|
|
|
|
2015-04-30 06:13:20 -05:00
|
|
|
#[derive(Copy, Clone, Eq, PartialEq, Debug)]
|
2015-05-23 00:02:59 -05:00
|
|
|
pub enum NewlineStyle {
|
2015-04-30 06:13:20 -05:00
|
|
|
Windows, // \r\n
|
|
|
|
Unix, // \n
|
|
|
|
}
|
|
|
|
|
2015-06-04 07:08:32 -05:00
|
|
|
impl_enum_decodable!(NewlineStyle, Windows, Unix);
|
2015-05-23 00:02:59 -05:00
|
|
|
|
2015-04-20 19:02:30 -05:00
|
|
|
#[derive(Copy, Clone, Eq, PartialEq, Debug)]
|
2015-05-23 00:02:59 -05:00
|
|
|
pub enum BraceStyle {
|
2015-04-20 19:02:30 -05:00
|
|
|
AlwaysNextLine,
|
|
|
|
PreferSameLine,
|
|
|
|
// Prefer same line except where there is a where clause, in which case force
|
|
|
|
// the brace to the next line.
|
|
|
|
SameLineWhere,
|
|
|
|
}
|
|
|
|
|
2015-06-04 07:08:32 -05:00
|
|
|
impl_enum_decodable!(BraceStyle, AlwaysNextLine, PreferSameLine, SameLineWhere);
|
2015-05-23 00:02:59 -05:00
|
|
|
|
2015-04-20 19:02:30 -05:00
|
|
|
// How to indent a function's return type.
|
|
|
|
#[derive(Copy, Clone, Eq, PartialEq, Debug)]
|
2015-05-23 00:02:59 -05:00
|
|
|
pub enum ReturnIndent {
|
2015-04-20 19:02:30 -05:00
|
|
|
// Aligned with the arguments
|
|
|
|
WithArgs,
|
|
|
|
// Aligned with the where clause
|
|
|
|
WithWhereClause,
|
|
|
|
}
|
2015-03-07 16:46:35 -06:00
|
|
|
|
2015-06-04 07:08:32 -05:00
|
|
|
impl_enum_decodable!(ReturnIndent, WithArgs, WithWhereClause);
|
2015-05-23 00:02:59 -05:00
|
|
|
|
2015-07-15 17:44:43 -05:00
|
|
|
// How to stle a struct literal.
|
|
|
|
#[derive(Copy, Clone, Eq, PartialEq, Debug)]
|
|
|
|
pub enum StructLitStyle {
|
|
|
|
// First line on the same line as the opening brace, all lines aligned with
|
|
|
|
// the first line.
|
|
|
|
VisualIndent,
|
|
|
|
// First line is on a new line and all lines align with block indent.
|
|
|
|
BlockIndent,
|
|
|
|
// FIXME Maybe we should also have an option to align types.
|
|
|
|
}
|
|
|
|
|
|
|
|
impl_enum_decodable!(StructLitStyle, VisualIndent, BlockIndent);
|
|
|
|
|
2015-06-08 18:42:29 -05:00
|
|
|
enum ErrorKind {
|
2015-06-23 06:26:04 -05:00
|
|
|
// Line has exceeded character limit
|
2015-06-08 18:42:29 -05:00
|
|
|
LineOverflow,
|
|
|
|
// Line ends in whitespace
|
|
|
|
TrailingWhitespace,
|
|
|
|
// TO-DO or FIX-ME item without an issue number
|
|
|
|
BadIssue(Issue),
|
|
|
|
}
|
|
|
|
|
|
|
|
impl fmt::Display for ErrorKind {
|
|
|
|
fn fmt(&self, fmt: &mut fmt::Formatter) -> Result<(), fmt::Error> {
|
|
|
|
match *self {
|
|
|
|
ErrorKind::LineOverflow => {
|
|
|
|
write!(fmt, "line exceeded maximum length")
|
2015-07-15 21:17:07 -05:00
|
|
|
}
|
2015-06-08 18:42:29 -05:00
|
|
|
ErrorKind::TrailingWhitespace => {
|
|
|
|
write!(fmt, "left behind trailing whitespace")
|
2015-07-15 21:17:07 -05:00
|
|
|
}
|
2015-06-08 18:42:29 -05:00
|
|
|
ErrorKind::BadIssue(issue) => {
|
|
|
|
write!(fmt, "found {}", issue)
|
2015-07-15 21:17:07 -05:00
|
|
|
}
|
2015-06-08 18:42:29 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Formatting errors that are identified *after* rustfmt has run
|
|
|
|
struct FormattingError {
|
|
|
|
line: u32,
|
|
|
|
kind: ErrorKind,
|
|
|
|
}
|
|
|
|
|
2015-07-15 21:17:07 -05:00
|
|
|
impl FormattingError {
|
|
|
|
fn msg_prefix(&self) -> &str {
|
|
|
|
match self.kind {
|
|
|
|
ErrorKind::LineOverflow |
|
|
|
|
ErrorKind::TrailingWhitespace => "Rustfmt failed at",
|
|
|
|
ErrorKind::BadIssue(_) => "WARNING:",
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn msg_suffix(&self) -> &str {
|
|
|
|
match self.kind {
|
|
|
|
ErrorKind::LineOverflow |
|
|
|
|
ErrorKind::TrailingWhitespace => "(sorry)",
|
|
|
|
ErrorKind::BadIssue(_) => "",
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-06-08 18:42:29 -05:00
|
|
|
struct FormatReport {
|
|
|
|
// Maps stringified file paths to their associated formatting errors
|
|
|
|
file_error_map: HashMap<String, Vec<FormattingError>>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl fmt::Display for FormatReport {
|
|
|
|
// Prints all the formatting errors.
|
|
|
|
fn fmt(&self, fmt: &mut fmt::Formatter) -> Result<(), fmt::Error> {
|
|
|
|
for (file, errors) in self.file_error_map.iter() {
|
|
|
|
for error in errors {
|
|
|
|
try!(write!(fmt,
|
2015-07-15 21:17:07 -05:00
|
|
|
"{} {}:{}: {} {}\n",
|
|
|
|
error.msg_prefix(),
|
2015-06-08 18:42:29 -05:00
|
|
|
file,
|
|
|
|
error.line,
|
2015-07-15 21:17:07 -05:00
|
|
|
error.kind,
|
|
|
|
error.msg_suffix()));
|
2015-06-08 18:42:29 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
Ok(())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-07 16:46:35 -06:00
|
|
|
// Formatting which depends on the AST.
|
2015-06-23 06:26:04 -05:00
|
|
|
fn fmt_ast<'a>(krate: &ast::Crate, codemap: &'a CodeMap, config: &'a Config) -> ChangeSet<'a> {
|
|
|
|
let mut visitor = FmtVisitor::from_codemap(codemap, config);
|
2015-03-07 16:46:35 -06:00
|
|
|
visit::walk_crate(&mut visitor, krate);
|
|
|
|
visitor.changes
|
|
|
|
}
|
|
|
|
|
2015-04-21 05:50:43 -05:00
|
|
|
// Formatting done on a char by char or line by line basis.
|
|
|
|
// TODO warn on bad license
|
|
|
|
// TODO other stuff for parity with make tidy
|
2015-06-23 06:26:04 -05:00
|
|
|
fn fmt_lines(changes: &mut ChangeSet, config: &Config) -> FormatReport {
|
2015-04-23 01:02:55 -05:00
|
|
|
let mut truncate_todo = Vec::new();
|
2015-06-08 18:42:29 -05:00
|
|
|
let mut report = FormatReport { file_error_map: HashMap::new() };
|
2015-04-23 01:02:55 -05:00
|
|
|
|
2015-03-07 16:46:35 -06:00
|
|
|
// Iterate over the chars in the change set.
|
|
|
|
for (f, text) in changes.text() {
|
|
|
|
let mut trims = vec![];
|
2015-04-13 20:00:46 -05:00
|
|
|
let mut last_wspace: Option<usize> = None;
|
2015-03-07 16:46:35 -06:00
|
|
|
let mut line_len = 0;
|
|
|
|
let mut cur_line = 1;
|
2015-04-23 01:02:55 -05:00
|
|
|
let mut newline_count = 0;
|
2015-06-08 18:42:29 -05:00
|
|
|
let mut errors = vec![];
|
2015-07-19 16:39:48 -05:00
|
|
|
let mut issue_seeker = BadIssueSeeker::new(config.report_todo, config.report_fixme);
|
2015-06-08 18:42:29 -05:00
|
|
|
|
2015-03-07 16:46:35 -06:00
|
|
|
for (c, b) in text.chars() {
|
2015-07-19 16:39:48 -05:00
|
|
|
if c == '\r' {
|
|
|
|
continue;
|
|
|
|
}
|
2015-06-08 18:42:29 -05:00
|
|
|
|
|
|
|
// Add warnings for bad todos/ fixmes
|
|
|
|
if let Some(issue) = issue_seeker.inspect(c) {
|
|
|
|
errors.push(FormattingError {
|
|
|
|
line: cur_line,
|
|
|
|
kind: ErrorKind::BadIssue(issue)
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2015-05-04 07:32:48 -05:00
|
|
|
if c == '\n' {
|
2015-03-07 16:46:35 -06:00
|
|
|
// Check for (and record) trailing whitespace.
|
|
|
|
if let Some(lw) = last_wspace {
|
2015-03-08 23:18:48 -05:00
|
|
|
trims.push((cur_line, lw, b));
|
2015-03-07 16:46:35 -06:00
|
|
|
line_len -= b - lw;
|
|
|
|
}
|
|
|
|
// Check for any line width errors we couldn't correct.
|
2015-06-23 06:26:04 -05:00
|
|
|
if line_len > config.max_width {
|
2015-06-08 18:42:29 -05:00
|
|
|
errors.push(FormattingError {
|
|
|
|
line: cur_line,
|
|
|
|
kind: ErrorKind::LineOverflow
|
|
|
|
});
|
2015-03-07 16:46:35 -06:00
|
|
|
}
|
|
|
|
line_len = 0;
|
|
|
|
cur_line += 1;
|
2015-04-23 01:02:55 -05:00
|
|
|
newline_count += 1;
|
2015-03-07 16:46:35 -06:00
|
|
|
last_wspace = None;
|
|
|
|
} else {
|
2015-04-23 01:02:55 -05:00
|
|
|
newline_count = 0;
|
2015-03-07 16:46:35 -06:00
|
|
|
line_len += 1;
|
|
|
|
if c.is_whitespace() {
|
|
|
|
if last_wspace.is_none() {
|
|
|
|
last_wspace = Some(b);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
last_wspace = None;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-04-23 01:02:55 -05:00
|
|
|
if newline_count > 1 {
|
2015-04-23 01:30:12 -05:00
|
|
|
debug!("track truncate: {} {} {}", f, text.len, newline_count);
|
2015-06-08 18:42:29 -05:00
|
|
|
truncate_todo.push((f.to_owned(), text.len - newline_count + 1))
|
2015-04-23 01:02:55 -05:00
|
|
|
}
|
|
|
|
|
2015-03-08 23:18:48 -05:00
|
|
|
for &(l, _, _) in trims.iter() {
|
2015-06-08 18:42:29 -05:00
|
|
|
errors.push(FormattingError {
|
|
|
|
line: l,
|
|
|
|
kind: ErrorKind::TrailingWhitespace
|
|
|
|
});
|
2015-03-07 16:46:35 -06:00
|
|
|
}
|
2015-06-08 18:42:29 -05:00
|
|
|
|
|
|
|
report.file_error_map.insert(f.to_owned(), errors);
|
2015-03-07 16:46:35 -06:00
|
|
|
}
|
2015-04-23 01:02:55 -05:00
|
|
|
|
|
|
|
for (f, l) in truncate_todo {
|
2015-05-01 11:17:14 -05:00
|
|
|
changes.get_mut(&f).truncate(l);
|
2015-04-23 01:02:55 -05:00
|
|
|
}
|
2015-06-08 18:42:29 -05:00
|
|
|
|
|
|
|
report
|
2015-03-07 16:46:35 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
struct RustFmtCalls {
|
2015-04-22 23:22:48 -05:00
|
|
|
write_mode: WriteMode,
|
2015-06-23 06:26:04 -05:00
|
|
|
config: Option<Box<config::Config>>,
|
2015-03-07 16:46:35 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
impl<'a> CompilerCalls<'a> for RustFmtCalls {
|
|
|
|
fn no_input(&mut self,
|
|
|
|
_: &getopts::Matches,
|
2015-05-23 00:02:59 -05:00
|
|
|
_: &rustc_config::Options,
|
2015-03-09 01:17:14 -05:00
|
|
|
_: &Option<PathBuf>,
|
|
|
|
_: &Option<PathBuf>,
|
2015-03-07 16:46:35 -06:00
|
|
|
_: &diagnostics::registry::Registry)
|
2015-03-09 01:17:14 -05:00
|
|
|
-> Option<(Input, Option<PathBuf>)> {
|
2015-03-07 16:46:35 -06:00
|
|
|
panic!("No input supplied to RustFmt");
|
|
|
|
}
|
|
|
|
|
|
|
|
fn build_controller(&mut self, _: &Session) -> driver::CompileController<'a> {
|
2015-04-22 23:22:48 -05:00
|
|
|
let write_mode = self.write_mode;
|
2015-06-23 06:26:04 -05:00
|
|
|
|
|
|
|
let mut config_option = None;
|
|
|
|
swap(&mut self.config, &mut config_option);
|
|
|
|
let config = config_option.unwrap();
|
|
|
|
|
2015-03-07 16:46:35 -06:00
|
|
|
let mut control = driver::CompileController::basic();
|
|
|
|
control.after_parse.stop = Compilation::Stop;
|
2015-05-20 13:20:15 -05:00
|
|
|
control.after_parse.callback = Box::new(move |state| {
|
2015-03-07 16:46:35 -06:00
|
|
|
let krate = state.krate.unwrap();
|
|
|
|
let codemap = state.session.codemap();
|
2015-06-23 06:26:04 -05:00
|
|
|
let mut changes = fmt_ast(krate, codemap, &*config);
|
2015-04-23 00:04:07 -05:00
|
|
|
// For some reason, the codemap does not include terminating newlines
|
|
|
|
// so we must add one on for each file. This is sad.
|
|
|
|
changes.append_newlines();
|
2015-06-23 06:26:04 -05:00
|
|
|
println!("{}", fmt_lines(&mut changes, &*config));
|
2015-03-07 16:46:35 -06:00
|
|
|
|
2015-06-23 06:26:04 -05:00
|
|
|
let result = changes.write_all_files(write_mode, &*config);
|
2015-04-20 23:28:10 -05:00
|
|
|
|
2015-04-22 23:22:48 -05:00
|
|
|
match result {
|
|
|
|
Err(msg) => println!("Error writing files: {}", msg),
|
|
|
|
Ok(result) => {
|
|
|
|
if let WriteMode::Return(callback) = write_mode {
|
|
|
|
callback(result);
|
|
|
|
}
|
|
|
|
}
|
2015-04-20 23:28:10 -05:00
|
|
|
}
|
2015-05-20 13:20:15 -05:00
|
|
|
});
|
2015-03-07 16:46:35 -06:00
|
|
|
|
|
|
|
control
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-23 00:02:59 -05:00
|
|
|
// args are the arguments passed on the command line, generally passed through
|
|
|
|
// to the compiler.
|
|
|
|
// write_mode determines what happens to the result of running rustfmt, see
|
|
|
|
// WriteMode.
|
|
|
|
// default_config is a string of toml data to be used to configure rustfmt.
|
|
|
|
pub fn run(args: Vec<String>, write_mode: WriteMode, default_config: &str) {
|
2015-06-23 06:26:04 -05:00
|
|
|
let config = Some(Box::new(config::Config::from_toml(default_config)));
|
2015-07-22 15:05:34 -05:00
|
|
|
let mut call_ctxt = RustFmtCalls { write_mode: write_mode, config: config };
|
2015-04-23 01:10:43 -05:00
|
|
|
rustc_driver::run_compiler(&args, &mut call_ctxt);
|
2015-04-22 23:22:48 -05:00
|
|
|
}
|