2018-11-27 02:59:49 +00:00
|
|
|
// Detecting lib features (i.e., features that are not lang features).
|
2018-07-23 01:20:33 +01:00
|
|
|
//
|
2018-11-27 02:59:49 +00:00
|
|
|
// These are declared using stability attributes (e.g., `#[stable (..)]`
|
2018-07-23 02:20:50 +01:00
|
|
|
// and `#[unstable (..)]`), but are not declared in one single location
|
2018-07-23 01:20:33 +01:00
|
|
|
// (unlike lang features), which means we need to collect them instead.
|
|
|
|
|
2019-02-05 11:20:45 -06:00
|
|
|
use crate::ty::TyCtxt;
|
2019-02-09 11:24:02 +09:00
|
|
|
use crate::hir::intravisit::{self, NestedVisitorMap, Visitor};
|
2018-07-23 01:20:33 +01:00
|
|
|
use syntax::symbol::Symbol;
|
|
|
|
use syntax::ast::{Attribute, MetaItem, MetaItemKind};
|
2019-05-10 09:57:08 +10:00
|
|
|
use syntax_pos::{Span, sym};
|
2018-07-23 01:20:33 +01:00
|
|
|
use rustc_data_structures::fx::{FxHashSet, FxHashMap};
|
2018-12-03 01:14:35 +01:00
|
|
|
use rustc_macros::HashStable;
|
2019-02-08 00:56:05 +09:00
|
|
|
use errors::DiagnosticId;
|
2018-07-23 01:20:33 +01:00
|
|
|
|
2018-12-03 01:14:35 +01:00
|
|
|
#[derive(HashStable)]
|
2018-07-23 01:20:33 +01:00
|
|
|
pub struct LibFeatures {
|
|
|
|
// A map from feature to stabilisation version.
|
|
|
|
pub stable: FxHashMap<Symbol, Symbol>,
|
|
|
|
pub unstable: FxHashSet<Symbol>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl LibFeatures {
|
|
|
|
fn new() -> LibFeatures {
|
|
|
|
LibFeatures {
|
2018-10-16 16:57:53 +02:00
|
|
|
stable: Default::default(),
|
|
|
|
unstable: Default::default(),
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-27 00:06:57 +01:00
|
|
|
pub fn to_vec(&self) -> Vec<(Symbol, Option<Symbol>)> {
|
|
|
|
let mut all_features: Vec<_> = self.stable.iter().map(|(f, s)| (*f, Some(*s)))
|
2018-07-23 01:20:33 +01:00
|
|
|
.chain(self.unstable.iter().map(|f| (*f, None)))
|
2018-07-27 00:06:57 +01:00
|
|
|
.collect();
|
|
|
|
all_features.sort_unstable_by_key(|f| f.0.as_str());
|
|
|
|
all_features
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-11 22:03:44 +03:00
|
|
|
pub struct LibFeatureCollector<'tcx> {
|
2019-06-14 00:48:52 +03:00
|
|
|
tcx: TyCtxt<'tcx>,
|
2018-07-23 01:20:33 +01:00
|
|
|
lib_features: LibFeatures,
|
|
|
|
}
|
|
|
|
|
2019-06-11 22:03:44 +03:00
|
|
|
impl LibFeatureCollector<'tcx> {
|
2019-06-14 00:48:52 +03:00
|
|
|
fn new(tcx: TyCtxt<'tcx>) -> LibFeatureCollector<'tcx> {
|
2018-07-23 01:20:33 +01:00
|
|
|
LibFeatureCollector {
|
|
|
|
tcx,
|
|
|
|
lib_features: LibFeatures::new(),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-15 17:34:56 +01:00
|
|
|
fn extract(&self, attr: &Attribute) -> Option<(Symbol, Option<Symbol>, Span)> {
|
2019-05-10 09:57:08 +10:00
|
|
|
let stab_attrs = [sym::stable, sym::unstable, sym::rustc_const_unstable];
|
2018-08-15 17:34:56 +01:00
|
|
|
|
2018-11-27 02:59:49 +00:00
|
|
|
// Find a stability attribute (i.e., `#[stable (..)]`, `#[unstable (..)]`,
|
2018-08-15 17:34:56 +01:00
|
|
|
// `#[rustc_const_unstable (..)]`).
|
|
|
|
if let Some(stab_attr) = stab_attrs.iter().find(|stab_attr| {
|
2019-04-05 03:05:30 +02:00
|
|
|
attr.check_name(**stab_attr)
|
2018-08-15 17:34:56 +01:00
|
|
|
}) {
|
|
|
|
let meta_item = attr.meta();
|
|
|
|
if let Some(MetaItem { node: MetaItemKind::List(ref metas), .. }) = meta_item {
|
|
|
|
let mut feature = None;
|
|
|
|
let mut since = None;
|
|
|
|
for meta in metas {
|
|
|
|
if let Some(mi) = meta.meta_item() {
|
|
|
|
// Find the `feature = ".."` meta-item.
|
2019-05-08 14:33:06 +10:00
|
|
|
match (mi.name_or_empty(), mi.value_str()) {
|
|
|
|
(sym::feature, val) => feature = val,
|
|
|
|
(sym::since, val) => since = val,
|
2018-08-15 17:34:56 +01:00
|
|
|
_ => {}
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
}
|
2018-08-15 17:34:56 +01:00
|
|
|
}
|
|
|
|
if let Some(feature) = feature {
|
|
|
|
// This additional check for stability is to make sure we
|
|
|
|
// don't emit additional, irrelevant errors for malformed
|
|
|
|
// attributes.
|
2019-05-07 16:03:44 +10:00
|
|
|
if *stab_attr != sym::stable || since.is_some() {
|
2018-08-15 17:34:56 +01:00
|
|
|
return Some((feature, since, attr.span));
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
}
|
2018-08-15 17:34:56 +01:00
|
|
|
// We need to iterate over the other attributes, because
|
|
|
|
// `rustc_const_unstable` is not mutually exclusive with
|
|
|
|
// the other stability attributes, so we can't just `break`
|
|
|
|
// here.
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-15 17:34:56 +01:00
|
|
|
None
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
fn collect_feature(&mut self, feature: Symbol, since: Option<Symbol>, span: Span) {
|
|
|
|
let already_in_stable = self.lib_features.stable.contains_key(&feature);
|
|
|
|
let already_in_unstable = self.lib_features.unstable.contains(&feature);
|
|
|
|
|
|
|
|
match (since, already_in_stable, already_in_unstable) {
|
|
|
|
(Some(since), _, false) => {
|
2018-07-23 01:21:03 +01:00
|
|
|
if let Some(prev_since) = self.lib_features.stable.get(&feature) {
|
|
|
|
if *prev_since != since {
|
|
|
|
let msg = format!(
|
|
|
|
"feature `{}` is declared stable since {}, \
|
|
|
|
but was previously declared stable since {}",
|
|
|
|
feature,
|
|
|
|
since,
|
|
|
|
prev_since,
|
|
|
|
);
|
|
|
|
self.tcx.sess.struct_span_err_with_code(span, &msg,
|
|
|
|
DiagnosticId::Error("E0711".into())).emit();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-23 01:20:33 +01:00
|
|
|
self.lib_features.stable.insert(feature, since);
|
|
|
|
}
|
|
|
|
(None, false, _) => {
|
|
|
|
self.lib_features.unstable.insert(feature);
|
|
|
|
}
|
|
|
|
(Some(_), _, true) | (None, true, _) => {
|
|
|
|
let msg = format!(
|
|
|
|
"feature `{}` is declared {}, but was previously declared {}",
|
|
|
|
feature,
|
2018-10-02 18:29:48 +02:00
|
|
|
if since.is_some() { "stable" } else { "unstable" },
|
|
|
|
if since.is_none() { "stable" } else { "unstable" },
|
2018-07-23 01:20:33 +01:00
|
|
|
);
|
|
|
|
self.tcx.sess.struct_span_err_with_code(span, &msg,
|
|
|
|
DiagnosticId::Error("E0711".into())).emit();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-11 22:03:44 +03:00
|
|
|
impl Visitor<'tcx> for LibFeatureCollector<'tcx> {
|
2018-08-15 17:34:56 +01:00
|
|
|
fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
|
2018-12-04 13:45:36 +01:00
|
|
|
NestedVisitorMap::All(&self.tcx.hir())
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
|
2018-08-15 17:34:56 +01:00
|
|
|
fn visit_attribute(&mut self, attr: &'tcx Attribute) {
|
|
|
|
if let Some((feature, stable, span)) = self.extract(attr) {
|
|
|
|
self.collect_feature(feature, stable, span);
|
|
|
|
}
|
2018-07-23 01:20:33 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-21 23:49:03 +02:00
|
|
|
pub fn collect(tcx: TyCtxt<'_>) -> LibFeatures {
|
2018-07-23 01:20:33 +01:00
|
|
|
let mut collector = LibFeatureCollector::new(tcx);
|
2019-06-21 01:55:40 +03:00
|
|
|
let krate = tcx.hir().krate();
|
|
|
|
for attr in &krate.non_exported_macro_attrs {
|
|
|
|
collector.visit_attribute(attr);
|
|
|
|
}
|
|
|
|
intravisit::walk_crate(&mut collector, krate);
|
2018-07-23 01:20:33 +01:00
|
|
|
collector.lib_features
|
|
|
|
}
|