rust/tests/ui/malformed/issue-107423-unused-delim-only-one-no-pair.stderr

error: this file contains an unclosed delimiter
  --> $DIR/issue-107423-unused-delim-only-one-no-pair.rs:7:11
   |
LL | fn a(){{{
   |       --- ^
   |       |||
   |       ||unclosed delimiter
   |       |unclosed delimiter
   |       unclosed delimiter

error: aborting due to previous error
don't point at nonexisting code beyond EOF when warning about unused delims Previously we would show this: ``` warning: unnecessary braces around block return value --> /tmp/bad.rs:1:8 \| 1 \| fn a(){{{ \| ^ ^ \| = note: `#[warn(unused_braces)]` on by default help: remove these braces \| 1 - fn a(){{{ 1 + fn a(){{ \| ``` which is now hidden in this case. We would create a span spanning between the pair of redundant {}s but there is only EOF instead of the `}` so we would previously point at nothing. This would cause the debug assertion ice to trigger. I would have loved to just only point at the second delim and say "you can remove that" but I'm not sure how to do that without refactoring the entire diagnostic which seems tricky. :( But given that this does not seem to regress any other tests we have, I think this edge-casey enough be acceptable. Fixes https://github.com/rust-lang/rust/issues/107423 r? @compiler-errors 2023-02-04 06:27:53 -06:00			`error: this file contains an unclosed delimiter`
			`--> $DIR/issue-107423-unused-delim-only-one-no-pair.rs:7:11`
			`\|`
			`LL \| fn a(){{{`
			`\| --- ^`
			`\| \|\|\|`
			`\| \|\|unclosed delimiter`
			`\| \|unclosed delimiter`
			`\| unclosed delimiter`

remove duplicated diagnostic for unclosed delimiter 2023-02-28 01:56:34 -06:00			`error: aborting due to previous error`
don't point at nonexisting code beyond EOF when warning about unused delims Previously we would show this: ``` warning: unnecessary braces around block return value --> /tmp/bad.rs:1:8 \| 1 \| fn a(){{{ \| ^ ^ \| = note: `#[warn(unused_braces)]` on by default help: remove these braces \| 1 - fn a(){{{ 1 + fn a(){{ \| ``` which is now hidden in this case. We would create a span spanning between the pair of redundant {}s but there is only EOF instead of the `}` so we would previously point at nothing. This would cause the debug assertion ice to trigger. I would have loved to just only point at the second delim and say "you can remove that" but I'm not sure how to do that without refactoring the entire diagnostic which seems tricky. :( But given that this does not seem to regress any other tests we have, I think this edge-casey enough be acceptable. Fixes https://github.com/rust-lang/rust/issues/107423 r? @compiler-errors 2023-02-04 06:27:53 -06:00