rust/clippy_lints/src/methods/unwrap_or_else_default.rs

66 lines
2.1 KiB
Rust
Raw Normal View History

//! Lint for `some_result_or_option.unwrap_or_else(Default::default)`
use super::UNWRAP_OR_ELSE_DEFAULT;
2021-12-23 23:44:13 -06:00
use clippy_utils::{
diagnostics::span_lint_and_sugg, is_default_equivalent_ctor, is_diag_trait_item, is_trait_item,
source::snippet_with_applicability, ty::is_type_diagnostic_item,
};
2021-12-23 23:41:00 -06:00
use rustc_hir::ExprKind;
use rustc_errors::Applicability;
use rustc_hir as hir;
use rustc_lint::LateContext;
use rustc_span::sym;
pub(super) fn check<'tcx>(
cx: &LateContext<'tcx>,
expr: &'tcx hir::Expr<'_>,
recv: &'tcx hir::Expr<'_>,
u_arg: &'tcx hir::Expr<'_>,
) {
// something.unwrap_or_else(Default::default)
// ^^^^^^^^^- recv ^^^^^^^^^^^^^^^^- u_arg
// ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- expr
let recv_ty = cx.typeck_results().expr_ty(recv);
2021-10-02 18:51:01 -05:00
let is_option = is_type_diagnostic_item(cx, recv_ty, sym::Option);
let is_result = is_type_diagnostic_item(cx, recv_ty, sym::Result);
2021-12-23 23:41:00 -06:00
let is_default_eq = match &u_arg.kind {
ExprKind::Path(qpath) => {
if let Some(repl_def_id) = cx.qpath_res(qpath, u_arg.hir_id).opt_def_id() {
if is_diag_trait_item(cx, repl_def_id, sym::Default)
2021-12-23 23:44:13 -06:00
|| is_default_equivalent_ctor(cx, repl_def_id, qpath)
{
2021-12-23 23:41:00 -06:00
true
} else {
false
}
} else {
false
}
},
2021-12-23 23:44:13 -06:00
_ => false,
2021-12-23 23:41:00 -06:00
};
if_chain! {
if is_option || is_result;
2021-12-23 23:41:00 -06:00
if is_trait_item(cx, u_arg, sym::Default) || is_default_eq;
then {
let mut applicability = Applicability::MachineApplicable;
span_lint_and_sugg(
cx,
UNWRAP_OR_ELSE_DEFAULT,
expr.span,
"use of `.unwrap_or_else(..)` to construct default value",
"try",
format!(
"{}.unwrap_or_default()",
snippet_with_applicability(cx, recv.span, "..", &mut applicability)
),
applicability,
);
}
}
}