mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
a733082be9
rust/tests/ui/pattern/usefulness/issue-30240.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

32 lines
1.1 KiB
Plaintext
Raw Normal View History

Fix #78549 Before #78430, string literals worked because `specialize_constructor` didn't actually care too much which constructor was passed to it unless needed. Since then, string literals are special cased and a bit hacky. I did not anticipate patterns for the `&str` type other than string literals, hence this bug. This makes string literals less hacky.
2020-10-31 20:58:48 -05:00
error[E0004]: non-exhaustive patterns: `&_` not covered
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-30240.rs:2:11
Move some `compile-fail` tests to `ui`
2018-07-15 16:11:54 -05:00
|
Update tests
2019-03-09 06:03:44 -06:00
LL | match "world" {
Fix #78549 Before #78430, string literals worked because `specialize_constructor` didn't actually care too much which constructor was passed to it unless needed. Since then, string literals are special cased and a bit hacky. I did not anticipate patterns for the `&str` type other than string literals, hence this bug. This makes string literals less hacky.
2020-10-31 20:58:48 -05:00
| ^^^^^^^ pattern `&_` not covered
Point at enum definition when match patterns are not exhaustive ``` error[E0004]: non-exhaustive patterns: type `X` is non-empty --> file.rs:9:11 | 1 | / enum X { 2 | | A, | | - variant not covered 3 | | B, | | - variant not covered 4 | | C, | | - variant not covered 5 | | } | |_- `X` defined here ... 9 | match x { | ^ | = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms error[E0004]: non-exhaustive patterns: `B` and `C` not covered --> file.rs:11:11 | 1 | / enum X { 2 | | A, 3 | | B, 4 | | C, | | - not covered 5 | | } | |_- `X` defined here ... 11 | match x { | ^ patterns `C` not covered ``` When a match expression doesn't have patterns covering every variant, point at the enum's definition span. On a best effort basis, point at the variant(s) that are missing. This does not handle the case when the missing pattern is due to a field's enum variants: ``` enum E1 { A, B, C, } enum E2 { A(E1), B, } fn foo() { match E2::A(E1::A) { E2::A(E1::B) => {} E2::B => {} } //~^ ERROR `E2::A(E1::A)` and `E2::A(E1::C)` not handled } ``` Unify look between match with no arms and match with some missing patterns. Fix #37518.
2019-02-10 07:12:00 -06:00
|
non-exhastive diagnostic: add note re. scrutinee type
2020-03-27 00:44:30 -05:00
= note: the matched value is of type `&str`
Improve clarity of diagnostic message on non-exhaustive matches
2023-09-03 06:55:11 -05:00
= note: `&str` cannot be matched exhaustively, so a wildcard `_` is necessary
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
When finding a match expr with a single arm that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:14:17 -06:00
|
Perform match checking on THIR.
2023-02-27 11:43:39 -06:00
LL ~ "hello" => {},
When finding a match expr with a single arm that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:14:17 -06:00
LL + &_ => todo!()
|
Move some `compile-fail` tests to `ui`
2018-07-15 16:11:54 -05:00
Fix #78549 Before #78430, string literals worked because `specialize_constructor` didn't actually care too much which constructor was passed to it unless needed. Since then, string literals are special cased and a bit hacky. I did not anticipate patterns for the `&str` type other than string literals, hence this bug. This makes string literals less hacky.
2020-10-31 20:58:48 -05:00
error[E0004]: non-exhaustive patterns: `&_` not covered
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-30240.rs:6:11
Move some `compile-fail` tests to `ui`
2018-07-15 16:11:54 -05:00
|
Update tests
2019-03-09 06:03:44 -06:00
LL | match "world" {
Fix #78549 Before #78430, string literals worked because `specialize_constructor` didn't actually care too much which constructor was passed to it unless needed. Since then, string literals are special cased and a bit hacky. I did not anticipate patterns for the `&str` type other than string literals, hence this bug. This makes string literals less hacky.
2020-10-31 20:58:48 -05:00
| ^^^^^^^ pattern `&_` not covered
Point at enum definition when match patterns are not exhaustive ``` error[E0004]: non-exhaustive patterns: type `X` is non-empty --> file.rs:9:11 | 1 | / enum X { 2 | | A, | | - variant not covered 3 | | B, | | - variant not covered 4 | | C, | | - variant not covered 5 | | } | |_- `X` defined here ... 9 | match x { | ^ | = help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms error[E0004]: non-exhaustive patterns: `B` and `C` not covered --> file.rs:11:11 | 1 | / enum X { 2 | | A, 3 | | B, 4 | | C, | | - not covered 5 | | } | |_- `X` defined here ... 11 | match x { | ^ patterns `C` not covered ``` When a match expression doesn't have patterns covering every variant, point at the enum's definition span. On a best effort basis, point at the variant(s) that are missing. This does not handle the case when the missing pattern is due to a field's enum variants: ``` enum E1 { A, B, C, } enum E2 { A(E1), B, } fn foo() { match E2::A(E1::A) { E2::A(E1::B) => {} E2::B => {} } //~^ ERROR `E2::A(E1::A)` and `E2::A(E1::C)` not handled } ``` Unify look between match with no arms and match with some missing patterns. Fix #37518.
2019-02-10 07:12:00 -06:00
|
non-exhastive diagnostic: add note re. scrutinee type
2020-03-27 00:44:30 -05:00
= note: the matched value is of type `&str`
Improve clarity of diagnostic message on non-exhaustive matches
2023-09-03 06:55:11 -05:00
= note: `&str` cannot be matched exhaustively, so a wildcard `_` is necessary
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
|
Perform match checking on THIR.
2023-02-27 11:43:39 -06:00
LL ~ "hello" => {},
When finding a match expr with multiple arms that requires more, suggest it Given ```rust match Some(42) { Some(0) => {} Some(1) => {} } ``` suggest ```rust match Some(42) { Some(0) => {} Some(1) => {} None | Some(_) => todo!(), } ```
2021-12-15 20:28:09 -06:00
LL + &_ => todo!()
|
Move some `compile-fail` tests to `ui`
2018-07-15 16:11:54 -05:00
error: aborting due to 2 previous errors
For more information about this error, try `rustc --explain E0004`.
Reference in New Issue Copy Permalink