rust/tests/ui/lint/rfc-2457-non-ascii-idents/lint-confusable-idents.rs

#![deny(confusable_idents)]
#![allow(uncommon_codepoints, non_upper_case_globals)]

const ｓ: usize = 42;
const s_s: usize = 42;

fn main() {
    let s = "rust"; //~ ERROR found both
    let ｓ_ｓ = "rust2"; //~ ERROR found both
    not_affected();
}

fn not_affected() {
    let s1 = 1;
    let sl = 'l';
}
-												Implement `confusable_idents` lint.

											
										
										
											2020-04-24 20:38:31 -05:00
+								#![deny(confusable_idents)]
 								#![allow(uncommon_codepoints, non_upper_case_globals)]
-												Refactor non_ascii_idents lints, exclude ascii pair for confusable_idents lint.

											
										
										
											2020-05-09 20:10:15 -05:00
+								const ｓ: usize = 42;
-												Fix symbol ordering for confusable idents detection.

Confusable idents detection uses a type `BTreeMap<Symbol, Span>`. This is
highly dubious given that `Symbol` doesn't guarantee a meaningful order. (In
practice, it currently gives an order that mostly matches source code order.)

As a result, changes in `Symbol` representation make the
`lint-confusable-idents.rs` test fail, because this error message:

> identifier pair considered confusable between `ｓ` and `s`

is changed to this:

> identifier pair considered confusable between `s` and `ｓ`

and the corresponding span pointers get swapped erroneously, leading to
an incorrect "previous identifier" label.

This commit sorts the relevant symbols by span before doing the checking,
which ensures that the ident that appears first in the code will be mentioned
first in the message. The commit also extends the test slightly to be more
thorough.

											
										
										
											2020-08-05 02:29:13 -05:00
+								const s_s: usize = 42;
-												Implement `confusable_idents` lint.

											
										
										
											2020-04-24 20:38:31 -05:00
 								fn main() {
-												Reword confusable idents lint

Fix #76140.

											
										
										
											2023-08-04 11:46:08 -05:00
+								    let s = "rust"; //~ ERROR found both
 								    let ｓ_ｓ = "rust2"; //~ ERROR found both
-												Refactor non_ascii_idents lints, exclude ascii pair for confusable_idents lint.

											
										
										
											2020-05-09 20:10:15 -05:00
+								    not_affected();
 								}
 								fn not_affected() {
 								    let s1 = 1;
 								    let sl = 'l';
-												Implement `confusable_idents` lint.

											
										
										
											2020-04-24 20:38:31 -05:00
+								}