2018-07-28 10:34:52 -05:00
|
|
|
#![warn(clippy::write_literal)]
|
2022-10-06 02:44:38 -05:00
|
|
|
#![allow(clippy::uninlined_format_args, unused_must_use)]
|
2018-04-04 22:46:39 -05:00
|
|
|
|
|
|
|
use std::io::Write;
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let mut v = Vec::new();
|
|
|
|
|
2018-04-21 13:23:59 -05:00
|
|
|
// these should be fine
|
2022-01-27 08:12:45 -06:00
|
|
|
write!(v, "Hello");
|
|
|
|
writeln!(v, "Hello");
|
2018-04-04 22:46:39 -05:00
|
|
|
let world = "world";
|
2022-01-27 08:12:45 -06:00
|
|
|
writeln!(v, "Hello {}", world);
|
|
|
|
writeln!(v, "Hello {world}", world = world);
|
|
|
|
writeln!(v, "3 in hex is {:X}", 3);
|
|
|
|
writeln!(v, "2 + 1 = {:.4}", 3);
|
|
|
|
writeln!(v, "2 + 1 = {:5.4}", 3);
|
|
|
|
writeln!(v, "Debug test {:?}", "hello, world");
|
|
|
|
writeln!(v, "{0:8} {1:>8}", "hello", "world");
|
|
|
|
writeln!(v, "{1:8} {0:>8}", "hello", "world");
|
|
|
|
writeln!(v, "{foo:8} {bar:>8}", foo = "hello", bar = "world");
|
|
|
|
writeln!(v, "{bar:8} {foo:>8}", foo = "hello", bar = "world");
|
|
|
|
writeln!(v, "{number:>width$}", number = 1, width = 6);
|
|
|
|
writeln!(v, "{number:>0width$}", number = 1, width = 6);
|
|
|
|
writeln!(v, "{} of {:b} people know binary, the other half doesn't", 1, 2);
|
|
|
|
writeln!(v, "10 / 4 is {}", 2.5);
|
|
|
|
writeln!(v, "2 + 1 = {}", 3);
|
2022-09-21 12:02:37 -05:00
|
|
|
writeln!(v, "From expansion {}", stringify!(not a string literal));
|
2018-04-04 22:46:39 -05:00
|
|
|
|
2018-04-21 13:23:59 -05:00
|
|
|
// these should throw warnings
|
2022-01-27 08:12:45 -06:00
|
|
|
write!(v, "Hello {}", "world");
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
|
|
|
//~| NOTE: `-D clippy::write-literal` implied by `-D warnings`
|
2022-01-27 08:12:45 -06:00
|
|
|
writeln!(v, "Hello {} {}", world, "world");
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
2022-01-27 08:12:45 -06:00
|
|
|
writeln!(v, "Hello {}", "world");
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
2022-09-21 12:02:37 -05:00
|
|
|
writeln!(v, "{} {:.4}", "a literal", 5);
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
2018-04-04 22:46:39 -05:00
|
|
|
|
|
|
|
// positional args don't change the fact
|
|
|
|
// that we're using a literal -- this should
|
|
|
|
// throw a warning
|
2022-01-27 08:12:45 -06:00
|
|
|
writeln!(v, "{0} {1}", "hello", "world");
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
2022-01-27 08:12:45 -06:00
|
|
|
writeln!(v, "{1} {0}", "hello", "world");
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
2018-04-04 22:46:39 -05:00
|
|
|
|
|
|
|
// named args shouldn't change anything either
|
2022-01-27 08:12:45 -06:00
|
|
|
writeln!(v, "{foo} {bar}", foo = "hello", bar = "world");
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
2022-01-27 08:12:45 -06:00
|
|
|
writeln!(v, "{bar} {foo}", foo = "hello", bar = "world");
|
2023-08-24 14:32:12 -05:00
|
|
|
//~^ ERROR: literal with an empty format string
|
2023-10-06 10:35:45 -05:00
|
|
|
|
|
|
|
// #10128
|
|
|
|
writeln!(v, "{0} {1} {2}", "hello", 2, "world");
|
|
|
|
//~^ ERROR: literal with an empty format string
|
|
|
|
writeln!(v, "{2} {1} {0}", "hello", 2, "world");
|
|
|
|
//~^ ERROR: literal with an empty format string
|
|
|
|
writeln!(v, "{0} {1} {2}, {bar}", "hello", 2, 3, bar = 4);
|
|
|
|
//~^ ERROR: literal with an empty format string
|
|
|
|
writeln!(v, "{0} {1} {2}, {3} {4}", "hello", 2, 3, "world", 4);
|
|
|
|
//~^ ERROR: literal with an empty format string
|
2018-04-04 22:46:39 -05:00
|
|
|
}
|