mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
99e4127d85
rust/tests/ui/span/issue-24690.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

30 lines
886 B
Plaintext
Raw Normal View History

rustc: Rearchitect lints to be emitted more eagerly In preparation for incremental compilation this commit refactors the lint handling infrastructure in the compiler to be more "eager" and overall more incremental-friendly. Many passes of the compiler can emit lints at various points but before this commit all lints were buffered in a table to be emitted at the very end of compilation. This commit changes these lints to be emitted immediately during compilation using pre-calculated lint level-related data structures. Linting today is split into two phases, one set of "early" lints run on the `syntax::ast` and a "late" set of lints run on the HIR. This commit moves the "early" lints to running as late as possible in compilation, just before HIR lowering. This notably means that we're catching resolve-related lints just before HIR lowering. The early linting remains a pass very similar to how it was before, maintaining context of the current lint level as it walks the tree. Post-HIR, however, linting is structured as a method on the `TyCtxt` which transitively executes a query to calculate lint levels. Each request to lint on a `TyCtxt` will query the entire crate's 'lint level data structure' and then go from there about whether the lint should be emitted or not. The query depends on the entire HIR crate but should be very quick to calculate (just a quick walk of the HIR) and the red-green system should notice that the lint level data structure rarely changes, and should hopefully preserve incrementality. Overall this resulted in a pretty big change to the test suite now that lints are emitted much earlier in compilation (on-demand vs only at the end). This in turn necessitated the addition of many `#![allow(warnings)]` directives throughout the compile-fail test suite and a number of updates to the UI test suite.
2017-07-26 23:51:09 -05:00
warning: unused variable: `theOtherTwo`
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-24690.rs:13:9
deduplicate one-time diagnostics on lint ID as well as span and message Some lint-level attributes (like `bad-style`, or, more dramatically, `warnings`) can affect more than one lint; it seems fairer to point out the attribute once for each distinct lint affected. Also, a UI test is added. This remains in the matter of #24690.
2016-10-27 01:07:38 -05:00
|
Update tests
2019-03-09 06:03:44 -06:00
LL | let theOtherTwo = 2;
Reword unused variable warning
2020-03-23 03:02:46 -05:00
| ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_theOtherTwo`
deduplicate one-time diagnostics on lint ID as well as span and message Some lint-level attributes (like `bad-style`, or, more dramatically, `warnings`) can affect more than one lint; it seems fairer to point out the attribute once for each distinct lint affected. Also, a UI test is added. This remains in the matter of #24690.
2016-10-27 01:07:38 -05:00
|
Normalise notes with the/is
2020-01-22 17:57:38 -06:00
note: the lint level is defined here
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-24690.rs:8:9
deduplicate one-time diagnostics on lint ID as well as span and message Some lint-level attributes (like `bad-style`, or, more dramatically, `warnings`) can affect more than one lint; it seems fairer to point out the attribute once for each distinct lint affected. Also, a UI test is added. This remains in the matter of #24690.
2016-10-27 01:07:38 -05:00
|
Update UI tests
2018-02-22 18:42:32 -06:00
LL | #![warn(unused)]
rustc: Rearchitect lints to be emitted more eagerly In preparation for incremental compilation this commit refactors the lint handling infrastructure in the compiler to be more "eager" and overall more incremental-friendly. Many passes of the compiler can emit lints at various points but before this commit all lints were buffered in a table to be emitted at the very end of compilation. This commit changes these lints to be emitted immediately during compilation using pre-calculated lint level-related data structures. Linting today is split into two phases, one set of "early" lints run on the `syntax::ast` and a "late" set of lints run on the HIR. This commit moves the "early" lints to running as late as possible in compilation, just before HIR lowering. This notably means that we're catching resolve-related lints just before HIR lowering. The early linting remains a pass very similar to how it was before, maintaining context of the current lint level as it walks the tree. Post-HIR, however, linting is structured as a method on the `TyCtxt` which transitively executes a query to calculate lint levels. Each request to lint on a `TyCtxt` will query the entire crate's 'lint level data structure' and then go from there about whether the lint should be emitted or not. The query depends on the entire HIR crate but should be very quick to calculate (just a quick walk of the HIR) and the red-green system should notice that the lint level data structure rarely changes, and should hopefully preserve incrementality. Overall this resulted in a pretty big change to the test suite now that lints are emitted much earlier in compilation (on-demand vs only at the end). This in turn necessitated the addition of many `#![allow(warnings)]` directives throughout the compile-fail test suite and a number of updates to the UI test suite.
2017-07-26 23:51:09 -05:00
| ^^^^^^
normalize use of backticks in compiler messages for librustc/lint https://github.com/rust-lang/rust/issues/60532
2019-07-16 15:17:38 -05:00
= note: `#[warn(unused_variables)]` implied by `#[warn(unused)]`
deduplicate one-time diagnostics on lint ID as well as span and message Some lint-level attributes (like `bad-style`, or, more dramatically, `warnings`) can affect more than one lint; it seems fairer to point out the attribute once for each distinct lint affected. Also, a UI test is added. This remains in the matter of #24690.
2016-10-27 01:07:38 -05:00
improve non_snake_case diagnostics Use a structured suggestion and tighten the span to just the identifier.
2019-01-04 09:19:52 -06:00
warning: variable `theTwo` should have a snake case name
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-24690.rs:12:9
deduplicate one-time diagnostics on lint ID as well as span and message Some lint-level attributes (like `bad-style`, or, more dramatically, `warnings`) can affect more than one lint; it seems fairer to point out the attribute once for each distinct lint affected. Also, a UI test is added. This remains in the matter of #24690.
2016-10-27 01:07:38 -05:00
|
Update tests
2019-03-09 06:03:44 -06:00
LL | let theTwo = 2;
improve non_snake_case diagnostics Use a structured suggestion and tighten the span to just the identifier.
2019-01-04 09:19:52 -06:00
| ^^^^^^ help: convert the identifier to snake case: `the_two`
rustc: Rearchitect lints to be emitted more eagerly In preparation for incremental compilation this commit refactors the lint handling infrastructure in the compiler to be more "eager" and overall more incremental-friendly. Many passes of the compiler can emit lints at various points but before this commit all lints were buffered in a table to be emitted at the very end of compilation. This commit changes these lints to be emitted immediately during compilation using pre-calculated lint level-related data structures. Linting today is split into two phases, one set of "early" lints run on the `syntax::ast` and a "late" set of lints run on the HIR. This commit moves the "early" lints to running as late as possible in compilation, just before HIR lowering. This notably means that we're catching resolve-related lints just before HIR lowering. The early linting remains a pass very similar to how it was before, maintaining context of the current lint level as it walks the tree. Post-HIR, however, linting is structured as a method on the `TyCtxt` which transitively executes a query to calculate lint levels. Each request to lint on a `TyCtxt` will query the entire crate's 'lint level data structure' and then go from there about whether the lint should be emitted or not. The query depends on the entire HIR crate but should be very quick to calculate (just a quick walk of the HIR) and the red-green system should notice that the lint level data structure rarely changes, and should hopefully preserve incrementality. Overall this resulted in a pretty big change to the test suite now that lints are emitted much earlier in compilation (on-demand vs only at the end). This in turn necessitated the addition of many `#![allow(warnings)]` directives throughout the compile-fail test suite and a number of updates to the UI test suite.
2017-07-26 23:51:09 -05:00
|
normalize use of backticks in compiler messages for librustc/lint https://github.com/rust-lang/rust/issues/60532
2019-07-16 15:17:38 -05:00
= note: `#[warn(non_snake_case)]` on by default
deduplicate one-time diagnostics on lint ID as well as span and message Some lint-level attributes (like `bad-style`, or, more dramatically, `warnings`) can affect more than one lint; it seems fairer to point out the attribute once for each distinct lint affected. Also, a UI test is added. This remains in the matter of #24690.
2016-10-27 01:07:38 -05:00
improve non_snake_case diagnostics Use a structured suggestion and tighten the span to just the identifier.
2019-01-04 09:19:52 -06:00
warning: variable `theOtherTwo` should have a snake case name
Remove licenses
2018-12-25 09:56:47 -06:00
--> $DIR/issue-24690.rs:13:9
Fix test/ui/span/issue-24690.stderr The errors are now emitted in a different order (in order of source location rather than going back and forth) but otherwise everything's the same.
2017-01-06 17:51:16 -06:00
|
Update tests
2019-03-09 06:03:44 -06:00
LL | let theOtherTwo = 2;
improve non_snake_case diagnostics Use a structured suggestion and tighten the span to just the identifier.
2019-01-04 09:19:52 -06:00
| ^^^^^^^^^^^ help: convert the identifier to snake case: `the_other_two`
Fix test/ui/span/issue-24690.stderr The errors are now emitted in a different order (in order of source location rather than going back and forth) but otherwise everything's the same.
2017-01-06 17:51:16 -06:00
rustc: Add a warning count upon completion
2020-03-11 10:30:09 -05:00
warning: 3 warnings emitted
Reference in New Issue Copy Permalink