rust/tests/ui/manual_find_map.fixed

76 lines
1.7 KiB
Rust
Raw Normal View History

2021-01-14 16:36:36 -06:00
// run-rustfix
#![allow(dead_code)]
#![warn(clippy::manual_find_map)]
#![allow(clippy::redundant_closure)] // FIXME suggestion may have redundant closure
fn main() {
// is_some(), unwrap()
let _ = (0..).find_map(|a| to_opt(a));
// ref pattern, expect()
let _ = (0..).find_map(|a| to_opt(a));
// is_ok(), unwrap_or()
let _ = (0..).find_map(|a| to_res(a).ok());
}
fn no_lint() {
// no shared code
let _ = (0..).filter(|n| *n > 1).map(|n| n + 1);
// very close but different since filter() provides a reference
let _ = (0..).find(|n| to_opt(n).is_some()).map(|a| to_opt(a).unwrap());
// similar but different
let _ = (0..).find(|n| to_opt(n).is_some()).map(|n| to_res(n).unwrap());
let _ = (0..)
.find(|n| to_opt(n).map(|n| n + 1).is_some())
.map(|a| to_opt(a).unwrap());
}
fn to_opt<T>(_: T) -> Option<T> {
unimplemented!()
}
fn to_res<T>(_: T) -> Result<T, ()> {
unimplemented!()
}
struct OptionFoo {
field: Option<String>,
}
struct ResultFoo {
field: Result<String, ()>,
}
fn issue_8920() {
let vec = vec![OptionFoo {
field: Some(String::from("str")),
}];
let _ = vec.iter().find_map(|f| f.field.clone());
2022-06-04 02:55:33 -05:00
let mut vec = vec![ResultFoo {
field: Ok(String::from("str")),
}];
let _ = vec.iter().find_map(|f| f.field.clone().ok());
2022-06-04 02:55:33 -05:00
let _ = vec.iter().find_map(|f| f.field.as_ref().ok());
let _ = vec
.iter()
.find_map(|f| f.field.as_deref().ok());
let _ = vec
.iter_mut()
.find_map(|f| f.field.as_mut().ok());
let _ = vec
.iter_mut()
.find_map(|f| f.field.as_deref_mut().ok());
let _ = vec
.iter()
.find_map(|f| f.field.to_owned().ok());
}