2020-11-01 04:48:42 -06:00
|
|
|
//! Renderer for function calls.
|
|
|
|
|
2021-01-22 09:59:22 -06:00
|
|
|
use hir::{HasSource, HirDisplay, Type};
|
2021-01-20 11:38:12 -06:00
|
|
|
use ide_db::SymbolKind;
|
2021-03-06 18:56:07 -06:00
|
|
|
use itertools::Itertools;
|
2021-01-22 09:59:22 -06:00
|
|
|
use syntax::ast::Fn;
|
2020-11-01 03:35:04 -06:00
|
|
|
|
|
|
|
use crate::{
|
2021-03-12 17:06:17 -06:00
|
|
|
item::{CompletionItem, CompletionItemKind, CompletionKind, CompletionRelevance, ImportEdit},
|
2021-03-15 21:26:59 -05:00
|
|
|
render::{
|
|
|
|
builder_ext::Params, compute_exact_name_match, compute_exact_type_match, compute_ref_match,
|
|
|
|
RenderContext,
|
|
|
|
},
|
2020-11-01 03:35:04 -06:00
|
|
|
};
|
|
|
|
|
2020-11-03 01:33:13 -06:00
|
|
|
pub(crate) fn render_fn<'a>(
|
|
|
|
ctx: RenderContext<'a>,
|
2020-12-03 03:13:28 -06:00
|
|
|
import_to_add: Option<ImportEdit>,
|
2020-11-03 01:33:13 -06:00
|
|
|
local_name: Option<String>,
|
|
|
|
fn_: hir::Function,
|
2021-01-01 00:26:39 -06:00
|
|
|
) -> Option<CompletionItem> {
|
2020-11-27 10:00:03 -06:00
|
|
|
let _p = profile::span("render_fn");
|
2021-03-21 19:30:56 -05:00
|
|
|
Some(FunctionRender::new(ctx, local_name, fn_, false)?.render(import_to_add))
|
|
|
|
}
|
|
|
|
|
|
|
|
pub(crate) fn render_method<'a>(
|
|
|
|
ctx: RenderContext<'a>,
|
|
|
|
import_to_add: Option<ImportEdit>,
|
|
|
|
local_name: Option<String>,
|
|
|
|
fn_: hir::Function,
|
|
|
|
) -> Option<CompletionItem> {
|
|
|
|
let _p = profile::span("render_method");
|
|
|
|
Some(FunctionRender::new(ctx, local_name, fn_, true)?.render(import_to_add))
|
2020-11-03 01:33:13 -06:00
|
|
|
}
|
|
|
|
|
2020-11-01 03:35:04 -06:00
|
|
|
#[derive(Debug)]
|
2020-11-03 01:33:13 -06:00
|
|
|
struct FunctionRender<'a> {
|
2020-11-01 03:35:04 -06:00
|
|
|
ctx: RenderContext<'a>,
|
|
|
|
name: String,
|
2020-12-01 04:53:12 -06:00
|
|
|
func: hir::Function,
|
2020-11-01 03:35:04 -06:00
|
|
|
ast_node: Fn,
|
2021-03-21 19:30:56 -05:00
|
|
|
is_method: bool,
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
impl<'a> FunctionRender<'a> {
|
2020-11-03 01:33:13 -06:00
|
|
|
fn new(
|
2020-11-01 03:35:04 -06:00
|
|
|
ctx: RenderContext<'a>,
|
|
|
|
local_name: Option<String>,
|
|
|
|
fn_: hir::Function,
|
2021-03-21 19:30:56 -05:00
|
|
|
is_method: bool,
|
2021-01-01 00:26:39 -06:00
|
|
|
) -> Option<FunctionRender<'a>> {
|
2020-11-01 03:35:04 -06:00
|
|
|
let name = local_name.unwrap_or_else(|| fn_.name(ctx.db()).to_string());
|
2021-01-01 00:26:39 -06:00
|
|
|
let ast_node = fn_.source(ctx.db())?.value;
|
2020-11-01 03:35:04 -06:00
|
|
|
|
2021-03-21 19:30:56 -05:00
|
|
|
Some(FunctionRender { ctx, name, func: fn_, ast_node, is_method })
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
|
|
|
|
2020-12-03 03:13:28 -06:00
|
|
|
fn render(self, import_to_add: Option<ImportEdit>) -> CompletionItem {
|
2020-11-01 03:35:04 -06:00
|
|
|
let params = self.params();
|
2021-03-12 03:12:32 -06:00
|
|
|
let mut item = CompletionItem::new(
|
2021-03-11 09:46:41 -06:00
|
|
|
CompletionKind::Reference,
|
|
|
|
self.ctx.source_range(),
|
|
|
|
self.name.clone(),
|
|
|
|
);
|
2021-03-12 03:12:32 -06:00
|
|
|
item.kind(self.kind())
|
2020-12-01 04:53:12 -06:00
|
|
|
.set_documentation(self.ctx.docs(self.func))
|
2021-01-18 17:08:59 -06:00
|
|
|
.set_deprecated(
|
|
|
|
self.ctx.is_deprecated(self.func) || self.ctx.is_deprecated_assoc_item(self.func),
|
|
|
|
)
|
2020-11-01 03:35:04 -06:00
|
|
|
.detail(self.detail())
|
2021-03-15 21:26:59 -05:00
|
|
|
.add_call_parens(self.ctx.completion, self.name.clone(), params)
|
2021-03-11 09:46:41 -06:00
|
|
|
.add_import(import_to_add);
|
|
|
|
|
2021-03-15 21:26:59 -05:00
|
|
|
let ret_type = self.func.ret_type(self.ctx.db());
|
|
|
|
item.set_relevance(CompletionRelevance {
|
|
|
|
exact_type_match: compute_exact_type_match(self.ctx.completion, &ret_type),
|
|
|
|
exact_name_match: compute_exact_name_match(self.ctx.completion, self.name.clone()),
|
|
|
|
..CompletionRelevance::default()
|
|
|
|
});
|
2021-03-12 17:06:17 -06:00
|
|
|
|
2021-03-15 21:26:59 -05:00
|
|
|
if let Some(ref_match) = compute_ref_match(self.ctx.completion, &ret_type) {
|
2021-03-21 19:30:56 -05:00
|
|
|
// FIXME
|
|
|
|
// For now we don't properly calculate the edits for ref match
|
|
|
|
// completions on methods, so we've disabled them. See #8058.
|
|
|
|
if !self.is_method {
|
|
|
|
item.ref_match(ref_match);
|
|
|
|
}
|
2021-03-12 17:06:17 -06:00
|
|
|
}
|
|
|
|
|
2021-03-12 03:12:32 -06:00
|
|
|
item.build()
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
fn detail(&self) -> String {
|
2021-03-12 15:46:40 -06:00
|
|
|
let ret_ty = self.func.ret_type(self.ctx.db());
|
|
|
|
let ret = if ret_ty.is_unit() {
|
|
|
|
// Omit the return type if it is the unit type
|
|
|
|
String::new()
|
|
|
|
} else {
|
|
|
|
format!(" {}", self.ty_display())
|
|
|
|
};
|
|
|
|
|
|
|
|
format!("fn({}){}", self.params_display(), ret)
|
|
|
|
}
|
|
|
|
|
|
|
|
fn params_display(&self) -> String {
|
|
|
|
if let Some(self_param) = self.func.self_param(self.ctx.db()) {
|
2021-03-06 18:56:07 -06:00
|
|
|
let params = self
|
|
|
|
.func
|
|
|
|
.assoc_fn_params(self.ctx.db())
|
|
|
|
.into_iter()
|
|
|
|
.skip(1) // skip the self param because we are manually handling that
|
|
|
|
.map(|p| p.ty().display(self.ctx.db()).to_string());
|
|
|
|
|
|
|
|
std::iter::once(self_param.display(self.ctx.db()).to_owned()).chain(params).join(", ")
|
|
|
|
} else {
|
|
|
|
let params = self
|
|
|
|
.func
|
|
|
|
.assoc_fn_params(self.ctx.db())
|
|
|
|
.into_iter()
|
|
|
|
.map(|p| p.ty().display(self.ctx.db()).to_string())
|
|
|
|
.join(", ");
|
|
|
|
params
|
2021-03-12 15:46:40 -06:00
|
|
|
}
|
|
|
|
}
|
2021-03-06 18:56:07 -06:00
|
|
|
|
2021-03-12 15:46:40 -06:00
|
|
|
fn ty_display(&self) -> String {
|
2021-03-06 18:56:07 -06:00
|
|
|
let ret_ty = self.func.ret_type(self.ctx.db());
|
|
|
|
|
2021-03-12 15:46:40 -06:00
|
|
|
format!("-> {}", ret_ty.display(self.ctx.db()))
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
fn add_arg(&self, arg: &str, ty: &Type) -> String {
|
|
|
|
if let Some(derefed_ty) = ty.remove_ref() {
|
|
|
|
for (name, local) in self.ctx.completion.locals.iter() {
|
|
|
|
if name == arg && local.ty(self.ctx.db()) == derefed_ty {
|
2020-11-01 03:59:43 -06:00
|
|
|
let mutability = if ty.is_mutable_reference() { "&mut " } else { "&" };
|
|
|
|
return format!("{}{}", mutability, arg);
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
arg.to_string()
|
|
|
|
}
|
|
|
|
|
|
|
|
fn params(&self) -> Params {
|
2020-12-01 05:23:00 -06:00
|
|
|
let ast_params = match self.ast_node.param_list() {
|
|
|
|
Some(it) => it,
|
|
|
|
None => return Params::Named(Vec::new()),
|
|
|
|
};
|
|
|
|
|
|
|
|
let mut params_pats = Vec::new();
|
2020-12-01 04:53:12 -06:00
|
|
|
let params_ty = if self.ctx.completion.dot_receiver.is_some() {
|
|
|
|
self.func.method_params(self.ctx.db()).unwrap_or_default()
|
|
|
|
} else {
|
2020-12-01 05:23:00 -06:00
|
|
|
if let Some(s) = ast_params.self_param() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::hit!(parens_for_method_call_as_assoc_fn);
|
2020-12-01 05:23:00 -06:00
|
|
|
params_pats.push(Some(s.to_string()));
|
|
|
|
}
|
2020-12-01 04:53:12 -06:00
|
|
|
self.func.assoc_fn_params(self.ctx.db())
|
|
|
|
};
|
2020-12-01 05:23:00 -06:00
|
|
|
params_pats
|
|
|
|
.extend(ast_params.params().into_iter().map(|it| it.pat().map(|it| it.to_string())));
|
|
|
|
|
|
|
|
let params = params_pats
|
2020-11-01 03:35:04 -06:00
|
|
|
.into_iter()
|
|
|
|
.zip(params_ty)
|
2020-12-01 05:23:00 -06:00
|
|
|
.flat_map(|(pat, param_ty)| {
|
|
|
|
let pat = pat?;
|
2020-12-12 11:27:09 -06:00
|
|
|
let name = pat;
|
2020-12-01 05:23:00 -06:00
|
|
|
let arg = name.trim_start_matches("mut ").trim_start_matches('_');
|
|
|
|
Some(self.add_arg(arg, param_ty.ty()))
|
2020-11-01 03:35:04 -06:00
|
|
|
})
|
|
|
|
.collect();
|
|
|
|
Params::Named(params)
|
|
|
|
}
|
|
|
|
|
|
|
|
fn kind(&self) -> CompletionItemKind {
|
2020-12-01 04:53:12 -06:00
|
|
|
if self.func.self_param(self.ctx.db()).is_some() {
|
2020-11-01 03:35:04 -06:00
|
|
|
CompletionItemKind::Method
|
|
|
|
} else {
|
2021-01-20 11:38:12 -06:00
|
|
|
SymbolKind::Function.into()
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2020-11-01 04:36:30 -06:00
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use crate::{
|
2021-01-06 11:43:46 -06:00
|
|
|
test_utils::{check_edit, check_edit_with_config, TEST_CONFIG},
|
2020-11-01 04:36:30 -06:00
|
|
|
CompletionConfig,
|
|
|
|
};
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn inserts_parens_for_function_calls() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(inserts_parens_for_function_calls);
|
2020-11-01 04:36:30 -06:00
|
|
|
check_edit(
|
|
|
|
"no_args",
|
|
|
|
r#"
|
|
|
|
fn no_args() {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { no_$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn no_args() {}
|
|
|
|
fn main() { no_args()$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_edit(
|
|
|
|
"with_args",
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { with_$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
|
|
|
fn main() { with_args(${1:x}, ${2:y})$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn bar(s: &S) { s.f$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
|
|
|
fn bar(s: &S) { s.foo()$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
struct S {}
|
|
|
|
impl S {
|
|
|
|
fn foo(&self, x: i32) {}
|
|
|
|
}
|
|
|
|
fn bar(s: &S) {
|
2021-01-06 14:15:48 -06:00
|
|
|
s.f$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S {}
|
|
|
|
impl S {
|
|
|
|
fn foo(&self, x: i32) {}
|
|
|
|
}
|
|
|
|
fn bar(s: &S) {
|
|
|
|
s.foo(${1:x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2020-12-01 05:23:00 -06:00
|
|
|
#[test]
|
|
|
|
fn parens_for_method_call_as_assoc_fn() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(parens_for_method_call_as_assoc_fn);
|
2020-12-01 05:23:00 -06:00
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { S::f$0 }
|
2020-12-01 05:23:00 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
|
|
|
fn main() { S::foo(${1:&self})$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2020-11-01 04:36:30 -06:00
|
|
|
#[test]
|
|
|
|
fn suppress_arg_snippets() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(suppress_arg_snippets);
|
2020-11-01 04:36:30 -06:00
|
|
|
check_edit_with_config(
|
2021-01-06 11:43:46 -06:00
|
|
|
CompletionConfig { add_call_argument_snippets: false, ..TEST_CONFIG },
|
2020-11-01 04:36:30 -06:00
|
|
|
"with_args",
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { with_$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
|
|
|
fn main() { with_args($0) }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn strips_underscores_from_args() {
|
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
fn foo(_foo: i32, ___bar: bool, ho_ge_: String) {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { f$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn foo(_foo: i32, ___bar: bool, ho_ge_: String) {}
|
|
|
|
fn main() { foo(${1:foo}, ${2:bar}, ${3:ho_ge_})$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_ref_when_matching_local_in_scope() {
|
|
|
|
check_edit(
|
|
|
|
"ref_arg",
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
2021-01-06 14:15:48 -06:00
|
|
|
ref_ar$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
ref_arg(${1:&x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_mut_ref_when_matching_local_in_scope() {
|
|
|
|
check_edit(
|
|
|
|
"ref_arg",
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &mut Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
2021-01-06 14:15:48 -06:00
|
|
|
ref_ar$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &mut Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
ref_arg(${1:&mut x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_ref_when_matching_local_in_scope_for_method() {
|
|
|
|
check_edit(
|
|
|
|
"apply_foo",
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
struct Bar {}
|
|
|
|
impl Bar {
|
|
|
|
fn apply_foo(&self, x: &Foo) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
let y = Bar {};
|
2021-01-06 14:15:48 -06:00
|
|
|
y.$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
struct Bar {}
|
|
|
|
impl Bar {
|
|
|
|
fn apply_foo(&self, x: &Foo) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
let y = Bar {};
|
|
|
|
y.apply_foo(${1:&x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn trim_mut_keyword_in_func_completion() {
|
|
|
|
check_edit(
|
|
|
|
"take_mutably",
|
|
|
|
r#"
|
|
|
|
fn take_mutably(mut x: &i32) {}
|
|
|
|
|
|
|
|
fn main() {
|
2021-01-06 14:15:48 -06:00
|
|
|
take_m$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn take_mutably(mut x: &i32) {}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
take_mutably(${1:x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|