rust/clippy_lints/src/needless_pass_by_value.rs

449 lines
17 KiB
Rust
Raw Normal View History

2018-05-30 03:15:50 -05:00
use crate::utils::ptr::get_spans;
2018-11-27 14:14:15 -06:00
use crate::utils::{
2019-08-19 11:30:32 -05:00
get_trait_def_id, implements_trait, is_copy, is_self, match_type, multispan_sugg, paths, snippet, snippet_opt,
span_lint_and_then,
2018-11-27 14:14:15 -06:00
};
use if_chain::if_chain;
use matches::matches;
use rustc::hir::intravisit::FnKind;
use rustc::hir::*;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
use rustc::middle::expr_use_visitor as euv;
use rustc::middle::mem_categorization as mc;
use rustc::traits;
use rustc::ty::{self, RegionKind, TypeFoldable};
2019-04-08 15:43:55 -05:00
use rustc::{declare_lint_pass, declare_tool_lint};
use rustc_data_structures::fx::{FxHashMap, FxHashSet};
use rustc_errors::Applicability;
use rustc_target::spec::abi::Abi;
2017-10-08 03:51:44 -05:00
use std::borrow::Cow;
use syntax::ast::Attribute;
use syntax::errors::DiagnosticBuilder;
use syntax_pos::Span;
2017-02-18 02:00:36 -06:00
2018-03-28 08:24:26 -05:00
declare_clippy_lint! {
/// **What it does:** Checks for functions taking arguments by value, but not
/// consuming them in its
/// body.
///
/// **Why is this bad?** Taking arguments by reference is more flexible and can
/// sometimes avoid
/// unnecessary allocations.
///
/// **Known problems:**
/// * This lint suggests taking an argument by reference,
/// however sometimes it is better to let users decide the argument type
/// (by using `Borrow` trait, for example), depending on how the function is used.
///
/// **Example:**
/// ```rust
/// fn foo(v: Vec<i32>) {
/// assert_eq!(v.len(), 42);
/// }
/// ```
///
/// ```rust
/// // should be
/// fn foo(v: &[i32]) {
/// assert_eq!(v.len(), 42);
/// }
/// ```
pub NEEDLESS_PASS_BY_VALUE,
pedantic,
"functions taking arguments by value, but not consuming them in its body"
2017-02-18 02:00:36 -06:00
}
2019-04-08 15:43:55 -05:00
declare_lint_pass!(NeedlessPassByValue => [NEEDLESS_PASS_BY_VALUE]);
2017-02-18 02:00:36 -06:00
2017-03-16 02:57:17 -05:00
macro_rules! need {
2018-11-27 14:14:15 -06:00
($e: expr) => {
if let Some(x) = $e {
x
} else {
return;
}
};
2017-03-16 02:57:17 -05:00
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
2019-01-13 09:19:02 -06:00
#[allow(clippy::too_many_lines)]
2017-02-18 02:00:36 -06:00
fn check_fn(
&mut self,
cx: &LateContext<'a, 'tcx>,
kind: FnKind<'tcx>,
decl: &'tcx FnDecl,
body: &'tcx Body,
span: Span,
2019-02-20 04:11:11 -06:00
hir_id: HirId,
2017-02-18 02:00:36 -06:00
) {
2019-08-19 11:30:32 -05:00
if span.from_expansion() {
2017-02-18 02:00:36 -06:00
return;
}
match kind {
FnKind::ItemFn(.., header, _, attrs) => {
if header.abi != Abi::Rust || requires_exact_signature(attrs) {
return;
}
},
FnKind::Method(..) => (),
_ => return,
2017-02-18 02:00:36 -06:00
}
// Exclude non-inherent impls
2019-06-25 16:41:10 -05:00
if let Some(Node::Item(item)) = cx.tcx.hir().find(cx.tcx.hir().get_parent_node(hir_id)) {
2018-07-16 08:07:39 -05:00
if matches!(item.node, ItemKind::Impl(_, _, _, _, Some(_), _, _) |
ItemKind::Trait(..))
{
return;
}
}
2017-10-08 04:04:45 -05:00
// Allow `Borrow` or functions to be taken by value
2019-05-17 16:53:54 -05:00
let borrow_trait = need!(get_trait_def_id(cx, &paths::BORROW_TRAIT));
let whitelisted_traits = [
2017-10-08 04:04:45 -05:00
need!(cx.tcx.lang_items().fn_trait()),
need!(cx.tcx.lang_items().fn_once_trait()),
need!(cx.tcx.lang_items().fn_mut_trait()),
2019-05-17 16:53:54 -05:00
need!(get_trait_def_id(cx, &paths::RANGE_ARGUMENT_TRAIT)),
2017-10-08 04:04:45 -05:00
];
let sized_trait = need!(cx.tcx.lang_items().sized_trait());
2017-02-18 02:00:36 -06:00
let fn_def_id = cx.tcx.hir().local_def_id(hir_id);
let preds = traits::elaborate_predicates(cx.tcx, cx.param_env.caller_bounds.to_vec())
.filter(|p| !p.is_global())
2017-11-04 14:55:56 -05:00
.filter_map(|pred| {
if let ty::Predicate::Trait(poly_trait_ref) = pred {
2018-11-27 14:14:15 -06:00
if poly_trait_ref.def_id() == sized_trait || poly_trait_ref.skip_binder().has_escaping_bound_vars()
{
2017-11-04 14:55:56 -05:00
return None;
}
Some(poly_trait_ref)
} else {
None
2017-10-08 06:17:04 -05:00
}
})
.collect::<Vec<_>>();
2017-08-09 02:30:56 -05:00
// Collect moved variables and spans which will need dereferencings from the
// function body.
let MovedVariablesCtxt {
moved_vars,
spans_need_deref,
..
} = {
2017-02-18 02:00:36 -06:00
let mut ctx = MovedVariablesCtxt::new(cx);
2017-09-04 09:10:36 -05:00
let region_scope_tree = &cx.tcx.region_scope_tree(fn_def_id);
2019-06-02 11:58:11 -05:00
euv::ExprUseVisitor::new(
&mut ctx,
cx.tcx,
fn_def_id,
cx.param_env,
region_scope_tree,
cx.tables,
None,
)
.consume_body(body);
ctx
2017-02-18 02:00:36 -06:00
};
let fn_sig = cx.tcx.fn_sig(fn_def_id);
let fn_sig = cx.tcx.erase_late_bound_regions(&fn_sig);
2017-02-18 02:00:36 -06:00
2018-11-27 14:14:15 -06:00
for (idx, ((input, &ty), arg)) in decl.inputs.iter().zip(fn_sig.inputs()).zip(&body.arguments).enumerate() {
// All spans generated from a proc-macro invocation are the same...
if span == input.span {
return;
}
// Ignore `self`s.
if idx == 0 {
if let PatKind::Binding(.., ident, _) = arg.pat.node {
2018-06-28 08:46:58 -05:00
if ident.as_str() == "self" {
continue;
}
}
}
2018-11-27 14:14:15 -06:00
//
// * Exclude a type that is specifically bounded by `Borrow`.
2019-01-30 19:15:29 -06:00
// * Exclude a type whose reference also fulfills its bound. (e.g., `std::convert::AsRef`,
2018-11-27 14:14:15 -06:00
// `serde::Serialize`)
let (implements_borrow_trait, all_borrowable_trait) = {
let preds = preds
.iter()
2017-10-08 06:17:04 -05:00
.filter(|t| t.skip_binder().self_ty() == ty)
.collect::<Vec<_>>();
(
preds.iter().any(|t| t.def_id() == borrow_trait),
2018-11-27 14:14:15 -06:00
!preds.is_empty()
&& preds.iter().all(|t| {
let ty_params = &t
.skip_binder()
.trait_ref
.substs
.iter()
.skip(1)
.cloned()
.collect::<Vec<_>>();
implements_trait(cx, cx.tcx.mk_imm_ref(&RegionKind::ReEmpty, ty), t.def_id(), ty_params)
2018-11-27 14:14:15 -06:00
}),
)
};
if_chain! {
if !is_self(arg);
if !ty.is_mutable_ptr();
if !is_copy(cx, ty);
if !whitelisted_traits.iter().any(|&t| implements_trait(cx, ty, t, &[]));
if !implements_borrow_trait;
if !all_borrowable_trait;
2019-03-07 14:51:05 -06:00
if let PatKind::Binding(mode, canonical_id, ..) = arg.pat.node;
if !moved_vars.contains(&canonical_id);
then {
if mode == BindingAnnotation::Mutable || mode == BindingAnnotation::RefMut {
continue;
}
// Dereference suggestion
2018-07-23 06:01:12 -05:00
let sugg = |db: &mut DiagnosticBuilder<'_>| {
2018-12-04 16:19:42 -06:00
if let ty::Adt(def, ..) = ty.sty {
if let Some(span) = cx.tcx.hir().span_if_local(def.did) {
if cx.param_env.can_type_implement_copy(cx.tcx, ty).is_ok() {
db.span_help(span, "consider marking this type as Copy");
}
}
}
let deref_span = spans_need_deref.get(&canonical_id);
if_chain! {
2019-05-17 16:53:54 -05:00
if match_type(cx, ty, &paths::VEC);
if let Some(clone_spans) =
2019-05-17 16:53:54 -05:00
get_spans(cx, Some(body.id()), idx, &[("clone", ".to_owned()")]);
2018-07-12 03:03:06 -05:00
if let TyKind::Path(QPath::Resolved(_, ref path)) = input.node;
if let Some(elem_ty) = path.segments.iter()
2019-05-17 16:53:54 -05:00
.find(|seg| seg.ident.name == sym!(Vec))
.and_then(|ps| ps.args.as_ref())
.map(|params| params.args.iter().find_map(|arg| match arg {
GenericArg::Type(ty) => Some(ty),
_ => None,
}).unwrap());
then {
let slice_ty = format!("&[{}]", snippet(cx, elem_ty.span, "_"));
db.span_suggestion(
2018-09-18 10:07:54 -05:00
input.span,
"consider changing the type to",
slice_ty,
Applicability::Unspecified,
);
for (span, suggestion) in clone_spans {
db.span_suggestion(
span,
&snippet_opt(cx, span)
.map_or(
"change the call to".into(),
|x| Cow::from(format!("change `{}` to", x)),
),
suggestion.into(),
Applicability::Unspecified,
);
}
// cannot be destructured, no need for `*` suggestion
assert!(deref_span.is_none());
return;
}
2017-10-08 03:51:44 -05:00
}
2019-05-17 16:53:54 -05:00
if match_type(cx, ty, &paths::STRING) {
if let Some(clone_spans) =
2019-05-17 16:53:54 -05:00
get_spans(cx, Some(body.id()), idx, &[("clone", ".to_string()"), ("as_str", "")]) {
db.span_suggestion(
2018-09-18 10:07:54 -05:00
input.span,
"consider changing the type to",
"&str".to_string(),
Applicability::Unspecified,
);
for (span, suggestion) in clone_spans {
db.span_suggestion(
span,
&snippet_opt(cx, span)
.map_or(
"change the call to".into(),
|x| Cow::from(format!("change `{}` to", x))
),
suggestion.into(),
Applicability::Unspecified,
);
}
assert!(deref_span.is_none());
return;
2017-10-08 03:51:44 -05:00
}
}
let mut spans = vec![(input.span, format!("&{}", snippet(cx, input.span, "_")))];
// Suggests adding `*` to dereference the added reference.
if let Some(deref_span) = deref_span {
spans.extend(
deref_span
.iter()
.cloned()
.map(|span| (span, format!("*{}", snippet(cx, span, "<expr>")))),
);
spans.sort_by_key(|&(span, _)| span);
}
multispan_sugg(db, "consider taking a reference instead".to_string(), spans);
};
span_lint_and_then(
cx,
NEEDLESS_PASS_BY_VALUE,
input.span,
"this argument is passed by value, but not consumed in the function body",
sugg,
);
}
}
2017-02-18 02:00:36 -06:00
}
}
}
/// Functions marked with these attributes must have the exact signature.
fn requires_exact_signature(attrs: &[Attribute]) -> bool {
attrs.iter().any(|attr| {
2019-05-17 16:53:54 -05:00
[sym!(proc_macro), sym!(proc_macro_attribute), sym!(proc_macro_derive)]
.iter()
2019-03-18 06:15:23 -05:00
.any(|&allow| attr.check_name(allow))
})
}
struct MovedVariablesCtxt<'a, 'tcx> {
2017-02-18 02:00:36 -06:00
cx: &'a LateContext<'a, 'tcx>,
2019-03-01 06:26:06 -06:00
moved_vars: FxHashSet<HirId>,
2017-08-09 02:30:56 -05:00
/// Spans which need to be prefixed with `*` for dereferencing the
/// suggested additional reference.
2019-03-01 06:26:06 -06:00
spans_need_deref: FxHashMap<HirId, FxHashSet<Span>>,
2017-02-18 02:00:36 -06:00
}
impl<'a, 'tcx> MovedVariablesCtxt<'a, 'tcx> {
2017-02-18 02:00:36 -06:00
fn new(cx: &'a LateContext<'a, 'tcx>) -> Self {
2017-08-21 06:32:12 -05:00
Self {
cx,
moved_vars: FxHashSet::default(),
spans_need_deref: FxHashMap::default(),
2017-02-18 02:00:36 -06:00
}
}
2019-02-24 12:43:15 -06:00
fn move_common(&mut self, _consume_id: HirId, _span: Span, cmt: &mc::cmt_<'tcx>) {
let cmt = unwrap_downcast_or_interior(cmt);
2017-09-12 07:26:40 -05:00
if let mc::Categorization::Local(vid) = cmt.cat {
self.moved_vars.insert(vid);
}
2017-02-18 02:00:36 -06:00
}
2017-02-20 03:18:31 -06:00
fn non_moving_pat(&mut self, matched_pat: &Pat, cmt: &mc::cmt_<'tcx>) {
2017-02-20 03:18:31 -06:00
let cmt = unwrap_downcast_or_interior(cmt);
if let mc::Categorization::Local(vid) = cmt.cat {
2019-03-01 06:26:06 -06:00
let mut id = matched_pat.hir_id;
2017-02-20 03:18:31 -06:00
loop {
let parent = self.cx.tcx.hir().get_parent_node(id);
2017-02-20 03:18:31 -06:00
if id == parent {
// no parent
return;
}
id = parent;
2019-06-25 16:34:07 -05:00
if let Some(node) = self.cx.tcx.hir().find(id) {
2017-02-20 03:18:31 -06:00
match node {
2018-08-28 06:13:42 -05:00
Node::Expr(e) => {
2017-02-20 03:18:31 -06:00
// `match` and `if let`
2018-07-12 02:30:57 -05:00
if let ExprKind::Match(ref c, ..) = e.node {
2017-02-20 03:18:31 -06:00
self.spans_need_deref
2017-09-12 07:26:40 -05:00
.entry(vid)
.or_insert_with(FxHashSet::default)
2017-02-20 03:18:31 -06:00
.insert(c.span);
}
},
2017-02-20 03:18:31 -06:00
2018-08-28 06:13:42 -05:00
Node::Stmt(s) => {
2017-02-20 03:18:31 -06:00
// `let <pat> = x;`
if_chain! {
if let StmtKind::Local(ref local) = s.node;
then {
self.spans_need_deref
.entry(vid)
.or_insert_with(FxHashSet::default)
.insert(local.init
.as_ref()
.map(|e| e.span)
.expect("`let` stmt without init aren't caught by match_pat"));
}
}
},
2017-02-20 03:18:31 -06:00
_ => {},
2017-02-20 03:18:31 -06:00
}
}
}
}
2017-02-20 03:18:31 -06:00
}
2017-02-18 02:00:36 -06:00
}
impl<'a, 'tcx> euv::Delegate<'tcx> for MovedVariablesCtxt<'a, 'tcx> {
2019-02-24 12:43:15 -06:00
fn consume(&mut self, consume_id: HirId, consume_span: Span, cmt: &mc::cmt_<'tcx>, mode: euv::ConsumeMode) {
if let euv::ConsumeMode::Move(_) = mode {
self.move_common(consume_id, consume_span, cmt);
}
2017-02-18 02:00:36 -06:00
}
fn matched_pat(&mut self, matched_pat: &Pat, cmt: &mc::cmt_<'tcx>, mode: euv::MatchMode) {
if let euv::MatchMode::MovingMatch = mode {
2019-02-24 12:43:15 -06:00
self.move_common(matched_pat.hir_id, matched_pat.span, cmt);
} else {
2017-02-20 03:18:31 -06:00
self.non_moving_pat(matched_pat, cmt);
}
}
2017-02-18 02:00:36 -06:00
fn consume_pat(&mut self, consume_pat: &Pat, cmt: &mc::cmt_<'tcx>, mode: euv::ConsumeMode) {
if let euv::ConsumeMode::Move(_) = mode {
2019-02-24 12:43:15 -06:00
self.move_common(consume_pat.hir_id, consume_pat.span, cmt);
}
2017-02-18 02:00:36 -06:00
}
2018-11-27 14:14:15 -06:00
fn borrow(
&mut self,
2019-02-24 12:43:15 -06:00
_: HirId,
2018-11-27 14:14:15 -06:00
_: Span,
_: &mc::cmt_<'tcx>,
_: ty::Region<'_>,
_: ty::BorrowKind,
_: euv::LoanCause,
) {
}
2017-02-18 02:00:36 -06:00
2019-02-24 12:43:15 -06:00
fn mutate(&mut self, _: HirId, _: Span, _: &mc::cmt_<'tcx>, _: euv::MutateMode) {}
2017-02-18 02:00:36 -06:00
2019-03-01 06:26:06 -06:00
fn decl_without_init(&mut self, _: HirId, _: Span) {}
2017-02-18 02:00:36 -06:00
}
fn unwrap_downcast_or_interior<'a, 'tcx>(mut cmt: &'a mc::cmt_<'tcx>) -> mc::cmt_<'tcx> {
loop {
match cmt.cat {
mc::Categorization::Downcast(ref c, _) | mc::Categorization::Interior(ref c, _) => {
cmt = c;
},
_ => return (*cmt).clone(),
}
2018-11-27 14:14:15 -06:00
}
}