mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
92f2d27d1b
rust/tests/ui/rfc-2008-non-exhaustive/uninhabited/match_with_exhaustive_patterns.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

84 lines
2.8 KiB
Plaintext
Raw Normal View History

pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error[E0004]: non-exhaustive patterns: type `UninhabitedEnum` is non-empty
[WIP] fix tests after rebase
2019-12-14 07:17:09 -06:00
--> $DIR/match_with_exhaustive_patterns.rs:22:11
Fix uninhabitedness of non-exhaustive enums. This commit ensures that non-exhaustive enums are considered inhabited when used in extern crates.
2019-05-04 05:03:06 -05:00
|
LL | match x {}
| ^
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `UninhabitedEnum` defined here
--> $DIR/auxiliary/uninhabited.rs:5:1
|
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
LL | pub enum UninhabitedEnum {
| ^^^^^^^^^^^^^^^^^^^^^^^^
Improve error message for non-exhaustive matches on non-exhaustive enums
2021-05-12 12:25:12 -05:00
= note: the matched value is of type `UninhabitedEnum`, which is marked as non-exhaustive
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern as shown
When encountering a match expr with no arms, suggest it Given ```rust match Some(42) {} ``` suggest ```rust match Some(42) { None | Some(_) => todo!(), } ```
2021-12-15 20:05:58 -06:00
|
LL ~ match x {
LL + _ => todo!(),
LL ~ }
|
Fix uninhabitedness of non-exhaustive enums. This commit ensures that non-exhaustive enums are considered inhabited when used in extern crates.
2019-05-04 05:03:06 -05:00
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error[E0004]: non-exhaustive patterns: type `UninhabitedStruct` is non-empty
[WIP] fix tests after rebase
2019-12-14 07:17:09 -06:00
--> $DIR/match_with_exhaustive_patterns.rs:26:11
Add a bunch more tests.
2019-05-04 06:07:04 -05:00
|
LL | match x {}
| ^
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `UninhabitedStruct` defined here
--> $DIR/auxiliary/uninhabited.rs:9:1
|
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
LL | pub struct UninhabitedStruct {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
= note: the matched value is of type `UninhabitedStruct`
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern as shown
When encountering a match expr with no arms, suggest it Given ```rust match Some(42) {} ``` suggest ```rust match Some(42) { None | Some(_) => todo!(), } ```
2021-12-15 20:05:58 -06:00
|
LL ~ match x {
LL + _ => todo!(),
LL ~ }
|
Add a bunch more tests.
2019-05-04 06:07:04 -05:00
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
error[E0004]: non-exhaustive patterns: type `UninhabitedTupleStruct` is non-empty
[WIP] fix tests after rebase
2019-12-14 07:17:09 -06:00
--> $DIR/match_with_exhaustive_patterns.rs:30:11
Add a bunch more tests.
2019-05-04 06:07:04 -05:00
|
LL | match x {}
| ^
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `UninhabitedTupleStruct` defined here
--> $DIR/auxiliary/uninhabited.rs:14:1
|
LL | pub struct UninhabitedTupleStruct(!);
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
= note: the matched value is of type `UninhabitedTupleStruct`
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern as shown
When encountering a match expr with no arms, suggest it Given ```rust match Some(42) {} ``` suggest ```rust match Some(42) { None | Some(_) => todo!(), } ```
2021-12-15 20:05:58 -06:00
|
LL ~ match x {
LL + _ => todo!(),
LL ~ }
|
Add a bunch more tests.
2019-05-04 06:07:04 -05:00
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
error[E0004]: non-exhaustive patterns: `UninhabitedVariants::Tuple(_)` and `UninhabitedVariants::Struct { .. }` not covered
[WIP] fix tests after rebase
2019-12-14 07:17:09 -06:00
--> $DIR/match_with_exhaustive_patterns.rs:34:11
Add a bunch more tests.
2019-05-04 06:07:04 -05:00
|
LL | match x {}
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
| ^ patterns `UninhabitedVariants::Tuple(_)` and `UninhabitedVariants::Struct { .. }` not covered
Remove trailing whitespace from error messages
2021-06-10 06:52:00 -05:00
|
Point at uncovered variants in enum definition in `note` instead of a `span_label` This makes the order of the output always consistent: 1. Place of the `match` missing arms 2. The `enum` definition span 3. The structured suggestion to add a fallthrough arm
2021-12-15 23:06:44 -06:00
note: `UninhabitedVariants` defined here
--> $DIR/auxiliary/uninhabited.rs:17:23
Add a bunch more tests.
2019-05-04 06:07:04 -05:00
|
Shorten def_span for more items.
2022-02-13 09:27:59 -06:00
LL | pub enum UninhabitedVariants {
| ----------------------------
LL | #[non_exhaustive] Tuple(!),
| ^^^^^ not covered
LL | #[non_exhaustive] Struct { x: ! }
| ^^^^^^ not covered
pretty: trim paths of unique symbols If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not.
2020-09-02 02:40:56 -05:00
= note: the matched value is of type `UninhabitedVariants`
Change wording of suggestion to add missing `match` arm
2021-12-16 16:46:13 -06:00
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern, a match arm with multiple or-patterns as shown, or multiple match arms
When encountering a match expr with no arms, suggest it Given ```rust match Some(42) {} ``` suggest ```rust match Some(42) { None | Some(_) => todo!(), } ```
2021-12-15 20:05:58 -06:00
|
LL ~ match x {
Include enum path in variant suggestion
2022-09-02 22:01:35 -05:00
LL + UninhabitedVariants::Tuple(_) | UninhabitedVariants::Struct { .. } => todo!(),
When encountering a match expr with no arms, suggest it Given ```rust match Some(42) {} ``` suggest ```rust match Some(42) { None | Some(_) => todo!(), } ```
2021-12-15 20:05:58 -06:00
LL ~ }
|
Add a bunch more tests.
2019-05-04 06:07:04 -05:00
error: aborting due to 4 previous errors
Fix uninhabitedness of non-exhaustive enums. This commit ensures that non-exhaustive enums are considered inhabited when used in extern crates.
2019-05-04 05:03:06 -05:00
For more information about this error, try `rustc --explain E0004`.
Reference in New Issue Copy Permalink