2017-02-07 14:05:30 -06:00
|
|
|
error: this if statement can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:6:5
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if x == "hello" {
|
|
|
|
LL | | if y == "world" {
|
|
|
|
LL | | println!("Hello world!");
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-08-01 09:30:44 -05:00
|
|
|
= note: `-D clippy::collapsible-if` implied by `-D warnings`
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | if x == "hello" && y == "world" {
|
|
|
|
LL | println!("Hello world!");
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:12:5
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if x == "hello" || x == "world" {
|
|
|
|
LL | | if y == "world" || y == "hello" {
|
|
|
|
LL | | println!("Hello world!");
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | if (x == "hello" || x == "world") && (y == "world" || y == "hello") {
|
|
|
|
LL | println!("Hello world!");
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:18:5
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if x == "hello" && x == "world" {
|
|
|
|
LL | | if y == "world" || y == "hello" {
|
|
|
|
LL | | println!("Hello world!");
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | if x == "hello" && x == "world" && (y == "world" || y == "hello") {
|
|
|
|
LL | println!("Hello world!");
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:24:5
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if x == "hello" || x == "world" {
|
|
|
|
LL | | if y == "world" && y == "hello" {
|
|
|
|
LL | | println!("Hello world!");
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | if (x == "hello" || x == "world") && y == "world" && y == "hello" {
|
|
|
|
LL | println!("Hello world!");
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:30:5
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if x == "hello" && x == "world" {
|
|
|
|
LL | | if y == "world" && y == "hello" {
|
|
|
|
LL | | println!("Hello world!");
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | if x == "hello" && x == "world" && y == "world" && y == "hello" {
|
|
|
|
LL | println!("Hello world!");
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:36:5
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | / if 42 == 1337 {
|
|
|
|
LL | | if 'a' != 'A' {
|
|
|
|
LL | | println!("world!")
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | if 42 == 1337 && 'a' != 'A' {
|
|
|
|
LL | println!("world!")
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:45:12
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else {
|
2017-04-23 08:25:22 -05:00
|
|
|
| ____________^
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | if y == "world" {
|
|
|
|
LL | | println!("world!")
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else if y == "world" {
|
|
|
|
LL | println!("world!")
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:53:12
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else {
|
2017-04-23 08:25:22 -05:00
|
|
|
| ____________^
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | if let Some(42) = Some(42) {
|
|
|
|
LL | | println!("world!")
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
|
|
LL | println!("world!")
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:61:12
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else {
|
2017-04-23 08:25:22 -05:00
|
|
|
| ____________^
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | if y == "world" {
|
|
|
|
LL | | println!("world")
|
|
|
|
LL | | }
|
2017-04-10 08:36:07 -05:00
|
|
|
... |
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-04-23 08:25:22 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else if y == "world" {
|
|
|
|
LL | println!("world")
|
|
|
|
LL | }
|
|
|
|
LL | else {
|
|
|
|
LL | println!("!")
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:72:12
|
2017-05-11 05:00:31 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else {
|
2017-05-11 05:00:31 -05:00
|
|
|
| ____________^
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | if let Some(42) = Some(42) {
|
|
|
|
LL | | println!("world")
|
|
|
|
LL | | }
|
2017-05-11 05:00:31 -05:00
|
|
|
... |
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2017-05-11 05:00:31 -05:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
|
|
LL | println!("world")
|
|
|
|
LL | }
|
|
|
|
LL | else {
|
|
|
|
LL | println!("!")
|
|
|
|
LL | }
|
2017-07-10 08:29:29 -05:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:83:12
|
2018-12-09 23:27:19 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else {
|
2018-12-09 23:27:19 -06:00
|
|
|
| ____________^
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | if let Some(42) = Some(42) {
|
|
|
|
LL | | println!("world")
|
|
|
|
LL | | }
|
2018-12-09 23:27:19 -06:00
|
|
|
... |
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | | }
|
|
|
|
LL | | }
|
2018-12-09 23:27:19 -06:00
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2018-12-09 23:27:19 -06:00
|
|
|
|
|
2018-12-27 09:57:55 -06:00
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
|
|
LL | println!("world")
|
|
|
|
LL | }
|
|
|
|
LL | else {
|
|
|
|
LL | println!("!")
|
|
|
|
LL | }
|
2018-12-09 23:27:19 -06:00
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:94:12
|
2018-12-27 09:57:55 -06:00
|
|
|
|
|
|
|
|
LL | } else {
|
|
|
|
| ____________^
|
|
|
|
LL | | if x == "hello" {
|
|
|
|
LL | | println!("world")
|
|
|
|
LL | | }
|
|
|
|
... |
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2018-12-27 09:57:55 -06:00
|
|
|
|
|
|
|
|
LL | } else if x == "hello" {
|
|
|
|
LL | println!("world")
|
|
|
|
LL | }
|
|
|
|
LL | else {
|
|
|
|
LL | println!("!")
|
|
|
|
LL | }
|
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:105:12
|
2018-12-27 09:57:55 -06:00
|
|
|
|
|
|
|
|
LL | } else {
|
|
|
|
| ____________^
|
|
|
|
LL | | if let Some(42) = Some(42) {
|
|
|
|
LL | | println!("world")
|
|
|
|
LL | | }
|
|
|
|
... |
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
|
|
|
| |_____^
|
2017-02-07 14:05:30 -06:00
|
|
|
help: try
|
2018-12-27 09:57:55 -06:00
|
|
|
|
|
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
|
|
LL | println!("world")
|
|
|
|
LL | }
|
|
|
|
LL | else {
|
|
|
|
LL | println!("!")
|
|
|
|
LL | }
|
|
|
|
|
|
2017-02-07 14:05:30 -06:00
|
|
|
|
2018-10-16 15:20:27 -05:00
|
|
|
error: this if statement can be collapsed
|
2019-01-07 15:33:18 -06:00
|
|
|
--> $DIR/collapsible_if.rs:164:5
|
2018-12-27 09:57:55 -06:00
|
|
|
|
|
|
|
|
LL | / if x == "hello" {
|
|
|
|
LL | | if y == "world" { // Collapsible
|
|
|
|
LL | | println!("Hello world!");
|
|
|
|
LL | | }
|
|
|
|
LL | | }
|
|
|
|
| |_____^
|
2018-10-16 15:20:27 -05:00
|
|
|
help: try
|
2018-12-27 09:57:55 -06:00
|
|
|
|
|
|
|
|
LL | if x == "hello" && y == "world" { // Collapsible
|
|
|
|
LL | println!("Hello world!");
|
|
|
|
LL | }
|
|
|
|
|
|
2018-10-16 15:20:27 -05:00
|
|
|
|
|
|
|
error: aborting due to 14 previous errors
|
2018-01-16 10:06:27 -06:00
|
|
|
|