rust/crates/ide_assists/src/handlers/merge_imports.rs

345 lines
6.4 KiB
Rust
Raw Normal View History

use ide_db::helpers::merge_imports::{try_merge_imports, try_merge_trees, MergeBehavior};
use syntax::{algo::neighbor, ast, ted, AstNode};
use crate::{
assist_context::{AssistContext, Assists},
utils::next_prev,
2020-06-28 17:36:05 -05:00
AssistId, AssistKind,
};
// Assist: merge_imports
//
// Merges two imports with a common prefix.
//
// ```
2021-01-06 14:15:48 -06:00
// use std::$0fmt::Formatter;
// use std::io;
// ```
// ->
// ```
// use std::{fmt::Formatter, io};
// ```
pub(crate) fn merge_imports(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
let tree: ast::UseTree = ctx.find_node_at_offset()?;
let mut imports = None;
let mut uses = None;
2020-07-30 07:12:04 -05:00
if let Some(use_item) = tree.syntax().parent().and_then(ast::Use::cast) {
let (merged, to_remove) =
2020-09-05 08:51:26 -05:00
next_prev().filter_map(|dir| neighbor(&use_item, dir)).find_map(|use_item2| {
try_merge_imports(&use_item, &use_item2, MergeBehavior::Crate).zip(Some(use_item2))
2020-03-19 06:18:59 -05:00
})?;
imports = Some((use_item, merged, to_remove));
2020-03-19 06:18:59 -05:00
} else {
let (merged, to_remove) =
2020-09-05 08:51:26 -05:00
next_prev().filter_map(|dir| neighbor(&tree, dir)).find_map(|use_tree| {
try_merge_trees(&tree, &use_tree, MergeBehavior::Crate).zip(Some(use_tree))
2020-09-05 08:51:26 -05:00
})?;
2020-03-19 06:18:59 -05:00
uses = Some((tree.clone(), merged, to_remove))
2020-03-19 06:18:59 -05:00
};
let target = tree.syntax().text_range();
2020-06-28 17:36:05 -05:00
acc.add(
2020-07-02 16:48:35 -05:00
AssistId("merge_imports", AssistKind::RefactorRewrite),
2020-06-28 17:36:05 -05:00
"Merge imports",
target,
|builder| {
if let Some((to_replace, replacement, to_remove)) = imports {
2021-05-16 06:18:49 -05:00
let to_replace = builder.make_mut(to_replace);
let to_remove = builder.make_mut(to_remove);
ted::replace(to_replace.syntax(), replacement.syntax());
to_remove.remove();
}
if let Some((to_replace, replacement, to_remove)) = uses {
2021-05-16 06:18:49 -05:00
let to_replace = builder.make_mut(to_replace);
let to_remove = builder.make_mut(to_remove);
ted::replace(to_replace.syntax(), replacement.syntax());
to_remove.remove()
}
2020-06-28 17:36:05 -05:00
},
)
}
#[cfg(test)]
mod tests {
use crate::tests::{check_assist, check_assist_not_applicable};
use super::*;
#[test]
fn test_merge_equal() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::fmt$0::{Display, Debug};
use std::fmt::{Display, Debug};
",
r"
use std::fmt::{Debug, Display};
",
)
}
#[test]
fn test_merge_first() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::fmt$0::Debug;
use std::fmt::Display;
",
r"
2020-05-20 16:14:31 -05:00
use std::fmt::{Debug, Display};
",
)
}
#[test]
fn test_merge_second() {
check_assist(
merge_imports,
r"
use std::fmt::Debug;
2021-01-06 14:15:48 -06:00
use std::fmt$0::Display;
",
r"
use std::fmt::{Debug, Display};
",
2020-03-19 06:18:59 -05:00
);
}
2020-08-12 11:49:43 -05:00
#[test]
fn merge_self1() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::fmt$0;
2020-08-12 11:49:43 -05:00
use std::fmt::Display;
",
r"
use std::fmt::{self, Display};
",
);
}
#[test]
fn merge_self2() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::{fmt, $0fmt::Display};
2020-08-12 11:49:43 -05:00
",
r"
use std::{fmt::{self, Display}};
2020-08-12 11:49:43 -05:00
",
);
}
2020-09-05 08:51:26 -05:00
#[test]
fn skip_pub1() {
check_assist_not_applicable(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
pub use std::fmt$0::Debug;
2020-09-05 08:51:26 -05:00
use std::fmt::Display;
",
);
}
#[test]
fn skip_pub_last() {
check_assist_not_applicable(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::fmt$0::Debug;
2020-09-05 08:51:26 -05:00
pub use std::fmt::Display;
",
);
}
#[test]
fn skip_pub_crate_pub() {
check_assist_not_applicable(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
pub(crate) use std::fmt$0::Debug;
pub use std::fmt::Display;
",
);
}
#[test]
fn skip_pub_pub_crate() {
check_assist_not_applicable(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
pub use std::fmt$0::Debug;
pub(crate) use std::fmt::Display;
",
);
}
#[test]
fn merge_pub() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
pub use std::fmt$0::Debug;
pub use std::fmt::Display;
",
r"
pub use std::fmt::{Debug, Display};
",
)
}
#[test]
fn merge_pub_crate() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
pub(crate) use std::fmt$0::Debug;
pub(crate) use std::fmt::Display;
",
r"
pub(crate) use std::fmt::{Debug, Display};
",
)
}
#[test]
fn test_merge_nested() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::{fmt$0::Debug, fmt::Display};
",
r"
2020-05-20 16:14:31 -05:00
use std::{fmt::{Debug, Display}};
",
2020-03-19 06:18:59 -05:00
);
}
#[test]
fn test_merge_nested2() {
2020-03-19 06:18:59 -05:00
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::{fmt::Debug, fmt$0::Display};
2020-03-19 06:18:59 -05:00
",
r"
use std::{fmt::{Debug, Display}};
2020-03-23 14:57:42 -05:00
",
);
}
#[test]
fn test_merge_single_wildcard_diff_prefixes() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std$0::cell::*;
use std::str;
",
r"
2020-05-20 16:14:31 -05:00
use std::{cell::*, str};
",
)
}
#[test]
fn test_merge_both_wildcard_diff_prefixes() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std$0::cell::*;
use std::str::*;
",
r"
2020-05-20 16:14:31 -05:00
use std::{cell::*, str::*};
",
)
}
2020-03-23 14:57:42 -05:00
#[test]
fn removes_just_enough_whitespace() {
check_assist(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use foo$0::bar;
2020-03-23 14:57:42 -05:00
use foo::baz;
/// Doc comment
",
r"
2020-05-20 16:14:31 -05:00
use foo::{bar, baz};
2020-03-23 14:57:42 -05:00
/// Doc comment
",
);
}
#[test]
fn works_with_trailing_comma() {
check_assist(
merge_imports,
r"
use {
2021-01-06 14:15:48 -06:00
foo$0::bar,
foo::baz,
};
",
r"
use {
2020-05-20 16:14:31 -05:00
foo::{bar, baz},
};
",
);
check_assist(
merge_imports,
r"
use {
foo::baz,
2021-01-06 14:15:48 -06:00
foo$0::bar,
};
",
r"
use {
2020-05-20 16:14:31 -05:00
foo::{bar, baz},
};
2020-03-19 06:18:59 -05:00
",
);
}
#[test]
fn test_double_comma() {
check_assist(
merge_imports,
r"
2020-04-12 20:34:01 -05:00
use foo::bar::baz;
2021-01-06 14:15:48 -06:00
use foo::$0{
2020-04-12 20:34:01 -05:00
FooBar,
};
",
r"
use foo::{FooBar, bar::baz};
",
)
}
#[test]
fn test_empty_use() {
check_assist_not_applicable(
merge_imports,
r"
2021-01-06 14:15:48 -06:00
use std::$0
fn main() {}",
);
}
}