rust/tests/ui/needless_bool/fixable.fixed

134 lines
2.4 KiB
Rust
Raw Normal View History

#![warn(clippy::needless_bool)]
#![allow(
unused,
dead_code,
clippy::no_effect,
clippy::if_same_then_else,
2021-10-04 01:33:40 -05:00
clippy::equatable_if_let,
2023-06-10 06:43:30 -05:00
clippy::needless_if,
2021-06-25 15:34:45 -05:00
clippy::needless_return,
clippy::self_named_constructors,
clippy::struct_field_names
)]
2018-10-11 05:16:22 -05:00
use std::cell::Cell;
2017-09-18 05:47:33 -05:00
macro_rules! bool_comparison_trigger {
($($i:ident: $def:expr, $stb:expr );+ $(;)*) => (
#[derive(Clone)]
pub struct Trigger {
$($i: (Cell<bool>, bool, bool)),+
}
#[allow(dead_code)]
impl Trigger {
pub fn trigger(&self, key: &str) -> bool {
$(
if let stringify!($i) = key {
return self.$i.1 && self.$i.2 == $def;
}
)+
false
}
}
)
}
2017-09-18 05:47:33 -05:00
fn main() {
let x = true;
2016-07-03 18:17:31 -05:00
let y = false;
x;
!x;
!(x && y);
2021-12-14 06:27:55 -06:00
let a = 0;
let b = 1;
a != b;
a == b;
a >= b;
a > b;
a <= b;
a < b;
2018-12-09 16:26:16 -06:00
if x {
x
} else {
false
}; // would also be questionable, but we don't catch this yet
bool_ret3(x);
bool_ret4(x);
bool_ret5(x, x);
2016-07-03 18:17:31 -05:00
bool_ret6(x, x);
needless_bool(x);
needless_bool2(x);
needless_bool3(x);
needless_bool_condition();
if a == b {
true
} else {
// Do not lint as this comment might be important
false
};
}
fn bool_ret3(x: bool) -> bool {
return x;
2016-07-03 18:17:31 -05:00
}
fn bool_ret4(x: bool) -> bool {
return !x;
}
fn bool_ret5(x: bool, y: bool) -> bool {
return x && y;
2016-07-03 18:17:31 -05:00
}
fn bool_ret6(x: bool, y: bool) -> bool {
return !(x && y);
}
fn needless_bool(x: bool) {
if x {};
}
fn needless_bool2(x: bool) {
if !x {};
}
fn needless_bool3(x: bool) {
bool_comparison_trigger! {
test_one: false, false;
test_three: false, false;
test_two: true, true;
}
2018-12-09 16:26:16 -06:00
if x {};
if !x {};
}
fn needless_bool_in_the_suggestion_wraps_the_predicate_of_if_else_statement_in_brackets() {
let b = false;
let returns_bool = || false;
let x = if b {
true
} else { !returns_bool() };
}
unsafe fn no(v: u8) -> u8 {
v
}
#[allow(clippy::unnecessary_operation)]
fn needless_bool_condition() -> bool {
(unsafe { no(4) } & 1 != 0);
let _brackets_unneeded = unsafe { no(4) } & 1 != 0;
fn foo() -> bool {
// parentheses are needed here
(unsafe { no(4) } & 1 != 0)
}
foo()
}