2021-02-27 14:29:19 -06:00
|
|
|
use crate::{
|
|
|
|
assist_context::{AssistContext, Assists},
|
2021-03-01 14:04:18 -06:00
|
|
|
AssistId,
|
2021-02-27 14:29:19 -06:00
|
|
|
};
|
2021-03-06 11:45:00 -06:00
|
|
|
use ide_db::helpers::FamousDefs;
|
2021-02-27 14:29:19 -06:00
|
|
|
use syntax::{
|
2021-03-01 14:04:18 -06:00
|
|
|
ast::{self, Impl, NameOwner},
|
|
|
|
AstNode,
|
2021-02-27 14:29:19 -06:00
|
|
|
};
|
2021-02-27 14:18:51 -06:00
|
|
|
|
|
|
|
// Assist: generate_default_from_new
|
|
|
|
//
|
2021-02-27 15:00:19 -06:00
|
|
|
// Generates default implementation from new method.
|
2021-02-27 14:18:51 -06:00
|
|
|
//
|
|
|
|
// ```
|
|
|
|
// struct Example { _inner: () }
|
|
|
|
//
|
|
|
|
// impl Example {
|
2021-02-27 15:00:19 -06:00
|
|
|
// pub fn n$0ew() -> Self {
|
2021-02-27 14:18:51 -06:00
|
|
|
// Self { _inner: () }
|
|
|
|
// }
|
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
// ->
|
|
|
|
// ```
|
|
|
|
// struct Example { _inner: () }
|
2021-02-27 15:00:19 -06:00
|
|
|
//
|
2021-02-27 14:18:51 -06:00
|
|
|
// impl Example {
|
|
|
|
// pub fn new() -> Self {
|
|
|
|
// Self { _inner: () }
|
|
|
|
// }
|
|
|
|
// }
|
2021-02-27 15:00:19 -06:00
|
|
|
//
|
2021-02-27 14:18:51 -06:00
|
|
|
// impl Default for Example {
|
|
|
|
// fn default() -> Self {
|
|
|
|
// Self::new()
|
|
|
|
// }
|
|
|
|
// }
|
|
|
|
// ```
|
|
|
|
pub(crate) fn generate_default_from_new(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
|
2021-03-01 13:19:19 -06:00
|
|
|
let fn_node = ctx.find_node_at_offset::<ast::Fn>()?;
|
|
|
|
let fn_name = fn_node.name()?;
|
2021-02-27 14:18:51 -06:00
|
|
|
|
2021-03-01 13:19:19 -06:00
|
|
|
if fn_name.text() != "new" {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::hit!(other_function_than_new);
|
2021-02-27 14:18:51 -06:00
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
2021-03-01 13:19:19 -06:00
|
|
|
if fn_node.param_list()?.params().next().is_some() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::hit!(new_function_with_parameters);
|
2021-02-27 14:18:51 -06:00
|
|
|
return None;
|
|
|
|
}
|
|
|
|
|
2021-03-01 13:19:19 -06:00
|
|
|
let impl_ = fn_node.syntax().ancestors().into_iter().find_map(ast::Impl::cast)?;
|
2021-03-06 13:21:48 -06:00
|
|
|
if is_default_implemented(ctx, &impl_) {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::hit!(default_block_is_already_present);
|
|
|
|
cov_mark::hit!(struct_in_module_with_default);
|
2021-03-04 12:26:18 -06:00
|
|
|
return None;
|
|
|
|
}
|
2021-02-27 14:18:51 -06:00
|
|
|
|
2021-03-01 13:19:19 -06:00
|
|
|
let insert_location = impl_.syntax().text_range();
|
2021-02-27 14:18:51 -06:00
|
|
|
|
|
|
|
acc.add(
|
|
|
|
AssistId("generate_default_from_new", crate::AssistKind::Generate),
|
|
|
|
"Generate a Default impl from a new fn",
|
2021-03-01 13:19:19 -06:00
|
|
|
insert_location,
|
2021-02-27 14:18:51 -06:00
|
|
|
move |builder| {
|
2021-03-01 14:04:18 -06:00
|
|
|
let code = default_fn_node_for_new(impl_);
|
|
|
|
builder.insert(insert_location.end(), code);
|
2021-02-27 14:18:51 -06:00
|
|
|
},
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
2021-03-01 14:04:18 -06:00
|
|
|
fn default_fn_node_for_new(impl_: Impl) -> String {
|
|
|
|
format!(
|
|
|
|
"
|
|
|
|
|
|
|
|
impl Default for {} {{
|
|
|
|
fn default() -> Self {{
|
2021-02-27 14:18:51 -06:00
|
|
|
Self::new()
|
2021-03-01 14:04:18 -06:00
|
|
|
}}
|
|
|
|
}}",
|
|
|
|
impl_.self_ty().unwrap().syntax().text()
|
|
|
|
)
|
2021-02-27 14:18:51 -06:00
|
|
|
}
|
|
|
|
|
2021-03-06 13:21:48 -06:00
|
|
|
fn is_default_implemented(ctx: &AssistContext, impl_: &Impl) -> bool {
|
2021-03-04 12:26:18 -06:00
|
|
|
let db = ctx.sema.db;
|
2021-03-06 13:21:48 -06:00
|
|
|
let impl_ = ctx.sema.to_def(impl_);
|
2021-03-06 13:56:05 -06:00
|
|
|
let impl_def = match impl_ {
|
|
|
|
Some(value) => value,
|
2021-03-06 13:21:48 -06:00
|
|
|
None => return false,
|
2021-03-06 13:56:05 -06:00
|
|
|
};
|
2021-03-06 13:21:48 -06:00
|
|
|
|
2021-03-29 10:46:33 -05:00
|
|
|
let ty = impl_def.self_ty(db);
|
2021-03-06 11:45:00 -06:00
|
|
|
let krate = impl_def.module(db).krate();
|
2021-03-06 13:21:48 -06:00
|
|
|
let default = FamousDefs(&ctx.sema, Some(krate)).core_default_Default();
|
2021-03-06 13:56:05 -06:00
|
|
|
let default_trait = match default {
|
|
|
|
Some(value) => value,
|
2021-03-06 13:21:48 -06:00
|
|
|
None => return false,
|
2021-03-06 13:56:05 -06:00
|
|
|
};
|
2021-03-06 13:21:48 -06:00
|
|
|
|
|
|
|
ty.impls_trait(db, default_trait, &[])
|
2021-03-04 12:26:18 -06:00
|
|
|
}
|
|
|
|
|
2021-02-27 14:18:51 -06:00
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
2021-03-06 11:45:00 -06:00
|
|
|
use ide_db::helpers::FamousDefs;
|
|
|
|
|
2021-02-27 14:18:51 -06:00
|
|
|
use crate::tests::{check_assist, check_assist_not_applicable};
|
|
|
|
|
|
|
|
use super::*;
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn generate_default() {
|
2021-03-06 11:45:00 -06:00
|
|
|
check_pass(
|
2021-02-27 14:18:51 -06:00
|
|
|
r#"
|
|
|
|
struct Example { _inner: () }
|
|
|
|
|
|
|
|
impl Example {
|
|
|
|
pub fn ne$0w() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Example { _inner: () }
|
|
|
|
|
|
|
|
impl Example {
|
|
|
|
pub fn new() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Example {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn generate_default2() {
|
2021-03-06 11:45:00 -06:00
|
|
|
check_pass(
|
2021-02-27 14:18:51 -06:00
|
|
|
r#"
|
|
|
|
struct Test { value: u32 }
|
|
|
|
|
|
|
|
impl Test {
|
|
|
|
pub fn ne$0w() -> Self {
|
|
|
|
Self { value: 0 }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Test { value: u32 }
|
|
|
|
|
|
|
|
impl Test {
|
|
|
|
pub fn new() -> Self {
|
|
|
|
Self { value: 0 }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Test {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn new_function_with_parameters() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(new_function_with_parameters);
|
2021-03-06 11:45:00 -06:00
|
|
|
check_not_applicable(
|
2021-02-27 14:29:19 -06:00
|
|
|
r#"
|
2021-02-27 14:18:51 -06:00
|
|
|
struct Example { _inner: () }
|
|
|
|
|
|
|
|
impl Example {
|
|
|
|
pub fn $0new(value: ()) -> Self {
|
|
|
|
Self { _inner: value }
|
|
|
|
}
|
|
|
|
}
|
2021-02-27 14:29:19 -06:00
|
|
|
"#,
|
2021-02-27 14:18:51 -06:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn other_function_than_new() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(other_function_than_new);
|
2021-03-06 11:45:00 -06:00
|
|
|
check_not_applicable(
|
2021-02-27 14:29:19 -06:00
|
|
|
r#"
|
2021-02-27 14:18:51 -06:00
|
|
|
struct Example { _inner: () }
|
|
|
|
|
2021-03-06 13:56:05 -06:00
|
|
|
impl Example {
|
2021-02-27 14:18:51 -06:00
|
|
|
pub fn a$0dd() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-02-27 14:29:19 -06:00
|
|
|
"#,
|
2021-02-27 14:18:51 -06:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2021-03-04 12:26:18 -06:00
|
|
|
#[test]
|
|
|
|
fn default_block_is_already_present() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(default_block_is_already_present);
|
2021-03-06 11:45:00 -06:00
|
|
|
check_not_applicable(
|
2021-03-04 12:26:18 -06:00
|
|
|
r#"
|
|
|
|
struct Example { _inner: () }
|
2021-02-27 14:29:19 -06:00
|
|
|
|
2021-03-06 13:21:48 -06:00
|
|
|
impl Example {
|
2021-03-04 12:26:18 -06:00
|
|
|
pub fn n$0ew() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
2021-02-27 14:29:19 -06:00
|
|
|
|
2021-03-04 12:26:18 -06:00
|
|
|
impl Default for Example {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
2021-02-27 14:18:51 -06:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn standalone_new_function() {
|
2021-03-06 11:45:00 -06:00
|
|
|
check_not_applicable(
|
2021-02-27 14:29:19 -06:00
|
|
|
r#"
|
2021-02-27 14:18:51 -06:00
|
|
|
fn n$0ew() -> u32 {
|
|
|
|
0
|
|
|
|
}
|
2021-03-01 13:19:19 -06:00
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn multiple_struct_blocks() {
|
2021-03-06 11:45:00 -06:00
|
|
|
check_pass(
|
2021-03-01 13:19:19 -06:00
|
|
|
r#"
|
|
|
|
struct Example { _inner: () }
|
|
|
|
struct Test { value: u32 }
|
|
|
|
|
|
|
|
impl Example {
|
2021-03-01 14:04:18 -06:00
|
|
|
pub fn new$0() -> Self {
|
2021-03-01 13:19:19 -06:00
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Example { _inner: () }
|
|
|
|
struct Test { value: u32 }
|
|
|
|
|
|
|
|
impl Example {
|
2021-03-01 14:04:18 -06:00
|
|
|
pub fn new() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Example {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn when_struct_is_after_impl() {
|
2021-03-06 11:45:00 -06:00
|
|
|
check_pass(
|
2021-03-01 14:04:18 -06:00
|
|
|
r#"
|
|
|
|
impl Example {
|
|
|
|
pub fn $0new() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
struct Example { _inner: () }
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
impl Example {
|
|
|
|
pub fn new() -> Self {
|
2021-03-01 13:19:19 -06:00
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Example {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
2021-03-01 14:04:18 -06:00
|
|
|
|
|
|
|
struct Example { _inner: () }
|
2021-03-04 12:26:18 -06:00
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn struct_in_module() {
|
2021-03-06 11:45:00 -06:00
|
|
|
check_pass(
|
2021-03-04 12:26:18 -06:00
|
|
|
r#"
|
|
|
|
mod test {
|
|
|
|
struct Example { _inner: () }
|
|
|
|
|
|
|
|
impl Example {
|
|
|
|
pub fn n$0ew() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
mod test {
|
|
|
|
struct Example { _inner: () }
|
|
|
|
|
|
|
|
impl Example {
|
|
|
|
pub fn new() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Example {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn struct_in_module_with_default() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(struct_in_module_with_default);
|
2021-03-06 11:45:00 -06:00
|
|
|
check_not_applicable(
|
2021-03-04 12:26:18 -06:00
|
|
|
r#"
|
|
|
|
mod test {
|
|
|
|
struct Example { _inner: () }
|
|
|
|
|
|
|
|
impl Example {
|
|
|
|
pub fn n$0ew() -> Self {
|
|
|
|
Self { _inner: () }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Example {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2021-02-27 14:29:19 -06:00
|
|
|
"#,
|
2021-02-27 14:18:51 -06:00
|
|
|
);
|
|
|
|
}
|
2021-03-06 11:45:00 -06:00
|
|
|
|
|
|
|
fn check_pass(before: &str, after: &str) {
|
|
|
|
let before = &format!("//- /main.rs crate:main deps:core{}{}", before, FamousDefs::FIXTURE);
|
|
|
|
check_assist(generate_default_from_new, before, after);
|
|
|
|
}
|
|
|
|
|
|
|
|
fn check_not_applicable(before: &str) {
|
|
|
|
let before = &format!("//- /main.rs crate:main deps:core{}{}", before, FamousDefs::FIXTURE);
|
|
|
|
check_assist_not_applicable(generate_default_from_new, before);
|
|
|
|
}
|
2021-02-27 14:18:51 -06:00
|
|
|
}
|