rust/clippy_lints/src/const_static_lifetime.rs

52 lines
1.7 KiB
Rust
Raw Normal View History

use crate::redundant_static_lifetime::RedundantStaticLifetime;
use crate::utils::in_macro_or_desugar;
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
2019-04-08 15:43:55 -05:00
use rustc::{declare_lint_pass, declare_tool_lint};
use syntax::ast::*;
2018-03-28 08:24:26 -05:00
declare_clippy_lint! {
/// **What it does:** Checks for constants with an explicit `'static` lifetime.
///
/// **Why is this bad?** Adding `'static` to every reference can create very
/// complicated types.
///
/// **Known problems:** None.
///
/// **Example:**
2019-03-05 16:23:50 -06:00
/// ```ignore
/// const FOO: &'static [(&'static str, &'static str, fn(&Bar) -> bool)] =
/// &[...]
/// ```
/// This code can be rewritten as
2019-03-05 16:23:50 -06:00
/// ```ignore
/// const FOO: &[(&str, &str, fn(&Bar) -> bool)] = &[...]
/// ```
2017-11-04 14:55:56 -05:00
pub CONST_STATIC_LIFETIME,
2018-03-28 08:24:26 -05:00
style,
"Using explicit `'static` lifetime for constants when elision rules would allow omitting them."
}
2019-04-08 15:43:55 -05:00
declare_lint_pass!(StaticConst => [CONST_STATIC_LIFETIME]);
impl StaticConst {
// Recursively visit types
2018-07-23 06:01:12 -05:00
fn visit_type(&mut self, ty: &Ty, cx: &EarlyContext<'_>) {
let mut rsl =
RedundantStaticLifetime::new(CONST_STATIC_LIFETIME, "Constants have by default a `'static` lifetime");
rsl.visit_type(ty, cx)
}
}
impl EarlyLintPass for StaticConst {
2018-07-23 06:01:12 -05:00
fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
2019-05-11 22:40:05 -05:00
if !in_macro_or_desugar(item.span) {
// Match only constants...
if let ItemKind::Const(ref var_type, _) = item.node {
self.visit_type(var_type, cx);
}
}
}
2018-02-02 01:03:21 -06:00
// Don't check associated consts because `'static` cannot be elided on those (issue #2438)
}