mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
81dc1e64d2
rust/tests/ui-fulldeps/internal-lints/diagnostics.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

75 lines
2.6 KiB
Plaintext
Raw Normal View History

lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:43:31
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
Rename `DiagnosticBuilder` as `Diag`. Much better! Note that this involves renaming (and updating the value of) `DIAGNOSTIC_BUILDER` in clippy.
2024-02-22 17:20:45 -06:00
LL | Diag::new(dcx, level, "untranslatable diagnostic")
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
note: the lint level is defined here
Disable `tests/ui-fulldeps/internal-lints/diagnostics.rs` on stage 1. When you make a change to the diagnostic lints, it uses the old version of the lints with stage 1 and the new version with stage 2, which often leads to failures in stage 1. Let's just stick to stage 2.
2024-03-04 18:54:37 -06:00
--> $DIR/diagnostics.rs:7:9
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
LL | #![deny(rustc::untranslatable_diagnostic)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:64:19
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
LL | diag.note("untranslatable diagnostic");
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
Rewrite the `untranslatable_diagnostic` lint. Currently it only checks calls to functions marked with `#[rustc_lint_diagnostics]`. This commit changes it to check calls to any function with an `impl Into<{D,Subd}iagMessage>` parameter. This greatly improves its coverage and doesn't rely on people remembering to add `#[rustc_lint_diagnostics]`. The commit also adds `#[allow(rustc::untranslatable_diagnostic)`] attributes to places that need it that are caught by the improved lint. These places that might be easy to convert to translatable diagnostics. Finally, it also: - Expands and corrects some comments. - Does some minor formatting improvements. - Adds missing `DecorateLint` cases to `tests/ui-fulldeps/internal-lints/diagnostics.rs`.
2024-02-19 21:12:50 -06:00
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:85:19
Rewrite the `untranslatable_diagnostic` lint. Currently it only checks calls to functions marked with `#[rustc_lint_diagnostics]`. This commit changes it to check calls to any function with an `impl Into<{D,Subd}iagMessage>` parameter. This greatly improves its coverage and doesn't rely on people remembering to add `#[rustc_lint_diagnostics]`. The commit also adds `#[allow(rustc::untranslatable_diagnostic)`] attributes to places that need it that are caught by the improved lint. These places that might be easy to convert to translatable diagnostics. Finally, it also: - Expands and corrects some comments. - Does some minor formatting improvements. - Adds missing `DecorateLint` cases to `tests/ui-fulldeps/internal-lints/diagnostics.rs`.
2024-02-19 21:12:50 -06:00
|
LL | diag.note("untranslatable diagnostic");
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Rewrite the `untranslatable_diagnostic` lint. Currently it only checks calls to functions marked with `#[rustc_lint_diagnostics]`. This commit changes it to check calls to any function with an `impl Into<{D,Subd}iagMessage>` parameter. This greatly improves its coverage and doesn't rely on people remembering to add `#[rustc_lint_diagnostics]`. The commit also adds `#[allow(rustc::untranslatable_diagnostic)`] attributes to places that need it that are caught by the improved lint. These places that might be easy to convert to translatable diagnostics. Finally, it also: - Expands and corrects some comments. - Does some minor formatting improvements. - Adds missing `DecorateLint` cases to `tests/ui-fulldeps/internal-lints/diagnostics.rs`.
2024-02-19 21:12:50 -06:00
Rename `DecorateLint` as `LintDiagnostic`. To match `derive(LintDiagnostic)`.
2024-03-07 19:03:51 -06:00
error: diagnostics should only be created in `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls
Remove `LintDiagnostic::msg` * instead simply set the primary message inside the lint decorator functions * it used to be this way before [#]101986 which introduced `msg` to prevent good path delayed bugs (which no longer exist) from firing under certain circumstances when lints were suppressed / silenced * this is no longer necessary for various reasons I presume * it shaves off complexity and makes further changes easier to implement
2024-05-22 09:46:05 -05:00
--> $DIR/diagnostics.rs:99:21
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
Fix up some `ui-fulldeps` tests.
2023-12-17 21:13:53 -06:00
LL | let _diag = dcx.struct_err(crate::fluent_generated::no_crate_example);
| ^^^^^^^^^^
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
note: the lint level is defined here
Disable `tests/ui-fulldeps/internal-lints/diagnostics.rs` on stage 1. When you make a change to the diagnostic lints, it uses the old version of the lints with stage 1 and the new version with stage 2, which often leads to failures in stage 1. Let's just stick to stage 2.
2024-03-04 18:54:37 -06:00
--> $DIR/diagnostics.rs:8:9
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
LL | #![deny(rustc::diagnostic_outside_of_impl)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Rename `DecorateLint` as `LintDiagnostic`. To match `derive(LintDiagnostic)`.
2024-03-07 19:03:51 -06:00
error: diagnostics should only be created in `Diagnostic`/`Subdiagnostic`/`LintDiagnostic` impls
Remove `LintDiagnostic::msg` * instead simply set the primary message inside the lint decorator functions * it used to be this way before [#]101986 which introduced `msg` to prevent good path delayed bugs (which no longer exist) from firing under certain circumstances when lints were suppressed / silenced * this is no longer necessary for various reasons I presume * it shaves off complexity and makes further changes easier to implement
2024-05-22 09:46:05 -05:00
--> $DIR/diagnostics.rs:102:21
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
Fix up some `ui-fulldeps` tests.
2023-12-17 21:13:53 -06:00
LL | let _diag = dcx.struct_err("untranslatable diagnostic");
| ^^^^^^^^^^
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:102:32
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
|
Fix up some `ui-fulldeps` tests.
2023-12-17 21:13:53 -06:00
LL | let _diag = dcx.struct_err("untranslatable diagnostic");
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:120:7
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
|
LL | f("untranslatable diagnostic", crate::fluent_generated::no_crate_example);
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:122:50
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
|
LL | f(crate::fluent_generated::no_crate_example, "untranslatable diagnostic");
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:124:7
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
|
LL | f("untranslatable diagnostic", "untranslatable diagnostic");
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
error: diagnostics should be created using translatable messages
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
--> $DIR/diagnostics.rs:124:36
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
|
LL | f("untranslatable diagnostic", "untranslatable diagnostic");
`untranslatable_diagnostic` lint: point at the untranslated thing and not the function/method call
2024-08-10 11:29:20 -05:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Add more test cases for untranslatable_diagnostic lint
2024-08-10 12:15:52 -05:00
error: aborting due to 10 previous errors
lint: add diagnostic translation migration lints Introduce allow-by-default lints for checking whether diagnostics are written in `SessionDiagnostic`/`AddSubdiagnostic` impls and whether diagnostics are translatable. These lints can be denied for modules once they are fully migrated to impls and translation. Signed-off-by: David Wood <david.wood@huawei.com>
2022-06-10 09:50:06 -05:00
Reference in New Issue Copy Permalink