2020-11-01 04:48:42 -06:00
|
|
|
//! Renderer for function calls.
|
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
use hir::{db::HirDatabase, AsAssocItem, HirDisplay};
|
2021-01-20 11:38:12 -06:00
|
|
|
use ide_db::SymbolKind;
|
2021-03-06 18:56:07 -06:00
|
|
|
use itertools::Itertools;
|
2021-11-24 09:01:33 -06:00
|
|
|
use stdx::format_to;
|
2020-11-01 03:35:04 -06:00
|
|
|
|
|
|
|
use crate::{
|
2021-12-21 07:51:06 -06:00
|
|
|
context::CompletionContext,
|
2021-10-27 10:18:42 -05:00
|
|
|
item::{CompletionItem, CompletionItemKind, CompletionRelevance, ImportEdit},
|
2021-03-15 21:26:59 -05:00
|
|
|
render::{
|
2021-03-22 23:18:34 -05:00
|
|
|
builder_ext::Params, compute_exact_name_match, compute_ref_match, compute_type_match,
|
2021-03-15 21:26:59 -05:00
|
|
|
RenderContext,
|
|
|
|
},
|
2020-11-01 03:35:04 -06:00
|
|
|
};
|
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
enum FuncType {
|
|
|
|
Function,
|
|
|
|
Method(Option<hir::Name>),
|
|
|
|
}
|
|
|
|
|
2021-07-21 12:50:28 -05:00
|
|
|
pub(crate) fn render_fn(
|
|
|
|
ctx: RenderContext<'_>,
|
2020-12-03 03:13:28 -06:00
|
|
|
import_to_add: Option<ImportEdit>,
|
2021-05-31 07:13:09 -05:00
|
|
|
local_name: Option<hir::Name>,
|
2021-12-21 07:51:06 -06:00
|
|
|
func: hir::Function,
|
|
|
|
) -> CompletionItem {
|
2020-11-27 10:00:03 -06:00
|
|
|
let _p = profile::span("render_fn");
|
2021-12-21 07:51:06 -06:00
|
|
|
render(ctx, local_name, func, FuncType::Function, import_to_add)
|
2021-03-21 19:30:56 -05:00
|
|
|
}
|
|
|
|
|
2021-07-21 12:50:28 -05:00
|
|
|
pub(crate) fn render_method(
|
|
|
|
ctx: RenderContext<'_>,
|
2021-03-21 19:30:56 -05:00
|
|
|
import_to_add: Option<ImportEdit>,
|
2021-05-28 07:38:09 -05:00
|
|
|
receiver: Option<hir::Name>,
|
2021-05-31 07:13:09 -05:00
|
|
|
local_name: Option<hir::Name>,
|
2021-12-21 07:51:06 -06:00
|
|
|
func: hir::Function,
|
|
|
|
) -> CompletionItem {
|
2021-03-21 19:30:56 -05:00
|
|
|
let _p = profile::span("render_method");
|
2021-12-21 07:51:06 -06:00
|
|
|
render(ctx, local_name, func, FuncType::Method(receiver), import_to_add)
|
2020-11-03 01:33:13 -06:00
|
|
|
}
|
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
fn render(
|
|
|
|
ctx @ RenderContext { completion }: RenderContext<'_>,
|
|
|
|
local_name: Option<hir::Name>,
|
2020-12-01 04:53:12 -06:00
|
|
|
func: hir::Function,
|
2021-12-21 07:51:06 -06:00
|
|
|
func_type: FuncType,
|
|
|
|
import_to_add: Option<ImportEdit>,
|
|
|
|
) -> CompletionItem {
|
|
|
|
let db = completion.db;
|
2020-11-01 03:35:04 -06:00
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
let name = local_name.unwrap_or_else(|| func.name(db));
|
|
|
|
let params = params(completion, func, &func_type);
|
2021-07-03 15:29:47 -05:00
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
// FIXME: SmolStr?
|
|
|
|
let call = match &func_type {
|
|
|
|
FuncType::Method(Some(receiver)) => format!("{}.{}", receiver, &name),
|
|
|
|
_ => name.to_string(),
|
|
|
|
};
|
|
|
|
let mut item = CompletionItem::new(
|
|
|
|
if func.self_param(db).is_some() {
|
|
|
|
CompletionItemKind::Method
|
|
|
|
} else {
|
|
|
|
CompletionItemKind::SymbolKind(SymbolKind::Function)
|
|
|
|
},
|
|
|
|
ctx.source_range(),
|
|
|
|
call.clone(),
|
|
|
|
);
|
|
|
|
item.set_documentation(ctx.docs(func))
|
|
|
|
.set_deprecated(ctx.is_deprecated(func) || ctx.is_deprecated_assoc_item(func))
|
|
|
|
.detail(detail(db, func))
|
|
|
|
.add_call_parens(completion, call.clone(), params);
|
|
|
|
|
|
|
|
if import_to_add.is_none() {
|
|
|
|
if let Some(actm) = func.as_assoc_item(db) {
|
|
|
|
if let Some(trt) = actm.containing_trait_or_trait_impl(db) {
|
|
|
|
item.trait_name(trt.name(db).to_smol_str());
|
2021-03-21 19:30:56 -05:00
|
|
|
}
|
2021-03-12 17:06:17 -06:00
|
|
|
}
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
if let Some(import_to_add) = import_to_add {
|
|
|
|
item.add_import(import_to_add);
|
|
|
|
}
|
|
|
|
item.lookup_by(name.to_smol_str());
|
|
|
|
|
|
|
|
let ret_type = func.ret_type(db);
|
|
|
|
item.set_relevance(CompletionRelevance {
|
|
|
|
type_match: compute_type_match(completion, &ret_type),
|
|
|
|
exact_name_match: compute_exact_name_match(completion, &call),
|
|
|
|
..CompletionRelevance::default()
|
|
|
|
});
|
|
|
|
|
|
|
|
if let Some(ref_match) = compute_ref_match(completion, &ret_type) {
|
|
|
|
// FIXME
|
|
|
|
// For now we don't properly calculate the edits for ref match
|
|
|
|
// completions on methods, so we've disabled them. See #8058.
|
|
|
|
if matches!(func_type, FuncType::Function) {
|
|
|
|
item.ref_match(ref_match);
|
2021-11-24 09:01:33 -06:00
|
|
|
}
|
2021-03-12 15:46:40 -06:00
|
|
|
}
|
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
item.build()
|
|
|
|
}
|
2021-03-06 18:56:07 -06:00
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
fn detail(db: &dyn HirDatabase, func: hir::Function) -> String {
|
|
|
|
let ret_ty = func.ret_type(db);
|
|
|
|
let mut detail = format!("fn({})", params_display(db, func));
|
|
|
|
if !ret_ty.is_unit() {
|
|
|
|
format_to!(detail, " -> {}", ret_ty.display(db));
|
2021-03-12 15:46:40 -06:00
|
|
|
}
|
2021-12-21 07:51:06 -06:00
|
|
|
detail
|
|
|
|
}
|
2021-03-06 18:56:07 -06:00
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
fn params_display(db: &dyn HirDatabase, func: hir::Function) -> String {
|
|
|
|
if let Some(self_param) = func.self_param(db) {
|
|
|
|
let assoc_fn_params = func.assoc_fn_params(db);
|
|
|
|
let params = assoc_fn_params
|
|
|
|
.iter()
|
|
|
|
.skip(1) // skip the self param because we are manually handling that
|
|
|
|
.map(|p| p.ty().display(db));
|
|
|
|
format!(
|
|
|
|
"{}{}",
|
|
|
|
self_param.display(db),
|
|
|
|
params.format_with("", |display, f| {
|
|
|
|
f(&", ")?;
|
|
|
|
f(&display)
|
|
|
|
})
|
|
|
|
)
|
|
|
|
} else {
|
|
|
|
let assoc_fn_params = func.assoc_fn_params(db);
|
|
|
|
assoc_fn_params.iter().map(|p| p.ty().display(db)).join(", ")
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
2021-12-21 07:51:06 -06:00
|
|
|
}
|
2020-11-01 03:35:04 -06:00
|
|
|
|
2021-12-21 07:51:06 -06:00
|
|
|
fn params(ctx: &CompletionContext<'_>, func: hir::Function, func_type: &FuncType) -> Params {
|
|
|
|
let (params, self_param) =
|
|
|
|
if ctx.has_dot_receiver() || matches!(func_type, FuncType::Method(Some(_))) {
|
|
|
|
(func.method_params(ctx.db).unwrap_or_default(), None)
|
2020-11-01 03:35:04 -06:00
|
|
|
} else {
|
2021-12-21 07:51:06 -06:00
|
|
|
let self_param = func.self_param(ctx.db);
|
|
|
|
|
|
|
|
let mut assoc_params = func.assoc_fn_params(ctx.db);
|
|
|
|
if self_param.is_some() {
|
|
|
|
assoc_params.remove(0);
|
|
|
|
}
|
|
|
|
(assoc_params, self_param)
|
|
|
|
};
|
|
|
|
|
|
|
|
Params::Named(self_param, params)
|
2020-11-01 03:35:04 -06:00
|
|
|
}
|
2020-11-01 04:36:30 -06:00
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use crate::{
|
2021-06-16 14:45:02 -05:00
|
|
|
tests::{check_edit, check_edit_with_config, TEST_CONFIG},
|
2020-11-01 04:36:30 -06:00
|
|
|
CompletionConfig,
|
|
|
|
};
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn inserts_parens_for_function_calls() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(inserts_parens_for_function_calls);
|
2020-11-01 04:36:30 -06:00
|
|
|
check_edit(
|
|
|
|
"no_args",
|
|
|
|
r#"
|
|
|
|
fn no_args() {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { no_$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn no_args() {}
|
|
|
|
fn main() { no_args()$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_edit(
|
|
|
|
"with_args",
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { with_$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
|
|
|
fn main() { with_args(${1:x}, ${2:y})$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn bar(s: &S) { s.f$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
|
|
|
fn bar(s: &S) { s.foo()$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
struct S {}
|
|
|
|
impl S {
|
|
|
|
fn foo(&self, x: i32) {}
|
|
|
|
}
|
|
|
|
fn bar(s: &S) {
|
2021-01-06 14:15:48 -06:00
|
|
|
s.f$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S {}
|
|
|
|
impl S {
|
|
|
|
fn foo(&self, x: i32) {}
|
|
|
|
}
|
|
|
|
fn bar(s: &S) {
|
|
|
|
s.foo(${1:x})$0
|
|
|
|
}
|
2021-05-28 07:02:53 -05:00
|
|
|
"#,
|
|
|
|
);
|
|
|
|
|
|
|
|
check_edit(
|
2021-06-11 11:26:52 -05:00
|
|
|
"foo",
|
2021-05-28 07:02:53 -05:00
|
|
|
r#"
|
|
|
|
struct S {}
|
|
|
|
impl S {
|
|
|
|
fn foo(&self, x: i32) {
|
|
|
|
$0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S {}
|
|
|
|
impl S {
|
|
|
|
fn foo(&self, x: i32) {
|
|
|
|
self.foo(${1:x})$0
|
|
|
|
}
|
|
|
|
}
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2020-12-01 05:23:00 -06:00
|
|
|
#[test]
|
|
|
|
fn parens_for_method_call_as_assoc_fn() {
|
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { S::f$0 }
|
2020-12-01 05:23:00 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct S;
|
|
|
|
impl S {
|
|
|
|
fn foo(&self) {}
|
|
|
|
}
|
|
|
|
fn main() { S::foo(${1:&self})$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2020-11-01 04:36:30 -06:00
|
|
|
#[test]
|
|
|
|
fn suppress_arg_snippets() {
|
2021-03-08 14:19:44 -06:00
|
|
|
cov_mark::check!(suppress_arg_snippets);
|
2020-11-01 04:36:30 -06:00
|
|
|
check_edit_with_config(
|
2021-01-06 11:43:46 -06:00
|
|
|
CompletionConfig { add_call_argument_snippets: false, ..TEST_CONFIG },
|
2020-11-01 04:36:30 -06:00
|
|
|
"with_args",
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { with_$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn with_args(x: i32, y: String) {}
|
|
|
|
fn main() { with_args($0) }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn strips_underscores_from_args() {
|
|
|
|
check_edit(
|
|
|
|
"foo",
|
|
|
|
r#"
|
|
|
|
fn foo(_foo: i32, ___bar: bool, ho_ge_: String) {}
|
2021-01-06 14:15:48 -06:00
|
|
|
fn main() { f$0 }
|
2020-11-01 04:36:30 -06:00
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn foo(_foo: i32, ___bar: bool, ho_ge_: String) {}
|
|
|
|
fn main() { foo(${1:foo}, ${2:bar}, ${3:ho_ge_})$0 }
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_ref_when_matching_local_in_scope() {
|
|
|
|
check_edit(
|
|
|
|
"ref_arg",
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
2021-01-06 14:15:48 -06:00
|
|
|
ref_ar$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
ref_arg(${1:&x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_mut_ref_when_matching_local_in_scope() {
|
|
|
|
check_edit(
|
|
|
|
"ref_arg",
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &mut Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
2021-01-06 14:15:48 -06:00
|
|
|
ref_ar$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
fn ref_arg(x: &mut Foo) {}
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
ref_arg(${1:&mut x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn insert_ref_when_matching_local_in_scope_for_method() {
|
|
|
|
check_edit(
|
|
|
|
"apply_foo",
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
struct Bar {}
|
|
|
|
impl Bar {
|
|
|
|
fn apply_foo(&self, x: &Foo) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
let y = Bar {};
|
2021-01-06 14:15:48 -06:00
|
|
|
y.$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
struct Foo {}
|
|
|
|
struct Bar {}
|
|
|
|
impl Bar {
|
|
|
|
fn apply_foo(&self, x: &Foo) {}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
let x = Foo {};
|
|
|
|
let y = Bar {};
|
|
|
|
y.apply_foo(${1:&x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn trim_mut_keyword_in_func_completion() {
|
|
|
|
check_edit(
|
|
|
|
"take_mutably",
|
|
|
|
r#"
|
|
|
|
fn take_mutably(mut x: &i32) {}
|
|
|
|
|
|
|
|
fn main() {
|
2021-01-06 14:15:48 -06:00
|
|
|
take_m$0
|
2020-11-01 04:36:30 -06:00
|
|
|
}
|
|
|
|
"#,
|
|
|
|
r#"
|
|
|
|
fn take_mutably(mut x: &i32) {}
|
|
|
|
|
|
|
|
fn main() {
|
|
|
|
take_mutably(${1:x})$0
|
|
|
|
}
|
|
|
|
"#,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|