mikros/rust
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
rust/tests/ui/invalid/invalid-plugin-attr.stderr

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

23 lines
700 B
Plaintext
Raw Normal View History

Plugins deprecation: don’t suggest simply removing the attribute Building Servo with a recent Nightly produces: ```rust warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597 --> components/script/lib.rs:14:1 | 14 | #![plugin(script_plugins)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute | = note: `#[warn(deprecated)]` on by default ``` First, linking to https://github.com/rust-lang/rust/issues/29597 is not ideal since there is pretty much no discussion there of the deprecation and what can be used instead. This PR changes the link to the deprecation PR which does have more discussion. Second, the “remove this attribute” suggestion is rather unhelpful. Just because a feature is deprecated doesn’t mean that simply removing its use without a replacement is acceptable. In the case of custom lint, there is no replacement available. Prefixing a message with “help:” when telling users that they’re screwed honestly feels disrespectful. This PR also changes the message to be more factual.
2019-10-17 13:51:46 +02:00
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675
plugin_registrary: use normal deprecation instead of hard coded warning.
2019-10-03 06:46:17 +02:00
--> $DIR/invalid-plugin-attr.rs:4:1
Deprecate `#![plugin]` and `#[plugin_registrar]`.
2019-09-22 01:32:51 +02:00
|
LL | #[plugin(bla)]
Plugins deprecation: don’t suggest simply removing the attribute Building Servo with a recent Nightly produces: ```rust warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/issues/29597 --> components/script/lib.rs:14:1 | 14 | #![plugin(script_plugins)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove this attribute | = note: `#[warn(deprecated)]` on by default ``` First, linking to https://github.com/rust-lang/rust/issues/29597 is not ideal since there is pretty much no discussion there of the deprecation and what can be used instead. This PR changes the link to the deprecation PR which does have more discussion. Second, the “remove this attribute” suggestion is rather unhelpful. Just because a feature is deprecated doesn’t mean that simply removing its use without a replacement is acceptable. In the case of custom lint, there is no replacement available. Prefixing a message with “help:” when telling users that they’re screwed honestly feels disrespectful. This PR also changes the message to be more factual.
2019-10-17 13:51:46 +02:00
| ^^^^^^^^^^^^^^ help: may be removed in a future compiler version
Deprecate `#![plugin]` and `#[plugin_registrar]`.
2019-09-22 01:32:51 +02:00
|
= note: `#[warn(deprecated)]` on by default
Remove `Session.used_attrs` and move logic to `CheckAttrVisitor` Instead of updating global state to mark attributes as used, we now explicitly emit a warning when an attribute is used in an unsupported position. As a side effect, we are to emit more detailed warning messages (instead of just a generic "unused" message). `Session.check_name` is removed, since its only purpose was to mark the attribute as used. All of the callers are modified to use `Attribute.has_name` Additionally, `AttributeType::AssumedUsed` is removed - an 'assumed used' attribute is implemented by simply not performing any checks in `CheckAttrVisitor` for a particular attribute. We no longer emit unused attribute warnings for the `#[rustc_dummy]` attribute - it's an internal attribute used for tests, so it doesn't mark sense to treat it as 'unused'. With this commit, a large source of global untracked state is removed.
2021-07-29 12:00:41 -05:00
error: crate-level attribute should be an inner attribute: add an exclamation mark: `#![foo]`
plugin_registrary: use normal deprecation instead of hard coded warning.
2019-10-03 06:46:17 +02:00
--> $DIR/invalid-plugin-attr.rs:4:1
Moved compile-fail tests to ui tests.
2018-08-08 14:28:26 +02:00
|
Update tests
2019-03-09 15:03:44 +03:00
LL | #[plugin(bla)]
Moved compile-fail tests to ui tests.
2018-08-08 14:28:26 +02:00
| ^^^^^^^^^^^^^^
|
Normalise notes with the/is
2020-01-22 23:57:38 +00:00
note: the lint level is defined here
plugin_registrary: use normal deprecation instead of hard coded warning.
2019-10-03 06:46:17 +02:00
--> $DIR/invalid-plugin-attr.rs:1:9
Moved compile-fail tests to ui tests.
2018-08-08 14:28:26 +02:00
|
LL | #![deny(unused_attributes)]
| ^^^^^^^^^^^^^^^^^
Remove `Session.used_attrs` and move logic to `CheckAttrVisitor` Instead of updating global state to mark attributes as used, we now explicitly emit a warning when an attribute is used in an unsupported position. As a side effect, we are to emit more detailed warning messages (instead of just a generic "unused" message). `Session.check_name` is removed, since its only purpose was to mark the attribute as used. All of the callers are modified to use `Attribute.has_name` Additionally, `AttributeType::AssumedUsed` is removed - an 'assumed used' attribute is implemented by simply not performing any checks in `CheckAttrVisitor` for a particular attribute. We no longer emit unused attribute warnings for the `#[rustc_dummy]` attribute - it's an internal attribute used for tests, so it doesn't mark sense to treat it as 'unused'. With this commit, a large source of global untracked state is removed.
2021-07-29 12:00:41 -05:00
error: aborting due to previous error; 1 warning emitted
Moved compile-fail tests to ui tests.
2018-08-08 14:28:26 +02:00
Reference in New Issue Copy Permalink