2015-10-28 11:50:00 -05:00
|
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
2016-12-01 15:31:56 -06:00
|
|
|
use rustc::hir::def::Def;
|
2016-12-29 17:00:55 -06:00
|
|
|
use rustc::hir::{Expr, Expr_, Stmt, StmtSemi, BlockCheckMode, UnsafeSource, BiAnd, BiOr};
|
2017-06-21 13:04:04 -05:00
|
|
|
use utils::{in_macro, span_lint, snippet_opt, span_lint_and_sugg};
|
2016-05-13 09:43:47 -05:00
|
|
|
use std::ops::Deref;
|
2015-10-28 11:50:00 -05:00
|
|
|
|
2016-08-06 02:55:04 -05:00
|
|
|
/// **What it does:** Checks for statements which have no effect.
|
2015-12-14 15:16:56 -06:00
|
|
|
///
|
2016-08-06 02:55:04 -05:00
|
|
|
/// **Why is this bad?** Similar to dead code, these statements are actually
|
|
|
|
/// executed. However, as they have no effect, all they do is make the code less
|
|
|
|
/// readable.
|
2015-12-14 15:16:56 -06:00
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
2016-07-15 17:25:44 -05:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// 0;
|
|
|
|
/// ```
|
2015-10-28 11:50:00 -05:00
|
|
|
declare_lint! {
|
|
|
|
pub NO_EFFECT,
|
|
|
|
Warn,
|
|
|
|
"statements with no effect"
|
|
|
|
}
|
|
|
|
|
2016-08-06 02:55:04 -05:00
|
|
|
/// **What it does:** Checks for expression statements that can be reduced to a
|
|
|
|
/// sub-expression.
|
2016-05-13 09:43:47 -05:00
|
|
|
///
|
2016-08-06 02:55:04 -05:00
|
|
|
/// **Why is this bad?** Expressions by themselves often have no side-effects.
|
|
|
|
/// Having such expressions reduces readability.
|
2016-05-13 09:43:47 -05:00
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
2016-07-15 17:25:44 -05:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// compute_array()[0];
|
|
|
|
/// ```
|
2016-05-13 09:43:47 -05:00
|
|
|
declare_lint! {
|
|
|
|
pub UNNECESSARY_OPERATION,
|
|
|
|
Warn,
|
|
|
|
"outer expressions with no effect"
|
|
|
|
}
|
|
|
|
|
2015-10-28 11:50:00 -05:00
|
|
|
fn has_no_effect(cx: &LateContext, expr: &Expr) -> bool {
|
2017-03-31 17:14:04 -05:00
|
|
|
if in_macro(expr.span) {
|
2015-10-28 11:50:00 -05:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
match expr.node {
|
2016-02-11 06:50:41 -06:00
|
|
|
Expr_::ExprLit(..) |
|
|
|
|
Expr_::ExprClosure(..) |
|
|
|
|
Expr_::ExprPath(..) => true,
|
|
|
|
Expr_::ExprIndex(ref a, ref b) |
|
|
|
|
Expr_::ExprBinary(_, ref a, ref b) => has_no_effect(cx, a) && has_no_effect(cx, b),
|
2016-09-30 08:35:24 -05:00
|
|
|
Expr_::ExprArray(ref v) |
|
2016-02-11 06:50:41 -06:00
|
|
|
Expr_::ExprTup(ref v) => v.iter().all(|val| has_no_effect(cx, val)),
|
|
|
|
Expr_::ExprRepeat(ref inner, _) |
|
|
|
|
Expr_::ExprCast(ref inner, _) |
|
|
|
|
Expr_::ExprType(ref inner, _) |
|
|
|
|
Expr_::ExprUnary(_, ref inner) |
|
|
|
|
Expr_::ExprField(ref inner, _) |
|
|
|
|
Expr_::ExprTupField(ref inner, _) |
|
|
|
|
Expr_::ExprAddrOf(_, ref inner) |
|
|
|
|
Expr_::ExprBox(ref inner) => has_no_effect(cx, inner),
|
|
|
|
Expr_::ExprStruct(_, ref fields, ref base) => {
|
2015-10-28 11:50:00 -05:00
|
|
|
fields.iter().all(|field| has_no_effect(cx, &field.expr)) &&
|
|
|
|
match *base {
|
|
|
|
Some(ref base) => has_no_effect(cx, base),
|
|
|
|
None => true,
|
|
|
|
}
|
2016-12-20 11:21:30 -06:00
|
|
|
},
|
2016-02-11 06:50:41 -06:00
|
|
|
Expr_::ExprCall(ref callee, ref args) => {
|
2016-12-01 15:31:56 -06:00
|
|
|
if let Expr_::ExprPath(ref qpath) = callee.node {
|
2017-01-13 10:04:56 -06:00
|
|
|
let def = cx.tables.qpath_def(qpath, callee.id);
|
2016-12-01 15:31:56 -06:00
|
|
|
match def {
|
|
|
|
Def::Struct(..) |
|
|
|
|
Def::Variant(..) |
|
|
|
|
Def::StructCtor(..) |
|
|
|
|
Def::VariantCtor(..) => args.iter().all(|arg| has_no_effect(cx, arg)),
|
|
|
|
_ => false,
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
false
|
2015-10-28 11:50:00 -05:00
|
|
|
}
|
2016-12-20 11:21:30 -06:00
|
|
|
},
|
2016-03-07 09:31:38 -06:00
|
|
|
Expr_::ExprBlock(ref block) => {
|
2016-04-14 13:14:03 -05:00
|
|
|
block.stmts.is_empty() &&
|
|
|
|
if let Some(ref expr) = block.expr {
|
2016-03-07 09:31:38 -06:00
|
|
|
has_no_effect(cx, expr)
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}
|
2016-12-20 11:21:30 -06:00
|
|
|
},
|
2015-10-28 11:50:00 -05:00
|
|
|
_ => false,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone)]
|
2016-06-10 09:17:20 -05:00
|
|
|
pub struct Pass;
|
2015-10-28 11:50:00 -05:00
|
|
|
|
2016-06-10 09:17:20 -05:00
|
|
|
impl LintPass for Pass {
|
2015-10-28 11:50:00 -05:00
|
|
|
fn get_lints(&self) -> LintArray {
|
2016-05-13 09:43:47 -05:00
|
|
|
lint_array!(NO_EFFECT, UNNECESSARY_OPERATION)
|
2015-10-28 11:50:00 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 06:13:40 -06:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
|
|
fn check_stmt(&mut self, cx: &LateContext<'a, 'tcx>, stmt: &'tcx Stmt) {
|
2015-10-28 11:50:00 -05:00
|
|
|
if let StmtSemi(ref expr, _) = stmt.node {
|
|
|
|
if has_no_effect(cx, expr) {
|
2016-01-03 22:26:12 -06:00
|
|
|
span_lint(cx, NO_EFFECT, stmt.span, "statement with no effect");
|
2016-05-13 09:43:47 -05:00
|
|
|
} else if let Some(reduced) = reduce_expression(cx, expr) {
|
|
|
|
let mut snippet = String::new();
|
|
|
|
for e in reduced {
|
2017-03-31 17:14:04 -05:00
|
|
|
if in_macro(e.span) {
|
2016-05-13 09:43:47 -05:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if let Some(snip) = snippet_opt(cx, e.span) {
|
|
|
|
snippet.push_str(&snip);
|
|
|
|
snippet.push(';');
|
|
|
|
} else {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
2017-06-21 13:04:04 -05:00
|
|
|
span_lint_and_sugg(cx,
|
2017-01-17 12:30:32 -06:00
|
|
|
UNNECESSARY_OPERATION,
|
|
|
|
stmt.span,
|
|
|
|
"statement can be reduced",
|
2017-06-21 13:04:04 -05:00
|
|
|
"replace it with",
|
|
|
|
snippet);
|
2016-05-13 09:43:47 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
fn reduce_expression<'a>(cx: &LateContext, expr: &'a Expr) -> Option<Vec<&'a Expr>> {
|
2017-03-31 17:14:04 -05:00
|
|
|
if in_macro(expr.span) {
|
2016-05-13 09:43:47 -05:00
|
|
|
return None;
|
|
|
|
}
|
|
|
|
match expr.node {
|
2016-12-29 17:00:55 -06:00
|
|
|
Expr_::ExprIndex(ref a, ref b) => Some(vec![&**a, &**b]),
|
|
|
|
Expr_::ExprBinary(ref binop, ref a, ref b) if binop.node != BiAnd && binop.node != BiOr => {
|
|
|
|
Some(vec![&**a, &**b])
|
|
|
|
},
|
2016-09-30 08:35:24 -05:00
|
|
|
Expr_::ExprArray(ref v) |
|
2016-11-23 15:44:00 -06:00
|
|
|
Expr_::ExprTup(ref v) => Some(v.iter().collect()),
|
2016-05-13 09:43:47 -05:00
|
|
|
Expr_::ExprRepeat(ref inner, _) |
|
|
|
|
Expr_::ExprCast(ref inner, _) |
|
|
|
|
Expr_::ExprType(ref inner, _) |
|
|
|
|
Expr_::ExprUnary(_, ref inner) |
|
|
|
|
Expr_::ExprField(ref inner, _) |
|
|
|
|
Expr_::ExprTupField(ref inner, _) |
|
|
|
|
Expr_::ExprAddrOf(_, ref inner) |
|
|
|
|
Expr_::ExprBox(ref inner) => reduce_expression(cx, inner).or_else(|| Some(vec![inner])),
|
2016-06-05 18:42:39 -05:00
|
|
|
Expr_::ExprStruct(_, ref fields, ref base) => {
|
|
|
|
Some(fields.iter().map(|f| &f.expr).chain(base).map(Deref::deref).collect())
|
2016-12-20 11:21:30 -06:00
|
|
|
},
|
2016-05-13 09:43:47 -05:00
|
|
|
Expr_::ExprCall(ref callee, ref args) => {
|
2016-12-01 15:31:56 -06:00
|
|
|
if let Expr_::ExprPath(ref qpath) = callee.node {
|
2017-01-13 10:04:56 -06:00
|
|
|
let def = cx.tables.qpath_def(qpath, callee.id);
|
2016-12-01 15:31:56 -06:00
|
|
|
match def {
|
|
|
|
Def::Struct(..) |
|
|
|
|
Def::Variant(..) |
|
|
|
|
Def::StructCtor(..) |
|
|
|
|
Def::VariantCtor(..) => Some(args.iter().collect()),
|
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
None
|
2016-05-13 09:43:47 -05:00
|
|
|
}
|
2016-12-20 11:21:30 -06:00
|
|
|
},
|
2016-05-13 09:43:47 -05:00
|
|
|
Expr_::ExprBlock(ref block) => {
|
|
|
|
if block.stmts.is_empty() {
|
2016-06-05 18:42:39 -05:00
|
|
|
block.expr.as_ref().and_then(|e| {
|
|
|
|
match block.rules {
|
|
|
|
BlockCheckMode::UnsafeBlock(UnsafeSource::UserProvided) => None,
|
|
|
|
BlockCheckMode::DefaultBlock => Some(vec![&**e]),
|
|
|
|
// in case of compiler-inserted signaling blocks
|
|
|
|
_ => reduce_expression(cx, e),
|
|
|
|
}
|
2016-05-13 09:43:47 -05:00
|
|
|
})
|
|
|
|
} else {
|
|
|
|
None
|
2015-10-28 11:50:00 -05:00
|
|
|
}
|
2016-12-20 11:21:30 -06:00
|
|
|
},
|
2016-05-13 09:43:47 -05:00
|
|
|
_ => None,
|
2015-10-28 11:50:00 -05:00
|
|
|
}
|
|
|
|
}
|