2022-12-29 07:28:34 -06:00
|
|
|
#![feature(yeet_expr)]
|
2021-04-08 10:50:13 -05:00
|
|
|
#![allow(unused)]
|
2021-10-07 04:21:30 -05:00
|
|
|
#![allow(
|
|
|
|
clippy::if_same_then_else,
|
|
|
|
clippy::single_match,
|
|
|
|
clippy::needless_bool,
|
2023-06-02 04:41:57 -05:00
|
|
|
clippy::equatable_if_let,
|
|
|
|
clippy::needless_else
|
2021-10-07 04:21:30 -05:00
|
|
|
)]
|
2019-09-25 07:28:19 -05:00
|
|
|
#![warn(clippy::needless_return)]
|
|
|
|
|
2022-06-30 03:50:09 -05:00
|
|
|
use std::cell::RefCell;
|
|
|
|
|
2019-09-25 07:28:19 -05:00
|
|
|
macro_rules! the_answer {
|
|
|
|
() => {
|
|
|
|
42
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_end_of_fn() -> bool {
|
|
|
|
if true {
|
|
|
|
// no error!
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
true
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_no_semicolon() -> bool {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
|
2023-01-27 14:09:08 -06:00
|
|
|
#[rustfmt::skip]
|
|
|
|
fn test_multiple_semicolon() -> bool {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
|
|
|
|
#[rustfmt::skip]
|
|
|
|
fn test_multiple_semicolon_with_spaces() -> bool {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
|
2019-09-25 07:28:19 -05:00
|
|
|
fn test_if_block() -> bool {
|
|
|
|
if true {
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_match(x: bool) -> bool {
|
|
|
|
match x {
|
|
|
|
true => false,
|
|
|
|
false => {
|
|
|
|
true
|
|
|
|
},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_closure() {
|
|
|
|
let _ = || {
|
|
|
|
true
|
|
|
|
};
|
|
|
|
let _ = || true;
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_macro_call() -> i32 {
|
2022-06-04 06:34:07 -05:00
|
|
|
the_answer!()
|
2019-09-25 07:28:19 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn test_void_fun() {
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_void_if_fun(b: bool) {
|
|
|
|
if b {
|
|
|
|
} else {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_void_match(x: u32) {
|
|
|
|
match x {
|
|
|
|
0 => (),
|
2021-12-30 08:10:43 -06:00
|
|
|
_ => (),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_nested_match(x: u32) {
|
|
|
|
match x {
|
|
|
|
0 => (),
|
|
|
|
1 => {
|
|
|
|
let _ = 42;
|
|
|
|
},
|
|
|
|
_ => (),
|
2019-09-25 07:28:19 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-06-30 03:50:09 -05:00
|
|
|
fn temporary_outlives_local() -> String {
|
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
return x.borrow().clone();
|
2020-08-28 09:10:16 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
fn borrows_but_not_last(value: bool) -> String {
|
|
|
|
if value {
|
2022-06-30 03:50:09 -05:00
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
let _a = x.borrow().clone();
|
2020-08-28 09:10:16 -05:00
|
|
|
String::from("test")
|
|
|
|
} else {
|
|
|
|
String::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-01-15 03:56:44 -06:00
|
|
|
macro_rules! needed_return {
|
|
|
|
($e:expr) => {
|
|
|
|
if $e > 3 {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_return_in_macro() {
|
|
|
|
// This will return and the macro below won't be executed. Removing the `return` from the macro
|
|
|
|
// will change semantics.
|
|
|
|
needed_return!(10);
|
|
|
|
needed_return!(0);
|
|
|
|
}
|
|
|
|
|
2021-01-30 11:06:34 -06:00
|
|
|
mod issue6501 {
|
2021-12-06 05:33:31 -06:00
|
|
|
#[allow(clippy::unnecessary_lazy_evaluations)]
|
2021-01-30 11:06:34 -06:00
|
|
|
fn foo(bar: Result<(), ()>) {
|
|
|
|
bar.unwrap_or_else(|_| {})
|
|
|
|
}
|
|
|
|
|
|
|
|
fn test_closure() {
|
|
|
|
let _ = || {
|
|
|
|
};
|
|
|
|
let _ = || {};
|
|
|
|
}
|
|
|
|
|
|
|
|
struct Foo;
|
|
|
|
#[allow(clippy::unnecessary_lazy_evaluations)]
|
|
|
|
fn bar(res: Result<Foo, u8>) -> Foo {
|
|
|
|
res.unwrap_or_else(|_| Foo)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-04-22 04:31:13 -05:00
|
|
|
async fn async_test_end_of_fn() -> bool {
|
|
|
|
if true {
|
|
|
|
// no error!
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
true
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_no_semicolon() -> bool {
|
|
|
|
true
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_if_block() -> bool {
|
|
|
|
if true {
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_match(x: bool) -> bool {
|
|
|
|
match x {
|
|
|
|
true => false,
|
|
|
|
false => {
|
|
|
|
true
|
|
|
|
},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_closure() {
|
|
|
|
let _ = || {
|
|
|
|
true
|
|
|
|
};
|
|
|
|
let _ = || true;
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_macro_call() -> i32 {
|
2022-06-04 06:34:07 -05:00
|
|
|
the_answer!()
|
2021-04-22 04:31:13 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_void_fun() {
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_void_if_fun(b: bool) {
|
|
|
|
if b {
|
|
|
|
} else {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_void_match(x: u32) {
|
|
|
|
match x {
|
|
|
|
0 => (),
|
2021-12-30 08:10:43 -06:00
|
|
|
_ => (),
|
2021-04-22 04:31:13 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-06-30 03:50:09 -05:00
|
|
|
async fn async_temporary_outlives_local() -> String {
|
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
return x.borrow().clone();
|
2019-09-25 07:28:19 -05:00
|
|
|
}
|
2021-04-22 04:31:13 -05:00
|
|
|
|
|
|
|
async fn async_borrows_but_not_last(value: bool) -> String {
|
|
|
|
if value {
|
2022-06-30 03:50:09 -05:00
|
|
|
let x = RefCell::<String>::default();
|
|
|
|
let _a = x.borrow().clone();
|
2021-04-22 04:31:13 -05:00
|
|
|
String::from("test")
|
|
|
|
} else {
|
|
|
|
String::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
async fn async_test_return_in_macro() {
|
|
|
|
needed_return!(10);
|
|
|
|
needed_return!(0);
|
|
|
|
}
|
|
|
|
|
2021-09-28 12:03:12 -05:00
|
|
|
fn let_else() {
|
|
|
|
let Some(1) = Some(1) else { return };
|
|
|
|
}
|
|
|
|
|
2022-06-04 06:34:07 -05:00
|
|
|
fn needless_return_macro() -> String {
|
|
|
|
let _ = "foo";
|
|
|
|
let _ = "bar";
|
|
|
|
format!("Hello {}", "world!")
|
|
|
|
}
|
|
|
|
|
2024-07-01 06:49:16 -05:00
|
|
|
fn issue_9361(n: i32) -> i32 {
|
|
|
|
#[expect(clippy::arithmetic_side_effects)]
|
2023-05-20 08:39:26 -05:00
|
|
|
return n + n;
|
2022-06-30 03:50:09 -05:00
|
|
|
}
|
|
|
|
|
2024-07-01 06:49:16 -05:00
|
|
|
mod issue_12998 {
|
|
|
|
fn expect_lint() -> i32 {
|
|
|
|
let x = 1;
|
|
|
|
|
|
|
|
#[expect(clippy::needless_return)]
|
|
|
|
return x;
|
|
|
|
}
|
|
|
|
|
|
|
|
fn expect_group() -> i32 {
|
|
|
|
let x = 1;
|
|
|
|
|
|
|
|
#[expect(clippy::style)]
|
|
|
|
return x;
|
|
|
|
}
|
|
|
|
|
|
|
|
fn expect_all() -> i32 {
|
|
|
|
let x = 1;
|
|
|
|
|
|
|
|
#[expect(clippy::all)]
|
|
|
|
return x;
|
|
|
|
}
|
|
|
|
|
|
|
|
fn expect_warnings() -> i32 {
|
|
|
|
let x = 1;
|
|
|
|
|
|
|
|
#[expect(warnings)]
|
|
|
|
return x;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-10-06 02:44:38 -05:00
|
|
|
fn issue8336(x: i32) -> bool {
|
|
|
|
if x > 0 {
|
|
|
|
println!("something");
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn issue8156(x: u8) -> u64 {
|
|
|
|
match x {
|
|
|
|
80 => {
|
|
|
|
10
|
|
|
|
},
|
|
|
|
_ => {
|
|
|
|
100
|
|
|
|
},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Ideally the compiler should throw `unused_braces` in this case
|
|
|
|
fn issue9192() -> i32 {
|
|
|
|
{
|
|
|
|
0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn issue9503(x: usize) -> isize {
|
|
|
|
unsafe {
|
|
|
|
if x > 12 {
|
|
|
|
*(x as *const isize)
|
|
|
|
} else {
|
|
|
|
!*(x as *const isize)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-12-01 11:29:38 -06:00
|
|
|
mod issue9416 {
|
|
|
|
pub fn with_newline() {
|
|
|
|
let _ = 42;
|
|
|
|
}
|
|
|
|
|
|
|
|
#[rustfmt::skip]
|
|
|
|
pub fn oneline() {
|
|
|
|
let _ = 42;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-12-29 07:28:34 -06:00
|
|
|
fn issue9947() -> Result<(), String> {
|
|
|
|
do yeet "hello";
|
|
|
|
}
|
|
|
|
|
2023-01-12 12:48:13 -06:00
|
|
|
// without anyhow, but triggers the same bug I believe
|
|
|
|
#[expect(clippy::useless_format)]
|
|
|
|
fn issue10051() -> Result<String, String> {
|
|
|
|
if true {
|
|
|
|
Ok(format!("ok!"))
|
|
|
|
} else {
|
|
|
|
Err(format!("err!"))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-02-25 18:08:29 -06:00
|
|
|
mod issue10049 {
|
|
|
|
fn single() -> u32 {
|
|
|
|
if true { 1 } else { 2 }
|
|
|
|
}
|
|
|
|
|
|
|
|
fn multiple(b1: bool, b2: bool, b3: bool) -> u32 {
|
|
|
|
(if b1 { 0 } else { 1 } | if b2 { 2 } else { 3 } | if b3 { 4 } else { 5 })
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-04-11 08:31:08 -05:00
|
|
|
fn test_match_as_stmt() {
|
|
|
|
let x = 9;
|
|
|
|
match x {
|
|
|
|
1 => 2,
|
|
|
|
2 => return,
|
|
|
|
_ => 0,
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2024-03-21 16:20:40 -05:00
|
|
|
fn allow_works() -> i32 {
|
|
|
|
#[allow(clippy::needless_return, clippy::match_single_binding)]
|
|
|
|
match () {
|
|
|
|
() => return 42,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-05-30 03:49:05 -05:00
|
|
|
fn conjunctive_blocks() -> String {
|
|
|
|
({ "a".to_string() } + "b" + { "c" })
|
|
|
|
}
|
|
|
|
|
2024-08-03 19:24:51 -05:00
|
|
|
fn issue12907() -> String {
|
|
|
|
"".split("").next().unwrap().to_string()
|
|
|
|
}
|
|
|
|
|
2021-04-22 04:31:13 -05:00
|
|
|
fn main() {}
|