2015-09-09 11:02:52 +02:00
|
|
|
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution and at
|
|
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
|
|
|
#![allow(non_snake_case)]
|
|
|
|
|
|
|
|
register_long_diagnostics! {
|
|
|
|
|
|
|
|
E0445: r##"
|
2015-09-09 11:15:33 +02:00
|
|
|
A private trait was used on a public type parameter bound. Erroneous code
|
|
|
|
examples:
|
2015-09-09 11:02:52 +02:00
|
|
|
|
2016-06-10 00:34:46 +02:00
|
|
|
```compile_fail,E0445
|
2016-08-26 19:23:42 +03:00
|
|
|
#![deny(private_in_public)]
|
|
|
|
|
2015-09-09 11:02:52 +02:00
|
|
|
trait Foo {
|
|
|
|
fn dummy(&self) { }
|
|
|
|
}
|
|
|
|
|
2015-11-21 18:36:10 +03:00
|
|
|
pub trait Bar : Foo {} // error: private trait in public interface
|
2016-02-07 13:02:52 +01:00
|
|
|
pub struct Bar2<T: Foo>(pub T); // same error
|
2015-09-09 12:16:43 +02:00
|
|
|
pub fn foo<T: Foo> (t: T) {} // same error
|
2015-09-09 11:02:52 +02:00
|
|
|
```
|
|
|
|
|
2015-11-21 18:36:10 +03:00
|
|
|
To solve this error, please ensure that the trait is also public. The trait
|
2016-02-15 17:57:21 +01:00
|
|
|
can be made inaccessible if necessary by placing it into a private inner
|
|
|
|
module, but it still has to be marked with `pub`. Example:
|
2015-09-09 11:02:52 +02:00
|
|
|
|
2016-02-07 13:02:52 +01:00
|
|
|
```ignore
|
2015-09-09 11:02:52 +02:00
|
|
|
pub trait Foo { // we set the Foo trait public
|
|
|
|
fn dummy(&self) { }
|
|
|
|
}
|
|
|
|
|
|
|
|
pub trait Bar : Foo {} // ok!
|
2016-02-07 13:02:52 +01:00
|
|
|
pub struct Bar2<T: Foo>(pub T); // ok!
|
2015-09-09 12:16:43 +02:00
|
|
|
pub fn foo<T: Foo> (t: T) {} // ok!
|
2015-09-09 11:02:52 +02:00
|
|
|
```
|
|
|
|
"##,
|
|
|
|
|
2015-09-09 11:08:35 +02:00
|
|
|
E0446: r##"
|
2015-12-04 21:51:18 +03:00
|
|
|
A private type was used in a public type signature. Erroneous code example:
|
2015-09-09 11:08:35 +02:00
|
|
|
|
2016-06-10 00:34:46 +02:00
|
|
|
```compile_fail,E0446
|
2016-08-26 19:23:42 +03:00
|
|
|
#![deny(private_in_public)]
|
|
|
|
|
2015-09-09 11:08:35 +02:00
|
|
|
mod Foo {
|
|
|
|
struct Bar(u32);
|
|
|
|
|
2015-11-21 18:36:10 +03:00
|
|
|
pub fn bar() -> Bar { // error: private type in public interface
|
2015-09-09 11:08:35 +02:00
|
|
|
Bar(0)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
```
|
|
|
|
|
2015-11-21 18:36:10 +03:00
|
|
|
To solve this error, please ensure that the type is also public. The type
|
2016-02-15 17:57:21 +01:00
|
|
|
can be made inaccessible if necessary by placing it into a private inner
|
|
|
|
module, but it still has to be marked with `pub`.
|
2015-11-21 18:36:10 +03:00
|
|
|
Example:
|
2015-09-09 11:08:35 +02:00
|
|
|
|
|
|
|
```
|
|
|
|
mod Foo {
|
|
|
|
pub struct Bar(u32); // we set the Bar type public
|
|
|
|
|
|
|
|
pub fn bar() -> Bar { // ok!
|
|
|
|
Bar(0)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
```
|
|
|
|
"##,
|
|
|
|
|
2015-09-09 11:15:33 +02:00
|
|
|
E0447: r##"
|
|
|
|
The `pub` keyword was used inside a function. Erroneous code example:
|
|
|
|
|
2016-05-22 19:00:20 +02:00
|
|
|
```ignore
|
2015-09-09 11:15:33 +02:00
|
|
|
fn foo() {
|
|
|
|
pub struct Bar; // error: visibility has no effect inside functions
|
|
|
|
}
|
|
|
|
```
|
|
|
|
|
2015-09-09 12:16:43 +02:00
|
|
|
Since we cannot access items defined inside a function, the visibility of its
|
|
|
|
items does not impact outer code. So using the `pub` keyword in this context
|
2015-09-09 11:15:33 +02:00
|
|
|
is invalid.
|
|
|
|
"##,
|
|
|
|
|
2015-09-09 11:47:00 +02:00
|
|
|
E0448: r##"
|
|
|
|
The `pub` keyword was used inside a public enum. Erroneous code example:
|
|
|
|
|
2016-02-07 13:02:52 +01:00
|
|
|
```compile_fail
|
2015-09-09 11:47:00 +02:00
|
|
|
pub enum Foo {
|
|
|
|
pub Bar, // error: unnecessary `pub` visibility
|
|
|
|
}
|
|
|
|
```
|
|
|
|
|
|
|
|
Since the enum is already public, adding `pub` on one its elements is
|
|
|
|
unnecessary. Example:
|
|
|
|
|
2016-06-10 00:34:46 +02:00
|
|
|
```compile_fail,
|
2015-09-09 11:47:00 +02:00
|
|
|
enum Foo {
|
2016-02-07 13:02:52 +01:00
|
|
|
pub Bar, // not ok!
|
2015-09-09 11:47:00 +02:00
|
|
|
}
|
2016-02-07 13:02:52 +01:00
|
|
|
```
|
2015-09-09 11:47:00 +02:00
|
|
|
|
2016-02-07 13:02:52 +01:00
|
|
|
This is the correct syntax:
|
2015-09-09 11:47:00 +02:00
|
|
|
|
2016-02-07 13:02:52 +01:00
|
|
|
```ignore
|
2015-09-09 11:47:00 +02:00
|
|
|
pub enum Foo {
|
|
|
|
Bar, // ok!
|
|
|
|
}
|
|
|
|
```
|
|
|
|
"##,
|
|
|
|
|
2015-09-09 12:16:43 +02:00
|
|
|
E0451: r##"
|
|
|
|
A struct constructor with private fields was invoked. Erroneous code example:
|
|
|
|
|
2016-06-10 00:34:46 +02:00
|
|
|
```compile_fail,E0451
|
2015-09-09 12:16:43 +02:00
|
|
|
mod Bar {
|
|
|
|
pub struct Foo {
|
|
|
|
pub a: isize,
|
|
|
|
b: isize,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
let f = Bar::Foo{ a: 0, b: 0 }; // error: field `b` of struct `Bar::Foo`
|
|
|
|
// is private
|
|
|
|
```
|
|
|
|
|
2016-02-16 21:31:50 -05:00
|
|
|
To fix this error, please ensure that all the fields of the struct are public,
|
|
|
|
or implement a function for easy instantiation. Examples:
|
2015-09-09 12:16:43 +02:00
|
|
|
|
|
|
|
```
|
|
|
|
mod Bar {
|
|
|
|
pub struct Foo {
|
|
|
|
pub a: isize,
|
|
|
|
pub b: isize, // we set `b` field public
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
let f = Bar::Foo{ a: 0, b: 0 }; // ok!
|
2016-02-07 13:02:52 +01:00
|
|
|
```
|
2015-09-09 12:16:43 +02:00
|
|
|
|
2016-02-07 13:02:52 +01:00
|
|
|
Or:
|
|
|
|
|
|
|
|
```
|
2015-09-09 12:16:43 +02:00
|
|
|
mod Bar {
|
|
|
|
pub struct Foo {
|
|
|
|
pub a: isize,
|
|
|
|
b: isize, // still private
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Foo {
|
|
|
|
pub fn new() -> Foo { // we create a method to instantiate `Foo`
|
|
|
|
Foo { a: 0, b: 0 }
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
let f = Bar::Foo::new(); // ok!
|
2015-09-09 12:08:21 +02:00
|
|
|
```
|
|
|
|
"##,
|
|
|
|
|
2015-09-09 12:16:43 +02:00
|
|
|
}
|
2017-01-20 20:11:42 +03:00
|
|
|
|
|
|
|
register_diagnostics! {
|
|
|
|
// E0450, moved into resolve
|
|
|
|
}
|