2016-04-07 10:46:48 -05:00
|
|
|
use rustc::hir::*;
|
2016-04-14 11:13:15 -05:00
|
|
|
use rustc::lint::*;
|
2016-02-12 11:35:44 -06:00
|
|
|
use syntax::ast::LitKind;
|
2016-04-14 11:13:15 -05:00
|
|
|
use utils::{is_direct_expn_of, match_path, paths, span_lint};
|
2015-12-23 15:37:52 -06:00
|
|
|
|
2016-02-05 17:41:54 -06:00
|
|
|
/// **What it does:** This lint checks for missing parameters in `panic!`.
|
2015-12-23 15:37:52 -06:00
|
|
|
///
|
|
|
|
/// **Known problems:** Should you want to use curly brackets in `panic!` without any parameter,
|
|
|
|
/// this lint will warn.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```
|
2016-02-05 17:41:54 -06:00
|
|
|
/// panic!("This `panic!` is probably missing a parameter there: {}");
|
2015-12-23 15:37:52 -06:00
|
|
|
/// ```
|
2016-02-05 17:13:29 -06:00
|
|
|
declare_lint! {
|
|
|
|
pub PANIC_PARAMS, Warn, "missing parameters in `panic!`"
|
|
|
|
}
|
2015-12-23 15:37:52 -06:00
|
|
|
|
|
|
|
#[allow(missing_copy_implementations)]
|
|
|
|
pub struct PanicPass;
|
|
|
|
|
|
|
|
impl LintPass for PanicPass {
|
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(PANIC_PARAMS)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl LateLintPass for PanicPass {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
|
|
|
|
if_let_chain! {[
|
2015-12-24 03:57:31 -06:00
|
|
|
let ExprBlock(ref block) = expr.node,
|
|
|
|
let Some(ref ex) = block.expr,
|
|
|
|
let ExprCall(ref fun, ref params) = ex.node,
|
2015-12-23 15:37:52 -06:00
|
|
|
params.len() == 2,
|
|
|
|
let ExprPath(None, ref path) = fun.node,
|
2016-05-12 12:11:13 -05:00
|
|
|
match_path(path, &paths::BEGIN_PANIC),
|
2015-12-23 15:37:52 -06:00
|
|
|
let ExprLit(ref lit) = params[0].node,
|
2016-03-15 15:02:08 -05:00
|
|
|
is_direct_expn_of(cx, params[0].span, "panic").is_some(),
|
2016-02-12 11:35:44 -06:00
|
|
|
let LitKind::Str(ref string, _) = lit.node,
|
2016-03-12 14:23:01 -06:00
|
|
|
let Some(par) = string.find('{'),
|
2016-03-15 15:02:08 -05:00
|
|
|
string[par..].contains('}')
|
2015-12-23 15:37:52 -06:00
|
|
|
], {
|
2016-03-15 15:02:08 -05:00
|
|
|
span_lint(cx, PANIC_PARAMS, params[0].span,
|
|
|
|
"you probably are missing some parameter in your format string");
|
2015-12-23 15:37:52 -06:00
|
|
|
}}
|
|
|
|
}
|
|
|
|
}
|